Commit Graph

7375 Commits

Author SHA1 Message Date
Eric Lippmann b4f4ce4406 Require the module's permission for every module automatically
Module permissions are not required if authentication is disabled on the controller.

refs #9644
2015-07-23 12:51:10 +02:00
Eric Lippmann 7c5b4de087 Fix coding style in RoleForm.php 2015-07-23 12:50:42 +02:00
Eric Lippmann b000ae3a37 Do not require permissions if authentication is not required
refs #9644
2015-07-23 12:50:02 +02:00
Eric Lippmann bf590ed380 Provide module permissions automatically
refs #9644
2015-07-22 15:01:54 +02:00
Eric Lippmann 5dcc307e87 Add namespace for module permissions to the module manager
refs #9644
2015-07-22 14:59:35 +02:00
Eric Lippmann aa567f8cd7 Introduce ModuleActionController::$requiresModulePermission
refs #9644
2015-07-22 14:56:02 +02:00
Eric Lippmann a75b1a35c6 monitoring: Don't fail when selecting custom variables while having a group by clause
refs #9692
2015-07-22 13:47:52 +02:00
Eric Lippmann 15cb24c6dc Throw an exception in IdoQuery::getCustomvarColumnName() in case the custom variable has not been joined
Queries extending IdoQuery and using the method getCustomvarColumnName() must be notified in case the custom variable has not been joined.

refs #9692
2015-07-22 12:03:34 +02:00
Eric Lippmann 3ed13366a8 Remove duplicate line in IdoQuery
I introduced this w/ 4522cf5090.
2015-07-22 12:03:34 +02:00
Eric Lippmann 4522cf5090 Add missing return to IdoQuery::getCustomvarColumnName()
Some filter combinations still seem to not work properly.

refs #9692
2015-07-21 15:27:01 +02:00
Matthias Jentsch 5478027855 Bring back user count in ldap backend inspection
We already use count later in the wizard anyways.

refs #9630
2015-07-16 16:52:56 +02:00
Matthias Jentsch 67f46bab27 Merge branch 'feature/add-inspectable-api-to-db-connections-9641'
resolves #9641
2015-07-16 16:30:46 +02:00
Matthias Jentsch 9ba4189617 fix coding guideline violations 2015-07-16 16:27:28 +02:00
Matthias Jentsch 6d209ee203 Fix unit DB Form unit tests broken by inspection
refs #9641
2015-07-16 16:22:13 +02:00
Matthias Jentsch e357960d1e Add Inspection API to DB backend
refs #9641
2015-07-16 16:16:55 +02:00
Matthias Jentsch 31618ce2cf Fix unit DB Form unit tests broken by inspection
refs #9641
2015-07-16 16:15:27 +02:00
Matthias Jentsch f4054d575b Add Inspection API to db connection
refs #9641
2015-07-16 15:29:45 +02:00
Matthias Jentsch 3cd6d2e490 Merge branch 'feature/add-inspectable-api-to-db-and-ldap-connections-9630'
resolves #9630
2015-07-16 13:56:56 +02:00
Matthias Jentsch c55ba6dff4 fix coding guideline violations 2015-07-16 13:51:35 +02:00
Matthias Jentsch ffe672c252 Improve message texts and scalabillity
Always start uppercase and don't use count() function until we've got a more scalable implementation in the LdapConnection.

refs #9630
2015-07-16 13:51:26 +02:00
Matthias Jentsch da5ceb0e73 Fix broken unit tests
Fix unit tests that were broken by API changes to the resource form classes and contemplate life choices.

refs #9630
2015-07-16 12:54:37 +02:00
Matthias Jentsch 6b8e5da76d Move all assertion functions into the inspect functions
Reduce code duplication and add class Inspection

refs #9630
2015-07-16 12:21:11 +02:00
Matthias Jentsch 59c4f8d056 Use Inspection API in User Backend Form
refs #9630
2015-07-15 19:35:25 +02:00
Matthias Jentsch cf8b760ade Use Inspection API in LdapResourceForm
refs #9630
2015-07-15 19:33:47 +02:00
Matthias Jentsch 276aa43aa2 Upgrdae Inspection API again
Do not use InspectionException any more to reduce complexity of nested inspections, but keep error states
in the Inspection object itself.

refs #9630
2015-07-15 18:39:09 +02:00
Matthias Jentsch 6762ef053e Upgrade Inspection API
Reduce code duplication and stateffullnes by using InspectionException to indicate that an error was thrown, and only using one inspect function.

refs #9630
2015-07-15 17:51:18 +02:00
Matthias Jentsch 11360f36e4 Fix grammar errors in backend titles 2015-07-15 15:37:59 +02:00
Matthias Jentsch 774d6ce94a Fix invalid function call in getCapabilities caused by refactoring 2015-07-15 15:36:32 +02:00
Matthias Jentsch 930303dfb2 Merge branch 'bugfix/ldap-connection-fail-when-encryption-not-possible-9608'
fixes #9608
2015-07-15 12:50:49 +02:00
Matthias Jentsch af58d6964b Fix isEncrypted function broken by refactaring
refs #9608
2015-07-15 12:23:30 +02:00
Matthias Jentsch 7daa97a166 Clean up unneded code
Remove the now useless error handling cases in case encryption wasn't successful.

refs #9608
2015-07-15 11:31:56 +02:00
Matthias Jentsch 3b8b5b0022 Revert accidentally commited unneded changes 2015-07-15 11:16:06 +02:00
Matthias Jentsch 6db80f1e74 Merge branch 'feature/ldap-connection-test-function-9605'
fixes #9605
2015-07-15 10:50:02 +02:00
Matthias Jentsch 212111511a Fix violations of coding guidelines 2015-07-15 10:32:54 +02:00
Matthias Jentsch 84899e3e56 Revert some unneeded changes
refs #9605
2015-07-15 09:56:18 +02:00
Johannes Meyer 9a90e2a183 Wizard: Be less hysteric to not to make users upset
fixes #9620
2015-07-15 08:50:39 +02:00
Matthias Jentsch f4d8bfc309 Display connection test info when inspecting LdapConnections
refs #9605
2015-07-14 18:36:26 +02:00
Matthias Jentsch 3ddb8ca1bd Add abillity to discover AD version and vendor name to discovery
refs #9605
2015-07-14 18:32:44 +02:00
Matthias Jentsch 40d432100b Add a function to test the connection health
refs #9605
2015-07-14 18:29:58 +02:00
Matthias Jentsch 6599940e6c Introduce Interface for inspecting ldap connections
refs #9605
2015-07-14 12:30:16 +02:00
Johannes Meyer 8b4c2c459a comments overview: Improve link titles 2015-07-13 12:51:50 +02:00
Johannes Meyer d6f756c670 downtimes overview: Improve link titles 2015-07-13 12:51:12 +02:00
Johannes Meyer c90da0378d downtimes overview: Fix detail links 2015-07-13 12:17:00 +02:00
Johannes Meyer 3db81a8d0f downtimes-header: Do not show links with a bold font 2015-07-10 15:46:24 +02:00
Johannes Meyer d0a588ef58 downtimes-header: Do not access a non-existent property, again
I don't get it..
2015-07-10 15:43:07 +02:00
Johannes Meyer ac8a2d1673 downtimes-header: Show proper times for fixed downtimes not yet started 2015-07-10 15:41:42 +02:00
Johannes Meyer 831581471c downtimes/show.phtml: Drop redundant link title
Such a title has not any advantage as it contains the same content
as the link label.
2015-07-10 15:17:25 +02:00
Johannes Meyer 3091b8cf5c downtimes/show.phtml: Do not show an (inappropriate) icon in the title 2015-07-10 15:16:16 +02:00
Johannes Meyer 52bde67653 Link: Show the link's label in its title as well 2015-07-10 15:12:56 +02:00
Johannes Meyer 9ca1a6dea6 downtimes-header: Add links for hosts and services 2015-07-10 15:11:59 +02:00