735 Commits

Author SHA1 Message Date
Eric Lippmann
b5e93afd86 CS: Add newline at end of file
find application/ library/ test/ modules/ -name *.php | xargs sed -i '$a\'
2013-09-04 18:28:35 +02:00
Eric Lippmann
35fd9fd391 CS: Remove whitespaces at end of line
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
Eric Lippmann
95e9117325 Fix SortBox not keeping Sort By input after submission 2013-09-04 18:21:10 +02:00
Jannis Moßhammer
355618d0e0 Merge branch 'bugfix/commands-as-object-4580'
refs #4580
fixes #4594
fixes #4496
2013-09-04 18:14:53 +02:00
Jannis Moßhammer
7f4e1936f7 Fix trigger downtime default value issing, docstring fixes
refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer
b74e264f01 Refactor comment command handling
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm

refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer
e0620aa04e Fix DateTimePicker not respecting user preferences
refs #4675
2013-09-04 18:08:00 +02:00
Johannes Meyer
9a476f16f4 Re-refactor dispatch process of commands and acknowledgement handling
refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer
1593406f31 Refactor Acknowledgement command handling
#refs 4580
2013-09-04 18:07:59 +02:00
Johannes Meyer
79eb6588c5 Restructure dispatch process of commands
refs #4580
2013-09-04 18:07:59 +02:00
Johannes Meyer
95d7a8a553 Fix triggered_by field in ScheduleDowntimeForm is not a select box
refs #4496
2013-09-04 18:07:59 +02:00
Eric Lippmann
a44d17f0a6 Merge branch 'bugfix/sorting-as-widget-4601'
fixes #4601
2013-09-04 17:15:41 +02:00
Eric Lippmann
05d08fb0b8 Fix Bootstrap typed wrong
refs #4601
2013-09-04 17:12:44 +02:00
Eric Lippmann
2b10782d6b Fix use \Monitoring without Icinga\Module prefix
refs #4601
2013-09-04 16:08:20 +02:00
Jannis Moßhammer
b1df9fa67d Readd import in BaseTestCase that got lost during rebase
refs #4601
2013-09-04 15:22:01 +02:00
Jannis Moßhammer
e915119845 Fix grid styling and add links for hosts and service
refs #4601
2013-09-04 15:22:01 +02:00
Jannis Moßhammer
d27e34cef8 Codestyle and Test fixes for SortBox
refs #4601
2013-09-04 15:22:00 +02:00
Jannis Moßhammer
57e66c247a Add sort widget, change js path from module to app, small style fixes
refs #4601
2013-09-04 15:22:00 +02:00
Eric Lippmann
f22a965bc4 Merge branch 'bugfix/preferences-not-writable-exception-4529'
fixes #4529
2013-09-04 14:59:57 +02:00
Eric Lippmann
6afeaac6b2 Make 'ini' in descriptions uppercase, add comment to index.php about date_default_timezone_set
refs #4529
2013-09-04 14:56:55 +02:00
Jannis Moßhammer
c9673bfea3 Catch database errors, set fallback tz
The fallback timezone is set in case an error occurs
before setupTimezone() is entered. In this case the user
is presented with an warning about missing timezone settings
if the php.ini doesn't contain timezone information

refs #4529
2013-09-04 14:27:37 +02:00
Jannis Moßhammer
95bc8a2f4f Add NullStore as preference fallback
refs #4529
2013-09-04 14:27:37 +02:00
Jannis Moßhammer
03cc43a3f6 Merge branch 'bugfix/missing-doc-4547-4548'
fixes #4546
fixes #4548
2013-09-04 13:55:08 +02:00
Eric Lippmann
68585b98b5 Doc: Add DateTimePicker documentation
refs #4547
2013-09-04 13:54:45 +02:00
Eric Lippmann
9c73802ce6 Doc: Add Testing Singletons paragraph
refs #4548
2013-09-04 13:54:45 +02:00
Jannis Moßhammer
4658405990 Merge branch 'bugfix/module-namespace-4586'
fixes #4586
2013-09-04 11:25:58 +02:00
Eric Lippmann
1b858cbdb4 Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
3e4d1aa2fb Monitoring/Tests: Replace BaseFormTest with BaseTestCase
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
6f383abdd1 Tests: Let the BaseTestCase require db and form libraries once it's being required
Further add function t() and mt() to the global namespace when requiring BaseTestCase

refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
e3044b8b62 Tests/Monitoring: Remove ScheduleDowntimeFormTest since it's being refactored in another branch
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
a89631fd92 Tests/Monitoring: Remove useless test ConfirmationFormTest
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
74b9731df5 Remove auto class requirement from BaseTestCase::createForm()
The tests for the respective forms must require the form class.

refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
092c5780ea CS: Fix violations for overdue files
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
8a062ff3e5 Fix tests after renaming the namespace
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
c86874d4ba Rename namespace Monitoring to Icingæ\Module\Monitoring
refs #4586
2013-09-04 11:21:11 +02:00
Eric Lippmann
03f081ce33 Module/Autoloader: Register Icinga\Module\<module> namespace
refs #4586
2013-09-04 11:21:11 +02:00
Jannis Moßhammer
67fcb09a89 Merge branch 'bugfix/proper-datetime-validation-4581'
fixes #4581
2013-09-04 11:06:51 +02:00
Jannis Moßhammer
a0e63a1320 Fix error message and move validation in own DateTimeValidator
refs #4581
refs #4632
2013-09-04 11:06:36 +02:00
Johannes Meyer
4d040fd761 Adjust command forms and tests
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
2013-09-04 11:06:36 +02:00
Johannes Meyer
14b56151aa Move configuration and preference handling to Form base class
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.

refs #4581
2013-09-04 11:06:24 +02:00
Johannes Meyer
86d721c317 Merge branch 'bugfix/proper-datetime-validation-4581'
fixes #4581
fixes #4632
2013-09-03 09:27:39 +02:00
Johannes Meyer
23f0962da1 Adjust command forms and tests
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
368bd3c9c7 Refactor datetime validation
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.

refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
1a003f8c8b Move configuration and preference handling to Form base class
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.

refs #4581
2013-09-03 09:27:02 +02:00
Eric Lippmann
30e36f1e09 Merge branch 'bugfix/pagination-fixes-4589'
fixes #4589
fixes #4591
fixes #4572
2013-09-02 18:43:16 +02:00
Eric Lippmann
b09b3676de Rename determineAuthenticationState to requiresLogin
refs #4572
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
9f923b4940 Fix pagination and remove ModuleController, rename handlesAuth
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
  therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
  so we don't need to overwrite the preDispatch method

refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
aac1d69ed2 Fix count query ignoring joins
Count queries were created before the required columns were added,
so they often returned more values than a resultset really offers

refs #4589
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
cce217c7c2 Merge branch 'bugfix/correct-check-result-type-distinction-4600'
fixes #4600
2013-09-02 17:24:53 +02:00
Johannes Meyer
d8eccd3858 Skip regression tests if no configuration available
refs #4600
refs #4666
2013-09-02 17:24:43 +02:00