Johannes Meyer
411c6e0546
Navigation: Fix that a module's item class is not found
...
refs #5600
2015-09-07 12:01:05 +02:00
Eric Lippmann
0f8c28d749
Merge branch 'master' into feature/api-9606
2015-09-07 11:33:44 +02:00
Johannes Meyer
f9b68b683b
NavigationItem: Consider unknown properties as element attributes
...
refs #5600
2015-09-07 09:49:05 +02:00
Johannes Meyer
ca72bd5455
NavigationRendererInterface: Use "div" as default outer element tag
...
"nav" is less often necessary.
refs #5600
2015-09-07 09:48:32 +02:00
Johannes Meyer
e63e15e471
Add class DashboardPane
...
refs #5600
2015-09-07 09:06:40 +02:00
Johannes Meyer
b5711f4031
Dashboard: Load panes by utilizing the new Navigation
...
This is only a quick fix to avoid adjusting the complete dashboard
implementation.
refs #5600
2015-09-07 09:05:50 +02:00
Johannes Meyer
a3539b0817
Navigation: Fix method getActiveItem() failing badly for empty navigations
...
refs #5600
2015-09-07 08:37:06 +02:00
Johannes Meyer
6dd49761ff
Navigation: Add method getActiveItem()
...
refs #5600
2015-09-04 16:21:09 +02:00
Johannes Meyer
6967fffb1f
Navigation: Add support dashboard-panes and check module permissions
...
refs #5600
2015-09-04 15:51:51 +02:00
Johannes Meyer
2af06e9415
NavigationItem: Re-introduce a default priority of 100
...
refs #5600
2015-09-04 14:20:21 +02:00
Johannes Meyer
b2a0f1b9c2
Navigation: Peform a case-insensitive search when merging items
...
refs #5600
2015-09-04 14:17:16 +02:00
Johannes Meyer
63f8f34c15
Navigation: Add method load()
...
Supports currently only module menus.
refs #5600
2015-09-04 13:55:31 +02:00
Johannes Meyer
881880f18f
SummaryNavigationItemRenderer: Fix method getTitle()
...
refs #5600
2015-09-04 13:48:29 +02:00
Johannes Meyer
8e24ec978d
BadgeNavigationItemRenderer: Use view() instead of getView()
...
refs #5600
2015-09-04 13:47:57 +02:00
Johannes Meyer
044fe031da
NavigationItemRenderer: Add method init()
...
refs #5600
2015-09-04 13:47:38 +02:00
Johannes Meyer
1a42c04c8e
NavigationItem: Fix locating a module's custom navigation renderer
...
refs #5600
2015-09-04 13:47:17 +02:00
Matthias Jentsch
ca33e71f2d
Deduplicate and clean up service summary component
...
Remove redundant component view script and streamline subFilter handling in all views that render it. Remove
heading from component to allow embedding in different types of views.
refs #10033
2015-09-04 13:02:57 +02:00
Johannes Meyer
5ff3db8a3c
Url: Explicitly handle '#'
...
Feels like a quick&dirty solution. Feel free to improve it.
refs #5600
2015-09-04 10:34:39 +02:00
Johannes Meyer
07588595f2
NavigationItem: Automatically determine whether it's active or not
...
refs #5600
2015-09-04 10:10:33 +02:00
Johannes Meyer
baefc89f85
NavigationRenderer: Provide a id for outer item markup (<li>)
...
refs #5600
2015-09-04 09:41:39 +02:00
Johannes Meyer
2855778dc7
Revert "NavigationItemRenderer: Provide a id if none is set"
...
This reverts commit c60839d798
.
2015-09-04 09:38:03 +02:00
Johannes Meyer
975cc92f6b
NavigationItem: Provide "#" as default url for items with children
...
refs #5600
2015-09-04 09:31:23 +02:00
Johannes Meyer
4e948b46bf
NavigationRenderer: Add id "navigation" to the navigation's heading
...
refs #5600
2015-09-04 09:26:28 +02:00
Johannes Meyer
c60839d798
NavigationItemRenderer: Provide a id if none is set
...
refs #5600
2015-09-04 09:25:58 +02:00
Johannes Meyer
a8d5a78aa2
NavigationItem: Fix method getUniqueName()
...
refs #5600
2015-09-04 09:25:25 +02:00
Johannes Meyer
a6b2c23684
Update navigation rendering code to fit the previous adjustments
...
refs #5600
2015-09-04 09:08:20 +02:00
Johannes Meyer
9e558c9861
Add class SummaryNavigationItemRenderer
...
refs #5600
2015-09-03 15:53:42 +02:00
Johannes Meyer
ad6a2938ab
Add class BadgeNavigationItemRenderer
...
refs #5600
2015-09-03 15:53:23 +02:00
Johannes Meyer
b53fb04a0f
Move navigation related renderer classes to the new namespace
...
refs #5600
2015-09-03 15:52:37 +02:00
Johannes Meyer
7adfc58878
NavigationItem: Add missing return keyword in method render()
...
refs #5600
2015-09-03 15:04:39 +02:00
Johannes Meyer
a930ea7f7a
Navigation: Add method render()
...
refs #5600
2015-09-03 15:04:07 +02:00
Johannes Meyer
9a725330fb
NavigationItem: Provide the item to the renderer before calling render
...
refs #5600
2015-09-03 14:22:38 +02:00
Johannes Meyer
16ece09b0a
NavigationItemRenderer: Add option $target
...
refs #5600
2015-09-03 13:36:34 +02:00
Johannes Meyer
67dee62c57
NavigationItemRenderer: Add support for options
...
refs #5600
2015-09-03 13:36:13 +02:00
Johannes Meyer
c3ad665c15
Navigation: Fix accessing a non-existent and static variable
...
refs #5600
2015-09-03 12:52:07 +02:00
Johannes Meyer
c35db55857
Navigation: Add missing new keyword
...
refs #5600
2015-09-03 11:26:27 +02:00
Johannes Meyer
2834e206d5
NavigationItem: Add support for custom renderers
...
refs #5600
2015-09-03 11:25:51 +02:00
Johannes Meyer
811269df01
NavigationItem: Rename method getView() to view()
...
refs #5600
2015-09-03 10:39:11 +02:00
Johannes Meyer
206168672b
NavigationItem: Add method getUniqueName()
...
refs #5600
2015-09-03 10:22:47 +02:00
Johannes Meyer
e6a6ae996a
Navigation: Merge other navigations more sophisticated
...
refs #5600
2015-09-03 09:57:52 +02:00
Johannes Meyer
537db6000e
NavigationItem: Add method merge()
...
refs #5600
2015-09-03 09:56:22 +02:00
Johannes Meyer
a626e8f7fb
NavigationItem: Allow to set and get single url parameters
...
refs #5600
2015-09-03 09:56:02 +02:00
Johannes Meyer
1fb5c96ef1
Navigation: Add method order()
...
refs #5600
2015-09-03 08:52:02 +02:00
Johannes Meyer
00447488ee
NavigationItem: Drop interface Countable
...
$item->count(), count of what?
$item->getChildren()->count(), Its children, of course!
refs #5600
2015-09-03 08:49:30 +02:00
Johannes Meyer
f4a6ab73c0
NavigationItem: Add property priority
...
refs #5600
2015-09-03 08:33:13 +02:00
Johannes Meyer
1393db687b
NavigationItem: Adjust some docblocks
...
refs #5600
2015-09-02 15:42:54 +02:00
Johannes Meyer
298c4ad38b
NavigationItem: Cast a string to Url already in setUrl()
...
refs #5600
2015-09-02 15:35:08 +02:00
Johannes Meyer
1788cc9b6a
NavigationItem: Use setView() to initiliaze $view
...
refs #5600
2015-09-02 15:33:45 +02:00
Johannes Meyer
6802c0a9e4
NavigationItem: Do not disable the complete parent hierarchy..
...
..if just a child gets deactivated.
refs #5600
2015-09-02 15:32:37 +02:00
Johannes Meyer
2bfeb335a5
NavigationItem: Add method setParent() and getParent()
...
refs #5600
2015-09-02 15:30:35 +02:00
Johannes Meyer
e2beb7d027
NavigationItem: Return the name if no label is set in getLabel()
...
refs #5600
2015-09-02 15:27:34 +02:00
Johannes Meyer
1ef4a2f7d0
NavigationItem: Do not provide a default for setProperties()
...
refs #5600
2015-09-02 15:26:07 +02:00
Johannes Meyer
8a29660226
NavigationItem: Overwrite the property in method setAttributes()
...
A setter sets something instead of patching it.
refs #5600
2015-09-02 15:25:10 +02:00
Johannes Meyer
5efcb18fa0
NavigationItem: Set the parent on a child in method setChildren()
...
refs #5600
2015-09-02 15:21:40 +02:00
Johannes Meyer
c9050e2f21
NavigationItem: Initialize $children before setting the properties
...
refs #5600
2015-09-02 15:20:26 +02:00
Johannes Meyer
62f7a49a45
NavigationItem: Reduce code complexity in method addChild()
...
refs #5600
2015-09-02 15:17:26 +02:00
Johannes Meyer
c03109c4c6
NavigationItem: Catch exceptions thrown in __toString()
...
refs #5600
2015-09-02 15:16:05 +02:00
Johannes Meyer
95a3f1c011
Navigation: Clear the parent name from a configured navigation item
...
refs #5600
2015-09-02 15:14:55 +02:00
Johannes Meyer
29413360d9
Navigation: Add method merge()
...
refs #5600
2015-09-02 13:34:56 +02:00
Johannes Meyer
a4c2081f64
Navigation: Remove method hasItems()
...
Redundant, as it's expressible with "! $nav->isEmpty()".
refs #5600
2015-09-02 13:29:07 +02:00
Johannes Meyer
f449c78dbf
NavigationItem: Make it having a name instead of a id..
...
..and require it as first argument on construction time.
refs #5600
2015-09-02 13:27:12 +02:00
Johannes Meyer
b3159ee60d
NavigationItem: Accept arrays for method setChildren()
...
refs #5600
2015-09-02 12:59:05 +02:00
Johannes Meyer
83974b7698
Navigation: Add method fromConfig()
...
refs #5600
2015-09-02 12:58:12 +02:00
Johannes Meyer
997b57834c
Navigation: Add method fromArray()
...
refs #5600
2015-09-02 12:57:49 +02:00
Johannes Meyer
0788041c43
Navigation: Accept item configuration for method addItem()
...
And check an item's permission.
refs #5600
2015-09-02 12:57:14 +02:00
Johannes Meyer
c154f96d44
Navigation: Add method createItem()
...
refs #5600
2015-09-01 16:02:44 +02:00
Eric Lippmann
52b0c8c258
lib: Add navigation classes (WIP)
...
- Lacks custom renderer functionality
- Lacks navigation item priorities
- Lacks permission handling
refs #5600
2015-09-01 12:48:45 +02:00
Eric Lippmann
4fb6856caf
Fix exception when navigating to the preferences after namespacing all controllers
2015-08-31 10:19:30 +02:00
Eric Lippmann
e7e1b1a98e
Dispatcher: Default to the default module if no module has been given in the request
...
This is most likely the case when custom routes have been added to the router w/o the module parameter being set.
refs #5786
2015-08-28 13:13:20 +02:00
Eric Lippmann
9cf56410e9
lib: Fix PHPDoc of Form::populate()
2015-08-27 15:52:13 +02:00
Eric Lippmann
4070f6c75b
Merge branch 'master' into feature/namespaced-controllers-5786
2015-08-27 15:05:44 +02:00
Eric Lippmann
28009eb563
Rename controller namespace to Controllers
...
refs #5786
2015-08-27 13:03:45 +02:00
Eric Lippmann
c294283636
Merge branch 'bugfix/service-grid-grouping-postgres-9333'
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
fixes #9333
fixes #9538
2015-08-27 12:58:49 +02:00
Johannes Meyer
8cc1970a9f
SearchDashboard: Use t() instead of the view helper
...
Since it's library code we do not need to use the module-aware
translation helper.
2015-08-25 16:51:50 +02:00
Eric Lippmann
c8790fad93
Merge branch 'bugfix/service-grid-display_name-9538' into bugfix/service-grid-grouping-postgres-9333
...
Conflicts:
library/Icinga/Data/PivotTable.php
modules/monitoring/application/controllers/ListController.php
2015-08-25 15:51:20 +02:00
Eric Lippmann
96fb3b5d4b
Merge branch 'master' into feature/api-9606
2015-08-25 09:25:59 +02:00
Eric Lippmann
ec390d7a8b
lib: Add Controller::httpBadRequest() for responding w/ HTTP 400 immideately
...
refs #9606
2015-08-24 15:59:59 +02:00
Johannes Meyer
7c86f19aee
SearchDashboard: Utilize createDashlet() and set a progress label
...
refs #8848
2015-08-24 12:36:59 +02:00
Johannes Meyer
320a4080ec
Dashlet: Add support for CSS animated progress labels
...
refs #8848
2015-08-24 12:36:35 +02:00
Johannes Meyer
db4c81a093
Pane: Add method createDashlet()
...
refs #8848
2015-08-24 12:35:38 +02:00
Eric Lippmann
ceaba90872
css: Load mixins.less
2015-08-21 16:45:05 +02:00
Matthias Jentsch
675a130787
Fix active configuration/application menu highlighting
...
Fix a bug that caused the application config to not be set to active when navigating through history.
refs #9761
2015-08-21 16:04:04 +02:00
Johannes Meyer
d31b60102e
Form: Fix that form titles are missing
...
The description may not be set at the time
loadDefaultDecorators() is called.
2015-08-21 14:20:09 +02:00
Johannes Meyer
9ca278d7b2
Merge branch 'master' into feature/activity-indicators-for-form-submits-8369
2015-08-21 13:37:54 +02:00
Johannes Meyer
fbca28c024
Form: Only add a form header if a description is set
...
refs #8369
2015-08-21 13:34:17 +02:00
Johannes Meyer
747f6dcf77
Form: Show the form autosubmit warning in the header tag...
...
...and use a unique id for the progress element.
refs #8369
2015-08-21 11:40:38 +02:00
Eric Lippmann
85ef98f72d
lib: Add PHPDoc to Request::hasCookieSupport()
2015-08-21 11:27:03 +02:00
Johannes Meyer
b9d64b40a4
forms.less: Fix help icon layout
2015-08-21 10:36:08 +02:00
Johannes Meyer
7244906515
Wizard: Use a constant for the name and id of the progress element
...
refs #8369
2015-08-21 10:16:23 +02:00
Johannes Meyer
07b17cc701
Wizard: Add Spinner decorator to the first (and only) submit button
...
refs #8369
2015-08-21 09:52:57 +02:00
Matthias Jentsch
44271471e3
Allow declarative definitions of badge renderers and improve interface
...
Allow the data backend, columns and generated tooltips to be defined in the configuration instead of providing subclasses for every new configuration. Provide an abstract BadgeMenuItemRenderer that allows creating Badges with less boilerplate.
fixes #9694
2015-08-20 18:16:33 +02:00
Johannes Meyer
46cd47b73c
Form: Automatically set data-progress-element...
...
..for forms with form based autosubmit warnings.
refs #8369
2015-08-20 16:54:20 +02:00
Johannes Meyer
32f8c0770c
Wizard: Use a single spinner for all submit buttons
...
refs #8369
2015-08-20 16:13:56 +02:00
Johannes Meyer
20f144bd4b
Spinner: Accept option `id'
...
refs #8369
2015-08-20 16:13:30 +02:00
Eric Lippmann
c5f444efe8
lib: Don't alias Zend classes in the ActionController
2015-08-20 16:10:39 +02:00
Eric Lippmann
6ca02a519b
lib: Fix type hint of Controller::getResponse()
2015-08-20 16:07:24 +02:00
Eric Lippmann
1c5a784022
lib: Move Request::sendJson() to Response::sendJson()
...
refs #9606
2015-08-20 16:05:45 +02:00
Eric Lippmann
870b73ae09
lib: Rename Request::getIsApiRequest() to ::isApiRequest()
...
There's no setter involved.
refs #9606
2015-08-20 16:02:25 +02:00
Eric Lippmann
62f0281a62
lib: Fix type hint of Controller::getRequest()
2015-08-20 16:00:24 +02:00
Eric Lippmann
1130e453f6
lib: Fix typos in the Form's PHPDoc
2015-08-20 15:57:52 +02:00
Eric Lippmann
f9f813e50b
lib: Fix PHPDoc of Form::populate()
2015-08-20 15:56:45 +02:00
Eric Lippmann
0ce4e12db8
lib: Fix type hints for Form::getElements()
2015-08-20 15:55:18 +02:00
Eric Lippmann
dd23bd9397
Form: Respond w/ JSON-encoded messages if API requests fail
...
refs #9606
2015-08-20 15:48:42 +02:00
Johannes Meyer
a77dc3665c
Form: Show a spinner for ongoing form submits
...
This will only be shown if there's no progress label set.
refs #8369
2015-08-20 15:05:02 +02:00
Johannes Meyer
275b57cb69
Form: Allow to set a progress label
...
refs #8369
2015-08-20 15:04:15 +02:00
Johannes Meyer
690d60672c
Introduce form element decorator Spinner
...
refs #8369
2015-08-20 14:34:43 +02:00
Eric Lippmann
71ff4512c3
lib/form: Bypass sent and submit handling if the form is an API target
...
refs #9606
2015-08-20 13:11:36 +02:00
Eric Lippmann
e07cdd21ac
lib: Add Request::sendJson()
...
refs #9606
2015-08-20 13:11:36 +02:00
Johannes Meyer
63e639caf0
Handle module identification directly in the ActionController
...
Fixes some issues with more complex customisations in a
module's controller.
Obsoletes: 93f8297344
2015-08-19 13:39:46 +02:00
Johannes Meyer
036da072c5
Revert "ActionController: Give modules a chance to dynamically require auth"
...
This reverts commit 93f8297344
.
2015-08-19 13:39:46 +02:00
Eric Lippmann
1492218962
Fix SortBox not usable w/o SortRules
...
The SortBox assumes the first avaiable sort column as default column if the given Sortable does not implement the SortRules interface.
When changing the direction of the default sort column, the sort box did not pass the column to Sortable::sort(). Thus the Sortable did not know by which column to sort.
Now the SortBox passes the sort column even if the direction of the default column is changed.
refs #9333
2015-08-18 14:18:48 +02:00
Johannes Meyer
93f8297344
ActionController: Give modules a chance to dynamically require auth
2015-08-18 11:28:02 +02:00
Eric Lippmann
e31dce97a9
Fix dispatching namespaced module controllers
...
refs #5786
2015-08-18 11:11:28 +02:00
Johannes Meyer
e5f249270a
Merge branch 'master' into feature/provide-a-complete-list-of-filter-columns-9029
2015-08-17 15:41:40 +02:00
Johannes Meyer
f7b0e6956d
FilterEditor: Only apply the filter if a query is set
...
refs #9029
2015-08-17 13:43:48 +02:00
Eric Lippmann
7252f3237a
Introduce a constant for the controller namespace
...
refs #5786
2015-08-17 13:43:34 +02:00
Eric Lippmann
06e879f078
Throw an expcetion in our Dispatcher if the controller is not an instance of Zend_Controller_Action_Interface
...
refs #5786
2015-08-17 13:38:16 +02:00
Eric Lippmann
e26a7fd4d1
Use Zend_Cotroller_Dispatcher_Standard::getActionMethod() in the Dispatcher
...
refs #5786
2015-08-17 13:34:47 +02:00
Eric Lippmann
965fee1e9e
Fix 'void' method result used in the Dispatcher
...
refs #5786
2015-08-17 13:31:05 +02:00
Eric Lippmann
8b32edd6e9
Default to Zend's dispatcher if the controller name is empty
...
refs #5786
2015-08-17 13:29:47 +02:00
Eric Lippmann
e8c0e97bb3
Add PHPDoc to the Dispatcher
...
refs #5786
2015-08-17 13:10:01 +02:00
Eric Lippmann
f972a034e7
Fix license header in Dispatcher
...
refs #5786
2015-08-17 13:08:41 +02:00
Eric Lippmann
392eee5a1f
Merge branch 'master' into feature/namespaced-controllers-5786
...
Conflicts:
library/Icinga/Application/Web.php
2015-08-17 12:59:44 +02:00
Johannes Meyer
97245c5166
FilterEditor: Uppercase all words for non labelled filter columns
...
refs #9029
2015-08-14 15:36:54 +02:00
Johannes Meyer
ca4789f114
FilterEditor: Fix automatic filter label creation
...
refs #9029
2015-08-13 17:20:40 +02:00
Johannes Meyer
1e6c394693
Controller: Create the filter editor in setupFilterControl() ...
...
...instead of demanding a concrete controller to do so.
We still have to decide how to handle parameter preservation
properly.
refs #9029
2015-08-13 17:05:13 +02:00
Johannes Meyer
63fb8dcafa
FilterEditor: Do not show an empty line at the bottom of the select
2015-08-13 15:59:00 +02:00
Johannes Meyer
41b80efa0e
FilterEditor: Support queries implementing the FilterColumns interface
...
refs #9029
2015-08-13 15:58:04 +02:00
Johannes Meyer
2e7ff7dd6e
FilterEditor: Require an instance of Filterable for setQuery()
...
refs #9029
2015-08-13 11:35:45 +02:00
Johannes Meyer
fc35f3e46b
FilterEditor: Apply the filter on the query internally
...
refs #9029
2015-08-13 11:33:25 +02:00
Johannes Meyer
069fcc40ea
FilterEditor: Accept null for method setColumns()
...
refs #9029
2015-08-13 11:30:26 +02:00
Johannes Meyer
9ad14fc644
FilterEditor: Accept null for method setSearchColumns()
...
refs #9029
2015-08-13 11:30:05 +02:00
Alexander Fuhr
a9ff6eebc0
Merge branch 'master' into bugfix/cookie-support-7383
2015-08-13 11:22:14 +02:00
Alexander Fuhr
813154f6ef
Cookie: Make it no static and use the request
...
refs #7383
2015-08-13 11:19:48 +02:00
Alexander Fuhr
2332b94f0b
Request: Add getResponse() to retrieve the Response
...
refs #7383
2015-08-13 11:19:08 +02:00
Johannes Meyer
fa1e3a763d
Do not show the full layout on the login page
...
...
refs #9892
2015-08-13 08:12:30 +02:00
Alexander Fuhr
ad8f16c185
Cookie: Set the rigth license line header
...
refs #7383
2015-08-11 16:37:05 +02:00
Alexander Fuhr
cea3727c97
Merge conflicts
2015-08-11 16:35:14 +02:00
Eric Lippmann
aa4e3c5a22
Dashboard: Defer construction of the Url object to Dashlet::getUrl()
...
Before, the Url object was constructed in Dashlet::setUrl() and Dashlet::__construct8) which lead to an exception when parsing a module's configuration.php from our CLI.
refs #9375
2015-08-10 14:05:08 +02:00
Eric Lippmann
1363ea4370
Menu: Defer construction of the Url object to Menu::getUrl()
...
Before, the Url object was constructed in Menu::setUrl() which lead to an exception when parsing a module's configuration.php from our CLI.
refs #9375
2015-08-10 14:05:00 +02:00
Johannes Meyer
c7cc9e66df
JavaScript: Load all available module javascript files
...
refs #9702
2015-08-06 15:15:02 +02:00
Johannes Meyer
9cea83242c
StyleSheet: Load all available module stylesheets
...
refs #9702
2015-08-06 15:14:29 +02:00
Markus Frosch
083900dae0
Implement DblClickSelect as a Icinga Behavior
...
refs #9826
2015-08-04 14:06:33 +02:00
Eric Lippmann
688a08585b
Merge branch 'master' into bugfix/error-prone-generictts-9611
...
Conflicts:
modules/monitoring/application/views/scripts/show/components/downtime.phtml
2015-08-03 15:05:45 +02:00
Eric Lippmann
ea5db51213
Fix "Try to get an inexistent pane." when clicking on the "Search" tab
2015-08-03 13:01:11 +02:00
Eric Lippmann
139baffdc6
lib: Make Dashboard::$tabs protected
...
The SearchDashboard has to override Dashboard::getTabs() in order to set up the correct tab.
2015-08-03 13:01:11 +02:00
Eric Lippmann
177fafaa56
lib: Fix TicketHook's PHPDoc
...
refs #9611
2015-08-03 11:05:48 +02:00
Eric Lippmann
451be1e97f
monitoring/hooks: Add TicketHook::createLinks()
...
Instead of calling preg_replace_callback w/o error handling in our view scripts, TicketHook::createLinks() will take care of that.
refs #9611
2015-07-31 15:31:41 +02:00
Johannes Meyer
6c105b867e
Form: Be less error-prone while calling array_search
2015-07-31 11:05:09 +02:00
Johannes Meyer
5345831742
SessionNamespace: Be less error-prone while calling array_search
2015-07-31 11:04:51 +02:00
Johannes Meyer
449a19c3a3
Session: Be less error-prone while calling array_search
2015-07-31 11:04:43 +02:00
Johannes Meyer
24cb123f47
Tabs: Be less error-prone while calling array_search
2015-07-31 11:04:36 +02:00
Eric Lippmann
a234852f32
Merge branch 'feature/basic-auth-9660'
...
resolves #9660
2015-07-30 15:05:07 +02:00
Eric Lippmann
9060e8a034
lib: Only call Icinga::app()->getRequest() for getting the request outside of a controller
...
Saves a call to getFrontController().
refs #9660
2015-07-30 14:02:44 +02:00
Eric Lippmann
81aad9d6a6
Rename Notifiation::getMessages() to popMessages()
...
Because the call to popMessages()--before getMessages()--automatically resets the notification messages on the instance, popMessages() is a much better name for the method.
refs #9660
2015-07-30 13:45:39 +02:00
Eric Lippmann
d545e1f7d1
lib: Don't write the empty notifications array into the session
...
I combined this w/ introducing some constants for notification types and PHPDoc.
refs #9660
2015-07-30 13:42:59 +02:00
Eric Lippmann
9aa1599a18
Form: Disable CSRF counter measure only on API requests
...
refs #9660
2015-07-30 12:04:22 +02:00
Eric Lippmann
c23c7a5fa9
lib: Add Request::getIsApiRequest()
...
If the Accept header is set to application/json it's an API request.
refs #9660
2015-07-30 12:03:33 +02:00
Eric Lippmann
db505281ee
lib: Disable CSRF token on HTTP authenticated users and not XHR
...
refs #9660
2015-07-30 09:33:04 +02:00
Eric Lippmann
9f0e48a0a1
Don't send the X-Icinga-Module header more than once
...
fixes #9349
2015-07-30 09:28:05 +02:00
Matthias Jentsch
20aa17c831
Merge branch 'bugfix/selected-row-lost-after-autorefresh-8623'
...
fixes #8623
2015-07-29 17:30:45 +02:00
Matthias Jentsch
3e7cc299ec
Fix issue that caused the refresh button to remove side bar
...
Do not apply base target globally for all toolbar elements, but specifically for those that should remove side-bars.
refs #8623
refs #6436
2015-07-29 17:18:52 +02:00
Thomas Gelf
ba906d2fca
FilterEditor: allow to set custom filter columns
2015-07-29 17:13:18 +02:00
Eric Lippmann
432efcb089
lib: Handle Response::setRerenderLayout() correctly
...
The header is different if it's not a redirect.
refs #9660
2015-07-29 15:08:36 +02:00
Eric Lippmann
aaae7e03b4
lib: Introduce Response::setRerenderLayout()
...
Instead of handling response headers based on flags in our controllers, this should happen in the request for usage w/o controllers.
refs #9660
2015-07-29 14:39:45 +02:00
Eric Lippmann
91720810cc
lib: Document Response::redirectAndExit()
...
refs #9660
2015-07-29 14:22:45 +02:00
Eric Lippmann
a31c799043
lib: Introduce Response::getRequest()
...
refs #9660
2015-07-29 14:20:39 +02:00
Eric Lippmann
07849e0fea
lib: Rename Authentication/Manager to Authentication/Auth
...
refs #9660
2015-07-28 17:08:55 +02:00
Eric Lippmann
7cfc78558d
Merge branch 'master' into feature/secure-modules-9644
...
Conflicts:
library/Icinga/Exception/IcingaException.php
2015-07-28 13:42:02 +02:00
Johannes Meyer
e231ef8061
SortBox: Fix some documenation and code style issues
2015-07-28 12:04:16 +02:00
Johannes Meyer
f7b35b04f4
SortBox: Properly apply sort rules and show the user the default
...
refs #6644
2015-07-28 12:03:50 +02:00
Eric Lippmann
78285b95a3
Make Controller::httpNotFound() variadic
...
refs #9644
2015-07-28 10:40:02 +02:00
Johannes Meyer
4d9aa54814
SortBox: Utilize a separate form for each control
...
refs #9421
2015-07-27 11:43:47 +02:00
Johannes Meyer
86ad6c48ff
Form: Automatically remove query parameters only for GET forms
...
refs #9421
2015-07-27 08:52:33 +02:00
Eric Lippmann
8358e9165c
Don't require the module permission for the default module
...
refs #9644
2015-07-24 15:11:21 +02:00
Thomas Gelf
727a2d7141
Paginator: relax requirements to Paginatable
...
* we need no full query interface here
* introduced new interface "Paginatable"
fixes #9483
2015-07-23 13:48:49 +02:00
Eric Lippmann
a34ad0227f
Don't load module menu entries if the authenticated user lacks the module permission
...
refs #9644
2015-07-23 12:59:30 +02:00
Eric Lippmann
fd77c30838
Don't load module dashboards if the authenticated user lacks the module permission
...
refs #9644
2015-07-23 12:57:23 +02:00
Eric Lippmann
e8e01257e6
Change interface of SearchDashboard to allow setting a user before calling ::search()
...
Because search dashlets are provided by modules, the authenticated user's module permissions have to be validated before loading search dashlets provided by modules.
refs #9644
2015-07-23 12:53:08 +02:00
Eric Lippmann
b4f4ce4406
Require the module's permission for every module automatically
...
Module permissions are not required if authentication is disabled on the controller.
refs #9644
2015-07-23 12:51:10 +02:00
Eric Lippmann
b000ae3a37
Do not require permissions if authentication is not required
...
refs #9644
2015-07-23 12:50:02 +02:00
Eric Lippmann
aa567f8cd7
Introduce ModuleActionController::$requiresModulePermission
...
refs #9644
2015-07-22 14:56:02 +02:00
Eric Lippmann
13d954a956
Fix rawurlencode call
2015-07-22 13:36:25 +02:00
Eric Lippmann
52e352751e
Revert "ModuleActionController: fix forward/X-Icinga-Module"
...
This reverts commit bf82bd4ce1
.
We have a not merged branch for this.
refs #9349
2015-07-22 13:34:44 +02:00
Markus Frosch
ab8e775188
Fix duplicate headers on forward() inside a controller
...
This avoids that the JS loader flattening arrays.
refs #9349
2015-07-22 13:34:44 +02:00
Johannes Meyer
54a77b7253
Merge branch 'master' into feature/support-for-file-uploads-8758
2015-07-22 13:30:56 +02:00
Johannes Meyer
a199d36207
Stylesheet: Disable extendend @import statements provided by LESS
...
fixes #9687
2015-07-22 12:45:10 +02:00
Thomas Gelf
bf82bd4ce1
ModuleActionController: fix forward/X-Icinga-Module
2015-07-22 10:53:42 +02:00
Johannes Meyer
cecd94be50
Merge branch 'master' into feature/support-for-file-uploads-8758
2015-07-22 08:47:24 +02:00
Johannes Meyer
c0de2e6ee3
Form: Add missing use statement for the ProgrammingError exception
2015-07-22 08:39:24 +02:00
Eric Lippmann
ce2b686252
Add file and line of logged menu item renderer exceptions
...
fixes #9696
2015-07-21 16:54:23 +02:00
Johannes Meyer
8f2849f32a
Form: Improve code readability..
...
..and avoid the necessity to provide another mock when testing
Form::handleRequest().
refs #8758
2015-07-21 16:48:56 +02:00
Johannes Meyer
7c89887773
Form: Provide an absolute url as redirect url for successful frame uploads
...
refs #8758
2015-07-21 16:35:56 +02:00
Johannes Meyer
6c9819204d
Form: Only work with a single type when handling redirect urls
...
$form->setRedirectUrl('some/url') still works, but $form->getRedirectUrl()
will only return instances of Icinga\Web\Url now.
2015-07-21 16:33:24 +02:00
Johannes Meyer
fc481e527b
Form: Process request parameter _frameUpload
...
This parameter is being used to flag a request as form submission issued
by utilizing an iframe. Appending it to a form's action causes no redirection
to take place in case of successful submission and a reduced but still valid
layout to be printed in any way. Redirection must be handled by the client
regarding the meta tag "redirectUrl".
refs #8758
2015-07-21 15:22:24 +02:00
Johannes Meyer
0a9a066749
Form: Do not create a new instance of Url when returning the redirect url
...
We're shifting parameters and by creating a new instance we'll lose
such changes.
refs #8758
2015-07-21 15:13:56 +02:00
Johannes Meyer
47fbc24f17
Merge branch 'master' into bugfix/improve-form-notifications-8983
...
Conflicts:
library/Icinga/Web/Form.php
modules/setup/application/forms/AdminAccountPage.php
2015-07-20 15:52:10 +02:00
Johannes Meyer
2164bb86c8
Tabs: Do not create a new instance of Url when rendering the refresh url
...
We're shifting parameters and by creating a new instance we'll lose
such changes.
refs #8758
2015-07-16 11:27:31 +02:00
Johannes Meyer
549f36f82c
Form: Do not create a new instance of Url when setting the action
...
We're shifting parameters and by creating a new instance we'll lose
such changes.
refs #8758
2015-07-16 11:27:02 +02:00
Johannes Meyer
d192410435
Introduce GET parameter _disableLayout to ... disable the entire layout
...
refs #8758
2015-07-16 11:23:48 +02:00