tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
13,897 Commits 119 Branches 71 Tags 80 MiB
Commit Graph

1791 Commits

Author SHA1 Message Date
Sukhwinder Dhillon be060edd9f AllcontactsQuery: Add `$baseQuery` explicitly as non-dynamic property 2023-08-23 10:53:14 +02:00
raviks789 e0f02c1d62 `CustomVarTable`: Import `Closure` 
The property `$hookApplier` is of type `Closure`, hence it has been imported.
 2023-08-23 10:53:14 +02:00
raviks789 d22d2fb1e0 `HoststatussummaryQuery`: Fix name case for `HoststatusQuery` 2023-08-23 10:53:13 +02:00
raviks789 b481a771d0 `ServicestatussummaryQuery`: Fix name case for `ServicestatusQuery` 2023-08-23 10:53:13 +02:00
raviks789 caede2aaa9 `MonitoringBackend`: Import interface `QueryInterface` 
The return type of `modules/monitoring/library/Monitoring/Backend/MonitoringBackend::query()` is `Icinga\Data\QueryInterface`.
Hence this interface is imported in `MonitoringBackend::class`.
 2023-08-23 10:53:13 +02:00
raviks789 a68e0595ff `CommandTransport`: Fix return type for method `createTransport()` 
`Icinga\Module\Monitoring\Command\Transport\CommandTransport::createTransport()` also returns `Icinga\Module\Monitoring\Command\Transport\ApiCommandTransport::class`.
Hence it is added to the method's return type in PHPDoc.
 2023-08-23 10:53:13 +02:00
raviks789 d7518388d8 `RemoteCommandFile`: Define parameter `$resource` as nullable for method `setResource()` 2023-08-23 10:53:13 +02:00
raviks789 3d61fe6bf2 `MonitoringWizard`: Fix type for parameter `$page` of method `setupPage()` 
The `$page` parameter for `Icinga\Module\Monitoring\MonitoringWizard::setupPage()` can also be
`Icinga\Module\Setup\Forms\RequirementsPage` or `Icinga\Module\Setup\Forms\SummaryPage`.
 2023-08-23 10:53:13 +02:00
raviks789 1b1182d9b9 `Macro`: Import generic class `stdClass` 
Generic empty class `stdClass` is imported as it is one of the return type for `Macro::resolveMacro()`
 2023-08-23 10:53:13 +02:00
raviks789 8b6f9fbfed `ObjectList`: Fix return type for `getScheduledDowntimes()` 2023-08-23 10:53:13 +02:00
raviks789 30c26f16fe `ObjectList`: Include `\Icinga\Data\Filter\FilterChain` as return type in `getFilter()` 2023-08-23 10:53:13 +02:00
raviks789 b813e0badb `Perfdata`: Fix return type for method `convert()` 2023-08-23 10:53:13 +02:00
raviks789 8fe428f987 `CustomVarTable`: Cast `$wrapper` to `ipl\Html\HtmlDocument` using inline `@var` in `renderGroup()` 2023-08-23 10:53:13 +02:00
raviks789 00f367c7d6 `MonitoredObjectController`: Access `MonitoredObject::fetchEventhistory()` with correct name case 2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon 72d155c57d Remove not in use class `Plugin.php` 2023-08-23 10:53:13 +02:00
Gianluca Piccolo db9888b1f1 Fixes #5020 2023-06-22 15:11:39 +02:00
Thomas Gelf 463cc748bf MonitoringBadgeNavigationItemRenderer: do not fail 
...on wildcard filter
 2023-06-22 15:07:47 +02:00
Sukhwinder Dhillon ea1e5f9245 TimeLine: Always parse `int` to validateTime() 
Php < 8.1 converts fetched time(stamp) to string. This must always be an int.
 2023-06-22 15:05:10 +02:00
raviks789 bff47213ee Show warning health state badges 
The warning state badges should be shown when notifications or active host/service checks are disabled.
 2022-10-10 10:00:06 +02:00
Johannes Meyer dae7bf4657 Macro: Log the object where a macro is not found 
fixes #3759
 2022-10-10 09:58:39 +02:00
Johannes Meyer 4b60f87021 IdoQuery: Correct doc of method `requireColumn()` 2022-07-05 09:55:32 +02:00
Johannes Meyer e5ec9a36f7 monitoring: Fix conversion rules for timestamps in various queries 2022-07-05 09:55:32 +02:00
Johannes Meyer 3d159fe434 TimeRange: Accept strings in method `validateTime()` 2022-06-30 08:41:47 +02:00
Johannes Meyer ec27f77861 DataView: Relax filter validation again 
There are way too much missing columns in data views all
over the place. I dont' see a justification to fix them
as it's only now this "issue" occurs. It's easier to
revert this change here.

fixes #4797
 2022-06-14 15:32:21 +02:00
Sukhwinder Dhillon 4ab79a6758 DataView: Remove not in use method `applyUrlFilter()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 3b04a0489e Replace class `Backend` use with `MonitoringBackend` and remove class `Backend` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 0db42b32e6 Remove not in use class `Icinga\Module\Monitoring\Environment.php` 2022-06-14 14:24:30 +02:00
Johannes Meyer 46a21d9709 Drop method `DbQuery::whereToSql()` 
It's been used by `DbQuery::renderFilter()` rather
exclusively. So if removing one, both need to go.
 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon be1ff03dd3 MonitoredObject: Remove deprecated methods `matches()` and `fromParams()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 60756afa34 Replace `MonitoringBackend::createBackend()` with `MonitoringBackend::instance()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 49bea36345 MonitoringBackend: Remove deprecated method `createBackedn()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 577d97a450 DataView: Move `sort()` body to `order()` and remove `sort()` and `fromRequest()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon d8ddc6600a overrides `customvarsWithOriginalNames` only if the given object is of type `host` 
A call to `__get()` reset the array if the given `$name` is a customvar
If `service` has a `host` customvar filter, the `fetchHostVariables()`
method was executed and overwrote the `customvarsWithOriginalNames` array.

fixes #4757
 2022-06-13 11:56:57 +02:00
Johannes Meyer 777d146ba1 Perfdata: Avoid passing null to `number_format()` 2022-05-27 14:41:42 +02:00
Johannes Meyer 0f64e24f99 MonitoredObject: Register filters with `whereEx()` 2022-05-12 16:33:30 +02:00
raviks789 8898ed85ab Change FilterMatch to FilterEqual class for single object filter on object name. 
Correspondingly the DbConnection::renderFilter() (as DbQuery::renderFilter() is deprecated and will be removed, hence no modifications here)
is also modified to render accordingly.
This correctly selects the host, service or contact in case the object name contains wild card characters like "\*".
 2022-05-12 16:28:35 +02:00
Johannes Meyer 3edb5c3c94 IdoQuery: Introduce method `whereEx()` 2022-05-12 16:28:35 +02:00
Johannes Meyer c5cf7abf0d IdoQuery: Avoid passing `null` to preg_replace() 
refs #4640
 2022-04-19 15:01:52 +02:00
Johannes Meyer 3dc384fb58 Avoid passing `null` to non-nullable arguments 2022-03-24 12:29:06 +01:00
Johannes Meyer c038e84fc2 Ensure Return Type Compatibility with Internal Classes 2022-03-24 12:29:06 +01:00
Johannes Meyer 0d032989e6 Fix style issues in recent security fixes 2022-03-08 15:20:16 +01:00
Johannes Meyer e815ff0309
Merge pull request from GHSA-qcmg-vr56-x9wf 
Fix/ghsa qcmg vr56 x9wf
 2022-03-08 12:03:41 +01:00
Johannes Meyer 6085b02b16 monitoring: Introduce new class `CustomVarTable` 2022-03-02 10:38:08 +01:00
Johannes Meyer b0a7464795 Introduce new hook `Monitoring/CustomVarRenderer` 2022-03-02 10:38:08 +01:00
Johannes Meyer 8779f9f175 IdoQuery: Join customvars with only live references 2022-02-28 13:08:05 +01:00
Johannes Meyer 1092421782 Ido\Query\: Add objecttype_id checks where missing 2022-02-28 13:07:17 +01:00
Johannes Meyer 00353a1f25
Merge pull request #4660 from Icinga/fix/unhandled-service-counter-not-always-visible-3921 
Drop the unhandled services counter in host lists
 2022-02-28 13:05:29 +01:00
Johannes Meyer e7bc0a136b Perfdata: Render unknown UOMs as-is 2022-02-28 11:53:59 +01:00
Johannes Meyer 796742f03d monitoring/list/hosts: Don't show unhandled service counts 
It has too much problems. It wasn't even visible since the
initial release, at least not if there were many results.
It being visible was more a case of chance than guarantee.
We now also identified a major issue with restrictions and
the way we can assemble queries here. In short, there are
too much technical difficulties that we deemed it not
worthwhile to keep.
 2022-02-25 17:09:13 +01:00
Johannes Meyer 2e9a94144f HostserviceproblemsummaryQuery: Don't clear order of the host status query 2022-02-25 17:08:39 +01:00