49cd55eddd
list/hosts: cleanup, should look like list/services
...
Quite some changes here:
* Compact view should show icons too
* Ignore host icons with legacy HTML hacks
* Remove duplicate code
* Reduce HTML
* Reduce intendation for better readability
* Show attempts on soft states only, even in compact view
* Use the same HTML tags and styles as in list/services
* Fixes nesting error on compact view
2014-08-22 11:06:45 +02:00
968fa0a1cc
Add configuration.php to Doc Module
...
refs #6639
2014-08-22 11:02:08 +02:00
30d0ebcdfd
Make 'modules/monitoring/config.ini' doesn't have to exist
2014-08-21 12:36:28 +02:00
b146a8c311
Relax locale code validation to just a format check
...
fixes #6930
2014-08-21 10:07:07 +02:00
b36fe5d564
Fix version access while refreshing translations
2014-08-21 10:07:07 +02:00
a8d33d90e2
Monitoring\Object: fix a couple of cv-related issues
...
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
2014-08-20 13:36:03 +02:00
bb65fb396a
Merge branch 'bugfix/sensitive-custom-vars-6641'
...
fixes #6641
2014-08-20 12:29:45 +02:00
78b98a7d67
SecurityForm: Add helptext
...
refs #6641
2014-08-20 12:21:11 +02:00
09dfcca0bc
Merge branch 'master' into bugfix/styled-history-views-6637
2014-08-20 11:39:03 +02:00
4ceecf1146
Let comment view look more standardized and add limit control
...
refs #6637
2014-08-20 11:34:24 +02:00
071937910b
Monitoring/Object: filter protected customvars
...
Move the responsibility from the viewscript to Monitoring/Object
refs #6641
2014-08-19 18:46:37 +02:00
ba748cbc4a
Refactor multiSelect and highlight
...
refs #6705
2014-08-19 18:33:28 +02:00
ea0248ecf4
Remove '{{SAVE_ICON}}', tiny design fixes
...
refs #6641
2014-08-19 17:54:22 +02:00
6fe47bf5b0
Fix rows highlighting after refresh
...
fixes #6705
2014-08-19 17:32:17 +02:00
3573908071
Let downtime view look more list-like and fix downtime end calculation
...
refs #6637
2014-08-19 17:03:35 +02:00
8c02f140c3
doc: fix translate calls w/ sprintf
2014-08-19 16:22:54 +02:00
3e079efe2a
SecurityForm: replace `customvars' with `protected_customvars'
...
refs #6641
2014-08-19 14:51:30 +02:00
7035099468
Fix the host_unhandled_service_count error
...
fixes #6833
2014-08-19 14:43:24 +02:00
65473ac8ee
Monitoring config: use SecurityForm
...
refs #6641
2014-08-19 14:04:00 +02:00
1ba3954b95
Monitoring config: implement SecurityForm
...
refs #6641
2014-08-19 14:02:26 +02:00
6b468b7f9b
Monitoring_ConfigController: make writeConfiguration's parameter `file' non-required
...
refs #6641
2014-08-19 13:51:10 +02:00
1c74fd7028
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/DocParser.php
2014-08-19 13:39:48 +02:00
55b3a5384a
doc: set page title
...
refs #4820
2014-08-19 13:38:18 +02:00
d35e0816c9
doc: use `sprintf' in exceptions
...
refs #4820
2014-08-19 13:20:46 +02:00
127e4f444f
doc: show prev chapter, index and next chapter links
...
refs #4820
2014-08-19 11:30:56 +02:00
0464099764
Monitoring: implement "Security" config tab
2014-08-19 11:19:30 +02:00
5c52e447f5
doc: upper case first character of a documentation's title
...
refs #4820
2014-08-19 10:26:38 +02:00
a333c3e57b
DocParser: remove explicit call to getRelativeUrl
...
As this URLs will get rendered we want them to be automatically casted
resulting in correct URLs with &
refs #6699
2014-08-19 10:07:46 +02:00
cb17590b71
doc: rename `nofollow' to `noFollow'
...
refs #4820
2014-08-19 09:57:22 +02:00
289aed8420
doc: Use `chapterId' instead of `chapterTitle' in URLs
...
Manually given chapter IDs are meant to not change while a chapter's title could change.
refs #4820
2014-08-19 09:45:53 +02:00
332be22f7e
Fix object history dates make output look similar to the event history
...
refs #6637
2014-08-18 15:32:12 +02:00
bbddb9ed87
Add limit-control and fix indentation of the eventhistory view
...
refs #6637
2014-08-18 15:30:59 +02:00
043688e514
Make event history view more fancier
...
refs #6637
2014-08-15 17:03:03 +02:00
cae84a5d7f
Fix float formatting of timeline circle margins and widths
...
fixes #6926
2014-08-15 13:39:02 +02:00
54461f9319
Treat hard states more severe than soft states
...
fixes #6571
2014-08-15 12:40:56 +02:00
dc8181cdc5
Escape linefeeds and carriage returns in commands and show them as html
...
fixes #6088
2014-08-14 10:23:04 +02:00
b5d6481c12
Make it possible to translate the process info view
...
refs #6610
2014-08-13 15:52:33 +02:00
96925487bd
CLI/monitoring/list: fix DataView-related exception
...
This uses the renamed DataView serviceStatus instead of the former
status and fixes the problem that CLI still assumed to have fetch
and count function on the DataView.
fixes #6777
2014-07-31 17:24:56 +02:00
51484ebf88
monitoring/Perfdata: ignore invalid min/max
...
key=23;0;0;0;0 and key=23;;;; lead to division by zero exceptions
This should fix this by ignoring empty strings for min/max (formerly
it got "converted" to float(0)) and also ignores min == max.
fixes #6828
2014-07-31 16:52:34 +02:00
f9e8ad3d0b
doc: Remove 'locale' directory
...
Since #6432 has been fixed, the empty locale directory can be removed.
refs #4820
2014-07-29 11:45:16 +02:00
f6b9b13654
doc: Rename 'chapterName' to 'chapterTitle'
...
refs #4820
2014-07-29 11:19:40 +02:00
3cafc8910a
doc/DocParser: Rename 'header' to 'title'
...
refs #4820
2014-07-29 11:12:06 +02:00
38a6df91b9
doc/DocParser: Rename 'chapterName' to 'chapterTitle'
...
refs #4820
2014-07-29 11:10:49 +02:00
55d3818ebb
doc/SectionRenderer: Support images
...
refs #4820
2014-07-29 11:10:06 +02:00
034923d886
Merge branch 'master' into feature/display-documentation-4820
2014-07-28 19:17:50 +02:00
788e3eb6fc
doc: No longer use separate view scripts
...
refs #4820
2014-07-28 19:17:03 +02:00
9eb4b62cd0
doc: Register PDF route
...
refs #4820
2014-07-28 19:15:44 +02:00
88312e6284
doc/lib: Add `SectionFilterIterator' for iterating over sections that are part of a particular chapter
...
refs #4820
2014-07-28 19:11:59 +02:00
79f6130e3c
doc/lib: Add `SectionRenderer' for rendering instances of `DocTree' as sections
...
refs #4820
2014-07-28 19:11:15 +02:00
8a229e15ab
doc/lib: Add `TocRenderer' for rendering instances of `DocTree' as toc
...
refs #4820
2014-07-28 19:10:40 +02:00
0033733062
doc/lib: Add `Renderer' as base class for toc and section renderer
...
refs #4820
2014-07-28 19:09:55 +02:00
134db3fc66
doc/DocParser: Replace `getDoc()' and `getToc()' with `getDocTree()'
...
refs #4820
2014-07-28 19:09:04 +02:00
51bc0274f3
doc/lib: Add `DocTree' for representing a documentation as tree of sections
...
refs #4820
2014-07-28 19:06:12 +02:00
c71086c748
doc/lib: Add `Section'
...
In the future a documentation will be represented as tree of sections.
refs #4820
2014-07-28 19:00:50 +02:00
c325c09293
doc/DocIterator: Use `NonEmptyFileIterator'
...
Considering empty files makes no sense.
refs #4820
2014-07-28 18:59:42 +02:00
4f8cbb99dd
doc/lib: Add `NonEmptyFileIterator' for iterating over non-empty files
...
refs #4820
2014-07-28 18:58:46 +02:00
71e81087b3
doc/ChapterNotFoundException: Remove unnecessary line breaks
...
refs #4820
2014-07-28 18:57:46 +02:00
77f8a3d67d
doc/DocEmptyException: Remove unnecessary line breaks
...
refs #4820
2014-07-28 18:55:54 +02:00
a0c331020b
doc/DocException: Extend `RuntimeException' instead of `Exception'
...
Errors in the documentation module can only be found on runtime.
refs #4820
2014-07-28 18:53:41 +02:00
507ac1c4d7
doc/MarkdownFileIterator: Nail down PHPDoc
...
refs #4820
2014-07-28 18:52:25 +02:00
a4b7204e23
Contactgroups view: correct links to contacts detail pages
...
fixes #6514
2014-07-23 13:10:09 +02:00
a2809552f2
Do not use htmlspecialchars in view scripts
...
fixes #6759
2014-07-23 12:41:05 +02:00
9269a0cbd5
Revert "Do not use htmlspecialchars in view scripts"
...
This reverts commit 607aa9b203
2014-07-23 12:29:27 +02:00
607aa9b203
Do not use htmlspecialchars in view scripts
...
fixes #6759
2014-07-23 12:12:49 +02:00
9af89e6ccf
doc module: style h[1-6], table and code
...
Headers have different sizes
Tables have borders
Table headers are left-aligned
Codes are displayed inline (except inside pre) and have scrollbars if necessary
refs #6484
fixes #6632
2014-07-23 11:28:45 +02:00
cb27a3d0f1
Do not use height and width in bar charts, to avoid layout errors
2014-07-22 17:57:40 +02:00
e005333806
Merge branch 'master' into feature/display-documentation-4820
2014-07-22 12:25:58 +02:00
0a500efd8a
Determine the max value in LinearUnit dynamically
...
The range between min and max should always be divisable by the amount of
ticks, to ensure that the vertical lines are always at a full discrete value.
fixes #6769
2014-07-21 17:21:54 +02:00
53c9292b41
Fix BarChart padding in Dashboard
...
Use max-width instead of width in the chart layout to make better use of the available space, but prevent the charts from growing too big. Use a bigger weight and height in the default dashboard configuration.
fixes #6744
2014-07-21 13:06:35 +02:00
f9a274d079
Add contact detail view
...
refs #4804
refs #6514
2014-07-18 17:35:24 +02:00
96d3406446
Prefer style="clear: both;" rather than Bootstrap's class="clearfix"
2014-07-17 17:46:28 +02:00
882699201d
Contacts: replace foreach loop with hardcoded HTML and move the styles to a CSS file
2014-07-17 17:33:45 +02:00
eca0d50bae
Don't use printf format strings as array keys
...
An array with printf format strings as keys looks pretty ugly
2014-07-17 11:26:18 +02:00
4d199180b3
We do not want to access $_POST directly if it is possible to avoid it
2014-07-17 09:28:10 +02:00
b7f5c8a84d
Fix that the default sort order of a view is not being applied
...
fixes #6644
2014-07-17 09:28:10 +02:00
b23e36aa1a
Swap array keys and values
...
Non-hardcoded keys may be not unique
2014-07-16 17:54:06 +02:00
62da942159
Don't close and re-open php tags, remove unneeded spaces
...
To close and re-open php tags makes no sense if there's nothing between them
2014-07-16 17:54:06 +02:00
1ad263170e
Revert "Small fixes"
...
This reverts commit 8086292b1b
2014-07-16 15:30:20 +02:00
f1d7cd8b50
Remove forgotten coding standards annotation
2014-07-16 13:59:43 +02:00
cb04c42bab
Use htmlspecialchars to prevent attacks
2014-07-16 13:10:28 +02:00
8086292b1b
Small fixes
2014-07-15 18:00:52 +02:00
4c415aac5c
Make contacts' view look more like contactgroups' view
2014-07-15 16:17:02 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
d021ddebee
Make contacts' view work like the downtimes' one
...
fixes #6513
2014-07-15 10:47:12 +02:00
bacea36ad9
Improve piechart limitation and show non-piechart perfdata as well
...
The perfdata helper did an improper limitation as it might have skipped
valid values due to applying the limit before the filter. When not in compact
view the helper now also shows non-piechart values by using their raw
representation.
refs #6515
2014-07-14 13:48:30 +02:00
5908e9fc70
Do not show pie charts for perfdata values when no percentage is available
...
refs #6515
2014-07-11 16:32:05 +02:00
ec2d1daa6b
Perfdata plugin should also have a knowledge about labels
...
Prior to this change the PerfdataSet only knew the labels of a performance
data value which prevented the Perfdata object from being used
individually.
refs #6515
2014-07-11 16:31:00 +02:00
906c132dc0
Merge branch 'master' into feature/display-documentation-4820
2014-07-11 16:05:09 +02:00
b4dc0f38b3
Fix monitoring backend configuration not showing resource selection fields
...
fixes #6448
2014-07-10 15:50:52 +02:00
53f3d74103
Fix word wrapping in perfdata labels and values
...
fixes #6377
2014-07-10 14:54:53 +02:00
b85ac3ab45
Translate labels in the ChartController
2014-07-09 18:13:40 +02:00
8d697a3d8e
Fix coding style
2014-07-09 18:13:40 +02:00
0d92efc1b0
Consider is_active column when fetching host and service statistics
...
fixes #6157
2014-07-09 11:49:22 +02:00
2b05aa9504
monitoring/list: do not apply empty filter
...
Fixes problems with the servicematrix when no filter is applied.
I'm not yet happy with this, calls to where() should automagically
handle existing empty filters.
fixes #6543
2014-07-08 16:36:05 +02:00
9a6821c860
monitoring/list/hosts: restore page behaviour
...
The problem here was that an accidentally removed closing div tag in
15325949
2014-07-08 15:17:00 +02:00
1950c09478
Remove encoding suffix from locale identifiers
...
We do not need those as the encoding of a gettext-catalog is already
mentioned in its header.
refs #6602
2014-07-07 09:09:22 +02:00
e3b2f15863
list/hosts: show unhandled services righthand
...
This way we automagically fix the problem with the wrong row links.
I guess we should re-introduce the "row-action" class allowing "precedence"
rules, so also a link not being the first one in a row could act as "row-link".
Changed formatting / text output a little bit, IMO even more cure is needed.
fixes #6645
2014-07-04 18:13:44 +02:00
d2098be625
Only display header when not in compact mode
...
fixes #6508
2014-07-04 12:45:17 +02:00
db5c6631d9
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/Controller.php
2014-07-01 12:42:55 +02:00
2ea418cbe6
doc module: Respond with 404 if a chapter was not found or the doc directory is empty
...
refs #4820
2014-06-30 15:48:43 +02:00
1bbfa9b9ca
doc module: Let `DocParser' throw `DocEmptyException' and `ChapterNotFound' exception
...
`DocEmptyException' is thrown during construction when a documentation directory is empty.
`ChapterNotFound' is thrown when a chapter was not found when calling `getChapter()'.
refs #4820
2014-06-30 15:24:40 +02:00
c48f7f9fba
doc module: Add `DocIterator::count()'
...
Method used to count available markdown documentation files.
refs #4820
2014-06-30 15:22:32 +02:00
a8e6dda783
doc module: Add `DocEmptyException'
...
refs #4820
2014-06-30 15:21:35 +02:00
0382e2265c
doc module: Add `ChapterNotFoundException'
...
refs #4820
2014-06-30 15:21:16 +02:00
93cc24a93a
doc module: Move `DocException' beneath `Exception' namespace
...
There are more exceptions to come which also will be beneath the `Exception' namespace.
refs #4820
2014-06-30 15:18:22 +02:00
f3172b96e4
Remove missed echo instruction for debug purposes
2014-06-30 14:06:11 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
71bd784992
Add files to skip during coverage generation to the global ignore list
...
refs #6091
2014-06-30 13:55:11 +02:00
9a1b7179e1
Fix violations of coding guidelines
2014-06-30 12:33:51 +02:00
7fe056d03a
Display note when host and service is not found
...
When the show/host and show/service views do not find a host or service,
don't show a non-working view, but display a error message
fixes #6469
2014-06-30 12:33:51 +02:00
a2fa5c055c
Display a message when a list view is empty
...
fixes #6469
2014-06-30 12:33:51 +02:00
e73471030c
doc/modules/index: Only list modules which have the 'doc' directory
...
refs #4820
2014-06-30 11:43:25 +02:00
1532594948
Deduplicate code: lists/hosts.phtml VS lists/hosts-compact.phtml
...
fixes #6541
2014-06-27 11:53:08 +02:00
a4fc6dedea
monitoring/list: fix limit=0 check
...
This used to be fixed, but got accidentally re-broken by last commit
this night.
2014-06-26 16:34:37 +02:00
7f99be73fd
Adjust usages of Icinga\Util\File to suit the new interface introduced earlier
2014-06-26 15:57:14 +02:00
a91bbd3a75
monitoring/list: add stateType parameter
...
This allows one to show only hard states, useful for support dashboards.
2014-06-26 00:42:38 +02:00
c85a0ac11e
list/limits: special treatment for 0 only, not null
2014-06-26 00:39:10 +02:00
d44f89f287
list/hosts: fix downtime icon
...
I re-enabled host list icons, they have been missing for a while. The
downtime icon logic used to be inverted, this fixes it. Also showing
acknowledgements now even if object is in downtime.
2014-06-25 21:46:03 +02:00
ff9c29472e
monitoring/status: re-introduce comments, problems
...
This re-introduces expensive columns been disabled time ago and adds
even more to it. We are now showing last comment, last ack comment and
service problem count on hosts in list views.
It still costs performance, but seems that we can stand it. I'd like
to add more like this to the host view.
2014-06-25 21:42:24 +02:00
d634889acb
DataView: ignore case on sort dir
...
fixes #6573
2014-06-25 21:34:05 +02:00
11ce302be0
Ido\StatusQuery: fine-tune query filters
...
This is still experimental. We normalize a lot of columns, this allows
us to sort in a convenient way while having nice "showable" columns.
When used as filters (same goes for ordering) however, functions and
operations on table columns often hinder the db from using indexes.
The new filter implementation allows us to override query creating per
single column, that's what this first sample is trying to show. We still
need to fix alias handling, so unfortunately I have to deal with "real
columns" in the case construct.
Performance gain in large environments is impressive, more to come.
2014-06-25 21:12:44 +02:00
86f70e0a4f
list/services: don't count with no limit
...
This is a performance evaluation right now, we might delegate such
logic to paginator later on. Cuts load time for lists and/or dashlets
with complicated filters by 50% - only for those with limit=0 of course.
2014-06-25 20:45:08 +02:00
32572ae653
Monitoring\Object\Service: don't load host comment
...
I'd like to reintroduce those columns, showing last object comment
and so one. Those joins are costly, we can fetch host comments way
easier directly from host object once we are here. But I guess we
don't even need it.
2014-06-25 20:21:19 +02:00
ae99dd39fd
Fix intendation in MultiController
...
Use spaces instead of tabs
2014-06-25 15:25:54 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
ae4aa9c182
Fix violations of coding guidelines
2014-06-25 15:07:39 +02:00
85aed364b7
Fix typing error in 'threshold'
2014-06-25 15:02:04 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
ccdf1ca354
monitoring/ConfigController: use notifications
2014-06-24 21:28:01 +02:00
2b2901524c
ConfigController: useless use of render
2014-06-24 21:24:40 +02:00
532ab60b36
monitoring/show/history: fix html on empty list
...
This view script used to render broken HTML on empty result
2014-06-24 21:23:51 +02:00
f75a4430a6
monitoring/config: make use of Config()
...
Thee helper function supports lazy loading, requires less code and is
easier to read.
2014-06-24 21:22:38 +02:00
d5d3f5548f
monitoring/list/hosts: support addcolumns parameter
...
At least it doesn't fail right now, this only works for services so far.
View script still needs to be adjusted, will probably be done with #6541 .
2014-06-24 21:12:55 +02:00
9187cd11bb
monitoring/configuration: provide a config tab
2014-06-24 21:01:44 +02:00
51c57520ad
iconSubmitForm: replace with labelSubmitForm
...
There is no way in ZF to have an input[type=submit] with an unescaped
label ( = value). I temporarily replaced all iconSubmitForms with
inputs labelled with "X" - as all we used them for were delete
operations.
2014-06-23 14:42:26 +02:00
010466f8f9
Replace sizeof with count
...
Do not use sizeof to get the length of an array, as the function name 'sizeof'
is misleading
2014-06-23 14:19:55 +02:00
d199a8b036
CommandForm: input[type=submit] instead of button
...
No need for a "button" here. As they have been broken in ZF for
a long while we should better stay with input[type=submit]
fixes #5978
2014-06-23 14:10:15 +02:00
4d42b4d2c4
ScheduleDowntimeForm: replace obsolete ::fromRequest
...
A serious fix would involve passing the current backend to our
command forms.
2014-06-23 13:35:58 +02:00
bde6e29c61
Display a message instead of empty service matrix
...
refs #6535
2014-06-23 12:24:27 +02:00
0efd44e1b0
CommandForm: don't clear class
...
autosubmit class got cleared for no reason after enabling autosubmission.
Please note that the fact that their submission leads to a new form is
another issue.
fixes #6540
2014-06-23 11:27:06 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
2a0e72273a
ChartController: use correct ActionController
...
...and some code cleanup
2014-06-22 14:08:04 +02:00
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
Thomas Gelf
Alexander Fuhr
Alexander Klimov
Johannes Meyer
Eric Lippmann
Matthias Jentsch
Matthias Jentsch