2573 Commits

Author SHA1 Message Date
Eric Lippmann
67ce376ef0 DowntimeQuery: Rename baseQuery to select 2014-04-15 17:58:06 +02:00
Eric Lippmann
64bee6a414 CustomvarQuery: Rename baseQuery to select 2014-04-15 17:57:12 +02:00
Eric Lippmann
22fa833836 ContactQuery: Rename baseQuery to select 2014-04-15 17:56:31 +02:00
Eric Lippmann
c2d633ac49 ContactgroupQuery: Rename baseQuery to select 2014-04-15 17:55:13 +02:00
Eric Lippmann
5caffa78e2 CommentQuery: Rename baseQuery to select 2014-04-15 17:53:07 +02:00
Eric Lippmann
8532622fab Db: Implement missing fetch*() functions on connection level
The BaseQuery forwards fetch*() function calls to its datasource with the
query as first parameter since the datasource implements the actual fetching functionality.
There's no interface for fetch*() functions on the datasource level yet.
2014-04-15 17:44:34 +02:00
Eric Lippmann
e525688383 Replace DatasourceInterface with Selectable 2014-04-15 17:43:45 +02:00
Eric Lippmann
1a2577dd47 Db/Connection: Replace getConnection() with getDpAdapter()
For readability getConnection() is deprecated in favor of getDpAdapter()
since Db/Connection is already the connection.
2014-04-15 17:37:44 +02:00
Eric Lippmann
c85ade39c0 Create count and select database queries separately
The previous implementation always created both the count
and the select query.
For readability the property baseQuery has been renamed to select which the
IDO queries must take into account.
2014-04-15 17:21:10 +02:00
Eric Lippmann
d94170372d Let the BaseQuery implement the query interfaces and remove filter functionality
This commit breaks the application as it introduces incompatible changes which
will be adopted bit by bit.

Since the filter functionality is subject to change it's removed from the BaseQuery.
The functions setOrderColumns() and getOrderColumns() are deprecated because they're
replaced by functions in the Sortable interface.
Further the Sortable interface now defines the sort constants ASC and DESC and are
thus removed from the BaseQuery. In addition the sort constants are no longer integers
but strings.
The distinct() and isDistinct() functions are removed because they're database specific.
They have been introduced with changes in the PivotTable implementation which should
actually not call distinct blindly anyway.
2014-04-15 16:40:25 +02:00
Eric Lippmann
659e6f774e Add interface "Queryable" (WIP)
Interface for classes which act as a data source and thus return or are a Fetchable.
The name of the interface is not yet final though.
2014-04-15 16:23:17 +02:00
Eric Lippmann
0f3d70c437 Add interface "Filterable" (WIP)
This interface is empty yet. It's meant to define how to filter a result set.
2014-04-15 16:20:11 +02:00
Eric Lippmann
e5e3dc9c43 Add interface "Sortable" defining how a result set can be sorted
This interface should be used to ensure that sorting a result set
is standardized among the different query implementations.
2014-04-15 16:07:27 +02:00
Eric Lippmann
3e0d254dfd Implement "Limitable" interface for retrieving just a portion of a result set
Defines how to set a limit count and offset and should be used everywhere
where setting limit and offset is supported.
2014-04-15 15:48:51 +02:00
Eric Lippmann
c083747f67 Add "Fetchable" interface for classes providing data retrieval
Classes for retrieving data must implement the Fetchable interface
which defines the usual fetch*() functions.
2014-04-15 15:40:07 +02:00
Eric Lippmann
2cc3823a95 Implement interface "Browsable" for classes providing page turning
This interface is intended to be used everywhere a Zend_Paginator
is returned within our code.
2014-04-15 15:36:13 +02:00
Johannes Meyer
f209393711 Add Mockery when provisioning vagrant
resolves #5623
2014-04-15 10:07:48 +02:00
Johannes Meyer
8e4b47d6e1 Merge branch 'bugfix/cleanup-test-4639'
fixes #4639
2014-04-14 15:39:00 +02:00
Johannes Meyer
301e29b5e8 Remove statusdat protocol tests
refs #4639
2014-04-14 15:35:27 +02:00
Johannes Meyer
1555f55857 Remove broken, invalid and useless ModuleManager tests
refs #4639
2014-04-14 14:32:04 +02:00
Johannes Meyer
f69707e6de Remove Notification tests
refs #4639
2014-04-14 13:17:04 +02:00
Johannes Meyer
4667a53121 Remove tab tests
refs #4639
2014-04-14 12:50:16 +02:00
Johannes Meyer
1ed1c0bc3c Remove user auth and backend tests
refs #4639
2014-04-14 11:44:02 +02:00
Johannes Meyer
9d9624b331 Remove testcase for the IndexController
refs #4639
2014-04-14 10:58:24 +02:00
Johannes Meyer
1df4d9022b Convert existing mocks to Mockery-mocks (Part 2)
refs #4639
2014-04-14 10:57:48 +02:00
Johannes Meyer
a844d33735 Do not create alias mock for Icinga\Application\Icinga
refs #4639
2014-04-14 08:31:46 +02:00
Johannes Meyer
4c8428423e Convert existing mocks to Mockery-mocks (Part 1)
refs #4639
2014-04-11 17:03:45 +02:00
Johannes Meyer
927772578d We do not want to use "@backupStaticAttributes enabled"
refs #4639
2014-04-11 15:31:29 +02:00
Johannes Meyer
f3c87782cb Remove uneccesary date_default_timezone_set calls
refs #4639
2014-04-11 10:32:47 +02:00
Johannes Meyer
6897db63a7 Extend session namespace tests
refs #4639
2014-04-11 09:36:09 +02:00
Johannes Meyer
3d62b8fda2 Add bootstrapping code for Mockery
refs #4639
2014-04-11 09:35:19 +02:00
Johannes Meyer
7903d44af9 Fix testing documentation
refs #4639
2014-04-10 15:54:50 +02:00
Johannes Meyer
1db9247d0d Fix module tests
refs #4639
2014-04-10 14:52:08 +02:00
Johannes Meyer
fe9cff843d Fix GeneralForm tests
refs #4639
2014-04-10 14:08:11 +02:00
Johannes Meyer
1e69169bab Fix database tests
refs #4639
2014-04-10 11:33:24 +02:00
Johannes Meyer
d78aec2d48 Fix statusdat component test
refs #4639
2014-04-10 10:42:50 +02:00
Johannes Meyer
ccae70bc80 Make all tests inherit from BaseTestCase and fix license headers and style
refs #4639
2014-04-10 10:32:50 +02:00
Johannes Meyer
6056327c6d Fix that it's not possible to set non-existing values in a session with setAll()
refs #4639
2014-04-09 16:18:51 +02:00
Johannes Meyer
bd986e8c81 Skip widget tests as view objects cannot be passed "around" anymore
refs #4639
2014-04-09 15:29:05 +02:00
Johannes Meyer
4c65acac13 Fix web url test
refs #4639
2014-04-09 15:03:09 +02:00
Johannes Meyer
e1793c9ea1 Make the statusdat reader test using its own cache location
refs #4639
2014-04-09 14:56:25 +02:00
Johannes Meyer
f9324032cb Fix autoloader not ignoring vendor prefixed class names
refs #4639
2014-04-09 14:20:05 +02:00
Johannes Meyer
3a29cc34c9 Mark faulty tests as skipped
refs #4639
2014-04-09 14:18:56 +02:00
Johannes Meyer
91675bac50 Remove require instructions from all tests and fix namespaces
refs #4639
2014-04-09 14:18:14 +02:00
Johannes Meyer
0dc4a4f541 Refactor php unittest bootstrapping
refs #4639
2014-04-09 10:42:06 +02:00
Marius Hein
7708b9901f Drop BaseTestCase static class loader
refs #4639
2014-04-09 09:27:01 +02:00
Marius Hein
746cc4b5d9 Drop obsolete test cases
refs #4639
2014-04-09 09:26:11 +02:00
Marius Hein
34822d9a02 Clean up tests [WIP]
refs #4639
2014-04-09 09:23:59 +02:00
Marius Hein
0ca0eef311 Test: Using autoloader for tests
refs #4639
2014-04-09 09:23:58 +02:00
Johannes Meyer
139023571f Fix exception on 404 in monitoring/show/ 2014-04-09 08:44:51 +02:00