d545e1f7d1
lib: Don't write the empty notifications array into the session
...
I combined this w/ introducing some constants for notification types and PHPDoc.
refs #9660
2015-07-30 13:42:59 +02:00
9aa1599a18
Form: Disable CSRF counter measure only on API requests
...
refs #9660
2015-07-30 12:04:22 +02:00
c23c7a5fa9
lib: Add Request::getIsApiRequest()
...
If the Accept header is set to application/json it's an API request.
refs #9660
2015-07-30 12:03:33 +02:00
db505281ee
lib: Disable CSRF token on HTTP authenticated users and not XHR
...
refs #9660
2015-07-30 09:33:04 +02:00
432efcb089
lib: Handle Response::setRerenderLayout() correctly
...
The header is different if it's not a redirect.
refs #9660
2015-07-29 15:08:36 +02:00
aaae7e03b4
lib: Introduce Response::setRerenderLayout()
...
Instead of handling response headers based on flags in our controllers, this should happen in the request for usage w/o controllers.
refs #9660
2015-07-29 14:39:45 +02:00
91720810cc
lib: Document Response::redirectAndExit()
...
refs #9660
2015-07-29 14:22:45 +02:00
a31c799043
lib: Introduce Response::getRequest()
...
refs #9660
2015-07-29 14:20:39 +02:00
07849e0fea
lib: Rename Authentication/Manager to Authentication/Auth
...
refs #9660
2015-07-28 17:08:55 +02:00
7cfc78558d
Merge branch 'master' into feature/secure-modules-9644
...
Conflicts:
library/Icinga/Exception/IcingaException.php
2015-07-28 13:42:02 +02:00
e231ef8061
SortBox: Fix some documenation and code style issues
2015-07-28 12:04:16 +02:00
f7b35b04f4
SortBox: Properly apply sort rules and show the user the default
...
refs #6644
2015-07-28 12:03:50 +02:00
78285b95a3
Make Controller::httpNotFound() variadic
...
refs #9644
2015-07-28 10:40:02 +02:00
4d9aa54814
SortBox: Utilize a separate form for each control
...
refs #9421
2015-07-27 11:43:47 +02:00
86ad6c48ff
Form: Automatically remove query parameters only for GET forms
...
refs #9421
2015-07-27 08:52:33 +02:00
8358e9165c
Don't require the module permission for the default module
...
refs #9644
2015-07-24 15:11:21 +02:00
727a2d7141
Paginator: relax requirements to Paginatable
...
* we need no full query interface here
* introduced new interface "Paginatable"
fixes #9483
2015-07-23 13:48:49 +02:00
a34ad0227f
Don't load module menu entries if the authenticated user lacks the module permission
...
refs #9644
2015-07-23 12:59:30 +02:00
fd77c30838
Don't load module dashboards if the authenticated user lacks the module permission
...
refs #9644
2015-07-23 12:57:23 +02:00
e8e01257e6
Change interface of SearchDashboard to allow setting a user before calling ::search()
...
Because search dashlets are provided by modules, the authenticated user's module permissions have to be validated before loading search dashlets provided by modules.
refs #9644
2015-07-23 12:53:08 +02:00
b4f4ce4406
Require the module's permission for every module automatically
...
Module permissions are not required if authentication is disabled on the controller.
refs #9644
2015-07-23 12:51:10 +02:00
b000ae3a37
Do not require permissions if authentication is not required
...
refs #9644
2015-07-23 12:50:02 +02:00
aa567f8cd7
Introduce ModuleActionController::$requiresModulePermission
...
refs #9644
2015-07-22 14:56:02 +02:00
13d954a956
Fix rawurlencode call
2015-07-22 13:36:25 +02:00
52e352751e
Revert "ModuleActionController: fix forward/X-Icinga-Module"
...
This reverts commit bf82bd4ce1#9349
2015-07-22 13:34:44 +02:00
ab8e775188
Fix duplicate headers on forward() inside a controller
...
This avoids that the JS loader flattening arrays.
refs #9349
2015-07-22 13:34:44 +02:00
54a77b7253
Merge branch 'master' into feature/support-for-file-uploads-8758
2015-07-22 13:30:56 +02:00
a199d36207
Stylesheet: Disable extendend @import statements provided by LESS
...
fixes #9687
2015-07-22 12:45:10 +02:00
bf82bd4ce1
ModuleActionController: fix forward/X-Icinga-Module
2015-07-22 10:53:42 +02:00
cecd94be50
Merge branch 'master' into feature/support-for-file-uploads-8758
2015-07-22 08:47:24 +02:00
c0de2e6ee3
Form: Add missing use statement for the ProgrammingError exception
2015-07-22 08:39:24 +02:00
ce2b686252
Add file and line of logged menu item renderer exceptions
...
fixes #9696
2015-07-21 16:54:23 +02:00
8f2849f32a
Form: Improve code readability..
...
..and avoid the necessity to provide another mock when testing
Form::handleRequest().
refs #8758
2015-07-21 16:48:56 +02:00
7c89887773
Form: Provide an absolute url as redirect url for successful frame uploads
...
refs #8758
2015-07-21 16:35:56 +02:00
6c9819204d
Form: Only work with a single type when handling redirect urls
...
$form->setRedirectUrl('some/url') still works, but $form->getRedirectUrl()
will only return instances of Icinga\Web\Url now.
2015-07-21 16:33:24 +02:00
fc481e527b
Form: Process request parameter _frameUpload
...
This parameter is being used to flag a request as form submission issued
by utilizing an iframe. Appending it to a form's action causes no redirection
to take place in case of successful submission and a reduced but still valid
layout to be printed in any way. Redirection must be handled by the client
regarding the meta tag "redirectUrl".
refs #8758
2015-07-21 15:22:24 +02:00
0a9a066749
Form: Do not create a new instance of Url when returning the redirect url
...
We're shifting parameters and by creating a new instance we'll lose
such changes.
refs #8758
2015-07-21 15:13:56 +02:00
47fbc24f17
Merge branch 'master' into bugfix/improve-form-notifications-8983
...
Conflicts:
library/Icinga/Web/Form.php
modules/setup/application/forms/AdminAccountPage.php
2015-07-20 15:52:10 +02:00
2164bb86c8
Tabs: Do not create a new instance of Url when rendering the refresh url
...
We're shifting parameters and by creating a new instance we'll lose
such changes.
refs #8758
2015-07-16 11:27:31 +02:00
549f36f82c
Form: Do not create a new instance of Url when setting the action
...
We're shifting parameters and by creating a new instance we'll lose
such changes.
refs #8758
2015-07-16 11:27:02 +02:00
d192410435
Introduce GET parameter _disableLayout to ... disable the entire layout
...
refs #8758
2015-07-16 11:23:48 +02:00
f3c8f2229f
ErrorLabeller: Provide localized output for the MimeType validator
...
refs #8758
2015-07-15 15:15:15 +02:00
5b908d85bb
Form: Fix notifications
...
* Coding style issues
* Notifications were not grouped by type
* Notifications of sub-forms were overwriting existing ones
(cherry picked from commit 147f6be714
2015-07-01 14:26:03 +02:00
d5ba40ac19
Form: Add hint support
...
Hints are short messages displayed at the bottom of a form
used to describe specific aspects on how to interact with
the form.
refs #8983
2015-06-30 15:02:58 +02:00
ea6f707bdf
FormDescriptions: Do not render a description for required fields
...
refs #8983
2015-06-30 14:28:27 +02:00
147f6be714
Form: Fix notifications
...
* Coding style issues
* Notifications were not grouped by type
* Notifications of sub-forms were overwriting existing ones
2015-06-30 14:25:33 +02:00
aecfb2eb97
Merge branch 'bugfix/multiselection-not-visible-9054'
...
fixes #9054
fixes #9346
2015-06-30 14:08:19 +02:00
702a9c9523
Form: Show notifications and errors below any descriptions
...
They might be textually related to one or more descriptions.
refs #8983
2015-06-30 13:22:54 +02:00
6a7e3fe440
Document multi selection and use clearer names
...
refs #9054
2015-06-30 13:03:41 +02:00
aec59d9941
Use current filter to highlight active rows instead of storing active rows in JS
...
Clean up selection code and move it into separate behavior and parse filter query to fetch selectable rows.
refs #9054
refs #9346
2015-06-29 18:48:42 +02:00
Eric Lippmann
Johannes Meyer
Thomas Gelf
Markus Frosch
Matthias Jentsch