54577d04bd
Merge branch 'master' into bugfix/time-formatting-6778
...
Conflicts:
modules/monitoring/application/views/scripts/list/comments.phtml
modules/monitoring/application/views/scripts/list/hostgroups.phtml
modules/monitoring/application/views/scripts/process/info.phtml
modules/monitoring/application/views/scripts/show/components/downtime.phtml
modules/monitoring/application/views/scripts/show/components/notifications.phtml
modules/monitoring/public/css/module.less
2015-05-21 14:57:01 +02:00
c47465a732
lib/filter: Fix check against unset search columns
...
refs #8241
2015-05-21 14:04:04 +02:00
b9a6e1042d
Merge branch 'master' into bugfix/Take-display_name-into-account-when-searching-for-host-and-service-names-8241
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
2015-05-20 17:02:49 +02:00
71fa736144
Merge branch 'master' into feature/user-and-group-management-8826
2015-05-20 10:46:55 +02:00
902c00e836
lib: Introduce Controller::httpNotFound()
...
Many actions require loading specific objects from database or any other storage.
If the object isn't found, Controller::httpNotFound($message) should be used
for immediately returning w/ HTTP 404.
2015-05-20 10:30:01 +02:00
3d1c3609c0
lib: Add UrlParams::shiftRequired()
2015-05-20 10:30:00 +02:00
3a2238f737
Rename UrlParams::req() to ::getRequired()
...
req() seems mysterious :)
2015-05-20 10:30:00 +02:00
cc050ed696
Display an error notification rather than throwing an exception
...
refs #8241
2015-05-19 17:36:24 +02:00
3243f9a65a
Don't handle the case $this->searchColumns === null for actions in which ::setSearchColumns() is called
...
refs #8241
2015-05-19 17:36:23 +02:00
fb07f0b94c
Merge branch 'master' into feature/user-and-group-management-8826
...
Conflicts:
library/Icinga/Authentication/Backend/LdapUserBackend.php
library/Icinga/Protocol/Ldap/Query.php
2015-05-19 14:14:03 +02:00
bd7c7f9636
Introduce widget Paginator
...
This does not support custom scrolling styles as of now. Custom view
scripts are supported though. In case Paginator::getPages() does not
suffice, feel free to improve this.
2015-05-19 13:57:21 +02:00
9edc4a129b
Fix date-and-time tooltips not showing the time
...
refs #6778
2015-05-19 13:25:57 +02:00
4f4d7ccba2
Correct PHPDoc of ::setSearchColumns()
2015-05-19 12:55:40 +02:00
f968984feb
Drop the DateTimeRenderer
...
refs #6778
2015-05-19 12:46:08 +02:00
ab7c529094
Show the expected input format if a date-and-time input is not valid
...
refs #6778
2015-05-19 11:22:23 +02:00
5cf8e2504e
lib/grid: Use PHP's DateTime instead of our DateTimeFactory
...
I'm about to drop the DateTimeFactory because date_default_timezone_set() in combination w/ PHP's DateTime is sufficient.
refs #6778
2015-05-19 11:14:41 +02:00
1ce9900c86
Add PHPDoc to ::setSearchColumns()
2015-05-19 11:12:36 +02:00
d53c3d7075
Add view helper functions for formatting, date, date and time, and time
...
refs #6778
2015-05-19 10:10:23 +02:00
a66cb907ae
Remove dateTimeRenderer view helper
...
The helper is no longer used anywhere.
refs #6778
2015-05-19 10:06:19 +02:00
1301b77547
Use DateFormatter::formatDate() for formatting the date and time tooltip in the format view helper
...
refs #6678
2015-05-19 10:04:17 +02:00
9477fdcea4
Use DateFormatter's format functions in the format view helper
...
refs #6778
2015-05-19 09:56:20 +02:00
592d5eadc1
Merge branch 'feature/improve-multi-select-view-8565'
2015-05-18 16:00:52 +02:00
aaa8e4bf6a
Don't render time information when the timestamp evaluates to false
...
refs #6778
2015-05-18 14:40:55 +02:00
82ee1d6e60
Merge branch 'master' into bugfix/significant-whitespaces-8777
...
Conflicts:
library/Icinga/Web/Widget/FilterEditor.php
2015-05-18 13:35:28 +02:00
524c449649
Merge branch 'master' into feature/user-and-group-management-8826
2015-05-18 11:28:07 +02:00
2cbcea25cb
Merge branch 'feature/ido-resource-validation-9203'
...
fixes #9214
resolves #9203
2015-05-15 15:59:18 +02:00
99c511eefd
Limiter: Do not use a hardcoded default limit
2015-05-15 15:22:22 +02:00
9a043386de
Controller: Make setupSortControl creating a Zend_Paginator on its own
...
We're accessing the url GET parameters `sort' and `dir' in a controller now.
fixes #8339
2015-05-15 14:37:41 +02:00
e04655e8cf
Controller: Apply the user chosen sort rules when in compact view as well
2015-05-15 14:37:41 +02:00
ad8903660d
Revert "SortBox::handleRequest(): set query order direction to asc if it's not given"
...
This reverts commit 59753acece
2015-05-15 14:37:41 +02:00
9f35db71bf
Form: Add typed notifications to the form
...
refs #9203
2015-05-15 13:04:01 +02:00
1eb11625ef
Add new FormNotification Decorator to render form notifications
...
refs #9203
2015-05-15 13:02:54 +02:00
59753acece
SortBox::handleRequest(): set query order direction to asc if it's not given
2015-05-13 14:40:40 +02:00
aa466ae721
Merge branch 'master' into feature/user-and-group-management-8826
2015-05-13 08:11:59 +02:00
d43513dcac
Controller: use Icinga\Data\Sortable
2015-05-12 16:38:31 +02:00
c91d3e52ac
Merge branch 'master' into feature/user-and-group-management-8826
2015-05-12 15:39:02 +02:00
afa0dc0956
SortBox::handleRequest(): check whether $this->query !== null
...
refs #9220
2015-05-12 10:29:50 +02:00
e1c3d23d12
Icinga\Web\Controller::setupSortControl(): set query on the newly created SortBox (if given)
...
refs #9220
2015-05-11 16:28:23 +02:00
32659647b9
Implement Icinga\Web\Widget\SortBox::handleRequest()
...
refs #9220
2015-05-11 16:09:20 +02:00
17ebe07e57
Implement Icinga\Web\Widget\SortBox::setQuery()
...
refs #9220
2015-05-11 15:37:00 +02:00
295254d1d5
Rename Icinga\Web\Widget\SortBox::applyRequest() to ...::setRequest()
...
refs #9220
2015-05-11 14:07:57 +02:00
152c6a8f7f
Merge Monitoring_ListController::hasBetterUrl() into Icinga\Web\Controller::init()
...
refs #9220
2015-05-11 13:36:58 +02:00
25f397042b
Merge branch 'master' into feature/improve-multi-select-view-8565
...
Conflicts:
modules/monitoring/application/controllers/HostsController.php
modules/monitoring/application/controllers/ServicesController.php
modules/monitoring/application/views/scripts/hosts/show.phtml
modules/monitoring/application/views/scripts/list/hosts.phtml
modules/monitoring/application/views/scripts/partials/host/objects-header.phtml
modules/monitoring/application/views/scripts/partials/service/objects-header.phtml
modules/monitoring/application/views/scripts/services/show.phtml
modules/monitoring/public/css/module.less
public/js/icinga/behavior/tooltip.js
2015-05-11 13:28:43 +02:00
f83d16acb2
RepositoryQuery: Do not lose the repository context during pagination
...
refs #8826
2015-05-07 14:45:47 +02:00
d171dd2ec9
Introduce controller UserController
...
Still only able to list users, more to follow...
refs #8826
2015-05-04 17:04:50 +02:00
ab0b478e4f
Icinga\Web\Widget\Tabextension\DashboardAction::apply(): translate label "Add To Dashboard"
2015-04-30 17:49:42 +02:00
ffe23a184f
Don't display "Add To Dashboard" on the dashboard
...
resolves #9026
2015-04-30 17:47:23 +02:00
7f28c0a237
Implement ProblemMenuItemRenderer
...
refs # 4139
2015-04-30 16:06:05 +02:00
9cd7765d9e
If session_save_path() returns '', use sys_get_temp_dir()
...
resolves #8994
2015-04-22 17:26:15 +02:00
d3964a31fb
MenuItemRenderer: add missing use clause
...
Otherwise this completely broke Icinga Web as soon as a single module
used a legacy icon.
refs #7658
2015-04-20 21:49:45 +02:00
d6e7061de3
Implement Icinga\Web\Widget\FilterEditor::setSearchColumns() for specifying custom search columns
2015-04-20 18:01:48 +02:00
5f3aafd3bd
Merge branch 'bugfix/menu-item-renderer-deduplication-7658'
...
fixes #7658
2015-04-20 17:15:21 +02:00
9ebf4742de
Use the MenuItemRenderer render() implemnetations
...
refs #7658
2015-04-20 17:07:34 +02:00
4eb5f75c62
Use default MenuItemRenderer as renderer if no custom renderer is set
...
refs #7658
2015-04-20 17:04:46 +02:00
f543321ac4
Replace MenuItemRenderer interface with a base class MenuItemRenderer
...
refs #7658
2015-04-20 17:02:42 +02:00
da7aa23820
Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876
2015-04-20 15:20:23 +02:00
7bc07c4368
Force absolute nampesace for module menu item renderer
...
refs #7642
2015-04-20 13:21:37 +02:00
a9819907ed
Add namespaced item renderer class loader
...
refs #7642
2015-04-20 13:08:49 +02:00
593ea7add5
Move monitoring module renderers from global module to monitoring module
...
refs #7642
2015-04-20 13:02:12 +02:00
54a370ca22
Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876
2015-04-20 11:15:04 +02:00
2bd31ee395
Icinga\Web\Controller: Add helper functions to create control widgets
...
refs #7876
2015-04-17 16:08:41 +02:00
b52b507134
FilterEditor: Fix css
2015-04-17 10:05:48 +02:00
6898a4e0d5
Display icon tooltips without delay
...
Original functionality was broken when changing the icon library.
2015-04-16 18:32:47 +02:00
168577ff33
Use icon instead of the letter 'X' in close tab
2015-04-16 18:32:47 +02:00
ff45faf123
lib: Remove prefixedTimeUntil()
...
refs #6778
2015-04-15 15:47:58 +02:00
44c8d37288
lib: Remove prefixedTimeSince()
...
refs #6778
2015-04-15 15:47:10 +02:00
796cbffbd7
Merge branch 'master' into bugfix/time-formatting-6778
...
Conflicts:
modules/monitoring/application/views/scripts/show/components/notifications.phtml
2015-04-15 15:43:39 +02:00
675d070b86
Set the view property `compact' exactly once
...
refs #7876
2015-04-15 15:33:00 +02:00
ed2de3c4d0
Fix SortBox widget
...
refs #7876
2015-04-15 14:20:36 +02:00
d882ea11b4
Avoid to set an empty redirect url parameter when accessing icinga web 2
2015-04-15 11:00:47 +02:00
638c00d685
Merge branch 'master' into feature/non-collated-ido-queries-8613
2015-04-13 15:55:32 +02:00
5a46821d91
Rename timeago, timesince and timeuntil CSS classes to time-ago, time-since and time-until
...
refs #6778
2015-04-10 14:19:08 +02:00
a817d9070e
Move setupSortControl() from Monitoring_ListController to Icinga\Web\Controller
2015-04-10 11:36:25 +02:00
3ec6caa15b
lib: Add timeAgo to views
...
refs #6778
2015-04-10 09:56:39 +02:00
55e9407371
Use `service' instead of `service_description' when searching for services
...
refs #8613
2015-04-08 14:57:30 +02:00
e94c99e20e
Use `host' instead of `host_name' when searching for hosts
...
refs #8613
2015-04-08 14:57:08 +02:00
45d1230b28
Merge branch 'master' into bugfix/significant-whitespaces-8777
2015-04-08 10:19:53 +02:00
a185107927
Trim off leading whitespaces from filter values when searching
...
Because whitespaces may be used when searching for entities using the query string format "column = value" we have to trim off leading whitespaces from filter values.
This loses the possibility for search for entities with leading whitespaces of course.
refs #8777
2015-04-08 10:14:42 +02:00
9596b4fdf7
Form: Make it possible to preserve default values during (auto)submission
2015-04-07 15:07:36 +02:00
967a2e82dc
Use (only) "@return $this" in fluent interfaces' documentation
2015-04-07 14:24:11 +02:00
6b63f3d8a2
Merge branch 'feature/require-mandatory-params-8886'
...
resolves #8886
2015-04-07 13:06:43 +02:00
dfd8c91827
Add PHPDoc to ActionController::$params
2015-04-07 12:25:46 +02:00
93b1a35de0
lib: Add UrlParams::req()
...
UrlParams::req() should be used for requiring a mandatory URL parameter.
refs #8886
2015-04-07 12:17:59 +02:00
e32eeb991e
Implement Icinga\Web\Widget\SortBox::create()
2015-04-07 11:37:06 +02:00
57ed849cee
Icinga\Web\Widget\SortBox::applyRequest(): return $this
2015-04-07 11:26:16 +02:00
5619ac960c
Add inline pies to host and service back to multi-select views
...
Add old inline pie code and visualize handled/unhandled state.
refs #8565
2015-04-02 16:25:20 +02:00
9fbd7822d0
Fix coding guideline violations
2015-03-31 17:41:57 +02:00
5383999ef7
Add warning to links that open in a new window
...
Add warning on mouseover / focus as recommended by as recommended by WCAG20 G201
refs #7937
2015-03-19 10:49:28 +01:00
63f87da53d
Session: reworked to avoid duplicate notifications
...
* clear session on initialization, store once on shutdown
* less static method calls
* fixes erraneous cli checks
2015-03-13 14:10:27 +01:00
e36c430bb3
Merge branch 'feature/protected-menu-8720'
...
resolves #8720
2015-03-13 04:26:19 +01:00
200982e4f5
Set form action automatically only if Form::setAction() has not been called
...
refs #8605
2015-03-13 03:59:43 +01:00
03f78a06fb
Optimize imports in the SearchDashboard
...
refs #8668
2015-03-12 18:48:59 +01:00
dc6b472ec9
Don't create search dashlets if the search string is empty
...
refs #8668
2015-03-12 18:47:34 +01:00
515fe3249f
Fix PHPDoc of SearchDashboard::search()
...
refs #8668
2015-03-12 18:44:23 +01:00
77cd48e6fe
We do not use the @package tag
2015-03-12 18:11:33 +01:00
6c5a6215ef
Render search results based on their priority
...
refs #8668
2015-03-12 18:11:06 +01:00
29d5fd351b
Merge branch 'bugfix/logout-external-8626'
...
fixes #8626
2015-03-12 16:47:49 +01:00
8563d5ed3f
PHPDoc: Use @var instead of @type
...
Becasue of too many kittens PSR-5 backed off of deprecating @var.
So that's the way we go too.
2015-03-12 16:08:47 +01:00
90971f2caf
Revert "Merge branch 'feature/organize-headings-7976'"
...
This reverts commit ea2a17a76ce72de8dfe1#7976
fixes #8647
2015-03-12 16:08:34 +01:00
093dfd627e
Security: Hide config menu items if the user lacks the required permission
...
refs #8720
2015-03-12 15:45:33 +01:00
da16bfcef3
Security: Use PermittedMenuItemFilter in the MenuRenderer
...
refs #8720
2015-03-12 15:45:30 +01:00
e6a60e214c
lib: Add PermittedMenuItemFilter ...
...
... for iterating over menu items the user is allowed to display
refs #8720
2015-03-12 15:45:27 +01:00
0c30356d52
Add Menu::getPermission() and Menu::setPermission()
...
Those two functions are required for filtering menu items based on a user's grants.
refs #8720
2015-03-12 15:44:43 +01:00
749957c3b4
Fix too greedy __SELF__ login redirect on XHR
...
I introduced this bug some commits earlier. We only must redirect to __SELF__ on XHR
if a redirect URL was set.
refs #8626
2015-03-12 00:57:03 +01:00
2f752ed1ac
Respond with HTTP status code 403 when an XHR requires authentication
...
refs #8626
2015-03-11 22:32:04 +01:00
bc1336b6f9
Fix stupid code in ActionController::redirectToLogin()
...
refs #8626
2015-03-11 21:49:20 +01:00
4ebfbf83ab
Leave note about __SELF__ in our action controller
...
refs #8626
2015-03-11 21:40:14 +01:00
ba0154ab79
Tab: Use the title as caption if there is no label set yet
2015-03-11 10:21:06 +01:00
2cf09ebc48
Revert "LdapResourceForm: Validate the host field and do not require a port"
...
This reverts commit a34d6026b3#7990
2015-03-11 08:00:20 +01:00
a34d6026b3
LdapResourceForm: Validate the host field and do not require a port
...
fixes #7990
2015-03-10 15:03:48 +01:00
d0383a241e
Use date and mktime instead of cal_days_in_month to count a month's days
...
fixes #8637
2015-03-10 12:30:22 +01:00
083c1a9e6b
Fix some spelling errors in comments and messages
...
fixes #8633
Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
6cfa958bb8
Allow setting `requirement' on form elements
...
It's supposed to be used as description what
kind of value an element will accept.
refs #7947
2015-03-06 08:53:34 +01:00
b9811f8590
Form: Do not set the requiredSuffix as option but use its virtual setter
...
This removes the invalid attribute on each <label> tag once the
FormDescriptions decorator removes the suffix.
refs #7947
2015-03-05 15:13:38 +01:00
b8eedc21bb
Form: Explicitly set subform decorators
...
refs #7947
2015-03-05 15:12:02 +01:00
764f125778
Make the FormDescriptions decorator able to handle sub forms
...
refs #7947
2015-03-05 15:08:30 +01:00
ff263946c8
Form: Fix translation domain detection while running unit tests
2015-03-04 09:38:00 +01:00
e2887df03e
Form: It's a field, not a control
2015-03-03 15:01:09 +01:00
8510835fba
Fix accessibility of the Autosubmit decorator when applied to a form
...
refs #7935
2015-03-03 14:35:46 +01:00
c2339d156b
Improve aria-hidden handling in the icon and img view helper
2015-03-03 14:35:41 +01:00
747e51553e
Allow the Autosubmit decorator being used on forms as well
...
refs #7935
2015-03-03 13:33:26 +01:00
642fa44fce
Move a form's title into the markup of its form
2015-03-03 09:53:25 +01:00
b1d0c12df3
Form: Introduce setTitle() as alias for Zend_Form::setDescription()
2015-03-02 18:40:46 +01:00
ad288c08ca
Form: Add the Description decorator by default for native title support
2015-03-02 18:40:46 +01:00
cbd061aa41
Fix that the FormDescriptions decorator does not ignore Notes and Buttons
2015-03-02 18:40:46 +01:00
1eacaa4c48
Improve the display of the text cue on required form elements
...
Shows just a message at the top of the form if all elements are required
and a explaining message what the cue is standing for otherwise.
refs #7934
2015-03-02 13:48:35 +01:00
1a334f8d64
Add decorator FormDescriptions
...
This decorator displays a list of messages at the top of a form.
refs #7947
2015-03-02 13:45:24 +01:00
7bb78330a9
Replace cancel icon with the trash icon...
...
...where the link's purpose is to remove something
2015-02-27 14:47:46 +01:00
74dfa6e72a
Fix invalid icon names passed to the icon view helper
2015-02-27 14:45:47 +01:00
96c132908d
Provide a warning on autosubmit form elements and a title for the apply btn
...
resolves #7935
2015-02-27 13:09:13 +01:00
4f0bddd7da
Do not add aria-label to icons and images with titles if aria-hidden is set
2015-02-27 12:12:24 +01:00
82017da85f
Help: Do not protect form element ids twice
2015-02-27 09:20:15 +01:00
c00e336ea8
Make the cue that is being appended to required form elements configurable
...
refs #7934
2015-02-27 09:08:05 +01:00
48c3199a2d
Form: Fix id protection
...
Altering element ids upon rendering makes it impossible to reference
them elsewhere. Zend_Form::getId() should be preferred over getName()
as it falls automatically back to getName() in case there is no id attribute
set. Setter are required to return their instance. Overwriting methods
without calling the parent (getId) without any valid (or at least
documented) reason is very bad practice.
refs #8460
2015-02-27 09:01:46 +01:00
6d81a194ab
Make form element descriptions accessible
...
Re-added the Help decorator to make sure an element's description
is being added in an accessible way.
2015-02-27 08:10:25 +01:00
0111fdf78e
Add an asterisk suffix to a form element's label if its required
...
The screen reader part "(required)" is not being considered with this
commit as most screen readers do not need this due to the ARIA and
HTML5 property.
resolves #7934
2015-02-26 16:05:13 +01:00
89451f3086
Ensure that form ids are unique
...
Add an unique prefix to each Form- or FormElement id, unless id protection is disabled explicitly, to prevent id collisions between different containers.
fixes #8460
2015-02-25 18:00:28 +01:00
cc403806f7
Fix refresh accessibility lable if it is empty
...
refs #7968
2015-02-25 15:28:09 +01:00
08ace05ac7
Remove animations.css from StyleSheet loading lessFiles
...
refs #7968
2015-02-25 13:56:32 +01:00
7f883a4770
Add own animation.less to provide own parameterized animate function
...
refs #7968
2015-02-25 13:51:26 +01:00
3a2b69a63c
Remove refreshTab property from Tabs
...
refs #7968
2015-02-25 13:24:11 +01:00
e219bb1664
Add doc for the label
...
refs #7968
2015-02-25 13:13:22 +01:00
481c58ec03
Add accessibility to renderRefreshTab
...
refs #7968
2015-02-25 12:14:26 +01:00
5297b15a61
Merge branch 'master' into feature/refresh-control-7968
2015-02-24 14:41:09 +01:00
d68c636359
Wizard: Disable the browser's form validation when navigating back
...
formnovalidate... The fukin awesomeness of HTML5 is sometimes
even impressing a god-damned h4x0r like me.
fixes #8507
2015-02-24 13:16:31 +01:00
8e8bab0795
Do only escape a qlink's label manually if necessary
2015-02-24 11:35:25 +01:00
956efe5ef9
Merge branch 'master' into feature/link-labels-8458
...
Conflicts:
application/views/scripts/config/application.phtml
application/views/scripts/config/module.phtml
application/views/scripts/config/modules.phtml
library/Icinga/Web/Widget/Dashboard/Dashlet.php
modules/monitoring/application/controllers/TimelineController.php
2015-02-24 08:42:36 +01:00
b626a96e16
Add aria-label to each box of the event grid
...
refs #8458
2015-02-23 17:14:40 +01:00
fb7640db0a
Add proper titles to the Limiter control
...
refs #8458
2015-02-23 17:06:01 +01:00
b2f817925b
Add proper titles to the FilterEditor
...
refs #8458
2015-02-23 17:05:39 +01:00
Eric Lippmann
Johannes Meyer
Alexander A. Klimov
Matthias Jentsch
Alexander Fuhr
Thomas Gelf
Louis Sautier