Commit Graph

4004 Commits

Author SHA1 Message Date
Jennifer Mourek 2902f3330c TacticalController: Remove UI tab element for exports 2018-02-20 12:30:56 +01:00
Jennifer Mourek 4074d7b3ac Apply requested changes 2018-02-19 15:37:52 +01:00
Jennifer Mourek 44abd01ffc TacticalController: Add OutputFormat and tab creation handling
Mimics the behaviour of the ListController
2018-02-19 11:04:39 +01:00
Max Stephan 493409b5d7
url filter also for services
use the url filter also for services
2018-02-08 12:01:36 +01:00
Alexander A. Klimov c717ebeb94 Make Plugin class loadable 2018-01-24 10:21:37 +01:00
Eric Lippmann 56d28a6c14 Prepare release version 2.5.1 2018-01-22 13:47:41 +01:00
Johannes Meyer e8fa99f913 PluginOutput: Use new PluginOutputPurifier helper instead 2018-01-19 16:16:35 +01:00
Johannes Meyer 42b685d336 Introduce class Icinga\Module\Monitoring\Web\Helper\PluginOutputPurifier 2018-01-19 16:16:35 +01:00
lippserd 226cc2c810
Merge pull request #3274 from Icinga/bugfix/inner-donut-labels-firefox-3226
Donut: place HTML tags outside <svg>
2018-01-18 10:15:49 +01:00
Michael Friedrich 4dfc309e12 Fix command transport documentation for inline comments
fixes #3281
2018-01-17 17:02:50 +01:00
lippserd 21d1e0d3cd
Merge pull request #3142 from Icinga/bugfix/icingacli-monitoring-list-host-without-services-3050
Split icingacli monitoring list
2018-01-17 16:03:06 +01:00
Alexander A. Klimov 0ad153a223 Tactical overview: always show the problems amount
refs #3226
2018-01-17 15:01:02 +01:00
lippserd f4c46cde19
Merge pull request #3278 from Icinga/bugfix/drop-obsolete-aggregates-from-event-history-query-2860
EventHistory: Drop obsolete SUM aggregates
2018-01-17 14:07:20 +01:00
Johannes Meyer 0610718930 PluginOutput: Allow ordered and unordered lists in html output
refs #2846
2018-01-17 13:02:11 +01:00
Johannes Meyer dff6c16bf8 PluginOutput: Properly handle whitespace for html output
refs #2846
2018-01-17 13:02:11 +01:00
Johannes Meyer b07e4b409f EventHistory: Drop obsolete SUM aggregates
Not used anywhere and not working for a long time already,
at least as filter columns.

refs #2860
2018-01-17 12:41:10 +01:00
lippserd 375b140c48
Merge pull request #3126 from mapa82/master
Monitoring: add setting acknowledge_expire_time
2018-01-17 12:18:00 +01:00
mapa82 9b81492e8b Monitoring: add setting acknowledge_expire_time
Signed-off-by: Alexander A. Klimov <alexander.klimov@icinga.com>
2018-01-17 12:07:03 +01:00
Alexander A. Klimov 4e57fa1dd7 Split icingacli monitoring list
refs #3050
2018-01-16 11:02:19 +01:00
lippserd 2fb9ce9f93
Merge pull request #3145 from Icinga/bugfix/history-eventgrid-format-2678
Accept /monitoring/list/eventgrid?format=*
2018-01-16 10:43:09 +01:00
lippserd 30e5ee9d79
Merge pull request #3227 from Icinga/feature/separate-reachability-and-check-source-2953
Separate reachability and check source info in detail views
2018-01-16 10:24:14 +01:00
lippserd e529b9b2ba
Merge pull request #3218 from Icinga/bugfix/remove-leading-and-trailing-blank-from-ip-address-2494
Remove leading and trailing blanks from ip addresses
2018-01-16 09:20:37 +01:00
lippserd 5b069bace4
Merge pull request #3138 from Icinga/bugfix/typo-existance-3062
Fix typo "existance"
2018-01-16 09:03:48 +01:00
lippserd 6abb91421a
Merge pull request #3220 from Icinga/fix/filter-by-custom-variables
Fix filter by host custom variables
2018-01-11 11:40:22 +01:00
Alexander A. Klimov 196cdbe4af Implement event history detail view
refs #3191
2018-01-09 13:04:06 +01:00
Alexander A. Klimov 0b6336c623 Separate reachability and check source info in detail views
refs #2953
2017-12-19 17:57:04 +01:00
Eric Lippmann 93ec798c6b Ido: Map h.host_object_id to s.host_object_id in the ServicegroupQuery
This is required to make filters work which filter by host custom variables without using any host related table.
2017-12-18 10:35:16 +01:00
Eric Lippmann b1f7923711 Ido: Allow custom variables to be mapped
If you filter by host custom variables and the query does not have the services table joined,
our query implementation calls the joinHosts method. Then, the column for the JOIN ON condition is
automatically set to h.host_object_id.
But it may be required by the query to call joinServices and use s.host_object_id instead of
h.host_object_id because the query does not use any host related table at all.

This is now possible when h.host_object_id is mapped to s.host_object_id:

class ServicesRelatedQuery
{
    protected $columnMap = array(
        'hosts' => array(
            'h.host_object_id' => 's.host_object_id'
        )
    );

    protected function joinHosts()
    {
        $this->requireVirtualTable('services');
    }
}
2017-12-18 10:23:45 +01:00
Alexander A. Klimov ba9d286567 Remove leading and trailing blanks from ip addresses
refs #2494
2017-12-15 13:08:14 +01:00
Eric Lippmann e376b137c7 Prepare release version 2.5.0 2017-11-27 16:18:13 +01:00
lippserd a5bf9e0175
Merge pull request #3029 from Icinga/bugfix/empty-host-and-service-groups-not-shown-2796
Bugfix/empty host and service groups not shown 2796
2017-11-27 14:24:11 +01:00
Alexander A. Klimov 5f443af14d Accept /monitoring/list/eventgrid?format=*
refs #2678
2017-11-24 17:16:33 +01:00
Alexander A. Klimov 667f3cca01 Fix typo "existance"
refs #3062
2017-11-23 16:28:19 +01:00
Eric Lippmann ca803e8f05 Fix monitoring health badge if programstatus has never been set 2017-11-22 11:12:24 +01:00
Eric Lippmann 3db9a1d77f Fix TacticalController if/else complexity 2017-11-22 11:12:24 +01:00
Jennifer Mourek d34ea588b1 Tactical overview: Add donut graphs 2017-11-21 23:38:04 +01:00
Eric Lippmann fd0fe9a403 Monitoring: Add icons and descriptions for second level menu items 2017-11-21 22:55:46 +01:00
Markus Frosch 762b4eeed2 de_DE: Extend and improve translation
refs #3067
2017-11-21 15:47:46 +01:00
Markus Frosch 2493cb8d63 Fix incorrect uses of translation around sprintf 2017-11-21 15:47:46 +01:00
Johannes Meyer e4fd8d5124 Setup: Only allow to validate the API transport configuration
refs #3101
2017-11-21 13:48:29 +01:00
Markus Frosch 22c6bf75e7 Setup: Fix that the API transport validation does not work
refs #3101
2017-11-21 13:48:17 +01:00
Eric Lippmann d11519ac49 pogsql: Group by custom variables when querying them
Custom variables added via the URL parameters addColumns or sort must be added to the GROUP BY list when using PostgreSQL.

Credits to @nbuchwitz who came up with the initial fix for this.

refs #1873
2017-11-16 09:20:22 +01:00
Florian Strohmaier 166f27b947 CSS: Optimize monitoring status bar spacing 2017-11-13 15:02:06 +01:00
cstegm bb794d6993 Detect UP and DOWN in plugin output to colorize output
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-10 11:33:52 +01:00
Klaus Jrgensen fa9b2981d7 Fix PHP fatal error on monitoring/health/info when asking for JSON
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-10 11:16:33 +01:00
Eric Lippmann 928185a144 Fix wrong unhandled services count in host views when restrictions are used
The query for fetching the unhandled services count utilises the hosts query as subquery.
Restrictions are applied to both the hosts query and the query for the unhandled services count.
This leads to wrong results since the restrictions are already in place for the unhandled services count because we're using the hosts query as subquery.

refs #2822
2017-11-10 10:17:32 +01:00
Johannes Meyer 23066d2cc4 ServicegroupQuery: Use left joins instead of inner joins
refs #2796
2017-11-09 09:42:46 +01:00
Johannes Meyer 4ef085bdcd HostgroupQuery: Use left joins instead of inner joins
refs #2796
2017-11-09 09:42:46 +01:00
Eric Lippmann 121fdaadb0 Allow to search for host and servicegroups by their case insensitive names too
refs #2971
2017-11-08 15:40:43 +01:00
Eric Lippmann f4ce2a5d82 Fix code style issues 2017-11-08 11:29:33 +01:00
Eric Lippmann 73a6750489 Make phpcs and PhpStorm happy w/ intentional switch, case fall-throughs
Unfortunately, PhpStorm does not regonise PSR2 fall-through comments.
On the other hand, phpcs does not support the @noinspection phpdoc comment (/**).
The fix is a mix of PSR2 comments and @noinspection tags in code comments.
2017-11-08 10:25:28 +01:00
Markus Frosch c3ef50978a style: Fix minor styleguide issues for PHPCS 2017-11-08 10:06:45 +01:00
lippserd 2caa07ce9b
Merge pull request #3027 from Icinga/bugfix/respect-limits-and-sort-order-for-format-requests-2967
Respect limits and sort orders for format requests
2017-11-06 09:51:19 +01:00
Michael Friedrich 1748b3df9d Fix help for icingacli monitoring list (--unhandled is --problems, etc.)
The help text still showed the wrong paramter, while it was not documented
as possible parameter either. In addition to that #562 unveils that a
custom --format parameter requires selected columns to do so.

This patch adds that into the documentation which is rendered as CLI command
help text then.

refs #562
2017-10-24 21:05:39 +02:00
Johannes Meyer 37aeff7791 Respect limits and sort orders for format requests
fixes #2967
2017-10-23 15:49:12 +02:00
tfylling 46a82c2739 Monitoring: Make downtime for all services checkbox configurable
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-23 11:17:25 +02:00
Nicolai Buchwitz bd5de0949d Remove array syntax from default comment filter
Added comment types 'comment' and 'ack' as separate fields and removed
the array syntax due to problems with the filter editor.

refs #2925

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-23 10:45:21 +02:00
Mikesch-mp c17c1b876c Export JSON with .json extension
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-18 13:47:08 +02:00
lippserd 91948a5a37 Merge pull request #2983 from Mikesch-mp/csv-export
Export CSV files with .csv extension
2017-10-18 13:21:59 +02:00
Mikesch-mp d76a18dd91 Export CSV files with .csv extension
refs #2808

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-18 13:21:19 +02:00
Blerim Sheqa 3b7147af16 Fix broken links in docs of monitoring and translation module 2017-10-09 15:52:10 +02:00
Eric Lippmann 8de0b80f9e Fix contact group member count
fixes #2837
2017-10-05 14:35:15 +02:00
lippserd 773dae3750 Merge pull request #2978 from Icinga/fix/drop-livestatus
Remove unsupported livestatus functionality
2017-09-29 11:15:54 +02:00
lippserd 4cadc90c92 Merge pull request #2972 from Icinga/feature/enhance-docs-add-missing-bits
Enhance the documentation, add missing bits and fix outdated information
2017-09-29 11:15:17 +02:00
Michael Friedrich 36b5c949fd Add documentation for addColumns in host/service list views
fixes #2579
2017-09-29 11:01:45 +02:00
Michael Friedrich 34bd8e14c3 Enhance the documentation and fix outdated information (preferences, etc.)
This applies a new structure for the main doc/ and modules/*/doc tree with

01-About.md
02-Installation.md
...

This allows us to link from the main doc directory into module specific
documentation entries.

Furthermore table formatting, examples, and missing settings have been added
where applicable.

This patch also takes care about proper URL anchors and file names and directories.

fixes #2950
2017-09-29 11:01:37 +02:00
Michael Friedrich ab364e0fc7 Remove unsupported livestatus functionality
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-09-29 10:33:55 +02:00
Eric Lippmann 3790fd0819 Bump version to 2.4.2
(cherry picked from commit 13e86b6320)
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-09-28 14:24:00 +02:00
lippserd 624fab8194 Merge pull request #2960 from Icinga/bugfix/host-severity-order-2926
Adjust host severity
2017-09-25 17:11:36 +02:00
Jennifer Mourek 0b30fbd15d Adjust host severity
refs #2926

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-09-25 17:03:33 +02:00
Alexander A. Klimov 467fc79095 Style monitored objects' detailview extensions as expected
refs #2949
2017-09-20 14:49:14 +02:00
Alexander A. Klimov c2ee3bef06 DetailviewExtensionHook: provide the concrete implementation's module
refs #2949
2017-09-20 14:49:08 +02:00
Michael Friedrich 2c312adf94 API Commands: Only send acknowledgement expire time if not null
Icinga 2 v2.7.0 is more strict with the `expiry` attribute if sent
(cannot be null, or in the past).

While acknowledgments with expire time worked well (and do so with this patch),
the command renderer did not check whether the value is actually not null
before setting it into the data form. The boolean value from the checkbox is
not available in the command renderer unfortunately.

@lippserd: Verified working with and without expire time inside the Vagrant boxes.

fixes #2911
2017-08-08 12:53:39 +02:00
Eric Lippmann 2b3853d01c Doc: Relax Icinga 2 API user permissions
Fixes #2884
2017-07-28 11:28:35 +02:00
Eric Lippmann adc2f90f74 Show DOWN hosts before UNREACHABLE when sorting by host_severity
refs #2034
2017-07-27 16:08:29 +02:00
Eric Lippmann 7c88ee70d2 Remove sort rules from Programstatus
Sort is not necessary here.
2017-07-27 15:03:12 +02:00
Eric Lippmann 1621755103 Don't call UNIX_TIMESTAMP when sorting by host_severity 2017-07-27 15:03:12 +02:00
Eric Lippmann 9b7a155db2 Don't call UNIX_TIMESTAMP when sorting by service_severity 2017-07-27 15:03:12 +02:00
Eric Lippmann 8a6240fe02 Reduce service_severity order by columns
Ordering by host and service display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
Eric Lippmann c5f2fc5aa5 Reduce service_display_names order by columns
Ordering by host_display_name too here reduces performance as it forces MySQL to use a temp table.
2017-07-27 15:03:12 +02:00
Eric Lippmann ee429f54d0 Reduce host_severity order by columns
Ordering by host_display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
Eric Lippmann e7776d08a9 Don't call UNIX_TIMESTAMP when sorting by host_last_state_change
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
Eric Lippmann 3a1afb3511 Don't call UNIX_TIMESTAMP when sorting by service_last_state_change
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
Eric Lippmann 9b529bcd15 Flip base tables in HoststatusQuery
This has no performance impact but all our queries should start w/ select from icinga_objects.
2017-07-27 15:03:12 +02:00
Eric Lippmann 370d148072 Optimize imports in HoststatusQuery 2017-07-27 15:03:12 +02:00
Eric Lippmann e42d86a4e1 Remove unncessary column definitions in the Hostgroupsummary and Servicegroupsummary data views 2017-07-27 15:03:12 +02:00
Eric Lippmann 0a3da99e7f Reduce filter columns of the Hostgroup and Servicegroup data views
Its not necessary to expose those columns because these data views do not directly accept user input.
2017-07-27 15:03:12 +02:00
Eric Lippmann 44da318109 Remove no-op order columns Hosts Severiy and Services Severity from the host group and service group views 2017-07-27 15:03:12 +02:00
Eric Lippmann b4df81e75a Optimize queries used for fetching the service group summaries 2017-07-27 15:03:12 +02:00
Eric Lippmann 06cb980308 Don't add GROUP BY for unjoined tables 2017-07-27 15:03:12 +02:00
Eric Lippmann 30cc51a823 Optimize queries used for fetching the host group summaries
refs #1883
2017-07-27 11:43:13 +02:00
Eric Lippmann f5a9016dea Optimize queries for creating the host and service problem badges in the menu
We now use two fast count queries w/ an appropriate filter instead of fetching a whole bunch of unnecessary host and service counters.
2017-07-27 11:38:00 +02:00
Eric Lippmann a9f3f99049 Don't hide errors in the BackendAvailabilityNavigationItemRenderer
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:35:40 +02:00
Eric Lippmann 439d78a982 Don't hide errors in the MonitoringBadgeNavigationItemRenderer
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:31:10 +02:00
Eric Lippmann 28790d254b Remove caching form the MonitoringBadgeNavigationItemRenderer
Caching will be no longer necessary because we will replace the queries used to fetch the problem badges.
2017-07-27 11:29:57 +02:00
Eric Lippmann c0d359fbbd Fix base class of MonitoringBadgeNavigationItemRenderer
The MonitoringBadgeNavigationItemRenderer extended the SummaryNavigationItemRenderer before which does not make sense because they have nothing in common.
2017-07-27 09:33:44 +02:00
Alexander A. Klimov 6848ed6c1e Merge branch 'bugfix/can-t-progress-in-wizard-due-to-error-2842'
fixes #2842
2017-07-05 14:40:10 +02:00
Alexander A. Klimov 5460465e07 Fix null->setDecorators()
refs #2842
2017-07-05 14:34:17 +02:00
Eric Lippmann d208b48b72 Monitoring: Fix permission for the 'Process check result' action
fixes #2878
2017-07-04 17:24:57 +02:00
Markus Frosch 3d3b1cdf4f RestRequestTest: Fully qualify expected exception 2017-06-13 11:07:16 +02:00