tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,430 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

117 Commits

Author SHA1 Message Date
Alexander Fuhr c8a24f72b8 Introduce getValue() in Preferences and fix the loading of values 2014-09-26 14:15:50 +02:00
Eric Lippmann 264d818133 Do not save config references in the `ActionController' 
This is redundant because our `Config' class already caches loaded configs.
 2014-09-19 14:44:21 +02:00
Eric Lippmann c51b05296e Merge branch 'master' into bugfix/commands-6593 2014-09-19 13:18:47 +02:00
Eric Lippmann d091e2150c Fix `ActionController::prepareInit()' php doc 2014-09-16 18:43:14 +02:00
Alexander Fuhr b38ef9c0bd Implement plural and context based translation functionality 
refs #6982
 2014-09-16 15:19:23 +02:00
Eric Lippmann f8edb4f220 lib: Add method `ActionController::prepareInit()' 
As it should not be required for controllers to call the parent's init() method, base controllers should use
prepareInit() in order to prepare the controller initialization.
 2014-09-16 09:28:10 +02:00
Alexander Fuhr e2b5e05f21 Implement plural translation (testing) 2014-09-15 14:11:42 +02:00
Alexander Fuhr 583fd46f15 Experimental Plural Translation Implementation 
Personal BACKUP
 2014-09-11 18:04:10 +02:00
Thomas Gelf 6faedf5733 ActionController: no benchmark for no renderer 
Benchmarks should not be shown when the renderer is no longer available.
 2014-09-02 16:49:28 +02:00
Alexander Klimov 45638b218c Throw IcingaException rather than Exception 
fixes #7014
 2014-08-27 16:03:15 +02:00
Thomas Gelf db3ef8fbd0 ActionController: remove redirectToLogin default 
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
 2014-08-19 12:28:24 +02:00
Thomas Gelf 9d4a4f49c9 ActionController: JS should redirect to __SELF__... 
...once you lost your session. That's the only way to do this in a
smooth way. When the server get's an unauthenticated request for a
single container, redirecting to auth/login?redir=<that-container>
was not what you expect.

Together with JS handling __SELF__ in redirection URLs this will
play fine.

refs #6935
 2014-08-19 09:57:24 +02:00
Thomas Gelf 8f729bfb65 ActionController: set a default window title 
In case a controller action didn't set a view title this fix restores
the default title on XHR requests.

fixes #6797
 2014-07-31 17:04:26 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files 
refs #6309
 2014-07-15 13:43:52 +02:00
Johannes Meyer bb2c85f90b Remove forgotten ActionController::requiresConfig() call 
Should have been reverted by last commit but was not.
 2014-07-07 16:12:26 +02:00
Johannes Meyer 82d2f5ac9b Revert "Merge branch 'feature/install-wizard-6136'" 
This reverts commit 88d4262e7c, reversing
changes made to 6fae333048.

Conflicts:

	application/controllers/InstallController.php
	library/Icinga/Web/Controller/ActionController.php
 2014-07-07 15:09:03 +02:00
Thomas Gelf 3772b9c16f ActionController: set layout module name early 
Didn't work correctly before
 2014-07-04 12:33:49 +02:00
Johannes Meyer f2e5d8afa5 Remove @codeCoverageIgnoreStart/-Stop annotations 
refs #6091
 2014-06-30 13:58:37 +02:00
Thomas Gelf 59dd80ed32 ActionController: benchmark should measure rendering 
We have been cheating a little bit, now the measurement should be more
precise.
 2014-06-25 20:37:17 +02:00
Thomas Gelf ea44de8698 ActionController/translate: detect domain only once 2014-06-22 20:09:23 +02:00
Thomas Gelf 23ed744747 params/_render: replace it everywhere 
Cleaning up controllers and JS, using headers only and respecting
history.
 2014-06-22 20:07:44 +02:00
Thomas Gelf 216f0f3f55 isIframe: clean up, load less html and js 
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
 2014-06-22 16:30:06 +02:00
Thomas Gelf 3774eb6889 ActionController: add isXhr() method 
Makes things easier as we use this a lot
 2014-06-22 15:36:41 +02:00
Thomas Gelf 331d756a2a ActionController: isolate ignoreXhrBody 
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
 2014-06-22 15:33:38 +02:00
Thomas Gelf b4f8ef74fa ActionController: remove obsolete code 2014-06-22 15:20:55 +02:00
Thomas Gelf 631603aba3 ActionController: create postDispatchXhr 
Moved XHR-specific stuff to a dedicated post-dispatch function
 2014-06-22 15:17:28 +02:00
Thomas Gelf cf995b366b ActionController: cleanup postDispatch 
Make XHR handling more readable, move module-related stuff to the
module controller
 2014-06-22 15:11:08 +02:00
Thomas Gelf de19745eb2 ActionController: move moduleInit to Module controller 2014-06-22 13:54:02 +02:00
Thomas Gelf 2cd25b7376 ActionController: if/else should be easy to read 2014-06-22 13:52:40 +02:00
Thomas Gelf b7fc0b67a8 Web/controllers: use own Request/Response objects 
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
 2014-06-22 13:49:21 +02:00
Thomas Gelf ef5e1b54fd Web\Window: fix it's usage, add helper function 
Improved window handling, fixed controllers using it.
 2014-06-22 13:21:21 +02:00
Thomas Gelf b350e3640d Web\Window: move window handle to dedicated class 
One more step in cleaning up our ActionController
 2014-06-22 13:01:48 +02:00
Thomas Gelf d69a6d1640 ActionController: remove getRequestUrl 
Thie removes complexity and makes redirection to login less error-
prone.
 2014-06-22 12:23:34 +02:00
Thomas Gelf 9608d8254d ActionController: remove addModuleContainer 
This method was obsolete
 2014-06-22 12:09:07 +02:00
Thomas Gelf 4980b700da ActionController: __construct() as first function 2014-06-22 12:07:50 +02:00
Thomas Gelf a4955df1a9 controller->Auth(): one more lazy-loading helper 
Not sure about the capital A, but doesn't look so bad - and similar
to Config().
 2014-06-22 12:06:09 +02:00
Thomas Gelf 373e1c5ecb Web\Controller: re-introduce ModuleActionController 
This will help getting rid of a couple of if/else constructs
 2014-06-22 12:03:37 +02:00
Thomas Gelf 216c2ca770 Autorefresh: should work also on initial page load 
fixes #6296
 2014-06-21 01:54:32 +02:00
Thomas Gelf 07134cf931 JS/XHR: handle multiple notifications 
As there seems to be problems with sending the same header multiple
times we put multiple notifications in one header.
 2014-06-20 13:20:20 +02:00
Thomas Gelf dbf03ee647 ActionController: refine url handling on redirect 2014-06-20 13:18:03 +02:00
Thomas Gelf 7cad4de3be ActionController: allow to disable autorefresh 2014-06-20 13:17:11 +02:00
Thomas Gelf 992a8a276b Web/ActionController: provide $this->params 
We always need params, this are our new URL params made accessible
this way. This is just for our query string, not for POST body params.
 2014-06-17 12:58:04 +00:00
Thomas Gelf 468b290277 Monitoring\Controller: provide $this->backend 
Every monitoring controller needs $backend, so why declaring it over
and over again. Created "moduleInit" dummy function in our base action
controller to allow such implementations without polluting init().
 2014-06-17 12:55:43 +00:00
Johannes Meyer 159d765f14 Fix that calling ActionController::translate() throws an exception 
Translating strings must not throw an exception
even if the given domain is not valid.

fixes #6432
 2014-06-11 13:39:22 +02:00
Thomas Gelf e01629fe0b ActionController: fix initial redirect 
refs #6419
 2014-06-06 08:32:21 +00:00
Thomas Gelf 99aae5a0d9 JS/XHR: get ready to get XHR redirect-aware 
These are just the first steps, there is more to come
 2014-06-05 03:37:36 +00:00
Eric Lippmann a379502b15 Preferences: Rename `showBenchmark' to `show_benchmark' 
We use underscore_case notation for all configuration keys.

refs #4952
 2014-06-02 13:33:55 +02:00
Thomas Gelf 88460189cd Encoding: no ASCII chars > 127 in HTTP headers 
Had quite some trouble with this, decided to URL-encode titles and
notifications.
 2014-05-28 21:34:36 +00:00
Thomas Gelf 360ac87550 Translation: add a module-aware translation helper 
With this fix $this->translate works in our view scripts

refs #6338
 2014-05-27 21:41:46 +00:00
Thomas Gelf 70ba36aad6 notifications: improve client- and serverside 
This is just a first step, trying to catch a few gotchas:

* it doesn't send notifications to the browser when issueing a redirect
  as redirects can currently not be catched in jQuery response handlers
* it tries to find a better notification handling place in the response
  handler (JS) - still imperfect
* it explicitely stores sessions once modified by notifications. Still
  need to crosscheck whether this is really needed and how we can get
  rid of this.

refs #6280
 2014-05-26 14:41:47 +00:00