tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,994 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

2994 Commits

Author SHA1 Message Date
Johannes Meyer fc72ddfbc8 Adjust Preferences/GeneralForm to use handleRequest() &. Co. 
refs #5525
 2014-09-05 10:21:24 +02:00
Johannes Meyer 7d212658bc Fix "Use statement with non compound name..." in TimelineController 2014-09-05 09:17:54 +02:00
Johannes Meyer d021747bde Fix form widgets 
refs #5525
 2014-09-05 09:17:09 +02:00
Johannes Meyer 8846f17ae1 Make it possible to disable form identification 
refs #5525
 2014-09-05 09:16:09 +02:00
Johannes Meyer 439d1895a7 Adjust Monitoring\BackendForm to use handleRequest() & Co. 
refs #5525
 2014-09-04 11:25:47 +02:00
Johannes Meyer 9d66cc9023 Adjust Monitoring\InstanceForm to use handleRequest() & Co. 
refs #5525
 2014-09-04 08:47:16 +02:00
Johannes Meyer 49562e75d7 Adjust ..\Monitoring\Form\Config\SecurityForm to use handleRequest() 
refs #5525
 2014-09-03 15:08:37 +02:00
Johannes Meyer 54a834266c Form::createElements() should add elements instead of returning them 
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().

refs #5525
 2014-09-03 12:21:31 +02:00
Eric Lippmann dd3901e891 `FormNumber': Fix "The use statement with non-compound name..." 
refs #5525
 2014-09-02 17:08:54 +02:00
Johannes Meyer 5ce9bef689 Replace usages of the `helptext' form element option with `description' 
refs #5525
 2014-09-02 17:03:51 +02:00
Eric Lippmann c7a4098c04 lib: Respect the disabled attribute in `FormNumber' 
refs #5525
 2014-09-02 16:54:43 +02:00
Eric Lippmann 5485ca8a25 lib: Use Zend's `Int' validator in the `Number' form element 
Further disabled default decorators since our form sets them.

refs #5525
 2014-09-02 16:54:43 +02:00
Johannes Meyer 95c839a8bd Remove remaining usages of the ElementWrapper- and HelpText-Decorator 
refs #5525
 2014-09-02 16:50:59 +02:00
Johannes Meyer 5464321a1b ConfigController: Remove obsolete functionality 2014-09-02 16:25:03 +02:00
Johannes Meyer 1ba3df310c Remove BaseConfigController, User\Message and Widget\AlertMesageBox 
refs #6758
 2014-09-02 16:25:03 +02:00
Johannes Meyer 2d86e6ba3b Rename ResourceForm and make it use handleRequest() & Co. 
refs #5525
 2014-09-02 16:25:03 +02:00
Johannes Meyer 5b14d8fed3 Fix that the force_creation checkbox disappears after another error 
Once the user enters invalid data after he tried to save a backend without
success (because the backend was not successfully validated) the shown
checkbox disappeared in this case regardless of whether it was checked
or not.

refs #5525
 2014-09-02 16:25:03 +02:00
Johannes Meyer 539ab91ffa Add the FormErrors decorator as default decorator for forms 
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.

refs #5525
 2014-09-02 16:25:03 +02:00
Johannes Meyer 338f549233 Add class ReadablePathValidator 2014-09-02 16:19:45 +02:00
Johannes Meyer aedc8cc8b1 Fix spelling issue in german translation catalog 2014-09-02 16:19:45 +02:00
Johannes Meyer 39bb01b433 Rename Icinga\Web\Form::onShow() to onRequest() 
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.

refs #5525
 2014-09-02 16:19:45 +02:00
Eric Lippmann d4c4ab7b2c lib/form: Fix default element decorators but breaking noscript layout 
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.

Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.

refs #5525
 2014-09-02 15:23:07 +02:00
Eric Lippmann 8478ef3fce lib: Remove `HelpText' form element decorator 
Zend already has a `Description' decorator.

refs #5525
 2014-09-02 15:05:47 +02:00
Eric Lippmann 7143837ae3 lib: Remove `ElementWrapper' form element decorator 
Zend has a `Label' decorator already.

refs #5525
 2014-09-02 15:04:23 +02:00
Johannes Meyer deebb64869 Adjust Icinga\Form\Config\General* to use handleRequest() & Co. 
refs #5525
 2014-09-01 16:16:56 +02:00
Johannes Meyer 0e63e36ec0 Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form 
This is a generic form not necessarily being used just for configuration
purposes.

refs #5525
 2014-09-01 15:11:09 +02:00
Johannes Meyer cd8015f41a Pass the current form instance to the callback as second argument 
refs #5525
 2014-09-01 14:58:16 +02:00
Eric Lippmann 0822aff293 library/form: Fix return value of `getName()' not being filterd the first time it's called 
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.

refs #5525
 2014-09-01 14:40:45 +02:00
Eric Lippmann f3e74f0f24 library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set 
Before, the class attribute would've been overwritten.

refs #5525
 2014-09-01 09:44:04 +02:00
Johannes Meyer fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-29 16:05:56 +02:00
Johannes Meyer ae35650c7e Adjust authentication backend forms to suit.. some form implementation 
refs #5525
 2014-08-29 15:16:13 +02:00
Johannes Meyer 364c7c0858 Add base form class for configuration forms 
refs #5525
 2014-08-29 12:25:25 +02:00
Johannes Meyer e020dd3541 Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath 
Prior to this change it was not possible to create an instance of Config
without passing a config file.
 2014-08-29 12:23:48 +02:00
Johannes Meyer 79b0ed64ec Make it possible to provide a closure to be called instead of onSuccess() 
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.

refs #5525
 2014-08-29 12:21:31 +02:00
Matthias Jentsch 055a107b90 Merge branch 'bugfix/piechart-labels-stick-out-7022' 
fixes #7022
 2014-08-29 09:14:36 +02:00
Johannes Meyer bf23688e73 Make autosubmit work in non-JS enviroments 
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.

refs #5525
 2014-08-29 09:08:53 +02:00
Johannes Meyer 486104d59e Check explictly for FALSE when calling onSuccess() 
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.

refs #5525
 2014-08-29 09:04:20 +02:00
Matthias Jentsch 3642b7b6fc Adjust CSS for inlinePies to be centered on the current line 2014-08-28 18:27:30 +02:00
Matthias Jentsch a26370bb12 Adjust PieCharts that are rendered without labels 
Center and resize PieCharts to use the full width and height of the available view port
 2014-08-28 18:25:19 +02:00
Matthias Jentsch e799d65d3f Only apply SVG responsiveness when not rendered in compact mode 
Don't let SVGs grow vertically in when displayed in the dashboard, to avoid wasted space
 2014-08-28 16:52:02 +02:00
Matthias Jentsch 648debff88 Draw charts for single ServiceGroups as PieChart 2014-08-28 16:50:29 +02:00
Matthias Jentsch 00a2d225a2 Ensure that PieCharts are centered and that labels dont leave the viewBox 
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
 2014-08-28 16:42:31 +02:00
Matthias Jentsch c5cface661 Improve readability of small pie charts 
Use a bigger font, to ensure that small pie charts still have readable labels.
 2014-08-28 16:40:34 +02:00
Matthias Jentsch 98809a1447 Do not use width and height as width and height percentages in the outer SVG element 
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
 2014-08-28 16:37:21 +02:00
Matthias Jentsch a9eec0d672 Remove useless width and height properties from PieChart 2014-08-28 16:33:38 +02:00
Matthias Jentsch f77cd9cafa Fix coding guidelines 2014-08-28 16:21:16 +02:00
Matthias Jentsch 573a4ea12f Fix spelling mistakes 2014-08-28 16:14:59 +02:00
Marius Hein 0da16e4c68 Merge branch 'bugfix/icinga2-contacts-7020' 
fixes #7020
 2014-08-28 13:42:16 +02:00
Marius Hein 0a2b504db8 Gracatar: Pre sized with 60px because of display latency 
refs #7020
 2014-08-28 13:41:21 +02:00
Marius Hein c4c5bcdd48 ContactQuery: Change timeperiod joins to joinLeft() 
refs #7020
 2014-08-28 13:39:49 +02:00