tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,237 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

6237 Commits

Author SHA1 Message Date
Eric Lippmann fde60f4a00 lib: Add HttpMethodNotAllowedException 
At the moment we throw a Zend_Controller_Action_Exception when the HTTP method is not allowed.
I'll replace this w/ the exception introduced.

refs #6281
 2015-05-21 17:19:07 +02:00
Eric Lippmann fcd7aaef87 lib: Add HttpException as base class for HTTP exceptions 
refs #6281
 2015-05-21 17:18:29 +02:00
Eric Lippmann 8f42d7a1d3 monitoring: Fix HTTP response code when showing an invalid downtime 
refs #6281
 2015-05-21 17:17:25 +02:00
Eric Lippmann 5e520e7b59 Don't display a error message as title too 
refs #6281
 2015-05-21 16:57:43 +02:00
Eric Lippmann 03b4de3253 Handle the HttpNotFoundException in the ErrorController 
refs #6281
 2015-05-21 16:56:27 +02:00
Eric Lippmann dd1025119d Throw HttpNotFoundException on Controller::httpNotFound() 
refs #6281
 2015-05-21 16:54:00 +02:00
Eric Lippmann c4ed49cb1a lib: Add HttpNotFoundException 
The HttpNotFoundException should be used for sending a HTTP 404 response w/ a custom message.

There's also Zend_Controller_Action_Exception but this exception will always show 'Page not found' because we
want to hide messages generated by Zend, like 'Action "foobar" does not exist and was not trapped in __call()'.

refs #6281
 2015-05-21 16:43:58 +02:00
Eric Lippmann 0b81a1130f monitoring: Fix HTTP response code when showing an invalid host 
refs #6281
 2015-05-21 16:18:09 +02:00
Eric Lippmann e8c704b98d monitoring: Fix HTTP response code when showing an invalid service 
refs #6281
 2015-05-21 16:18:09 +02:00
Eric Lippmann ce9110d22d Revert "Add proper respond http codes to service and host controller" 
This reverts commit 6df031dc78.

I revert this commit for the following reasons:
- MissingParameterException must not be thrown manually because we have UrlParams::getRequired() which was UrlParams::req() before.
- The commit introduces the untranslated string 'host or service'.
- 4xx are client, not server errors.
- Copy and paste code for the stack trace handling in the ErrorController.

refs #6281
 2015-05-21 16:14:02 +02:00
Eric Lippmann 902c00e836 lib: Introduce Controller::httpNotFound() 
Many actions require loading specific objects from database or any other storage.
If the object isn't found, Controller::httpNotFound($message) should be used
for immediately returning w/ HTTP 404.
 2015-05-20 10:30:01 +02:00
Eric Lippmann bd54784496 Don't override submit label in the ConfirmRemovalForm 2015-05-20 10:30:00 +02:00
Eric Lippmann 5a69c26d2c Fix typo in PHPDoc of ConfirmRemovalForm::init() 2015-05-20 10:30:00 +02:00
Eric Lippmann 338fad5da9 cli: Add Params::shiftRequired() 2015-05-20 10:30:00 +02:00
Eric Lippmann ccaebd1d73 cli: Rename Params::req() to ::getRequired() 2015-05-20 10:30:00 +02:00
Eric Lippmann 3d1c3609c0 lib: Add UrlParams::shiftRequired() 2015-05-20 10:30:00 +02:00
Eric Lippmann 3a2238f737 Rename UrlParams::req() to ::getRequired() 
req() seems mysterious :)
 2015-05-20 10:30:00 +02:00
Alexander A. Klimov b1b2e3fc21 Revert "Merge branch 'bugfix/Take-display_name-into-account-when-searching-for-host-and-service-names-8241'" 
This reverts commit 75b004dc42, reversing
changes made to bd7c7f9636.
 2015-05-19 17:13:46 +02:00
Matthias Jentsch 54207d3427 Revert "Abort pending AJAX requests before page unload" 
This reverts commit 94bdb8b4b0. After the patch, Firefox shows an error message on each reload for an unknown reason.

refs #7759
 2015-05-19 17:06:22 +02:00
Matthias Jentsch 94bdb8b4b0 Abort pending AJAX requests before page unload 
Abort all pending requests before the page unload, to avoid confusing error messages during page reloads. Avoid rendering the site unusable in cases where the site is still being used after the beforeunload event.

fixes #7759
 2015-05-19 16:35:44 +02:00
Eric Lippmann 0a8c9ad195 Merge branch 'feature/list-number-of-hosts-in-host-groups-8054' 
resolves #8054
 2015-05-19 15:10:20 +02:00
Alexander A. Klimov 75b004dc42 Merge branch 'bugfix/Take-display_name-into-account-when-searching-for-host-and-service-names-8241' 
fixes #8241
 2015-05-19 14:05:33 +02:00
Alexander A. Klimov a2b262eab1 Take display_name into account when searching for host and service names 
refs #8241
 2015-05-19 14:04:23 +02:00
Alexander A. Klimov 85dd496d35 Add parameter $searchColumns to ::filterQuery() 
refs #8241
 2015-05-19 14:01:18 +02:00
Johannes Meyer bd7c7f9636 Introduce widget Paginator 
This does not support custom scrolling styles as of now. Custom view
scripts are supported though. In case Paginator::getPages() does not
suffice, feel free to improve this.
 2015-05-19 13:57:21 +02:00
Johannes Meyer 4cedfce07f DataView: Fix that method getOffset() calls parent::hasOffset() 2015-05-19 13:57:20 +02:00
Johannes Meyer a629adb448 DataView: Remove method paginate() 2015-05-19 13:57:20 +02:00
Johannes Meyer 73e8c51fd1 Ldap\Query: Remove method paginate() 2015-05-19 13:57:20 +02:00
Eric Lippmann afe07f4814 Revert "Hostgroups view: reduce "Last Problem" column's width" 
This reverts commit 8b08473341.

Common table style is subject of #8935.

refs #8054
 2015-05-19 13:45:20 +02:00
Eric Lippmann 3296522d90 Merge branch 'feature/Allow-to-add-columns-to-monitoring-views-via-URL-4498' 
resolves #4498
 2015-05-19 13:35:04 +02:00
Alexander A. Klimov 4f4d7ccba2 Correct PHPDoc of ::setSearchColumns() 2015-05-19 12:55:40 +02:00
Alexander A. Klimov 1ce9900c86 Add PHPDoc to ::setSearchColumns() 2015-05-19 11:12:36 +02:00
Alexander A. Klimov d539a0e017 Add PHPDoc to ::addColumns() 
refs #4498
 2015-05-19 10:11:54 +02:00
Matthias Jentsch 94555d7998 Streamline layout of all multi-views 
Fix small inconsistencies between layout of downtime, comment, service and host multi-views.
 2015-05-18 17:17:30 +02:00
Alexander A. Klimov 0bde465295 Rename ::extraColumns() to ::addColumns() 
refs #4498
 2015-05-18 16:29:33 +02:00
Alexander A. Klimov 52d1cb8c8f Merge branch 'bugfix/Toggle-FeaturesCommandForm-make-notifications-more-verbose-9023' 
fixes #9023
 2015-05-18 16:09:07 +02:00
Alexander A. Klimov 7caba93a28 Replace `...' w/ `..' 
refs #9023
 2015-05-18 16:07:28 +02:00
Matthias Jentsch 592d5eadc1 Merge branch 'feature/improve-multi-select-view-8565' 2015-05-18 16:00:52 +02:00
Matthias Jentsch 1f20ba1bc6 Fix state summary base target in multi views 
refs #8565
 2015-05-18 15:48:04 +02:00
Matthias Jentsch c3129890aa Improve multi-view tabs 
Display the current object count next to the tab title, to clarify that those views display a summary of multiple items. Only display the current tab for hosts or services, to avoid confusion.

refs #8565
 2015-05-18 15:25:12 +02:00
Alexander A. Klimov 0d48ddcc06 ToggleObjectFeaturesCommandForm::onSuccess(): show a notification for each feature about whether it has been enabled or disabled 
refs #9023
 2015-05-18 15:18:26 +02:00
Matthias Jentsch 342a8a39d1 Fix state summary in multi views 
refs #8565
 2015-05-18 14:58:51 +02:00
Alexander A. Klimov 729fb9a4d1 ToggleInstanceFeaturesCommandForm::onSuccess(): notifications: show which feature has been enabled or disabled 
refs #9023
 2015-05-18 14:51:22 +02:00
Matthias Jentsch e84491d438 Improve multi view layout 
refs #8565
 2015-05-18 14:49:06 +02:00
Alexander A. Klimov 4fbadaea2c ToggleInstanceFeaturesCommandForm::createElements(): make form labels shorter 
refs #9023
 2015-05-18 14:20:17 +02:00
Marius Hein ca37226982 Merge branch 'feature/service-actions-9284' 
resolves #9284
 2015-05-18 14:08:05 +02:00
Marius Hein f4d25a71c8 Merge branch 'master' into feature/service-actions-9284 2015-05-18 14:07:41 +02:00
Matthias Jentsch 00bbb762a1 Integrate comments and downtimes into MonitoredObjectsController 
Add option to list all related commends and downtimes into the specific hosts and serivces views.

refs #8565
 2015-05-18 14:03:10 +02:00
Matthias Jentsch fe2ee3617b Remove pie charts from multi-views 
refs #8565
 2015-05-18 13:56:35 +02:00
Alexander A. Klimov 4ff7d7a845 Don't parse $object->check_execution_time w/ regex as it's always a float (or null) 2015-05-18 13:37:38 +02:00