Fixed SQL Injection vulnerability in admin/view.php

This commit is contained in:
Andre Lorbach 2012-05-22 10:56:59 +02:00
parent 565cc2b3e5
commit 0716c4ec9a

View File

@ -236,7 +236,7 @@ if ( isset($content['ISEDITORNEWVIEW']) && $content['ISEDITORNEWVIEW'] )
{ {
// If Columns are send using POST we use them, otherwise we try to use from the view itself, if available // If Columns are send using POST we use them, otherwise we try to use from the view itself, if available
if ( isset($_POST['Columns']) ) if ( isset($_POST['Columns']) )
$AllColumns = $_POST['Columns']; $AllColumns = DB_RemoveBadChars($_POST['Columns']);
else if ( isset($content['COLUMNS']) ) else if ( isset($content['COLUMNS']) )
$AllColumns = $content['COLUMNS']; $AllColumns = $content['COLUMNS'];
@ -492,9 +492,9 @@ if ( isset($_POST['op']) )
foreach ( $_POST['Columns'] as $myColKey) foreach ( $_POST['Columns'] as $myColKey)
{ {
if ( isset($content['COLUMNS']) ) if ( isset($content['COLUMNS']) )
$content['COLUMNS'] .= ", " . $myColKey; $content['COLUMNS'] .= ", " . DB_RemoveBadChars($myColKey);
else else
$content['COLUMNS'] = $myColKey; $content['COLUMNS'] = DB_RemoveBadChars($myColKey);
} }
// Add custom search now! // Add custom search now!
@ -538,9 +538,9 @@ if ( isset($_POST['op']) )
foreach ($_POST['Columns'] as $myColKey) foreach ($_POST['Columns'] as $myColKey)
{ {
if ( isset($content['COLUMNS']) ) if ( isset($content['COLUMNS']) )
$content['COLUMNS'] .= ", " . $myColKey; $content['COLUMNS'] .= ", " . DB_RemoveBadChars($myColKey);
else else
$content['COLUMNS'] = $myColKey; $content['COLUMNS'] = DB_RemoveBadChars($myColKey);
} }