tyler.durden/pixiewps
1
0
Fork 0
mirror of https://github.com/wiire-a/pixiewps.git synced 2025-07-27 07:44:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed redundant memcpy of E-S1 and E-S2

Browse Source
This commit is contained in:
wiire-a 2017-11-16 14:43:27 +01:00
parent edd5d30b4c
commit 06ce5c870c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pixiewps.c
View File

@ -901,11 +901,11 @@ usage_err:
do { do {
i++; i++;
glibc_seed(&glibc_prng, nonce_seed + i); glibc_seed(&glibc_prng, nonce_seed + i);
for (uint_fast8_t j = 0; j < GLIBC_MAX_GEN; j++) { for (uint_fast8_t j = 0; j < 4; j++) {
uint32_t be = h32_to_be(glibc_rand(&glibc_prng)); uint32_t be = h32_to_be(glibc_rand(&glibc_prng));
memcpy(&(wps->e_s1[4 * j]), &be, sizeof(uint32_t)); memcpy(&(wps->e_s1[4 * j]), &be, sizeof(uint32_t));
memcpy(wps->e_s2, wps->e_s1, WPS_SECRET_NONCE_LEN); /* E-S1 = E-S2 != E-Nonce */
} }
memcpy(wps->e_s2, wps->e_s1, WPS_SECRET_NONCE_LEN); /* E-S1 = E-S2 != E-Nonce */
s1_seed = nonce_seed + i; s1_seed = nonce_seed + i;
s2_seed = nonce_seed + i; s2_seed = nonce_seed + i;
@ -953,11 +953,11 @@ usage_err:
do { do {
i++; i++;
glibc_seed(&glibc_prng, nonce_seed - i); glibc_seed(&glibc_prng, nonce_seed - i);
for (uint_fast8_t j = 0; j < GLIBC_MAX_GEN; j++) { for (uint_fast8_t j = 0; j < 4; j++) {
uint32_t be = h32_to_be(glibc_rand(&glibc_prng)); uint32_t be = h32_to_be(glibc_rand(&glibc_prng));
memcpy(&(wps->e_s1[4 * j]), &be, sizeof(uint32_t)); memcpy(&(wps->e_s1[4 * j]), &be, sizeof(uint32_t));
memcpy(wps->e_s2, wps->e_s1, WPS_SECRET_NONCE_LEN); /* E-S1 = E-S2 != E-Nonce */
} }
memcpy(wps->e_s2, wps->e_s1, WPS_SECRET_NONCE_LEN); /* E-S1 = E-S2 != E-Nonce */
s1_seed = nonce_seed - i; s1_seed = nonce_seed - i;
s2_seed = nonce_seed - i; s2_seed = nonce_seed - i;