Feedback from code review

This commit is contained in:
Tim Chevalier 2024-10-30 17:02:25 -07:00 committed by Philip Chimento
parent d2d84950c3
commit 7fb465496f
3 changed files with 20 additions and 3 deletions

View File

@ -11,7 +11,6 @@ features: [Temporal]
// "1976-11-18T00:00:00+01:00[+01:00]"
const expected = new Temporal.ZonedDateTime(217119600000000000n, "+01:00");
// can be constructed with monthCode and without month
TemporalHelpers.assertZonedDateTimesEqual(Temporal.ZonedDateTime.from({
year: 1976,
month: 11,

View File

@ -14,3 +14,22 @@ assert.throws(TypeError, () => Temporal.ZonedDateTime.from({
days: 18,
timeZone: "+01:00"
}));
assert.throws(TypeError, () => Temporal.ZonedDateTime.from({
years: 1976,
months: 11,
day: 18,
timeZone: "+01:00"
}));
assert.throws(TypeError, () => Temporal.ZonedDateTime.from({
year: 1976,
months: 11,
days: 18,
timeZone: "+01:00"
}));
assert.throws(TypeError, () => Temporal.ZonedDateTime.from({
years: 1976,
month: 11,
days: 18,
timeZone: "+01:00"
}));

View File

@ -3,11 +3,10 @@
/*---
esid: sec-temporal.zoneddatetime.from
description: Temporal.ZonedDateTime.from({}) throws.
description: from() throws if a required property is undefined.
features: [Temporal]
---*/
// Temporal.ZonedDateTime.from(required prop undefined) throws
assert.throws(TypeError, () => Temporal.ZonedDateTime.from({
year: 1976,
month: undefined,