Commit Graph

553 Commits

Author SHA1 Message Date
jugglinmike 5757d60e17 Correct syntax in generated tests (#2373)
Prior to the application of this patch, the modified test template
included an unintentional syntax error. This caused all generated tests
to spuriously satisfy the expectation for an error.

Correct the syntax in the test template and regenerate the tests,
ensuring that when engines report a syntax error, they are demonstrating
the behavior which the tests were designed to verify.
2019-09-27 16:22:56 -04:00
Mike Pennisi f26c2a11bd Remove unnecessary "includes" directives
The values defined by the referenced files are not used by these tests.
This makes their inclusion superfluous, which needlessly increases the
time to execute the tests and may confuse some readers.
2019-09-25 13:59:24 -04:00
Nicolò Ribaudo 5de1bb4cd5 Add missing used features to private fields tests (#2361) 2019-09-24 13:51:47 -04:00
Nicolò Ribaudo 7697d3a1d5 Test specific error in super-private-access-invalid.case (#2355)
Without declaring #x in the class body, the thrown error could have been
about the undeclared private name rather than about the SuperProperty
2019-09-24 13:51:10 -04:00
Caio Lima 543cc598de Adding tests to verify early error when mixing private static and instance accessors (#2316) 2019-09-20 15:27:03 -03:00
Nicolò Ribaudo edafc79523 Add missing feature to prod-private-method-initialize-order.case (#2354) 2019-09-19 11:48:06 -03:00
Caio Lima d65b9b35be Abrupt completion cases (#2321)
* Added abrupt completition into PrivateFieldSet and PrivateFieldGet

* Adding abrupt completition for computed property evaluation

* Added case to cover abrupt completition on field initializer

* Fixing typo for 'complition' word

* Fixing typo into setter and getter description

* Fixing broken test abrupt-completition-on-field-initializer.js

* Fixing NITs

* Fixing typo of completion
2019-09-05 17:15:05 -03:00
Caio Lima a997838e4b Adding missing variations to verify private method name setup (#2323)
* Added missing cases for name into variations of private method definition

* Generated tests

* Fixing broken case 'private-async-generator-method-name'
2019-09-04 11:43:25 -03:00
Leo Balter 0e30ee06c9
Merge pull request #2322 from caiolima/private-method-length
Added private method length cases
2019-09-04 11:42:19 -03:00
Leo Balter 5d84854f27
Avoid usage of Object.keys when asserting order of returned values (#2320)
Fixes #2226
2019-09-04 11:38:18 -03:00
Caio Lima 32958aeb56 Generated tests 2019-08-30 13:35:28 -03:00
Caio Lima 7b1f479c8b Added case file to intercalated static/non-static computed fields (#2318)
* Added case file to intercalated static/non-static computed fields.

* Fixing error into tests to properly call 'C' instead of 'c'.
2019-08-29 16:02:21 -03:00
Shu-yu Guo a31961f7ea Add tests for nested private fields (#2317)
This came up with a V8 bug where private fields weren't resolved
properly from nested classes where both the inner and the outer class
had private fields.
2019-08-29 11:19:47 -03:00
Qiming Ma 407103728c Add tests for duplicate private methods (early-error) (#2308)
* Add tests for duplicate private methods

* Add generated js test files

* Fix indentation

* Add more features to tests

* Fix feature list format
2019-08-29 11:17:37 -03:00
Leo Balter 230ab42698
Merge pull request #2296 from caiolima/private-static-members-inner-class
Private static members inner class
2019-08-28 16:04:17 -03:00
Leo Balter daa5994b38
Merge pull request #2294 from leobalter/2285/accessor-names
Add cases for `default` identifier names in accessor-names
2019-08-28 15:05:12 -03:00
Caio Lima 33cc1cdb6c Adding case where the usage of private field inside computed property should throw a TypeError. (#2298) 2019-08-28 15:00:13 -03:00
Leo Balter 8d41122c2b
Merge pull request #2310 from mkubilayk/static-private-from-instance
Add tests covering static private methods used from instance methods
2019-08-28 14:19:00 -03:00
Leo Balter 3daa5e46fc
Merge pull request #2304 from caiolima/private-static-accessor
Private static accessor declaration and usage
2019-08-28 12:45:58 -03:00
Leo Balter 7ca7d01bfb
Merge pull request #2307 from caiolima/verify-different-brand
Verify different brand from static and instance private methods
2019-08-28 12:45:24 -03:00
Caio Lima 8790a8e98a Added private static accessor cases with direct eval access (#2305) 2019-08-28 12:44:14 -03:00
Kubilay Kahveci ca58913191 Generate tests 2019-08-23 13:50:23 +01:00
Caio Lima 04ccc8624e Generated tests 2019-08-20 15:27:59 -03:00
Caio Lima 01e89a8a0a Generated tests 2019-08-19 18:10:23 -03:00
Leo Balter bcb6c33387 Regenerate tests 2019-08-14 19:14:44 -04:00
Leo Balter 209845c7b5 Generate tests 2019-08-14 18:54:04 -04:00
Caio Lima 2401cc678b Fixing flags in some tests 2019-08-14 19:21:00 -03:00
Leo Balter ae4df81f6f Generate tests 2019-08-14 17:52:41 -04:00
Caio Lima 55a9ad0705 Added generated tests 2019-08-14 18:23:16 -03:00
Leo Balter c09563280d Generate tests 2019-08-14 17:02:04 -04:00
Leo Balter 4d06dbc7eb Generate tests 2019-08-14 16:48:44 -04:00
Caio Lima 65fd8d30a3 Adding tests to verify if '.name' of static members are configured properly (#2293) 2019-08-14 13:33:41 -04:00
Caio Lima c9a5cc34c8 Adding cases of access private static fields/methods through direct eval (#2289) 2019-08-14 13:30:44 -04:00
Joyee Cheung 2312e123b8 accessing private fields in TDZ should throw a ReferenceError (#2284) 2019-08-14 12:45:29 -04:00
Caio Lima 51b3953d61 Added cases to cover public static field initializer operations with 'this' biding. (#2283)
* Added cases to cover public static field initializer operations with 'this' biding.

* Added initializer that throws.

* Adding missing ';'

* Fixing broken test static-field-initializer-error.js. 'function' keyword
was missing.
2019-08-13 00:21:27 -04:00
Leo Balter 134652ea3c
Merge pull request #2282 from caiolima/static-fields-usage
Tests to cover simple declaration of static fields.
2019-08-13 00:16:40 -04:00
Caio Lima aced1f265f Tests to cover simple declaration of static fields. 2019-08-12 15:01:17 -03:00
Leo Balter 4d31d84531
Fix typo in file names (#2281)
Ref #2241
2019-08-12 09:44:49 -04:00
Leo Balter 84cff5090e
Merge pull request #2267 from mkubilayk/static-private-method-inner
Add tests for static private method access inside nested functions
2019-08-05 16:47:44 -04:00
Leo Balter c4dd26bcee Generate tests 2019-08-05 10:56:24 -04:00
Leo Balter ca9a3fde50 Generate tests 2019-08-05 10:56:24 -04:00
Leo Balter 8893f7a684 Generate tests 2019-08-05 10:55:32 -04:00
Leo Balter ddfe24afe3 Regenerate tests 2019-08-05 10:54:37 -04:00
Kubilay Kahveci 805e78d239 Generate tests 2019-08-02 11:25:10 +01:00
Caio Lima aeff2b0048 Adding case where PrivateName is used inside computed property. (#2241)
* Adding case where PrivateName is used inside computed property.

* Adding proper description to early errors on usage of undeclared private names inside computed property.
2019-07-30 14:53:56 -04:00
André Bargull 64b6b844eb Remove invalid template file
The template file violated the conventions from "src/class-elements/conventions.md".

Specifically there must be a global `C` variable, but default exports don't
create a global variable binding. There is no easy way to refer to the current
module and by that retrieve the default export, therefore the template was
removed.
2019-07-22 02:12:23 -07:00
Leo Balter b3b0e8e190
Merge pull request #2235 from mkubilayk/static-subclass-receiver
Check static private methods on super class are called with correct receiver
2019-07-19 14:01:51 -04:00
Leo Balter 5549fd0022
Merge pull request #2197 from jbhoosreddy/class-decl-module
Add more class declaration formations
2019-07-16 19:30:17 -04:00
Leo Balter 7c1775ae24
Merge pull request #2223 from gibson042/2019-07-rest-param-strict-body
Add tests for rest parameter with "use strict" (expecting syntax error)
2019-07-16 19:23:51 -04:00
Caio Lima b3aea7e831 Adding tests to verify cases on PrivateFieldSet and PrivateFieldGet where we should throw TypeError (#2229) 2019-07-16 19:22:02 -04:00
Kubilay Kahveci 90d59c52f8 Generate tests 2019-07-12 13:33:18 +01:00
jbhoosreddy ff05d31b6b generated tests 2019-07-10 20:38:33 -04:00
Richard Gibson c59db6e8bd Generate tests
SRC_DIR=src/function-forms ./make.py
2019-07-10 20:20:16 -04:00
Caio Lima ea359a1d81 Added tests to cover access of private members on inner regular functions and arrow functions. (#2228) 2019-07-10 16:58:19 -04:00
Nicolò Ribaudo 77f6cfb2aa Add missing features to class fields tests (#2220) 2019-07-03 17:22:14 -04:00
Caio Lima b1b4177796 Adding cases where private names are used on direct eval calls (#2213)
* Adding cases where private names are used on direct eval calls

* Removing return statement from setter case
2019-06-26 15:08:44 -04:00
Leo Balter 1fb2b78a8d
Merge pull request #2188 from caiolima/private-methods-own-property
Verify that private methods and accessors aren't visible to [[GetOwnProperty]] and [[HasProperty]].
2019-06-26 15:07:47 -04:00
Jaideep Bhoosreddy 51fc533565 Add test for multiple evaluations of classes with private (#2176) 2019-06-26 15:05:10 -04:00
Caio Lima 166d5ac589 Adding tests to validate HomeObject setup on private methods and accessors (#2214) 2019-06-26 12:03:36 -04:00
Caio Lima bf859771f0 Adding case with computed property and simplifying 'own-property.case' 2019-06-21 12:29:54 -03:00
Caio Lima f1ac274f9d Adding test cases to verify that private methods and accessors are not visible to [[GetOwnProperty]] and [[HasProperty]]. 2019-06-21 09:50:12 -03:00
Alexey Shvayka df1a1c75b7 Remove trailing spaces from YAML blocks (#2201) 2019-06-19 16:39:21 -04:00
Alexey Shvayka 084e45966f Add poisoned __proto__ tests (#2203)
* Add SuperProperty test

* Add SuperCall test

* Add ClassDeclaration test

* Add ClassExpression test
2019-06-19 16:38:30 -04:00
Caio Lima c0c0417f04 Adding new test cases to validate public class fields initialization. (#2186) 2019-05-30 11:21:26 -04:00
Leo Balter 77b0e84452 Regenerate tests 2019-05-29 15:59:27 -04:00
Aleksey Shvayka 465d0b587e Add for-of tests with bogus initializers (#2182) 2019-05-29 15:37:52 -04:00
Leo Balter dce80ecde1
Merge pull request #2178 from mkubilayk/private-before-super-return
Check private methods are not installed before super returns
2019-05-29 13:22:11 -04:00
Leo Balter 35dc11f569
Merge pull request #2171 from leobalter/call-innerb
Add assertion for private method shadowed by getter case
2019-05-29 10:54:30 -04:00
Kubilay Kahveci 240cc6992e Generate tests 2019-05-29 11:00:19 +01:00
Leo Balter c2ceb7345a Regenerate tests 2019-05-22 17:05:42 -04:00
Leo Balter a038f7b219 Fix yaml trailing line 2019-05-22 14:00:32 -04:00
Caio Lima 696d87274b Added case to with Function.prototype.call 2019-05-22 13:53:58 -04:00
Caio Lima 4114b3749f Adding tests to cover private methods comparison 2019-05-22 13:53:58 -04:00
Leo Balter 3c64d3eac4 Generate tests 2019-05-22 13:49:46 -04:00
Caio Lima 72945e0412 Adding test cases to cover usage of private methods and accessors on inner classes. (#2150) 2019-05-22 12:58:09 -04:00
Caio Lima 2682ab57cf Adding private brand check cases for private methods, getters and setters. (#2152) 2019-05-08 16:26:13 -04:00
Caio Lima 7ab73f5fb7 Fixing typo on 2019-05-08 15:21:26 -03:00
Caio Lima 4cd26da388 Adding more cases that can be present on ClassHeritage grammar rule 2019-05-08 15:12:24 -03:00
Caio Lima 4c62f6dd73 Adding case to verify if PrivateEnvironment is properly set when evaluating 'ClassHeritage' 2019-05-08 15:12:24 -03:00
Jason Orendorff 1988988a10 Add a couple more tests for ASI with fields. (#2128) 2019-04-17 10:55:01 -04:00
Leo Balter 93f2bae981
Merge pull request #2118 from jugglinmike/refactor-for-parsers-with
Refactor `with` statement tests for parsers
2019-04-02 14:08:18 -04:00
Mike Pennisi 9b396d0b0b Refactor `with` statement tests for parsers
The tests for the parsing of the `with` statement were expressed using
eval. This made the tests more complex than necessary and also prevented
the tests from providing value to ECMAScript parsers.

Remove the use of eval and instead express the expectations with literal
source text. Rename the files to make each test's purpose more clear.
2019-03-31 22:22:04 -04:00
Mike Pennisi 255338141b Remove redundant tests
These tests are syntactically equivalent to
`test/language/statements/with/12.10.1-7-s.js` and may therefore be
removed without degrading coverage.

While `test/language/statements/with/12.10.1-9-s.js` differs slightly in
the pattern used to enable strict mode, the relevant behavior of the
"use strict" directive prologue is expressly tested via
`test/language/directive-prologue/func-expr-inside-func-decl-parse.js`.
2019-03-31 22:21:41 -04:00
Mike Pennisi 159bcc7bad Improve test precision
Previously, some tests verified two independent concerns simultaneously:
syntactic validity and runtime completion value. The former is relevant
for ECMAScript runtimes and parsers alike, but the latter is only
observable by runtimes.

Express expectations regarding syntactic validity using literal program
code so they can be used by parsers. Maintain the original tests which
rely on eval in order to preserve coverage for statement completion
values.
2019-03-31 21:44:49 -04:00
Mike Pennisi aa4c533d28 Refactor misc. statement tests for parsers
The tests for the parsing of various statement were expressed using
eval. This made the tests more complex than necessary and also prevented
the tests from providing value to ECMAScript parsers.

Remove the use of eval and instead express the expectations with literal
source text. Rename the files to make each test's purpose more clear.
2019-03-31 21:44:49 -04:00
Caio Lima fd75ab0097 Adding tests to verify private fields on Proxy Objects (#2099) 2019-03-18 21:18:55 -04:00
Leo Balter 47bf9d1db9
Merge pull request #2100 from leobalter/2033/features-private
Add missing feature tags
2019-03-14 14:51:48 -04:00
Leo Balter 3378de1020 Regenerate tests 2019-03-13 15:46:40 -04:00
Leo Balter e227f54d01 Fix assertions previously not reached before
Fix #2049
2019-03-13 15:27:20 -04:00
André Bargull 3428a59ae8 Add test case for tc39/ecma262#1172 2019-03-11 10:34:46 -07:00
André Bargull c843ff0228 Test for abrupt completion of PromiseResolve in AsyncFromSyncIteratorContinuation
Issue: tc39/ecma262#1461
PR: tc39/ecma262#1470
2019-03-11 10:34:44 -07:00
André Bargull 252ca73626 Add test that only explicit undefined return value is awaited in async generator 2019-03-11 10:34:43 -07:00
André Bargull 1111d4996d Add test that return resumption value in async generator is awaited 2019-03-11 10:34:42 -07:00
André Bargull 9d711fdf11 Add test for "constructor" lookups and correct job order in for-await loop 2019-03-11 10:34:40 -07:00
André Bargull bb838d8d6b Add test when IteratorValue argument to AsyncGeneratorYield in yield* throws 2019-03-11 10:34:38 -07:00
Leo Balter 0fb6388682 Generate tests 2019-02-25 16:14:22 -05:00
Caio Lima b9f43c0711 Adding destructuring-binding on feature list 2019-02-14 15:14:46 -05:00
Caio Lima b8e92c2341 Added case to verify invalid syntax when using private field on object destructuring 2019-02-14 15:14:46 -05:00
Caio Lima 185e590880 Removed invalid super access tests and created properly syntax error checks 2019-02-14 15:12:48 -05:00
Caio Lima 4e3e82ee3f Fixing async tests and other NIT changes 2019-02-06 18:18:48 -02:00