tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
test262/test/harness
History
Mike Pennisi f782971ad2 Remove harness file, arrayContains.js 
The `arrayContains` function has a number of deficiencies which make it
inappropriate for Test262:

- It apparently isn't very useful: despite being available for over 7
  years, fewer than ten tests use it
- It's misleading: its documentation reads, "Verify that a subArray is
  contained within an array." In reality, it only verifies that all the
  elements of one array are present in another--order does not matter.
- It's not ergonomic for test authors: it has been misused to create
  tests that were prone to false positives [1]
- It's not ergonomic for implementers: ostensibly designed for use with
  `assert`, the failure messages produced by tests that use it do not
  necessarily have very much context

All code in the "harness" directory adds to the total amount of
project-specific information which contributors are expected to to
learn. In light of the above deficiencies, the burden of this particular
harness file is unjustified.

Remove the harness file and its associated tests. Update the tests which
depend on it to express their expectations using alternate methods, and
strengthen the tests to assert element order wherever appropriate.

[1] https://github.com/tc39/test262/pull/3289
 		2021-11-01 12:55:10 -04:00
..
assert-false.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-notsamevalue-nan.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-notsamevalue-notsame.js
…
assert-notsamevalue-objects.js
…
assert-notsamevalue-tostring.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-notsamevalue-zeros.js
…
assert-obj.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-samevalue-nan.js
…
assert-samevalue-objects.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-samevalue-same.js
…
assert-samevalue-tostring.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-samevalue-zeros.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-custom-typeerror.js Add identity tests for the assert.throws 2021-09-21 16:45:27 -04:00
assert-throws-custom.js
…
assert-throws-incorrect-ctor.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-native.js Remove explicit sta.js includes 2018-10-15 12:45:55 -04:00
assert-throws-no-arg.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-no-error.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-null-fn.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-null.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-primitive.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-throws-same-realm.js Add identity tests for the assert.throws 2021-09-21 16:45:27 -04:00
assert-throws-single-arg.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-tostring.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
assert-true.js
…
assertRelativeDateMs.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
byteConversionValues.js
…
compare-array-arguments.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-arraylike.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-different-elements.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-different-length.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-empty.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-falsy-arguments.js Gracefully handle nullish arguments in harness/compareArray 2020-08-31 15:17:24 -04:00
compare-array-message.js fix: ensure that symbol args as message don't break assert.compareArray 2021-10-05 15:16:53 -04:00
compare-array-same-elements-different-order.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-same-elements-same-order.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-samevalue.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-sparse.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
compare-array-symbol.js fix: corrections to assert.compareArray and assert.compareArray.format (#3226) 2021-10-01 12:52:15 -04:00
dateConstants.js
…
decimalToHexString.js
…
deepEqual-array.js Whitespace cleanups. CRLF => LF 2019-10-08 20:44:09 -04:00
deepEqual-circular.js Whitespace cleanups. CRLF => LF 2019-10-08 20:44:09 -04:00
deepEqual-deep.js Whitespace cleanups. CRLF => LF 2019-10-08 20:44:09 -04:00
deepEqual-mapset.js Whitespace cleanups. CRLF => LF 2019-10-08 20:44:09 -04:00
deepEqual-object.js Whitespace cleanups. CRLF => LF 2019-10-08 20:44:09 -04:00
deepEqual-primitives-bigint.js Split deepEqual tests requiring bigint (#2352) 2019-09-18 17:55:27 -03:00
deepEqual-primitives.js Split deepEqual tests requiring bigint (#2352) 2019-09-18 17:55:27 -03:00
detachArrayBuffer-host-detachArrayBuffer.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
detachArrayBuffer.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
fnGlobalObject.js
…
isConstructor.js Fix some generators feature flags (#1933) 2018-11-07 17:51:23 -05:00
nans.js Don't compute NaN values in functions (#1503) 2018-03-22 20:20:29 -04:00
nativeFunctionMatcher.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
promiseHelper.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifyconfigurable-configurable-object.js Correct bug in property helper (#2364) 2019-09-24 16:05:30 -04:00
propertyhelper-verifyconfigurable-configurable.js
…
propertyhelper-verifyconfigurable-not-configurable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifyenumerable-enumerable-symbol.js
…
propertyhelper-verifyenumerable-enumerable.js
…
propertyhelper-verifyenumerable-not-enumerable-symbol.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifyenumerable-not-enumerable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifynotconfigurable-configurable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifynotconfigurable-not-configurable.js Consolidate harness tests (#2374) 2019-09-27 16:24:02 -04:00
propertyhelper-verifynotenumerable-enumerable-symbol.js Remove explicit sta.js includes 2018-10-15 12:45:55 -04:00
propertyhelper-verifynotenumerable-enumerable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifynotenumerable-not-enumerable-symbol.js Frontmatter: fixup "description: |" to "description: >" 2018-01-05 12:29:17 -05:00
propertyhelper-verifynotenumerable-not-enumerable.js Frontmatter: fixup "description: |" to "description: >" 2018-01-05 12:29:17 -05:00
propertyhelper-verifynotwritable-not-writable-strict.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifynotwritable-writable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifywritable-array-length.js Fix isWritable throwing RangeError on Array "length" 2020-03-23 14:49:12 -04:00
propertyhelper-verifywritable-not-writable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
propertyhelper-verifywritable-writable.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
proxytrapshelper-default.js
…
proxytrapshelper-overrides.js
…
sta.js chore: migrate $ERROR -> throw new Test262Error in harness/ & test/harness 2021-07-21 15:15:55 -04:00
tcoHelper.js
…
testTypedArray-conversions-call-error.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
testTypedArray-conversions.js
…
testTypedArray.js Remove redundancy from test for testTypedArray.js 2021-10-29 15:20:45 -04:00
timer.js
…
verifyProperty-arguments.js Remove explicit sta.js includes 2018-10-15 12:45:55 -04:00
verifyProperty-configurable-object.js Correct bug in property helper (#2364) 2019-09-24 16:05:30 -04:00
verifyProperty-desc-is-not-object.js Remove explicit sta.js includes 2018-10-15 12:45:55 -04:00
verifyProperty-noproperty.js Remove explicit sta.js includes 2018-10-15 12:45:55 -04:00
verifyProperty-restore-accessor-symbol.js
…
verifyProperty-restore-accessor.js
…
verifyProperty-restore-symbol.js
…
verifyProperty-restore.js
…
verifyProperty-same-value.js Use SameValue in verifyProperty helper (#2185) 2019-06-12 14:14:14 -04:00
verifyProperty-string-prop.js
…
verifyProperty-symbol-prop.js
…
verifyProperty-undefined-desc.js Remove explicit sta.js includes 2018-10-15 12:45:55 -04:00
verifyProperty-value-error.js Migrate test/harness/* away from dependence on $ERROR(). Close gh-742 2020-09-16 17:37:16 -04:00
verifyProperty-value.js
…