Commit Graph

1690 Commits

Author SHA1 Message Date
pkandel 1a2f870c9b Second set of changes based on a review of the code comments in the Include directory for typos, grammar issues, and language clarity.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8467 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 16:16:15 +00:00
xli24 287f4f47b4 Add ASSERT check for AsmFlushCacheRange().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8465 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 14:29:12 +00:00
eric_tian 63fffe4e72 fix the issue when passing a L"" string to PrintXY.
1. According to the value of RowInfoArraySize to get the actual number of printed line.
2. If RowInfoArraySize equates 0, then it means nothing is printed.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8464 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 13:50:14 +00:00
vanjeff c8c44377af update comments per review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8463 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 09:22:50 +00:00
pkandel 630b41877e Reviewed the code comments in the Include/Protocol directory for typos, grammar issues, and language clarity.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8462 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 05:49:29 +00:00
qhuang8 2561f56540 1. Fix the bug that we should use rip relative addressing for x64 label to prevent GNU assembly generate incorrect code.
2. Sync the bug fix of MS assembly in r8455.
3. Correct the function prototype in comments.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8456 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-03 08:15:18 +00:00
qhuang8 1a76fbef84 Save label "@F" to 64-bit register (r10) instead of 32-bit register (eax) in case label @F is above 4G.
Use "far retq" to load CS and 64-bit rip instead.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8455 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-03 08:11:34 +00:00
eric_tian 134c1f33ed modify the implementation of GetInterface and GetConfiguration to force the high byte of output type parameters zero.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8447 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-03 01:57:56 +00:00
qhuang8 d48e8b0afa Use rip relative addressing for x64 label for Thunk16.S to prevent GCC assembly from generating 32-bit value with HIGHLOW fixup.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8444 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-02 23:40:06 +00:00
mdkinney 071a9a1f65 Correct parameter names for ASSERT() checks.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8414 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-31 17:19:40 +00:00
mdkinney 2075236eef This checkin addresses the compatibility issue of passing arguments of type VA_LIST between components. The type VA_LIST is mapped onto the compiler specific implementation of varargs. As a result, modules build with different compilers may not use the same VA_LIST structure. The solution to this issue is to define a new type called BASE_LIST that is a compiler independent method of passing varargs between modules.
Add BASE_LIST type to Base.h
Add BAS_ARG() macro to Base.h
Add 4 functions to PrintLib.h that use BASE_LIST.
Change ReportStatsuCodeExtractDebugInfo() from ReportStatusCodeLib.h to take a BASE_LIST argument instead of a VA_LIST argument
Add the 4 new functions to BasePrintLib implementation that use BASE_LIST
Update BaseReportStatusCodeLib implementation of ReportStatsuCodeExtractDebugInfo() to use a BASE_LIST argument instead of a VA_LIST argument



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8404 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-30 23:45:50 +00:00
qhuang8 a81c3daf0a Correct one minor instruction to clear the lower 4 bits of r11.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8391 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-26 12:04:46 +00:00
qhuang8 a148780114 Fix the bug in x64 thunk code that it cannot handle the case when GDT is loaded in above 4G table memory.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8390 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-26 11:41:12 +00:00
eric_tian 57ee276f16 update comments on implementation
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8389 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-26 10:04:43 +00:00
eric_tian 392b3cf8b5 sync the StrToImage flag of UGA to consistent with GOP
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8388 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-26 10:01:46 +00:00
eric_tian d9e63d93d5 update the file description of PrintXY and AsciiPrintXY. and also refine the implementation to return the number of actual printed characters.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8372 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 10:02:33 +00:00
lgao4 3e0c79b57b Fix ScsiLib build break by << operator, which is replaced by LShiftU64 of BaseLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8363 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 03:26:42 +00:00
xli24 7b2cc5499f Remove __APPLE__ usage in ProcessorBind.h files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8362 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 02:24:02 +00:00
mdkinney 1e966f6375 Remove redundant #include statements
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8357 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 22:06:20 +00:00
mdkinney be18ced7ff Remove redundant #include
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8356 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 20:20:14 +00:00
mdkinney 17f9a8d429 Update #ifndef to match the name of the include file.
Remove extra #include


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8355 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 20:07:36 +00:00
mdkinney 7a90d95a76 Remove extra #include that is not required for this include file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8351 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 18:55:01 +00:00
xli24 f4efc39f34 Define macro for .global/.globl in assembly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8348 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 10:40:29 +00:00
xli24 132f41f0a9 Replace .globl with ASM_GLOBAL
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8346 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 10:22:09 +00:00
xli24 d5172f911d 1. Remove .extern from GCC assembly.
2. Define macro for .global/.globl in GCC assembly.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8344 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 09:42:59 +00:00
rsun3 6b3ecf5cc2 Add back logic to encode LUN in CDB for compatibility with SCSI-2 spec, although LUN encoding in CDB is changed to be reserved in SCSI-3 spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8334 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-19 09:07:38 +00:00
xli24 5dc4fd7856 Fix the unaligned issue of PCI read/write buffer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8333 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-19 07:09:45 +00:00
rsun3 676e2a32f9 Fix bugs in the UEFI SCSI Library.
1. LUN number should not be encoded in CDB.
2. Left shift the PageControl field by 6 bits in ScsiModeSense10Command().

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8331 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-19 05:42:37 +00:00
xli24 99ade971a1 Add BaseLib for BaseCpuLib.inf.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8327 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-19 02:15:40 +00:00
lgao4 d7dfd027aa 1. Clean up MdePkg internal header files
The header files in MdePkg/Include/Ia32, X64, Ipf, Ebc, Pi, Uefi directories are the internal header files, which should not be directly included by the modules.

This patch cleans these internal header files to remove the uncessary ProcessorBind.h file.

2. Clean up MdePkg public header files to remove the uncessary internal header files.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8324 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-18 09:13:49 +00:00
eric_tian d3c0cbcecc cleanup the .S file to wrap all public symbols with ASM_PFX() macro,which is used to generate underscore prior to public symbol or not within various GCC distribution versions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8316 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-15 03:21:08 +00:00
xli24 44c0fd78ef Update CpuSleep() for IPF.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8315 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-15 02:51:38 +00:00
xli24 59ceeabe50 1. Add address check for "RegisterForRuntime" APIs of PciLib, PciCf8Lib, PciExpressLib, and PciSegmentLib.
2. Update ASSERT condition for PciCf8Lib, and PciSegmentLib class.

3. According to MDE Lib Spec, add check for reserved bit field 63..48 for PCI segment address.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8311 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-14 03:13:31 +00:00
vanjeff e1f1fb1658 fixed typo. EFI_OUT_OF_MEMORY should be EFI_OUT_OF_RESOURCES.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8299 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-12 05:39:31 +00:00
rsun3 faeb3214d4 Fix the implementation of AsciiStrStr() and StrStr() in MdePkg. If the length of SearchString is zero, then String is returned.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8297 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-12 03:33:34 +00:00
qhuang8 5630456909 Minor update the function interface for three re-allocate pool APIs to check the conformance of OldBuffer only when the memory allocation succeeds. In this way the assert condition is covered by CopyMem () API in BaseMemoryLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8296 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-12 02:29:22 +00:00
qhuang8 446b94b0a1 Add conformance check for OldBuffer and size even if the memory allocation fails.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8294 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-11 08:23:26 +00:00
qhuang8 f158ee678c Fix minor coding style issue for ScsiReadCapacity16Command() API in UefiScsiLib
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8291 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-11 07:22:49 +00:00
eric_tian e74738b1c3 In PrintXY() and AsciiPrintXY(), the number of chartacter returned is at most PcdUefiLibMaxPrintBufferSize, and will return the number of characters actually displayed on the screen not includng partial characters that may be clipped by the right edge of the display.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8289 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-11 06:58:28 +00:00
eric_tian 8d579453d3 add the extra comments into BasePeCoffRelocateImage, BasePeCoffLoadImage and BasePeCoffRelocateImageForRuntime to help user to know the usage model of these APIs.
The comments mainly used to clarify it's caller's responsibility to to perform cache maintenance operations

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8283 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-11 01:32:17 +00:00
mdkinney 6ed623e403 Update GCC version of VAR_ARG () to be compatible with non GCC version of VAR_ARG () so it handles TYPE parameters that are smaller than UINTN properly when GCC builtins are used for vararg parsing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8282 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-10 19:44:21 +00:00
mdkinney c85cea8046 Clarify BuildCvHob() API in HobLib to state that this function will ASSERT() if the platform does not support Capsule Volume HOBs. This allows PI implementations to ASSERT() and Framework implementations to provide a full implementation of this API.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8278 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-09 01:47:49 +00:00
mdkinney 5e11e7c691 Update function header description of ScsiReadCapacity16Command() in the UEFI Scsi Library
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8277 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-09 01:31:20 +00:00
mdkinney 6e10b70a62 Clarify that FreePages(), FreeAlignedPages(), and FreePool() may perform n actions if those operations are not possible. For example, the PEI Phase does not provide any services to free allocated pages or allocated pool memory.
Update comments in PeiMemoryAllocationLib and UefiMemoryAllocationLib to match updates to MemoryAllocationLib.h.

Add ASSERT() statements in PeiMemoryAllocationLib for the FreePages() and FreeAlignedPages() if Pages is 0.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8275 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-09 01:13:40 +00:00
mdkinney 727fb9b1d3 1) Clarify file and function header comments for the PE/COFF Extra Action library class
2) Update the file and function header comments in the BasePeCoffExtraActionLibNull
3) Add ASSERT() statements to APIs in BasePeCoffExtraActionLibNull is ImageContext is NULL.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8272 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-09 00:45:25 +00:00
mdkinney b9c8d8bd15 Clarify clipping behavior of PrintXY() and AsciiPrintXY().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8271 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-08 23:48:32 +00:00
mdkinney 6babbe1f8c Clarify ASSERT() conditions for Reallocate Pool functions.
Fix bug in Reallocate Pool functions in PEI Memory Allocation Lib.  The wrong memory type was being allocated.  This syncs the PEI Memory Allocation Lib with the fix that was previously made to the UEFI Memory Allocation Lib.



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8269 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-08 22:09:40 +00:00
mdkinney 0dcec41170 Clean up comment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8268 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-08 22:07:42 +00:00
rsun3 62e71e2fbe Fix bugs in StrStr() and AsciiStrStr().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8261 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-08 05:22:17 +00:00
eric_tian 130a2eecc4 The GCC compiler’s behavior is different than the Microsoft compilers for statically linked vararg functions. The GCC compilers do provide __builtin_ functions for accessing varargs. we should use these intrinsic functions with GCC
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8260 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-08 02:27:46 +00:00