jljusten
7538d53684
MdeModulePkg: Remove variables that are set, but not used
...
GCC 4.6 generates a warning when a variable is set,
but never used.
Signed-off-by: jljusten
Reviewed-by: lgao4
Reviewed-by: erictian
Reviewed-by: rsun3
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12617 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-31 15:58:05 +00:00
niruiyu
608817ad71
Change the SimpleTextInEx implementation to return CTRL+C when CTRL and C are both pressed; SimpleTextIn implementation still returns CTRL+3.
...
Signed-off-by: niruiyu
Reviewed-by: qianouyang
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12563 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-25 06:11:54 +00:00
qianouyang
3765794ca3
1. Add Partial Keystroke Support in UsbKb drivers. See the Uefi2.3.1a chapter 11.2
...
Signed-off-by: qianouyang
Reviewed-by: niruiyu vanjeff
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12494 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-30 07:28:16 +00:00
erictian
19bc852765
remove unnecessary retry logic from usb mass storage driver.
...
Signed-off-by: erictian
Reviewed-by: li-elvin
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12476 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-29 09:14:30 +00:00
vanjeff
d12c6a78aa
error handling enhancement for possible null pointer dereference
...
Signed-off-by: erictian
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12437 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-23 07:44:49 +00:00
vanjeff
2256f1f757
Roll back r12434.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12436 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-23 06:45:16 +00:00
erictian
6ac6017fe8
error handling enhancement for possible null pointer dereference
...
Signed-off-by: erictian
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12434 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-23 05:17:31 +00:00
erictian
125887e7e8
Coding style refinement.
...
Signed-off-by: erictian
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12396 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-21 03:35:54 +00:00
lgao4
c8ad2d7a29
Clean up the private GUID definition in module Level.
...
0. Remove the unused private GUID from module source files.
1. Use gEfiCallerIdGuid replace of the private module GUID.
2. Add the public header files to define HII FormSet and PackageList GUID used in every HII driver.
3. Move two EBC protocols for debug purpose from EBC driver to MdeModulePkg Include directory.
Signed-off-by: lgao4
Reviewed-by: ydong10 gdong1 tye jfan12 wli12 rsun3 jyao1
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12373 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-18 12:21:01 +00:00
erictian
a9292c1363
1) remove wrong global variable usage because it will bring data corrupt if there are multiple XHCI host controllers.
...
2) coding style clean up.
Signed-off-by: erictian
Reviewed-by: ydong10
Reviewed-by: jshi19
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12351 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-14 12:13:03 +00:00
oliviermartin
76e7eeea17
MdeModulePkg/UsbBusDxe: Removed unused variable
...
'SnString' is set but not used.
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12340 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-13 15:21:32 +00:00
erictian
ce9b590040
Fixed build error reported by ICC and GCC
...
Signed-off-by: erictian
Reviewed-by: li-elvin
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12209 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-25 10:19:11 +00:00
erictian
c4b8c2d807
Error handling refinement at UsbIoResetPort() to avoid device state machine getting corrupted when the device disconnect happens
...
Signed-off-by: erictian
Reviewed-by: niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12204 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-25 05:13:22 +00:00
erictian
92870c983c
Enabling usb3.0 XHCI support.
...
Signed-off-by: erictian
Reviewed-by: jshi19
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12185 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-23 14:36:33 +00:00
niruiyu
284ee2e829
Fix the comments to follow UEFI Spec regarding how to check an EFI_HANDLE is valid/invalid.
...
Signed-off-by: niruiyu
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11987 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-06 03:55:36 +00:00
jljusten
4b1bf81c20
MdeModulePkg: Add PEI USB drivers and related PPIs
...
Signed-off-by: jljusten
Reviewed-by: mdkinney
Reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11901 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 23:30:55 +00:00
erictian
08cd970203
fix file name lowercase/uppercase inconsistent issue.
...
Signed-off-by:erictian
Reviewed-by:niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11823 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-14 03:44:16 +00:00
erictian
f742e3c20b
fix file name lowercase/uppercase inconsistent issue.
...
Signed-off-by:erictian
Reviewed-by:niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11822 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-14 03:42:28 +00:00
erictian
7d3df54a6b
fix file name lowercase/uppercase inconsistent issue.
...
Signed-off-by:erictian
Reviewed-by:niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11821 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-14 03:39:23 +00:00
erictian
39840c50c1
Produce DiskInfo for usb mass storage device
...
Signed-off-by:erictian
Reviewed-by:niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11817 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-13 05:27:23 +00:00
andrewfish
63e78d5254
Fix X64 clang warnings.
...
Reviewed by: Rui Sun
Approved by: Rui Sun
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11753 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-04 22:27:37 +00:00
vanjeff
26fab514ee
Fix the issue when checking the value of KeyDescriptor->Modifier to see if it was out of bounds.
...
Signed-off-by: vanjeff
Reviewed-by: rsun3
Reviewed-by: erictian
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11723 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-02 06:51:59 +00:00
li-elvin
3d0a23854e
Add more status code in drivers.
...
Signed-off-by: li-elvin
Reviewed-by: jyao1
Reviewed-by: lgao4
Reviewed-by: erictian
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11706 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-26 06:29:30 +00:00
vanjeff
4ff492c312
Update USB keyboard driver to return scan code for Pause key.
...
Signed-off-by: vanjeff
Reviewed-by: erictian
Reviewed-by: niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11656 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-16 01:51:53 +00:00
niruiyu
fcf5e49dc9
Change BlockIo drivers to return EFI_NO_MEDIA or EFI_MEDIA_CHANGED even the Buffer/BufferSize/Lba is invalid so that caller can probe the media status easier.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11584 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-25 09:31:57 +00:00
niruiyu
c1fd2767c1
Fix the USB keyboard driver to call hotkey callback even no one is calling ReadKeyStroke
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11563 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-19 06:52:20 +00:00
xdu2
84909ad446
1. update MatchUsbWwid() to check Vendor Id, Product Id and Interface Number.
...
2. update SerialNumber comparing logic to handle possible NULL-terminator in WWID device path
3. fix bug in UsbIo->UsbIoGetSupportedLanguages(): TableSize is size in bytes of LangIDTable instead of number of LangID.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11197 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-24 05:32:34 +00:00
erictian
c6e797aeda
return EFI_DEVICE_ERROR if the Status value is not EFI_SUCCESS.
...
it's because BlockIo.Reset() only has two possible values: EFI_SUCCESS and EFI_DEVICE_ERROR according to UEFI2.3 spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10956 6f19259b-4bc3-4df7-8a09-765794883524
2010-10-19 02:55:16 +00:00
erictian
8304070106
set the interface of usb hid device to boot protocol if it's not in such case.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10953 6f19259b-4bc3-4df7-8a09-765794883524
2010-10-18 07:54:33 +00:00
ydong10
cd7bfc2c63
Refine code to make code run safely.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10880 6f19259b-4bc3-4df7-8a09-765794883524
2010-09-16 04:51:25 +00:00
ydong10
c9325700d0
Refine soma code to make code run safely.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10877 6f19259b-4bc3-4df7-8a09-765794883524
2010-09-15 07:48:11 +00:00
erictian
15cc67e616
raise TPL to TPL_CALLBACK level at DriverBindingStart() for all usb-related modules, which prevent DriverBindingStop() from being invoked when DriverBindingStart() runs.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10460 6f19259b-4bc3-4df7-8a09-765794883524
2010-05-05 05:21:38 +00:00
hhtian
cd5ebaa06d
Update the copyright notice format
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10420 6f19259b-4bc3-4df7-8a09-765794883524
2010-04-24 09:49:11 +00:00
erictian
d4a622c488
Use SimpleTextInEx.Reset to initialize correctly KeyToggleStatue and KeyShiftState value.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10382 6f19259b-4bc3-4df7-8a09-765794883524
2010-04-19 05:34:25 +00:00
lgao4
6bfbb5f0e0
1. Correct File header to ## @file
...
2. Remove unnecessary .common] postfix on section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10052 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-24 00:21:16 +00:00
erictian
ea02100237
1. free those inserted NsKeyNode resource when releasing SetKeyBoardLayout event.
...
2. cleanup HiiDataBaseDxe to directly use gEfiHiiKeyBoardLayoutGuid which is used as the guid of event group.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9978 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-11 02:47:10 +00:00
rsun3
4140a6635b
Coding style fix and minor improvements.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9977 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-11 02:33:16 +00:00
xli24
f9876ecf8a
Remove reference to PCDs of status code value. Use macros introduced in PI1.2 instead.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9833 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-27 04:00:58 +00:00
rsun3
1ccdbf2a3e
Improve coding style in MdeModulePkg.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9793 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-19 06:42:21 +00:00
rsun3
c11fa40c4e
Fix the issue in MdeModulePkg that mismatch between PCD type and the PCD Lib API to get the PCD.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9751 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-14 09:46:12 +00:00
eric_tian
efe9186f09
add error handling on usb related modules.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9566 6f19259b-4bc3-4df7-8a09-765794883524
2009-12-16 00:58:46 +00:00
jljusten
d7576cf9b6
MdeModulePkg-UsbBusDxe: Add work around for slower USB hubs/devices
...
Increase the value of USB_GENERAL_DEVICE_REQUEST_TIMEOUT from
50 milliseconds to 100 milliseconds. This provides a work around
for slower USB hubs and devices.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9330 6f19259b-4bc3-4df7-8a09-765794883524
2009-10-05 17:59:53 +00:00
vanjeff
af4a63857c
updated the Bus Driver that is able to create all or one of its child handles on each call to Start() not to create new child handle if RemainingDeviepath is the End of Device Path Node, per UEFI 2.3.
...
The others changes include:
1. Check RemainingDevicePath at beginning of Supported(), make sure it has been verified before Start() is called.
2. Check IO protocol firstly rather than EfiDevicePathProtocolGuid, reduce the times entering into Start() function because EfiDevicePathProtocolGuid existed on most of handle.
3. If no any child device is created on last time, and RemainingDevicePath is valid Uart Devcie path, go on creating child device handle based on this RemainingDevicePath.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9262 6f19259b-4bc3-4df7-8a09-765794883524
2009-09-14 08:55:03 +00:00
eric_tian
3af875e220
In various archs, Processor memory address may not be same with Pci memory address. For usb host controller, we should use pci memory address to initialize framelist register and all address field in QH/TD.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9259 6f19259b-4bc3-4df7-8a09-765794883524
2009-09-14 05:26:09 +00:00
eric_tian
16a97771ad
free allocated memory in error handler.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9173 6f19259b-4bc3-4df7-8a09-765794883524
2009-08-24 06:24:24 +00:00
eric_tian
73f8ef8c08
add error handler in return places.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9119 6f19259b-4bc3-4df7-8a09-765794883524
2009-08-19 02:32:56 +00:00
eric_tian
9420fc148a
modify the incorrect timeout value definitions in Usb driver
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9117 6f19259b-4bc3-4df7-8a09-765794883524
2009-08-19 01:41:43 +00:00
rsun3
88e349f1fe
Fixed a bug that the system hangs with an assert in DiskIo.c that is division overflow due to block size == 0 when no flppy media is present in a specific type of USB floppy drive (NEC PC-VP-BU04)at power on.
...
Root cause is that Read Capacity command returns media not present error, then UsbMassStorage driver issues Sense Request command to get the sense data. However, the USB floppy drive still returns the previous error for the Sense Request command. UsbBootRequestSense() does not handle this case correctly and returns EFI_SUCCESS so that the block size of the Block IO protocol instance is set to be 0.
Solution is to fix the logic to handle the case and add protective logic to avoid setting block size to be 0.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8979 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-23 01:30:16 +00:00
gikidy
4607d9e5e1
The USB keyboard driver use too high TPL event (Notify) to a ckeck repeated key stoke, should use CallBack instead.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8527 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-11 06:25:30 +00:00
mdkinney
776a705ef1
Update USB Mass Storage driver to declare its dependency on the BaseLib
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8353 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 20:04:23 +00:00