tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
audk/MdeModulePkg/Library
History
Laszlo Ersek 0bee7dbd2b MdeModulePkg/PlatformVarCleanupLib: fix HiiConstructConfigHdr() call 
The HiiConstructConfigHdr() function takes the "DriverHandle" parameter in
order to fetch the device path from it, and then turn the device path into
PATH routing information.

The HiiConstructConfigHdr() function is called from
VariableCleanupHiiExtractConfig(), which is only installed when "Type" is
"VarCleanupManually" in PlatformVarCleanup().

In that case, we create "Private->DriverHandle" as a new handle, and
install "mVarCleanupHiiVendorDevicePath" on it. Then we pass
"Private->DriverHandle" to HiiAddPackages(), which consumes the device
path for routing purposes.

It follows that the "DriverHandle" argument passed to
HiiConstructConfigHdr() should be the same driver handle, for matching
routing.

Currently we pass "Private->HiiHandle", which is clearly a typo, because
it is the return value of HiiAddPackages(), and stands for the published
HII package list.

Therefore this patch addresses an actual bug.

The typo has not been flagged by compilers because the UEFI spec
regrettably defines both EFI_HANDLE and EFI_HII_HANDLE as (VOID*).

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
 		2019-10-09 09:40:09 +02:00
..
AuthVariableLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BaseBmpSupportLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BaseHobLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BaseIpmiLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BaseMemoryAllocationLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BasePlatformHookLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BaseResetSystemLibNull MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem 2019-04-28 09:40:14 +08:00
BaseSerialPortLib16550 MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support 2019-04-29 15:50:16 +08:00
BaseSortLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BootLogoLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BootMaintenanceManagerUiLib MdeModulePkg/BM_UI: Add the new terminal types to related menu 2019-09-24 21:56:46 +08:00
BootManagerUiLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
BrotliCustomDecompressLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
CpuExceptionHandlerLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
CustomizedDisplayLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DebugAgentLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DeviceManagerUiLib MdeModulePkg: strip trailing whitespace 2019-10-04 11:18:32 +01:00
DisplayUpdateProgressLibGraphics MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DisplayUpdateProgressLibText MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeCapsuleLibFmp MdeModulePkg/DxeCapsuleLibFmp: Unload image on EFI_SECURITY_VIOLATION 2019-09-25 10:03:57 +08:00
DxeCapsuleLibNull MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib. 2019-06-26 15:10:42 +08:00
DxeCoreMemoryAllocationLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeCorePerformanceLib MdeModulePkg: fix cast in GetModuleInfoFromHandle() calls 2019-10-09 09:40:09 +02:00
DxeCrc32GuidedSectionExtractLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeDebugPrintErrorLevelLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeFileExplorerProtocol MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeIpmiLibIpmiProtocol MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxePerformanceLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxePrintLibPrint2Protocol MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeReportStatusCodeLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
DxeResetSystemLib MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem 2019-04-28 09:40:13 +08:00
DxeSecurityManagementLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
FileExplorerLib MdeModulePkg/FileExplorer: Set Handle to NULL after uninstall protocol 2019-04-28 09:32:42 +08:00
FmpAuthenticationLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
FrameBufferBltLib MdeModulePkg: Add missing sourceX for Blt 2019-09-25 11:54:53 +08:00
LockBoxNullLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
LzmaCustomDecompressLib MdeModulePkg: strip trailing whitespace 2019-10-04 11:18:32 +01:00
NonDiscoverableDeviceRegistrationLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
OemHookStatusCodeLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PciHostBridgeLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiCrc32GuidedSectionExtractLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiDebugLibDebugPpi MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiDebugPrintHobLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiDxeDebugLibReportStatusCode MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiIpmiLibIpmiPpi MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiPerformanceLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiReportStatusCodeLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PeiResetSystemLib MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem 2019-04-28 09:40:15 +08:00
PiDxeS3BootScriptLib MdeModulePkg: Enable/Disable S3BootScript dynamically. 2019-10-01 08:14:45 +08:00
PiSmmCoreMemoryAllocationLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PiSmmCoreSmmServicesTableLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PlatformBootManagerLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PlatformHookLibSerialPortPpi MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
PlatformVarCleanupLib MdeModulePkg/PlatformVarCleanupLib: fix HiiConstructConfigHdr() call 2019-10-09 09:40:09 +02:00
ResetUtilityLib MdeModulePkg/ResetUtilityLib: Use STATIC_ASSERT macro 2019-09-17 09:38:59 +08:00
RuntimeDxeReportStatusCodeLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
RuntimeResetSystemLib MdeModulePkg/RuntimeResetSystemLib.c: Change comments 2019-04-28 09:40:14 +08:00
SmmCorePerformanceLib MdeModulePkg: fix cast in GetModuleInfoFromHandle() calls 2019-10-09 09:40:09 +02:00
SmmCorePlatformHookLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
SmmIpmiLibSmmIpmiProtocol MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
SmmLockBoxLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
SmmMemoryAllocationProfileLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
SmmPerformanceLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
SmmReportStatusCodeLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
SmmSmiHandlerProfileLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
TpmMeasurementLibNull MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
UefiBootManagerLib MdeModulePkg/UefiBootManager: Unload image on EFI_SECURITY_VIOLATION 2019-09-25 10:03:57 +08:00
UefiHiiLib MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE in place of EFI_HII_HANDLE 2019-10-09 09:40:09 +02:00
UefiHiiServicesLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
UefiMemoryAllocationProfileLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
UefiSortLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
VarCheckHiiLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
VarCheckLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
VarCheckPcdLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00
VarCheckUefiLib MdeModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:08 -07:00