1715 Commits

Author SHA1 Message Date
Djordje Lukic
744aebc3fd
"Already exists" also means the pull finished
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-17 11:31:14 +01:00
Djordje Lukic
b0ee6d285a
Update docker/docker to be able to run this on a Mac, use goroutines when starting a stack
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-17 11:31:13 +01:00
Nicolas De Loof
9fdf69ea9c
Handle container (re)create/(re)start on compose up
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:29:12 +01:00
Nicolas De Loof
0d33e5cdcc
report docker resources creation in progress
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:50 +01:00
Nicolas De Loof
7944a1b94f
implement image pull on compose up with progress
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:49 +01:00
Nicolas De Loof
74de423cc3
reuse ECS logConsumer to implement formatted compose log output
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:08 +01:00
Nicolas De Loof
3f52508efe
Skeletton implementation for compose commands
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:08 +01:00
Nicolas De Loof
85ec312461
convert compose model into moby API types to prepare "up" local implementation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:08 +01:00
Chris Crone
367fbf35c0
Merge pull request #916 from gtardif/fix_compose_protos
Fix proto message names for ComposeStacks() input / output ; same for ComposeServices()
2020-11-17 11:02:46 +01:00
Guillaume Tardif
35bc1d096e Fix proto message names for ComposeStacks() input / output ; same for ComposeServices()
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-17 10:04:53 +01:00
Guillaume Tardif
bc966daf34
Merge pull request #912 from docker/compose-api
Compose api
2020-11-17 09:51:13 +01:00
Guillaume Tardif
08cf86bbff Rename compose List() => Stacks to avoid name collision, and remove confusion with compose ps, also renamed Services()
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-17 09:45:05 +01:00
Guillaume Tardif
40e6655c2e
Merge pull request #893 from docker/add-view-inspect
Add container inspect view
2020-11-17 09:34:07 +01:00
Nicolas De loof
a05df9490b
Merge pull request #913 from docker/gpu_spec
Add support for gpu devices reservation
2020-11-16 17:36:04 +01:00
Nicolas De loof
564b5fb793
Merge pull request #915 from docker/aws_creds
Don't mess with exiting .aws/credentials
2020-11-16 17:34:50 +01:00
Guillaume Tardif
4a975a5b0b Adding compose ps API
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-16 16:38:39 +01:00
Guillaume Tardif
631c75051d Adding compose ls API
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-16 14:58:28 +01:00
Nicolas De Loof
cb808dec31
Don't mess with exiting .aws/credentials
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-16 14:51:05 +01:00
Nicolas De Loof
efd0f2b9ec
Add support for gpu devices reservation
Adopt https://github.com/compose-spec/compose-spec/pull/100

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-16 14:24:25 +01:00
Guillaume Tardif
b4e8c28ecf Add compose project name in gRPC response for up and down
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-16 13:42:59 +01:00
Guillaume Tardif
5906677a2c Add gRPC proxy for compose down
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-16 12:19:59 +01:00
Guillaume Tardif
5abc68ebdd Add compose service, run compose up through API
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-16 12:11:52 +01:00
Guillaume Tardif
0ae42dea04
Merge pull request #906 from gtardif/help_metrics
Collect metrics --help flag
2020-11-13 15:10:26 +01:00
Guillaume Tardif
486e7b8f87 Also log help commands (no flag)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-13 14:29:08 +01:00
Guillaume Tardif
b238232a77 Reorder --help flag always first in metrics
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-13 14:06:56 +01:00
Guillaume Tardif
c1fe338ac7 Collect metrics --help flag
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-13 13:29:28 +01:00
Guillaume Tardif
91e5d178d2 Fix ports & Host config not being initialised in inspect view, fix E2E tests
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-12 18:00:22 +01:00
Ulysses Souza
49759af15c Add container inspect view
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-11-12 17:16:54 +01:00
Nicolas De loof
aa09ecb1f8
Merge pull request #905 from docker/fix_aci_potential_nil_panic
Use ACI .IsHttpStatus() rather than accessing .StatusCode directly
2020-11-12 15:12:14 +01:00
Guillaume Tardif
0d74298eed Use ACI .IsHttpStatus() rather than accessing .StatusCode directly, that might lead to nil pointer panic
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-12 15:01:18 +01:00
Nicolas De loof
3e0fadc78b
Merge pull request #896 from docker/aci_health_e2e
Deploy e2e compose stack with health check and validate it restarts failed container
2020-11-12 12:17:48 +01:00
Nicolas De loof
919db3f619
Merge pull request #904 from docker/reservation
Use reservations if user has not set limits
2020-11-12 12:01:00 +01:00
Guillaume Tardif
110106b1b7
Merge pull request #899 from docker/aci_volume_error_message
Specific error message when specifying path as a volume source
2020-11-12 11:45:49 +01:00
Guillaume Tardif
624308134f Specific error message when specifying path as a volume source. Removed volume reference validation already done at https://github.com/compose-spec/compose-go/blob/5afecaa4cb/loader/validate.go#L38
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-12 11:38:40 +01:00
Nicolas De Loof
8438eee612
Use reservations if user has not set limits
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-12 10:57:34 +01:00
Nicolas De loof
12d7ab55d6
Merge pull request #903 from docker/ecs_mapping 2020-11-12 10:29:57 +01:00
Nicolas De Loof
5ee75c70c9
Document ECS supported compose attributes
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-12 10:24:12 +01:00
Guillaume Tardif
949f0ce62e
Merge pull request #897 from docker/volume_conflict
Don't panic on bind mount
2020-11-10 17:09:53 +01:00
Guillaume Tardif
c67e4f6e50
Merge pull request #898 from gtardif/aci_healthcheck_doc
Updated health check docs
2020-11-10 17:07:42 +01:00
Guillaume Tardif
a0bd23ade9 Apply suggestions from code review
Co-authored-by: Chris Crone <christopher.crone@docker.com>

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-10 17:07:13 +01:00
Nicolas De Loof
8e847bfd9a
Include volume name in PolicyName to disambiguate
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-10 15:47:16 +01:00
Nicolas De Loof
06fd442a53
Don't panic on bind mount
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-10 15:47:04 +01:00
Nicolas De loof
16c3223623
Merge pull request #869 from docker/s3
publish Cloudformation template on s3
2020-11-10 15:45:31 +01:00
Guillaume Tardif
ef5e78dc14 Updated health check docs
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-10 15:37:07 +01:00
Guillaume Tardif
1cc0ccb189
Merge pull request #892 from docker/fix_log_stream_end
Avoid nil pointer when reading logs of a just terminated container.
2020-11-10 14:06:51 +01:00
Guillaume Tardif
2ac61a0f7f Deploy e2e compose stack with health check and validate it restarts failed container
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-10 14:04:58 +01:00
Nicolas De Loof
71ecbda48f
Publish on s3 if payload is > API limit
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-10 11:03:00 +01:00
Nicolas De Loof
10a384d35b
Pass region to create s3 bucket into
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-10 08:40:02 +01:00
Nicolas De Loof
3f184f7552
store cloudformation template on s3 to workaround API limit
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-10 08:40:02 +01:00
Guillaume Tardif
40334d570a Avoid nil pointer when reading logs of a just terminated container.
Hit this when following logs of a container restarted with a health check: 
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x168771e]

goroutine 1 [running]:
github.com/docker/compose-cli/aci.getACIContainerLogs(0x2d85260, 0xc000526c60, 0xc0001465a0, 0x24, 0xc0004f4da0, 0xa, 0xc0004f4db0, 0x7, 0x7ffeefbffab2, 0xb, ...)
	github.com/docker/compose-cli/aci/aci.go:285 +0x1fe
github.com/docker/compose-cli/aci.streamLogs(0x2d85260, 0xc000526c60, 0xc0001465a0, 0x24, 0xc0004f4da0, 0xa, 0xc0004f4db0, 0x7, 0x7ffeefbffab2, 0xb, ...)
	github.com/docker/compose-cli/aci/aci.go:297 +0x2e5
```

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-09 18:19:31 +01:00