Commit Graph

2577 Commits

Author SHA1 Message Date
Michael Friedrich 8545c5023a DB IDO: Don't clear endpoint* tables on start/reload
fixes #9586
2015-07-13 10:26:01 +02:00
Gunnar Beutner c2da4869a6 Fix incorrect return value for the macro() function
fixes #9584
2015-07-13 08:26:17 +02:00
Markus Frosch 97f48759cd Remove selective reconnecting behavior
We want to remove the partial reconnecting behavior, so that all endpoints of
a zone try to connect to a lower or higher zone in hierarchy.

fixes #9406

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-07-10 10:32:28 +02:00
Gunnar Beutner 0a3614723f Fix stability issues with the TlsStream/Stream classes
fixes #9481
2015-07-06 15:09:04 +02:00
Michael Friedrich d3cb1ad48a Cli: Don't add empty host/port endpoint attributes in node wizard
refs #9205
refs #9536
2015-07-03 13:03:07 +02:00
Jean Flach 9d3020cd31 Fix Port wrong default port in Node Wizard
fixes #9205
2015-07-03 09:42:27 +02:00
Michael Friedrich 426495bd67 Add log message for discarded cluster events (e.g. from unauthenticated clients)
fixes #9489
2015-07-02 13:06:18 +02:00
Michael Friedrich aab6d632e8 Fix wrong preprocessor macros 2015-06-24 14:14:58 +02:00
Michael Friedrich 656286f887 Fix unused variable in dbevents
refs #9055
2015-06-24 14:14:50 +02:00
Benedikt Heine 48dec15be3 node setup: indent accept_config and accept_commands
fixes #9450

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-06-19 09:24:08 +02:00
Gunnar Beutner 57713374cc Fix incorrect validator for command arguments
fixes #9436
2015-06-18 08:14:34 +02:00
Michael Friedrich f42bf537c3 Build fix
refs #9324
2015-06-15 17:25:17 +02:00
Markus Frosch 46fea5892c Fix objects cache dump in compat for multiline vars
Multiline vars should be written as:
  _test test1\ntest2

And not
  _test test1
test2

fixes #9328

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-06-15 17:21:57 +02:00
Markus Frosch 11574e0bf1 Fix multi line handling for compat check results
When a multi line result is submitted via the command pipe, any multi line
output is escaped to a actual string '\n', because any external command only
can be a single line.

Example:
  [1432735140] PROCESS_SERVICE_CHECK_RESULT;host;service;3;Test1\nTest2|test=1

We need to unescape this values, just like we use to escape multi line output
for IDO and status.dat.

fixes #9324

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-06-15 17:21:51 +02:00
Gunnar Beutner faf0865a94 Fix unexpected exception in Utility::DirName when specifying an empty path
refs #9263
2015-06-15 14:17:41 +02:00
Michael Friedrich 9ada3dd5be Fix unregistered function failure including <nscp> on Linux
fixes #9394
2015-06-15 10:40:02 +02:00
Michael Friedrich 3e14bde4c0 Fix incorrect type and state filter mapping for User objects in DB IDO
fixes #9143
2015-05-29 10:22:27 +02:00
Michael Friedrich a149b5ae72 Fix missing custom attributes in backends if name is equal to object attribute
fixes #9222
2015-05-29 10:21:52 +02:00
Gunnar Beutner 669317f169 Implement the basename and dirname script functions
refs #9256
2015-05-13 10:18:02 +02:00
Gunnar Beutner 2f3a8be2e6 Determine NSClient++ installation path using MsiGetComponentPath
fixes #9256
2015-05-13 10:16:07 +02:00
Jean Flach 1c7d6895bd Add Windows version string to --version
fixes #8888
2015-04-28 12:48:41 +02:00
Jean-Marcel Flach f13460a2dd Update ReleaseHelper to work with most Linux distributions
refs #8888
2015-04-28 12:48:41 +02:00
Michael Friedrich bb590658ac Fix DbEvents::AddCheckableCheckHistory argument
refs #9055
2015-04-27 15:13:00 +02:00
Michael Friedrich aaba240e37 DB IDO: Fix wrong check result timestamp for historical tables
refs #9055
2015-04-27 15:12:51 +02:00
Michael Friedrich beead48302 Add timestamp support for PerfdataWriter
Change the default from $timet$ to ${host,service}.last_check$

fixes #9185
2015-04-27 15:09:05 +02:00
Michael Friedrich 4fcbfbe8ca Rewrite some of the wizard questions
refs #8891
2015-04-27 11:13:52 +02:00
Jean-Marcel Flach 460d858a8e Change node wizard flow
fixes #8891
2015-04-27 11:13:38 +02:00
Michael Friedrich 23264a291e Fix failed assertion in DB IDO
fixes #9121
2015-04-27 11:00:59 +02:00
Michael Friedrich c59a8c8277 Fix that downtimes are always "fixed" even if scheduled as "flexible"
fixes #9142
2015-04-25 15:07:58 +02:00
Gunnar Beutner 21cf767488 Fix another potential deadlock in DB IDO
refs #9121
2015-04-22 21:36:35 +02:00
Gunnar Beutner 8bf8ef263d Fix deadlock in the IDO
fixes #9121
2015-04-22 21:34:22 +02:00
Michael Friedrich b16ed097f0 CLI: Be less verbose in 'node update-config'
fixes #9116
2015-04-20 15:01:00 +02:00
Michael Friedrich 4b2e1c2662 Change log level to 'notice' for 'Attempting to send notifications' messages
fixes #9021
2015-04-20 08:56:34 +02:00
Michael Friedrich e7a84ff8ba Don't update scheduleddowntime table w/ trigger_time column when only adding a downtime
fixes #9014
2015-04-20 08:55:59 +02:00
Jean-Marcel Flach 3b6465024f Make node wizard only accept y/Y and n/N
fixes #8917
2015-04-20 08:54:39 +02:00
Jean-Marcel Flach 44a4a442a0 Add accept config/commands option to node setup
fixes #8803
2015-04-20 08:51:45 +02:00
Jean-Marcel Flach c14f660476 Fix troubleshooht command truncating crash logs
fixes #9064
2015-04-20 08:49:24 +02:00
Michael Friedrich 201c41f2ca Fix custom attributes with recursive macro function calls
fixes #9073
2015-04-17 17:23:34 +02:00
Michael Friedrich 57cc7b195a Fix acknowledgement with expire time not added as comment expire_time
GetExpireTime() is always set to 0 which will make the comment reflect
wrong information compared to the text.

fixes #9041
2015-04-17 16:46:46 +02:00
Gunnar Beutner d3fc075000 Remove deadlock in db_ido
refs #9017
2015-04-14 15:11:20 +02:00
Michael Friedrich e659784a66 Trigger downtimes for NOT-OK states after OnDowntimeAdded()
The fix in #8389 must happen *after* adding the downtime which signals an
insert into the IDO DB.
Once the downtimes have been added to the database, the additional
trigger_time and is_in_effect can be updated accordingly, *if* the
current object is already in a NOT-OK state.

fixes #9016
2015-04-12 14:41:30 +02:00
Michael Friedrich 876bccd745 DB IDO: Fix status table scheduled_downtime_depth column not updated on downtime removal/end
fixes #9017
2015-04-11 11:42:22 +02:00
Gunnar Beutner 46b0392962 Fix complexity class for Dictionary::Get
fixes #8919
2015-03-31 10:40:34 +02:00
Gunnar Beutner a552e917b3 Improve timeperiod validation error messages
fixes #8893
2015-03-31 08:49:55 +02:00
Gunnar Beutner 17c929aabf Fix permissions for agent CheckResult messages
fixes #8821
2015-03-30 13:50:40 +02:00
Gunnar Beutner f97fded243 Fix validation errors for time ranges which span the DST transition
fixes #8892
2015-03-29 08:18:01 +02:00
Gunnar Beutner 47e17bfe89 Fix arrays in command arguments
fixes #8869
2015-03-26 09:44:47 +01:00
Gunnar Beutner d5a33e9f37 Fix crash in MakeX509CSR when using ancient versions of OpenSSL
fixes #8844
2015-03-26 09:44:39 +01:00
Gunnar Beutner 7a3957cb0b Fix incorrect variable values for apply+for
fixes #8851
2015-03-23 15:58:19 +01:00
Gunnar Beutner 148a6c5bf3 Make load order for objects more reliable
fixes #8770
2015-03-23 15:58:15 +01:00
Gunnar Beutner a99773b62d Fix: 'return' keyword doesn't work inside for loops
fixes #8834
2015-03-22 00:05:18 +01:00
Gunnar Beutner 60c8c38066 Fix copyright header indentation 2015-03-21 11:02:27 +01:00
Gunnar Beutner 3d1aba3287 Fix style violations 2015-03-21 10:04:32 +01:00
Michael Friedrich 7c0749679c Fix missing config validator for command arguments 'set_if'
fixes #8724
2015-03-20 16:15:22 +01:00
Gunnar Beutner 86a1bbf468 Allow using more than one %validator rule for the same type
fixes #8829
2015-03-20 15:55:13 +01:00
Gunnar Beutner 4e680e6d58 Flush stderr in Application::Exit
fixes #8734
2015-03-20 12:28:52 +01:00
Michael Friedrich 6c8bc20369 Use Utility::NaturalJoin for notification filter formatting
refs #8685
2015-03-19 14:09:14 +01:00
Michael Friedrich 6e778c4947 Show notification state/type filter names in notice/debug log
fixes #8685
2015-03-19 14:09:07 +01:00
Gunnar Beutner ab36912ccd Improve error message for invalid field access
fixes #8769
2015-03-19 13:48:31 +01:00
Gunnar Beutner 2826ef7647 Implement the parse_performance_data function
fixes #8693
2015-03-19 13:38:24 +01:00
Gunnar Beutner 1756859125 Don't ignore extraneous arguments for functions
fixes #8748
2015-03-19 13:37:36 +01:00
Louis Sautier 113a90dd7f Remove prompt to create a TicketSalt from the wizard
fixes #8766

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-16 15:25:23 +01:00
Gunnar Beutner ea7d1ee77d Add OS details in 'icinga2 --version'
fixes #8761
2015-03-16 13:52:59 +01:00
Gunnar Beutner f70cebca0c Build fix for 2.3.x 2015-03-16 13:45:18 +01:00
Gunnar Beutner 1fcb012976 Improve Flex version detection on Windows
refs #8750
2015-03-16 13:33:01 +01:00
Gunnar Beutner 9bcbc8f4f8 Don't update custom vars for each status update
fixes #8736
2015-03-16 10:23:56 +01:00
Gunnar Beutner 6155dd2e7d Ensure that flex meets the version requirements
fixes #8750
2015-03-16 10:23:13 +01:00
Michael Friedrich 6a6662644e Fix log message for cli commands breaks the init script
fixes #8721
2015-03-12 15:57:52 +01:00
Michael Friedrich 64214bd853 Fix crash in Dependency::Stop()
This partially reverts the fix in #8436

fixes #8687
refs #8436

Conflicts:
	lib/db_ido_pgsql/idopgsqlconnection.cpp
2015-03-12 11:56:20 +01:00
Michael Friedrich e1a07ad129 Fix formatting for the GDB stacktrace
fixes #8684
2015-03-11 16:31:52 +01:00
Michael Friedrich 9db3d42135 Make sure that the /var/log/icinga2/crash directory exists
fixes #8683
2015-03-11 16:08:37 +01:00
Gunnar Beutner cef5191d44 Fix timeout problem with API heartbeat messages
fixes #8672
2015-03-11 12:56:22 +01:00
Gunnar Beutner 21522f9ed6 Fix line continuation support for parentheses
fixes #8679
2015-03-11 09:55:38 +01:00
Gunnar Beutner 8516e78b92 Kill entire process group after plugin timeout
fixes #8540
2015-03-11 07:38:07 +01:00
Gunnar Beutner 73629172b4 Fix argument type for the StringContains function
refs #8659
2015-03-11 06:44:32 +01:00
Michael Friedrich 059cda9e37 Implement String#contains
fixes #8659
2015-03-11 06:44:23 +01:00
Gunnar Beutner 4e16f48255 Don't accept config updates for zones for which we have an authoritative copy of the config
fixes #8555
2015-03-09 08:46:01 +01:00
Gunnar Beutner 3046ad5d5e Fix incorrect value for the process_performance_data column in the icinga_hosts table
fixes #8544
2015-03-09 08:12:05 +01:00
Gunnar Beutner e50d3e6e5a Fix validator for dependencies
fixes #8596
2015-03-09 08:04:18 +01:00
Gunnar Beutner 22f3c5082d Add validator for time ranges in ScheduledDowntime objects
fixes #8600
2015-03-09 08:02:12 +01:00
Gunnar Beutner 60d5959ba4 Remove incorrect VERIFY
fixes #8628
2015-03-09 06:51:22 +01:00
Gunnar Beutner 77fc213d6d Remove unnecessary dynamic_casts 2015-03-07 14:47:54 +01:00
Gunnar Beutner 52102d815d Fix second Deserialize() call in ApiEvents::ExecuteCommandAPIHandler
refs #8117
2015-03-06 01:45:43 +01:00
Gunnar Beutner 139540b570 Make sure we don't evaluate apply rules for fake hosts used in agent checks
fixes #8117
2015-03-05 21:19:04 +01:00
Gunnar Beutner 9181d7ae05 Add missing service name in check results
refs #8257
2015-03-05 20:50:27 +01:00
Gunnar Beutner bb4beefca9 Add missing "return"s in Ido*Connection::Reconnect 2015-03-05 15:57:46 +01:00
Gunnar Beutner fd9dc32a3d Implement SNI support for the TlsStream class
fixes #8610
2015-03-05 14:15:42 +01:00
Gunnar Beutner 4a2a6d999a Fix incorrect debug hints for nested attributes
fixes #8604
2015-03-05 13:18:15 +01:00
Gunnar Beutner 4b15ec7774 Remove the macro argument for IMPL_TYPE_LOOKUP
fixes #8599
2015-03-05 07:42:13 +01:00
Gunnar Beutner 767ddbdec7 Fix compiler warning in Process::Run 2015-03-04 16:41:53 +01:00
Gunnar Beutner f41f9b085d Implement support for the 'Limit' column in Livestatus
fixes #8529
2015-03-04 12:18:04 +01:00
Gunnar Beutner afd1927a98 Improve Livestatus query performance
fixes #8594
2015-03-04 10:58:22 +01:00
Gunnar Beutner c33e78aa04 Don't discard config validators 2015-03-04 09:12:57 +01:00
Gunnar Beutner 4d63351561 Fix some compile warnings 2015-03-04 08:26:15 +01:00
Gunnar Beutner 9bbe9a4875 Fix a memory leak in *Expression::GetReference
fixes #8593
2015-03-04 08:00:38 +01:00
Gunnar Beutner c9c7f9bed1 Fix lag calculation for the 'cluster-zone' check 2015-03-03 14:42:22 +01:00
Gunnar Beutner 3615716983 Include GDB backtrace in crash reports
fixes #8575
2015-03-03 13:53:11 +01:00
Gunnar Beutner c3e32911a7 Fix: else if doesn't work without an else branch
fixes #8572
2015-03-03 10:22:21 +01:00
Gunnar Beutner 1d2b008dcb Fix validator for TimePeriod ranges
fixes #8568
2015-03-03 09:56:38 +01:00
Gunnar Beutner cf37decbef Fix start condition for downtimes
fixes #8560
2015-03-03 09:52:13 +01:00