tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
12,301 Commits 347 Branches 117 Tags 197 MiB
Commit Graph

1558 Commits

Author SHA1 Message Date
Mattia Codato 8f3617d074 Fix response strings 2020-06-30 15:48:29 +02:00
Mattia Codato 5c06256ac5 Use dynamic_pointer_cast 2020-06-30 15:41:47 +02:00
Mattia Codato 94be948ff6 Unify how to take macros parameter 2020-06-30 13:51:42 +02:00
Mattia Codato e4e0115c9d Get local endpoint if FromClient is not set and origin is local 2020-06-30 13:47:13 +02:00
Mattia Codato 22dc2f2393 Use SyncSendMessage for remote endpoint and call ExecuteCommandAPIHandler for local endpoint 2020-06-30 13:43:00 +02:00
Mattia Codato 7077605880 Use the right method to get the notification command 2020-06-29 13:55:20 +02:00
Mattia Codato 3f1b51b355 Use RelayMessage instead of SyncSendMessage 2020-06-29 09:28:02 +02:00
Mattia Codato da82c17891 Call Endpoint::GetByName only once 2020-06-26 16:38:40 +02:00
Mattia Codato 50693d7ea9 Add newline at the end of file 2020-06-26 16:36:57 +02:00
Mattia Codato fd761397ac Unify result status strings 2020-06-26 15:39:42 +02:00
Mattia Codato 899076c77b Code format 2020-06-26 14:29:03 +02:00
Mattia Codato 35bb329a59 Implement ClusterEvents::UpdateExecutionsAPIHandler 2020-06-26 12:33:44 +02:00
Mattia Codato 82444a59e2 Fix resolve macros. Check if endpoint is local or remote 2020-06-26 12:32:12 +02:00
Mattia Codato 714e75bbd1 Remove wait parameter, ttl is required, remove unnecessary checks 2020-06-26 09:33:23 +02:00
Benjamin Groeber e9b6c68fd5 Use tabs instead of spaces 2020-06-23 11:44:26 +02:00
Benjamin Groeber 2bb6f9d38d Fix formatting of long fn 2020-06-23 11:41:49 +02:00
Benjamin Groeber 159e3d2945 Remove superfluous else clause 2020-06-23 11:41:15 +02:00
Andrea Avancini 823fe34d24 Parameter evaluation, macro resolution, update executions, send ExecuteCommand message for ExecuteCommand Endpoint 2020-06-18 15:27:31 +02:00
Alexander A. Klimov 11c6c11076 Add Checkable#last_check_started 
refs #7888
 2020-06-09 12:03:02 +02:00
Alexander A. Klimov 9cb3779ec2 Add stub for event::UpdateExecutions 
refs #8034
 2020-06-02 17:16:30 +02:00
Alexander A. Klimov 120440b84f Introduce Checkable#executions 
refs #8034
 2020-06-02 17:09:13 +02:00
Alexander A. Klimov d6fad3232b Introduce Checkable#pending_executions 
refs #8034
 2020-06-02 16:59:42 +02:00
Alexander A. Klimov fc220bac69 Add stub for event::ExecutedCommand 
refs #8034
 2020-06-02 13:44:15 +02:00
Alexander A. Klimov 3f07dd6cae Add stub for event::ExecuteCommand w/ source 
refs #8034
 2020-06-02 11:52:58 +02:00
Alexander A. Klimov 752df8ea28 Add stub for /v1/actions/execute-command 
refs #8034
 2020-06-02 11:43:32 +02:00
Alexander A. Klimov 5b7f7344df /v1/actions/add-comment: add param expiry 
refs #4663
 2020-05-27 11:41:22 +02:00
Alexander A. Klimov c4a8afbe5f Icinga DB: record ack expiries 
refs #8012
 2020-05-15 12:02:51 +02:00
Noah Hilverling 4c9e4959f3
Merge pull request #7823 from Icinga/bugfix/unify-application-start-times 
Fix timing point for Application::GetStartTime() (related to command endpoint grace period)
 2020-03-09 09:45:57 +01:00
Alexander A. Klimov aa258685be Checkable#next_update: always use #check_interval if !#enable_active_checks 2020-03-06 10:03:56 +01:00
Alexander A. Klimov 0e24462064 Fire Checkable::OnFlappingChange only if flapping is enabled 
refs #7885
 2020-03-04 14:58:32 +01:00
Noah Hilverling 8f061ae80e Fix OnHostProblemChanged signal 2020-03-04 10:55:07 +01:00
Michael Friedrich 8e62fc8efb Fix 'check_timeout' not being forwarded to agent command endpoints 
fixes #6992
 2020-02-27 11:46:52 +01:00
Michael Friedrich d53eb34520 Unify Application::GetStartTime() and drop GetMainTime() 
This essentially moves the start time into the scope when main
starts to "do something", after the reload and configuration handling
is done.
 2020-02-11 17:26:15 +01:00
Michael Friedrich ae8a0b6a64 Introduce Application::GetUptime() 2020-02-11 16:47:50 +01:00
Michael Friedrich 3a4fb840d4 Tests: Add multi parent dependency test case 2020-02-11 15:13:25 +01:00
Michael Friedrich 9b0365ab43 Fix logical error with zero dependencies in IsReachable() 2020-02-11 15:13:25 +01:00
Henrik Triem d0c0beb8be Change behaviour of multiple dependencies (all failed = unreachable) 2020-02-11 15:13:25 +01:00
Michael Friedrich f961370e36 ApiEvents: Fix AcknowledgementCleared code quality 2020-02-06 13:03:04 +01:00
Alexander A. Klimov 86bbb79869 Checkable#next_update: ignore re-scheduled #next_check if !#enable_active_checks 
refs #7790
 2020-01-31 11:49:47 +01:00
Michael Friedrich 7e1e8b3393 Revert "Add NotificationResult class" 
This reverts commit 9621fd2e4b.
 2020-01-07 14:26:09 +01:00
Michael Friedrich 3605076f8b Revert "Add OnNewNotificationResult signal and ProcessNotificationResult handler" 
This reverts commit ac483f2a8a.
 2020-01-07 14:26:07 +01:00
Michael Friedrich 152709071d Revert "Implement last_notification_result handling for Notification objects" 
This reverts commit 1706b297a5.
 2020-01-07 14:21:06 +01:00
Michael Friedrich d242b41704 Revert "Make NotificationResult available for events: Cluster and Features" 
This reverts commit 566e59bbfa.
 2020-01-07 14:20:59 +01:00
Michael Friedrich 55e13fd001 Revert "Fix license headers" 
This reverts commit 48b3d25ce2.
 2020-01-07 14:20:45 +01:00
Alexander A. Klimov 4f68cfd299 IcingaDB: include consistent IDs, start time and end time in icinga:history:stream:{flapping,acknowledgement} 
refs #7689
 2019-12-10 10:44:26 +01:00
Alexander A. Klimov 829d07aefe Introduce Checkable#acknowledgement_last_change 
refs #7689
 2019-12-10 10:44:23 +01:00
Alexander A. Klimov 98ba1c03d0 Make Checkable#flapping_last_change consistent across nodes 
refs #7689
 2019-12-10 10:11:24 +01:00
Alexander A. Klimov da6a9174d1 Checkable#ClearAcknowledgement(): OnAcknowledgementCleared() at most once 2019-12-05 11:54:33 +01:00
Alexander A. Klimov 798ea54173 Refuse acking an already acked checkable 2019-12-05 11:08:16 +01:00
Noah Hilverling 71ef1de964
Merge pull request #7667 from Icinga/feature/icingadb-acks-history 
IcingaDB: populate icinga:history:stream:acknowledgement
 2019-12-05 09:20:36 +01:00
Alexander A. Klimov 798c56b809 IcingaDB: update service state on Host#problem change 
refs #7673
 2019-12-03 17:37:51 +01:00
Alexander A. Klimov ea5403a55c Extend Checkable::OnAcknowledgementCleared by removedBy 2019-12-03 17:00:54 +01:00
Alexander A. Klimov 1931501040 Checkable#GetProblem(): consider PENDING not a problem 2019-12-03 16:56:43 +01:00
Noah Hilverling ed1cede0a7
Merge pull request #7646 from Icinga/feature/remove-comment-author 
/v1/actions/remove-comment: let users specify themselves
 2019-11-26 16:07:09 +01:00
Noah Hilverling 6508e880b4
Merge pull request #7655 from Icinga/bugfix/commenttype 
CommentType: remove unused variants
 2019-11-26 15:47:45 +01:00
Alexander A. Klimov dcfc494d4d CommentType: remove unused variants 2019-11-26 11:29:04 +01:00
Alexander A. Klimov 80bf316e7b /v1/actions/remove-acknowledgement: let users specify themselves 2019-11-21 16:29:26 +01:00
Alexander A. Klimov d84efecb62 /v1/actions/remove-comment: let users specify themselves 2019-11-21 15:53:40 +01:00
Alexander A. Klimov a361bf716e /v1/actions/remove-downtime: let users specify themselves 2019-11-21 15:48:55 +01:00
Michael Friedrich 88c1a197b4
Merge pull request #7567 from Icinga/bugfix/apt-dist-upgrade-7558 
MacroProcessor::ResolveArguments(): skip null argument values
 2019-11-15 14:43:33 +01:00
Michael Friedrich b3eb9c6a07
Merge pull request #7439 from Icinga/feature/timeperiod-seconds 
LegacyTimePeriod: support specifying seconds
 2019-11-15 13:02:05 +01:00
Alexander A. Klimov 6c7a9eb651 IcingaDB#SendStatusUpdate(): add icinga:history:stream:state#previous_soft_state 2019-11-04 12:59:57 +01:00
Alexander Aleksandrovič Klimov f51454af65 git ls-files -z |xargs -0 perl -pi -e 's/RedisWriter/IcingaDB/g' 2019-11-02 14:00:24 +01:00
Alexander A. Klimov 746a48e2ca RedisWriter: add icinga:history:stream:{state,notification}#previous_hard_state 2019-11-02 14:00:24 +01:00
Jean Flach 037357aea5 Add severity 2019-11-02 14:00:23 +01:00
Jean Flach 02ecc3e445 Add additional fields 2019-11-02 14:00:23 +01:00
Alexander A. Klimov 768044a754 Replace std::shared_ptr<NamespaceValue> with NamespaceValue::Ptr 
refs #7361
 2019-10-21 17:10:51 +02:00
Alexander A. Klimov e4bdcedbca MacroProcessor::ResolveArguments(): skip null argument values 
refs #7558
 2019-10-08 17:06:06 +02:00
Michael Friedrich f0fcfdf910
Merge pull request #7538 from Icinga/bugfix/dependency-ignore_on_error-7536 
Dependency#OnAllConfigLoaded(): don't link *this with the child if *this is going to be dropped
 2019-09-25 12:12:22 +02:00
Alexander A. Klimov 7668314b4a Dependency#OnAllConfigLoaded(): don't link *this with the child if *this is going to be dropped 
refs #7536
 2019-09-25 11:30:50 +02:00
Alexander A. Klimov b8d495ae07 Introduce Checkable#next_update 2019-09-25 10:44:49 +02:00
Michael Friedrich 617f1d1333 Improve error message for command endpoint checkable's requiring a zone 
fixes #7514
 2019-09-23 09:41:08 +02:00
Michael Friedrich 55d7da30ca Metrics: Expose problem/handled counts for hosts/services 
With the addition of problem/handled as checkable runtime
attributes in #7096 we should also expose them via CIB
into

- icinga check
- /v1/status/CIB
- IcingaApplication runtime macros

This originates from a request by @phil-or at the recent
Icinga meetup in Linz.
 2019-08-29 17:04:23 +02:00
Alexander A. Klimov 28f708bb7c LegacyTimePeriod: support specifying seconds 2019-08-22 18:50:37 +02:00
Alexander A. Klimov efc7f2cf8d Correct current_concurrent_checks to actually running checks 
refs #7416
 2019-08-15 13:39:01 +02:00
Alexander A. Klimov 448a991404 Expose metric current_pending_callbacks 2019-08-14 17:22:27 +02:00
Michael Friedrich 59081c4f82
Merge pull request #7400 from Icinga/bugfix/cib-stats-concurrent-checks 
Fix missing stats for current_concurrent_checks via REST API
 2019-08-06 15:25:44 +02:00
Michael Friedrich 550a92f077 Fix missing stats for current_concurrent_checks via REST API 
It was added inside the 'icinga' check task, but not for the REST API.
Thanks for asking, @Thomas-Gelf
 2019-08-06 14:51:10 +02:00
Michael Friedrich 743dcad35d Improve logging for downtime/ack events (add, remove, expire) 
fixes #7374
 2019-08-06 13:28:58 +02:00
Michael Friedrich f58d1ef7f7 Revert "API: Improve error handling for 'schedule-downtime' action" 
This reverts commit 8ca38302fc.
 2019-08-01 14:03:44 +02:00
Michael Friedrich 8f3a1335dc Revert "API: Don't be so strict with the downtime start_time" 
This reverts commit 3b7cf5b9b5.
 2019-08-01 14:03:40 +02:00
Michael Friedrich 8098f4d54d Improve type logging for notifications 2019-07-16 13:46:16 +02:00
Alexander A. Klimov b95e92ea5f Stash notifications until object authority has been updated once 
refs #7086
 2019-07-11 13:07:50 +02:00
Michael Friedrich 60661eaecb
Merge pull request #7270 from Icinga/feature/notification-after-downtime-ends-5919 
Re-send suppressed notifications
 2019-07-11 10:46:59 +02:00
Michael Friedrich a3c6797310 Fix compiler warnings and style 2019-07-10 11:51:58 +02:00
Alexander A. Klimov ffa7b749cb Wait until the next check result if it's expected to arrive soon before re-sending a suppressed notification 
refs #5919
 2019-07-09 16:38:50 +02:00
Alexander A. Klimov ed56fa34dc Re-send suppressed notifications 
refs #5919
 2019-07-09 16:38:50 +02:00
Michael Friedrich 88e5d8c47a TimePeriod: Fully support and test "day -X" notation 
Previously no tests would have detected if this really worked or not.
 2019-07-09 16:21:07 +02:00
Michael Friedrich 0dc87668d6 Fix parsing of "day -X (last day of month)" in TimePeriod class 2019-07-09 16:16:43 +02:00
Michael Friedrich 7665143afa Tests: Rewrite TimePeriod tests using Boost::DateTime 
fixes #7257
 2019-07-09 15:34:07 +02:00
Michael Friedrich fdaab4b420
Merge pull request #7287 from Icinga/bugfix/script-debugger-crash-7284 
Service: don't rely on the own host being already set during derivative state calculation
 2019-07-08 09:31:15 +02:00
Alexander A. Klimov 3824b03913 Service: don't rely on the own host being already set during derivative state calculation 
refs #7284
 2019-07-04 16:14:40 +02:00
Michael Friedrich 3b7cf5b9b5 API: Don't be so strict with the downtime start_time 
There may be a slight overlap between the actual request
time and 'now'.

refs #7271
 2019-07-02 15:13:36 +02:00
Michael Friedrich 8ca38302fc API: Improve error handling for 'schedule-downtime' action 2019-07-02 11:15:43 +02:00
Henrik Triem 0381be32c5
Merge pull request #7192 from Crited/bugfix/notification_whitespaceremoval 
Remove double whitespaces for notifications log message

resolves #7192
 2019-06-19 16:42:58 +02:00
Alexander A. Klimov ffd736f56f LegacyTimePeriod::ProcessTimeRangeRaw(): support ranges across midnight 
refs #5261
 2019-06-06 13:11:34 +02:00
Michael Friedrich f6fc81c6c3 Combine all_services with child_options for schedule-downtime API action 2019-06-06 11:37:22 +02:00
Michael Friedrich e7c4253fa3 REST API: Allow to schedule downtimes for all services for one or more matching hosts 2019-06-06 11:37:22 +02:00
Alexander Stoll 471dbc79a3 Remove double whitespaces for notifications log message 
Add space to checkable debug message to unify timestamp format
 2019-05-22 14:13:14 +02:00
Michael Friedrich 368383bedd
Merge pull request #7154 from Elias481/fix/serializer-object-locking-7003 
Lock all kind of Objects during serialization
 2019-05-10 14:39:27 +02:00
Michael Friedrich 8ae206cd5d Improve validation for times.{begin,end} in notification objects 
fixes #6939
 2019-05-07 15:20:06 +02:00
Elias Ohm 44ac6cf1ec add some object locking to the Dump method (which could theoreticylly suffer from same reace condition as serializer) 2019-05-01 11:49:07 +02:00
Michael Friedrich 37de1a919b
Merge pull request #7088 from Icinga/feature/asio-event-queue 
Implement new event queue for ASIO consumers
 2019-04-25 16:54:43 +02:00
Alexander A. Klimov 90d9cd9257 Feed new event queue with events 2019-04-25 15:56:38 +02:00
Michael Friedrich a630d0185f
Merge pull request #6722 from Icinga/feature/notification-result 
Add notification result store/sync
 2019-04-25 15:56:14 +02:00
Alexander A. Klimov 5a17722c1f Replace _unlink() + rename() with boost::filesystem::rename() 
refs #7101
 2019-04-25 09:53:02 +02:00
Michael Friedrich 02db12ae02
Merge pull request #7050 from Icinga/feature/previous-state-change 
Implement previous_state_change
 2019-04-17 13:17:41 +02:00
Michael Friedrich 3665430005
Merge pull request #7112 from Icinga/bugfix/service-handled 
Include host state in Service#handled and Service#severity
 2019-04-17 13:16:23 +02:00
Michael Friedrich 64568f5966
Merge pull request #7121 from Icinga/bugfix/concurrent-checks 
Fix that MaxConcurrentChecks constant is overridden from 'checker' feature
 2019-04-17 13:14:32 +02:00
Michael Friedrich b906714254 Fix that MaxConcurrentChecks constant is overridden from 'checker' feature 
Note: This drops the deprecated concurrent_checks setting from the checker feature
entirely and refactors the underlaying code handling.

Also affects ReloadTimeout which is new for 2.11.

fixes #7111
 2019-04-16 15:04:57 +02:00
Alexander A. Klimov d7b63143cf Drop Checkable#reachable in favor of #last_reachable 2019-04-12 13:03:11 +02:00
Alexander A. Klimov 66949dd018 Service: reduce severity while host is down 2019-04-11 11:36:23 +02:00
Alexander A. Klimov ae18536b0f Service: be handled while host is down 2019-04-11 11:25:45 +02:00
Alexander A. Klimov 896d447e11 Add Checkable#problem and #handled 2019-04-09 11:34:59 +02:00
Alexander A. Klimov d33cfdf3c0 Declare Checkable#IsStateOK() const 2019-04-09 11:26:34 +02:00
Alexander A. Klimov acf28fb5b0 Expose Checkable#reachable 2019-04-09 11:09:02 +02:00
Michael Friedrich 48b3d25ce2 Fix license headers 2019-03-28 11:47:47 +01:00
Michael Friedrich 566e59bbfa Make NotificationResult available for events: Cluster and Features 2019-03-28 11:42:28 +01:00
Michael Friedrich 1706b297a5 Implement last_notification_result handling for Notification objects 2019-03-28 10:43:35 +01:00
Michael Friedrich ac483f2a8a Add OnNewNotificationResult signal and ProcessNotificationResult handler 2019-03-28 10:42:04 +01:00
Michael Friedrich 9621fd2e4b Add NotificationResult class 2019-03-28 10:42:04 +01:00
Michael Friedrich 93030709f5 Implement previous_state_change 2019-03-27 11:43:14 +01:00
Michael Friedrich 804c00ece5
Merge pull request #6999 from Icinga/bugfix/compiler-warnings 
Suppress or fix compiler warnings
 2019-03-18 08:44:30 +01:00
Alexander A. Klimov bf92e32496 Suppress or fix compiler warnings 2019-03-08 14:07:29 +01:00
Michael Friedrich e2df11520e
Merge pull request #6970 from Icinga/bugfix/perfdata-gaps 
Improve reload handling for features (metric & queue flush, activation priority)
 2019-02-26 15:38:15 +01:00
Michael Friedrich 458f997a18 Replace Copyright header with a short version, part II 2019-02-25 15:09:36 +01:00
Michael Friedrich d14a88235d Replace Copyright header with a short version, part I 
CLion -> replace in path
 2019-02-25 14:48:22 +01:00
Michael Friedrich 30d98b49eb
Merge pull request #6896 from Icinga/bugfix/notification-delay-5561 
Notification#BeginExecuteNotification(): SetNextNotification() correctly
 2019-02-22 09:27:59 +01:00
Michael Friedrich 7936a147ba Activate downtimes before any checkable object 2019-02-20 13:56:15 +01:00
Michael Friedrich a4f97c1246 Stop the IcingaApplication at the latest point, before any loggers 2019-02-20 13:55:34 +01:00
Michael Friedrich d1fb1a8eda Refactor conditions and add debug log messages for future crs and skipped crs 2019-02-08 13:32:13 +01:00
Jean Flach c97f3c80f5 Fix checkresults from the future breaking checks 2019-02-08 12:08:40 +01:00
Michael Friedrich 7ce30a86b8 Enhance notification logging 
- More details from the local context (notification, user, checkable, command names)
- Notice logs for when this notification object is paused in HA enabled zones
- Notice logs for interval=0 reminder notifications
- Object name for skipping recovery notifications when problem hasn't been notified before
 2019-02-07 15:42:09 +01:00
Michael Friedrich 04de273405
Merge pull request #6914 from Icinga/bugfix/clusterevents-missing-persistent-ack 
ClusterEvents::AcknowledgementSet event should forward 'persistent' attribute
 2019-02-04 13:52:44 +01:00
Michael Friedrich 5a8729fddd
Merge pull request #6853 from Icinga/bugfix/incorrect-command_endpoint-6666 
Checkable: require zone to be set if command_endpoint is set
 2019-02-04 13:51:31 +01:00
Michael Friedrich eb155495f7
Merge pull request #6916 from Icinga/bugfix/retry-interval-zero 
Don't allow retry_interval <= 0
 2019-01-30 15:28:26 +01:00
Alexander A. Klimov ce847324bc Downtime::AddDowntime(): place Downtimes in the same zone as the origin ScheduledDowntimes 2019-01-28 18:29:57 +01:00
Michael Friedrich 8cbd482072 Don't allow retry_interval <= 0 2019-01-28 17:33:05 +01:00
Michael Friedrich 9f2ccfbaa0 ClusterEvents::AcknowledgementSet event should forward 'persistent' attribute 2019-01-28 17:29:46 +01:00
Michael Friedrich b1442645ce
Merge pull request #6897 from Icinga/bugfix/getlocalzone-null 
Validate Zone::GetLocalZone() before using
 2019-01-25 08:31:57 +01:00
Michael Friedrich 6b7f651478
Merge pull request #6899 from Icinga/bugfix/localtime-zero-windows 
Log: Ensure not to pass negative values to localtime()
 2019-01-24 10:58:43 +01:00
Michael Friedrich 2fc33996b6 Log: Ensure not to pass negative values to localtime() 
refs #6887
 2019-01-16 17:27:38 +01:00
Alexander A. Klimov b09e7b287e Validate Zone::GetLocalZone() before using 2019-01-15 19:23:20 +01:00
Alexander A. Klimov 3b2054761a Notification#BeginExecuteNotification(): SetNextNotification() correctly 
refs #5561
 2019-01-11 18:25:12 +01:00
Alexander A. Klimov 9ae738d17f Allow Checkable#retry_interval to be 0 
refs #6871
 2019-01-09 11:27:33 +01:00
Alexander A. Klimov 12f3149eef Checkable: require zone to be set if command_endpoint is set 
refs #6666
 2018-12-20 13:59:28 +01:00
Michael Friedrich c4d57afa3d
Merge pull request #6821 from Icinga/bugfix/downtimes-disappear-satellite-6542 
Don't delete downtimes in satellite zones
 2018-12-18 16:13:36 +01:00
Michael Friedrich b40400e79f
Merge pull request #6826 from Icinga/bugfix/downtimes-recreate-satellite-6542 
Downtime#HasValidConfigOwner(): wait for ScheduledDowntimes
 2018-12-18 16:12:34 +01:00
Alexander A. Klimov c98d6a5254 Downtime#HasValidConfigOwner(): respect Downtime#authoritative_zone 
refs #6542
 2018-12-17 15:54:31 +01:00
Alexander A. Klimov 5431eae116 Add and populate Downtime#authoritative_zone 
refs #6542
 2018-12-17 15:54:23 +01:00