Commit Graph

136 Commits

Author SHA1 Message Date
Mattia Codato 6102cf0625 Call notificationCommand->Execute 2020-07-02 12:20:16 +02:00
Mattia Codato f2e9aee158 Update execMacros 2020-07-02 10:31:24 +02:00
Mattia Codato ee2f7bafdd Move some checks. Add macros parameters to ExecuteCommand message 2020-07-01 14:27:00 +02:00
Mattia Codato edbd8688fb Update status code 2020-07-01 08:19:35 +02:00
Mattia Codato cb32786880 Use RelayMessage to broadcast the updated executions 2020-06-30 17:50:08 +02:00
Mattia Codato 626080f610 Remove unnecessary check 2020-06-30 15:53:25 +02:00
Mattia Codato 15dac85583 Use HttpUtility::GetLastParameter to get endpoint 2020-06-30 15:51:15 +02:00
Mattia Codato 8f3617d074 Fix response strings 2020-06-30 15:48:29 +02:00
Mattia Codato 5c06256ac5 Use dynamic_pointer_cast 2020-06-30 15:41:47 +02:00
Mattia Codato 94be948ff6 Unify how to take macros parameter 2020-06-30 13:51:42 +02:00
Mattia Codato 22dc2f2393 Use SyncSendMessage for remote endpoint and call ExecuteCommandAPIHandler for local endpoint 2020-06-30 13:43:00 +02:00
Mattia Codato 7077605880 Use the right method to get the notification command 2020-06-29 13:55:20 +02:00
Mattia Codato 3f1b51b355 Use RelayMessage instead of SyncSendMessage 2020-06-29 09:28:02 +02:00
Mattia Codato da82c17891 Call Endpoint::GetByName only once 2020-06-26 16:38:40 +02:00
Mattia Codato 50693d7ea9 Add newline at the end of file 2020-06-26 16:36:57 +02:00
Mattia Codato fd761397ac Unify result status strings 2020-06-26 15:39:42 +02:00
Mattia Codato 899076c77b Code format 2020-06-26 14:29:03 +02:00
Mattia Codato 82444a59e2 Fix resolve macros. Check if endpoint is local or remote 2020-06-26 12:32:12 +02:00
Mattia Codato 714e75bbd1 Remove wait parameter, ttl is required, remove unnecessary checks 2020-06-26 09:33:23 +02:00
Benjamin Groeber e9b6c68fd5 Use tabs instead of spaces 2020-06-23 11:44:26 +02:00
Benjamin Groeber 2bb6f9d38d Fix formatting of long fn 2020-06-23 11:41:49 +02:00
Benjamin Groeber 159e3d2945 Remove superfluous else clause 2020-06-23 11:41:15 +02:00
Andrea Avancini 823fe34d24 Parameter evaluation, macro resolution, update executions, send ExecuteCommand message for ExecuteCommand Endpoint 2020-06-18 15:27:31 +02:00
Alexander A. Klimov 752df8ea28 Add stub for /v1/actions/execute-command
refs #8034
2020-06-02 11:43:32 +02:00
Alexander A. Klimov 5b7f7344df /v1/actions/add-comment: add param expiry
refs #4663
2020-05-27 11:41:22 +02:00
Alexander A. Klimov 829d07aefe Introduce Checkable#acknowledgement_last_change
refs #7689
2019-12-10 10:44:23 +01:00
Alexander A. Klimov 798ea54173 Refuse acking an already acked checkable 2019-12-05 11:08:16 +01:00
Alexander A. Klimov ea5403a55c Extend Checkable::OnAcknowledgementCleared by removedBy 2019-12-03 17:00:54 +01:00
Noah Hilverling ed1cede0a7
Merge pull request #7646 from Icinga/feature/remove-comment-author
/v1/actions/remove-comment: let users specify themselves
2019-11-26 16:07:09 +01:00
Alexander A. Klimov 80bf316e7b /v1/actions/remove-acknowledgement: let users specify themselves 2019-11-21 16:29:26 +01:00
Alexander A. Klimov d84efecb62 /v1/actions/remove-comment: let users specify themselves 2019-11-21 15:53:40 +01:00
Alexander A. Klimov a361bf716e /v1/actions/remove-downtime: let users specify themselves 2019-11-21 15:48:55 +01:00
Michael Friedrich f58d1ef7f7 Revert "API: Improve error handling for 'schedule-downtime' action"
This reverts commit 8ca38302fc.
2019-08-01 14:03:44 +02:00
Michael Friedrich 8f3a1335dc Revert "API: Don't be so strict with the downtime start_time"
This reverts commit 3b7cf5b9b5.
2019-08-01 14:03:40 +02:00
Michael Friedrich 3b7cf5b9b5 API: Don't be so strict with the downtime start_time
There may be a slight overlap between the actual request
time and 'now'.

refs #7271
2019-07-02 15:13:36 +02:00
Michael Friedrich 8ca38302fc API: Improve error handling for 'schedule-downtime' action 2019-07-02 11:15:43 +02:00
Michael Friedrich f6fc81c6c3 Combine all_services with child_options for schedule-downtime API action 2019-06-06 11:37:22 +02:00
Michael Friedrich e7c4253fa3 REST API: Allow to schedule downtimes for all services for one or more matching hosts 2019-06-06 11:37:22 +02:00
Michael Friedrich d14a88235d Replace Copyright header with a short version, part I
CLion -> replace in path
2019-02-25 14:48:22 +01:00
Michael Friedrich e480eb785e Improve error handling for invalid child_options for API downtime actions
fixes #6712
2018-10-24 11:00:24 +02:00
Jean Flach 6777255f60 Fix typo 2018-10-22 14:43:59 +02:00
Michael Friedrich dab53448bc icinga.com: Update *.{h,c}pp 2018-10-18 09:27:04 +02:00
Noah Hilverling 01fea22c77 Add child_options to ScheduledDowntime
refs #3935
2018-08-24 14:29:39 +02:00
Michael Friedrich 12471bf259 Allow to pass raw performance data in 'process-check-result' API action
This is how data is coming from Icinga Web 2 and still a valid input
type.

fixes #4786
2018-02-06 15:25:55 +01:00
Gunnar Beutner c2fb9fe226 Use initializer lists for arrays and dictionaries 2018-01-16 12:27:44 +01:00
Michael Friedrich 211a07f49a Add 'ttl' support for check result freshness via REST API
The `process-check-result` action can now optionally set the
`ttl` parameter. This overrules the configured freshness
check (check_interval).

The main idea behind this is to allow the external sender
to specify when the next check result is coming in.

For example, a backup script which should be run every
24h can specify the exact expected next check result.

The addition to the CheckResult class is necessary to
forward the check result throughout the cluster and
calculate the `next_check` value on each node. This
allows us to send in a check result on a satellite,
and the master determines the freshness and possible
notifications/state changes for Icinga Web 2.
2018-01-15 13:54:11 +01:00
Michael Insel 158ae2188e Change copyright header for 2018 2018-01-02 12:08:55 +01:00
Jean Flach 2636e6a77a Whitespace fix
What does this change?
* Remove use of spaces for formatting
These could be found by using `grep -r -l -P '^\t+ +[^*]'
* Removal of training whitespaces
* A few lines longer than 120 chars
2017-12-20 14:53:52 +01:00
Gunnar Beutner 325e4a2fb9 Use nullptr instead of <Type>::Ptr() 2017-11-30 17:47:09 +01:00
Noah Hilverling e31b236cba API: Fix http status codes
fixes #5550
2017-11-27 14:06:38 +01:00
Gunnar Beutner 043106242d Remove API stubs for now
refs #5450
2017-09-12 12:52:49 +02:00
Gunnar Beutner c02742925e Refactor PkiUtility class
refs #5450
2017-09-12 12:52:49 +02:00
Federico Cuello a6b4bd48e2 Fix parameter order for Acknowledge{,Svc,Host}Problem in API actions/external commands
It was preventing email notifications with default settings, as `persistent` defaults to false and therefore `notify` was not set.

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
2017-09-05 08:50:22 +02:00
Michael Friedrich e88b97079c API: Add execution_{start,end} attribute to 'process-check-result' action
fixes #5002
2017-08-21 17:20:56 +02:00
Michael Friedrich f282126bb4 Don't allow acknowledgement expire timestamps in the past
fixes #5250
2017-05-15 10:23:21 +02:00
Rune Darrud 273ca6a2cc Fix persistent comments for Acknowledgements
fixes #4818

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
2017-05-10 17:10:22 +02:00
Michael Friedrich 60f334df52 Fix notify/sticky parameter handling in 'acknowledge-problem' API action
refs #13939
2017-02-23 12:30:28 +01:00
Michael Friedrich b7caf0820d Ensure that *.icinga.com is used everywhere
fixes #13897
fixes #13277
2017-01-10 17:19:12 +01:00
Gunnar Beutner 23e30ccb67 Revert "Implement the 'evaluate-macros' API action"
This reverts commit 851135d3a1.

fixes #13091
2016-11-17 10:39:27 +01:00
Gunnar Beutner 851135d3a1 Implement the 'evaluate-macros' API action
fixes #13091
2016-11-09 09:13:42 +01:00
Michael Friedrich 09658f6d0e Add child_options for API action 'schedule-downtime'
fixes #10896
fixes #10897
2016-11-02 09:54:48 +01:00
Gunnar Beutner 288413f046 Replace BOOST_FOREACH with range-based for loops
fixes #12538
2016-08-25 06:46:17 +02:00
Michael Friedrich 520be9513b API: Fix that schedule-downtime action requires duration for fixed=true
fixes #12454
2016-08-16 17:09:25 +02:00
Michael Friedrich d341783a51 API: Implement 'generate-ticket' action and update distributed monitoring docs
fixes #12433
2016-08-15 15:19:28 +02:00
Gunnar Beutner 0eb0992d5e Fix custom notifications in a HA zone
fixes #9242
2016-06-07 12:44:12 +02:00
Michael Friedrich d682f56c38 Use UpdateNextCheck() for determining the retry_interval in ProcessCheckResult()
This patch also moves the next check updates for passive
check results into ProcessCheckResult(). That way the
next check status updates for DB IDO work in a sane way
again.

refs #11336
2016-03-15 13:02:38 +01:00
Michael Friedrich 7fb8bcd933 Use retry_interval on first OK -> NOT-OK state change
Only valid for active check results. The API actions were
missing that marker similar to the external command processor.

The initial OK -> NOT-OK transition should use the retry_interval
but nothing else.

fixes #11336
2016-03-11 12:00:30 +01:00
Michael Friedrich b8e3d61820 Revert "Properly set the next check time for active and passive checks"
This reverts commit 2a11b27972.

This patch does not properly work and breaks the check_interval setting
for passive checks. Requires a proper patch.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287
2016-03-05 18:15:03 +01:00
Jean Flach 964cfcebd3 Make schedule-downtime default fixed
fixes #10923
2016-02-08 16:04:41 +01:00
Michael Friedrich b960850ce3 DB IDO: Only update 'next_check' column when manually scheduling a check
Otherwise the changes from #7287 already take care of setting
the proper next check time from inside ProcessCheckResult().

There is no need to use the generic OnNextCheckChanged signal
but instead we're using a new one, locally just for DB IDO.

fixes #11019
2016-01-22 18:42:15 +01:00
Michael Friedrich 2a11b27972 Properly set the next check time for active and passive checks
fixes #7287
refs #11019
2016-01-22 18:40:14 +01:00
Gunnar Beutner 599929b0f6 Update copyright headers for 2016 2016-01-12 08:29:59 +01:00
Michael Friedrich f5da37b7df Remove obsolete checks from API actions
refs #10561
2015-11-10 16:13:14 +01:00
Michael Friedrich 1d2606cbfe Add filter targets for remove-{comment,downtime} actions
Drop remove-all-{comments,downtimes}. This is provided
by using host and service filters.

fixes #10561
2015-11-08 14:22:10 +01:00
Michael Friedrich 64c936d387 API Actions: Remove -by-id from actions and require names for comments and downtimes
The documentation is updated as well. Furthermore actions provide
detailed error information in case of an exception.
Includes DB IDO schema updates.

fixes #10512
2015-11-06 17:06:12 +01:00
Michael Friedrich 439dad5d6a API actions: Check if removal of comments and downtimes was succesful
refs #9080
2015-11-01 16:33:43 +01:00
Gunnar Beutner 050c520b2a Convert Comment/Downtime to config objects
fixes #9777
2015-10-28 17:56:29 +01:00
Jean Flach 2fc042e231 Update API actions and documentation
refs #9080 #9105
2015-10-27 14:15:07 +01:00
Jean Flach be320b2f77 Update API actions
fixes #10180
refs #9080
2015-10-22 11:33:26 +02:00
Jean Flach 01ced1549a Implement all actions except modified attributes
refs #9080 #9979
2015-08-26 13:53:17 +02:00
Michael Friedrich 981ed591e9 API: Return comment/downtime ids, refactor code
refs #9080
2015-08-21 12:49:51 +02:00
Jean Flach c5fe46a300 Experimental actions without types
refs #9080
2015-08-21 12:48:32 +02:00
Jean Flach afd6af39d5 Implement external commands as api actions
refs #9080
2015-08-21 12:48:32 +02:00
Gunnar Beutner 071d2f18fb Rename DynamicObject/DynamicType to ConfigObject/ConfigType
fixes #9914
2015-08-15 20:40:41 +02:00
Jean Flach 60f86d01fe Implement /v1/actions/process-check-result
Requires error handling.

refs #9080
2015-07-31 17:18:49 +02:00
Jean-Marcel Flach 9b6ebbc69b Implement basic actions framework
refs #9080
2015-07-30 17:50:17 +02:00