Commit Graph

2621 Commits

Author SHA1 Message Date
Gunnar Beutner 10441e9cd7 Fix permissions for agent CheckResult messages
fixes #8821
2015-03-30 13:50:14 +02:00
Jean-Marcel Flach 8e73d72447 Add accept config/commands option to node setup
fixes #8803
2015-03-30 13:20:47 +02:00
Gunnar Beutner 339b8aef48 Avoid unnecessary allocations in ScriptFrame::SetCurrentFrame 2015-03-29 22:26:07 +02:00
Gunnar Beutner a5c5569324 Improve timeperiod validation error messages
fixes #8893
2015-03-29 08:13:11 +02:00
Gunnar Beutner a6822fd59a Fix validation errors for time ranges which span the DST transition
fixes #8892
2015-03-29 08:05:01 +02:00
Gunnar Beutner 111b154a6d Remove unused #includes 2015-03-29 00:03:47 +01:00
Gunnar Beutner 42a7ca4e78 Avoid most other unnecessary PLT indirections
refs #8890
2015-03-28 17:40:01 +01:00
Gunnar Beutner 2cbc3142dc Avoid some unnecessary PLT indirections for constructor calls
refs #8890
2015-03-28 16:13:44 +01:00
Gunnar Beutner f8b48cc03b Build fix for db_ido_mysql
refs #8890
2015-03-28 12:22:40 +01:00
Gunnar Beutner 72a7b08480 Move implementation code from thpp files into separate files
fixes #8890
2015-03-28 11:08:12 +01:00
Gunnar Beutner ec7224e3ed Generate C++ code for type validators
fixes #7709
fixes #8867
2015-03-27 07:59:27 +01:00
Gunnar Beutner 3adec4576c Fix arrays in command arguments
fixes #8869
2015-03-26 09:29:52 +01:00
Gunnar Beutner c08aa37c99 Fix crash in MakeX509CSR when using ancient versions of OpenSSL
fixes #8844
2015-03-26 08:23:24 +01:00
Gunnar Beutner a4852dae67 Fix assertion failure in IdoMysqlConnection::FieldToEscapedString
fixes #8865
2015-03-26 07:16:22 +01:00
Gunnar Beutner d3c0c1e42b Fix incorrect variable values for apply+for
fixes #8851
2015-03-23 15:53:21 +01:00
Gunnar Beutner 665c3b45c1 Add support for the C++11 keyword 'override'
fixes #8842
2015-03-23 07:55:06 +01:00
Gunnar Beutner dda273dbcc Add missing include in loader.cpp 2015-03-22 15:04:00 +01:00
Gunnar Beutner 808a26ae72 Fix: 'return' keyword doesn't work inside for loops
fixes #8834
2015-03-22 00:04:57 +01:00
Gunnar Beutner ed29d06ab6 Implement constructor-style casts
fixes #8832
2015-03-21 22:48:23 +01:00
Gunnar Beutner 250fc54cd0 Fix copyright header indentation 2015-03-21 11:02:01 +01:00
Gunnar Beutner 151b6bbf00 Fix style violations 2015-03-21 10:04:14 +01:00
Michael Friedrich e1cb543bb5 Fix missing config validator for command arguments 'set_if'
fixes #8724
2015-03-20 16:12:24 +01:00
Gunnar Beutner e8cee8d5e2 Allow using more than one %validator rule for the same type
fixes #8829
2015-03-20 15:49:55 +01:00
Gunnar Beutner 76b0c6d89d Flush stderr in Application::Exit
fixes #8734
2015-03-20 12:28:43 +01:00
Gunnar Beutner 5588b8ed75 Don't allow users to instantiate the StreamLogger class
fixes #8823
2015-03-20 08:16:10 +01:00
Gunnar Beutner 16ef84fd35 Use TypeInstance field instead of looking up types by name
fixes #8817
2015-03-20 08:15:07 +01:00
Gunnar Beutner e22386e63f Make load order for objects more reliable
fixes #8770
2015-03-19 15:58:38 +01:00
Michael Friedrich 41d0c3f3d7 Add "random" CheckCommand for test and demo purposes
fixes #8816
2015-03-19 14:36:53 +01:00
Michael Friedrich 88f16abb3c Use Utility::NaturalJoin for notification filter formatting
refs #8685
2015-03-19 14:08:06 +01:00
Gunnar Beutner 6812e2668c Improve error message for invalid field access
fixes #8769
2015-03-19 13:48:51 +01:00
Gunnar Beutner 0884265180 Fix leak in ConfigCompiler::CompileStream
refs #8791
2015-03-19 08:17:57 +01:00
Gunnar Beutner 2aa65f3f4c Don't use the thread pool to compile Livestatus scripts
refs #8791
2015-03-18 14:36:46 +01:00
Gunnar Beutner 2c4f913a90 Fix crash in ConsoleCommand::Run
refs #8791
2015-03-18 14:29:02 +01:00
Gunnar Beutner 05e55ab79d Fix initialization order for type objects
refs #8791
2015-03-18 14:24:55 +01:00
Gunnar Beutner 3e08f2e0b5 Make order for deferred initializers deterministic
refs #8791
2015-03-18 13:24:31 +01:00
Gunnar Beutner 50b1e1cf6b Fix livestatus unit tests
refs #8791
2015-03-18 12:11:42 +01:00
Gunnar Beutner 6c96d5bc98 Clean up the start-up process a bit
fixes #8791
2015-03-18 11:14:51 +01:00
Gunnar Beutner fec1266b1b Add auto-completion suggestions for built-in attributes
refs #8776
2015-03-18 08:19:36 +01:00
Gunnar Beutner a2b701ad44 Improve auto-completion for the 'icinga2 console' command
refs #8776
2015-03-18 08:10:32 +01:00
Gunnar Beutner cd9dfd5744 Implement auto-completion support for 'icinga2 console'
refs #8776
2015-03-18 07:17:15 +01:00
Gunnar Beutner 37736caa5c Implement support for libedit
fixes #8776
2015-03-17 15:05:47 +01:00
Gunnar Beutner dae206e899 Move the base command templates into libmethods
fixes #8775
2015-03-17 08:19:31 +01:00
Louis Sautier 1eef0243c6 Remove prompt to create a TicketSalt from the wizard
fixes #8766

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-16 15:24:58 +01:00
Gunnar Beutner 0d7a382b82 Add OS details in 'icinga2 --version'
fixes #8761
2015-03-16 13:32:13 +01:00
Gunnar Beutner 4a8920b1d4 Improve Flex version detection on Windows
refs #8750
2015-03-16 13:32:02 +01:00
Gunnar Beutner 8072ca31d9 Ensure that flex meets the version requirements
fixes #8750
2015-03-15 21:08:06 +01:00
Gunnar Beutner 7877292685 Don't ignore extraneous arguments for functions
fixes #8748
2015-03-15 11:24:09 +01:00
Gunnar Beutner 316eee799e Merge COMMIT and BEGIN into the previous MySQL query
refs #8738
2015-03-14 07:58:55 +01:00
Gunnar Beutner c7c49d7219 Implement support for CLIENT_MULTI_STATEMENTS
fixes #8738
2015-03-13 20:23:14 +01:00
Gunnar Beutner 100eb0cf8a Don't update custom vars for each status update
fixes #8736
2015-03-13 13:46:00 +01:00
Gunnar Beutner cd20044e4f Implement the pending_queries metric for the IDO check task
refs #8688
2015-03-13 12:00:30 +01:00
Michael Friedrich 3c945914ff Show notification state/type filter names in notice/debug log
fixes #8685
2015-03-12 17:11:24 +01:00
Michael Friedrich 6abbafe810 Fix log message for cli commands breaks the init script
fixes #8721
2015-03-12 15:53:56 +01:00
Gunnar Beutner c996fbb5c4 Build fix
refs #8688
2015-03-12 13:44:17 +01:00
Gunnar Beutner 52b33f560f Improve output for the ido check task
refs #8688
2015-03-12 11:51:02 +01:00
Michael Friedrich 8573636cc9 Fix crash in Dependency::Stop()
This partially reverts the fix in #8436

fixes #8687
refs #8436
2015-03-12 11:44:55 +01:00
Gunnar Beutner a4d37132bf Implement a check for IDO database connections
fixes #8688
2015-03-12 10:19:12 +01:00
Gunnar Beutner 94fde1a6b2 Add support for using the 1.12.0 IDO database schema
fixes #8689
2015-03-12 10:19:12 +01:00
Michael Friedrich 05c237c780 Don't increment check attempt counter on OK->NOT-OK transition
refs #7287

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-11 16:33:36 +01:00
Michael Friedrich f198249eb1 Fix formatting for the GDB stacktrace
fixes #8684
2015-03-11 16:31:30 +01:00
Gunnar Beutner 228aafc945 Implement the parse_performance_data function
fixes #8693
2015-03-11 16:29:50 +01:00
Michael Friedrich 334cbbb722 Make sure that the /var/log/icinga2/crash directory exists
fixes #8683
2015-03-11 16:08:06 +01:00
Gunnar Beutner 5e39fbbdf5 Make sure that 'icinga2 console' serializes temporary attributes (rather than just config + state)
fixes #8690
2015-03-11 16:07:24 +01:00
Gunnar Beutner 44114232d3 Fix timeout problem with API heartbeat messages
fixes #8672
2015-03-11 12:53:43 +01:00
Gunnar Beutner 8682c530af Fix line continuation support for parentheses
fixes #8679
2015-03-11 10:01:03 +01:00
Gunnar Beutner ca27c8769e Kill entire process group after plugin timeout
fixes #8540
2015-03-11 07:12:59 +01:00
Gunnar Beutner bf6d19c50b Fix argument type for the StringContains function
refs #8659
2015-03-11 06:42:45 +01:00
Michael Friedrich 330c93fa77 Implement String#contains
fixes #8659
2015-03-11 00:11:18 +01:00
Gunnar Beutner 977ca844c7 Remove an unnecessary temporary variable 2015-03-10 15:23:27 +01:00
Gunnar Beutner 37aa3413d8 Allow some of the Array and Dictionary methods to be inlined by the compiler
fixes #8666
2015-03-10 13:46:24 +01:00
Gunnar Beutner 4e16f48255 Don't accept config updates for zones for which we have an authoritative copy of the config
fixes #8555
2015-03-09 08:46:01 +01:00
Gunnar Beutner 3046ad5d5e Fix incorrect value for the process_performance_data column in the icinga_hosts table
fixes #8544
2015-03-09 08:12:05 +01:00
Gunnar Beutner e50d3e6e5a Fix validator for dependencies
fixes #8596
2015-03-09 08:04:18 +01:00
Gunnar Beutner 22f3c5082d Add validator for time ranges in ScheduledDowntime objects
fixes #8600
2015-03-09 08:02:12 +01:00
Gunnar Beutner 60d5959ba4 Remove incorrect VERIFY
fixes #8628
2015-03-09 06:51:22 +01:00
Gunnar Beutner 77fc213d6d Remove unnecessary dynamic_casts 2015-03-07 14:47:54 +01:00
Gunnar Beutner 52102d815d Fix second Deserialize() call in ApiEvents::ExecuteCommandAPIHandler
refs #8117
2015-03-06 01:45:43 +01:00
Gunnar Beutner 139540b570 Make sure we don't evaluate apply rules for fake hosts used in agent checks
fixes #8117
2015-03-05 21:19:04 +01:00
Gunnar Beutner 9181d7ae05 Add missing service name in check results
refs #8257
2015-03-05 20:50:27 +01:00
Gunnar Beutner bb4beefca9 Add missing "return"s in Ido*Connection::Reconnect 2015-03-05 15:57:46 +01:00
Gunnar Beutner fd9dc32a3d Implement SNI support for the TlsStream class
fixes #8610
2015-03-05 14:15:42 +01:00
Gunnar Beutner 4a2a6d999a Fix incorrect debug hints for nested attributes
fixes #8604
2015-03-05 13:18:15 +01:00
Gunnar Beutner 4b15ec7774 Remove the macro argument for IMPL_TYPE_LOOKUP
fixes #8599
2015-03-05 07:42:13 +01:00
Gunnar Beutner 767ddbdec7 Fix compiler warning in Process::Run 2015-03-04 16:41:53 +01:00
Gunnar Beutner f41f9b085d Implement support for the 'Limit' column in Livestatus
fixes #8529
2015-03-04 12:18:04 +01:00
Gunnar Beutner afd1927a98 Improve Livestatus query performance
fixes #8594
2015-03-04 10:58:22 +01:00
Gunnar Beutner c33e78aa04 Don't discard config validators 2015-03-04 09:12:57 +01:00
Gunnar Beutner 4d63351561 Fix some compile warnings 2015-03-04 08:26:15 +01:00
Gunnar Beutner 9bbe9a4875 Fix a memory leak in *Expression::GetReference
fixes #8593
2015-03-04 08:00:38 +01:00
Gunnar Beutner c9c7f9bed1 Fix lag calculation for the 'cluster-zone' check 2015-03-03 14:42:22 +01:00
Gunnar Beutner 3615716983 Include GDB backtrace in crash reports
fixes #8575
2015-03-03 13:53:11 +01:00
Gunnar Beutner c3e32911a7 Fix: else if doesn't work without an else branch
fixes #8572
2015-03-03 10:22:21 +01:00
Gunnar Beutner 1d2b008dcb Fix validator for TimePeriod ranges
fixes #8568
2015-03-03 09:56:38 +01:00
Gunnar Beutner cf37decbef Fix start condition for downtimes
fixes #8560
2015-03-03 09:52:13 +01:00
Gunnar Beutner 2867d79514 Add VERIFY check in Utility::ExecuteDeferredInitializers
Coverity Bug ID: 1167738
2015-03-03 09:26:21 +01:00
Gunnar Beutner 3e12bfef25 Remove redundant error check in Utility::GetTime
Coverity Bug ID: 1167732
2015-03-03 09:23:29 +01:00
Gunnar Beutner 274e6e9785 Fix uninitialized field in the CheckerComponent class 2015-03-03 09:14:15 +01:00
Gunnar Beutner ac7a55cf56 Fix file descriptor leak in SetDaemonIO 2015-03-03 07:36:43 +01:00
Gunnar Beutner 7c31654552 Remove the return type for Utility::LoadExtensionLibrary 2015-03-03 07:19:34 +01:00
Gunnar Beutner bdb2a15e27 Use _exit instead of Exit in Application::SetResourceLimits 2015-03-02 17:19:41 +01:00
Jean Flach 4d0ee2a7fd Americaniz(s)e colo(u)r in troubleshoot cli 2015-03-02 16:42:38 +01:00
Michael Friedrich c61134d55a Fix deadlock in DB IDO and external command events
refs #8511
2015-03-02 16:20:22 +01:00
Michael Friedrich 97ff17eb4e Fix troubleshooting cli hint text
refs #3446
2015-03-02 15:28:02 +01:00
Michael Friedrich 1f9a719712 Fix output formatting in troubleshoot cli command
refs #3446
2015-03-02 14:37:58 +01:00
Michael Friedrich dd5ca24210 Fix compiler warnings 2015-03-02 14:10:26 +01:00
Jason Young faf6ce1a5f Update PerfdataValue::Parse to ignore invalid warn, crit, min, and max values
... instead of generating exception so that metric values can
still be passed to the graphing backend.
Also update icinga-perfdata tests to reflect these changes.

refs #5043

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-02 13:52:41 +01:00
Gunnar Beutner 5df3010826 Remove unused variable in PkiUtility::SignCsr 2015-03-02 13:32:08 +01:00
Gunnar Beutner 7aaa6975fc Remove unnecessary SubStr call 2015-03-02 13:30:37 +01:00
Gunnar Beutner 8a062a688b Remove redundant checks 2015-03-02 13:21:06 +01:00
Gunnar Beutner 09038eeb7c Remove unused variable 2015-03-02 13:21:06 +01:00
Jean-Marcel Flach e39896df15 Add more colour to troubleshoot cli 2015-03-02 13:17:49 +01:00
Gunnar Beutner 4d25a2cb22 Implement the assignment operator for the Value class 2015-03-02 12:55:48 +01:00
Gunnar Beutner bb393a9d4f Remove unused variables 2015-03-02 12:52:37 +01:00
Gunnar Beutner 1bcc1a7b92 Fix incorrect operator in Value::operator^ 2015-03-02 12:51:11 +01:00
Gunnar Beutner 79a69d3e89 Fix incorrect header length check in NetString::ReadStringFromStream 2015-03-02 12:47:24 +01:00
Gunnar Beutner 1e9e5edcff Fix incorrect assignment in Logger::EnableConsoleLog 2015-03-02 12:47:24 +01:00
Gunnar Beutner d913089a14 Remove redundant function 2015-03-02 12:47:20 +01:00
Gunnar Beutner 81e821b60c Make copy constructor private for the Log class 2015-03-02 12:42:33 +01:00
Gunnar Beutner b6ca140ee2 Fix incorrect return type for Application::Run 2015-03-02 12:41:44 +01:00
Gunnar Beutner f7ca0c5b52 Fix incorrect format specifier for fprintf 2015-03-02 12:41:44 +01:00
Jean-Marcel Flach 96583857c0 Fix whitespace 2015-03-02 12:35:58 +01:00
Jean-Marcel Flach 68e7de7e59 Work on troubleshoot cli
Changes the format timestamps are displayed.
--include-vars and --include-objects now print to console if --console
is given.
Also fixes two memory leaks.

fixes #8564 #8563
refs 3446
2015-03-02 12:21:34 +01:00
Gunnar Beutner 5968622108 Fix incorrect assignment in PluginUtility::ExecuteCommand
Coverity Bug ID: 1272344
2015-03-02 10:14:15 +01:00
Gunnar Beutner a296147839 Fix uninitialized fields in the StreamLogger class
Coverity Bug ID: 1272329
2015-03-02 10:14:15 +01:00
Gunnar Beutner ce1599fbb3 Fix uninitialized field in the LivestatusScriptFrame class
Coverity Bug ID: 1272326
2015-03-02 10:14:15 +01:00
Gunnar Beutner 8f7599d4b3 Fix uninitialized field in the LivestatusQuery class
Coverity Bug ID: 1272325
2015-03-02 10:14:15 +01:00
Gunnar Beutner 9548692f00 Fix uninitialized field in the Checkable class
Coverity Bug ID: 1272323
2015-03-02 10:14:14 +01:00
Gunnar Beutner 2ee1a197a9 Fix uninitialized field in the ScriptError class
Coverity Bug ID: 1272322
2015-03-02 10:14:14 +01:00
Gunnar Beutner e52a1f38f3 Fix uninitialized field in the ApiListener class
Coverity Bug ID: 1272321
2015-03-02 10:14:14 +01:00
Gunnar Beutner 41cb5977f3 Remove unreachable code
Coverity Bug ID: 1272319
2015-03-02 10:14:14 +01:00
Gunnar Beutner 5b286dae31 Fix leak in SocketEvents::Threadproc
Coverity Bug ID: 1272338
2015-03-02 10:14:14 +01:00
Gunnar Beutner b4be584679 Fix uninitialized fields
Coverity Bug ID: 1272331
2015-03-02 10:14:14 +01:00
Gunnar Beutner f1509d2f10 Fix uninitialized variable in DaemonUtility::ValidateConfigFiles
Coverity bug ID: 1272330
2015-03-02 10:14:14 +01:00
Jean-Marcel Flach ba9cf9e4c2 Add message concerning file compression to troubleshoot cli 2015-03-02 09:35:04 +01:00
Gunnar Beutner 2d65489f3a Make sure the WQ status timer is stopped properly
refs #8550
2015-03-01 22:25:48 +01:00
Gunnar Beutner cd380a8494 Fix another crash in Timer::Call
fixes #8550
2015-02-28 08:43:49 +01:00
Gunnar Beutner 4cc7d4963c Refactor the API timeout timer
refs #8554
2015-02-27 20:18:20 +01:00
Gunnar Beutner d7000fa757 Make sure that the timeout timer gets destroyed properly
refs #8554
2015-02-27 19:54:41 +01:00
Gunnar Beutner 9622b075bc Use the main threadpool to disconnect API clients
refs #8554
2015-02-27 18:32:28 +01:00
Gunnar Beutner 985c6bc7d9 Fix a deadlock in WorkQueue::WorkerThreadProc
refs #8554
2015-02-27 18:32:20 +01:00
Gunnar Beutner 5d1e549063 Fix a crash in Timer::Reschedule
refs #8554
2015-02-27 16:44:33 +01:00
Gunnar Beutner 5eb32efb05 Fix crash in SocketEvents::ThreadProc
fixes #8554
2015-02-27 15:53:38 +01:00
Jean-Marcel Flach 9ed21563ff Use RequestShutdown with exitcode instead of Application::Exit
fixes #8436
2015-02-27 14:43:30 +01:00
Gunnar Beutner 2884e8318d Fix null pointer dereference in ApiClient::TimeoutTimerHandler
fixes #8553
2015-02-27 14:12:50 +01:00
Jean-Marcel Flach 07fd4e6031 Add colours to troubleshoot cli
refs #3446
2015-02-27 14:09:26 +01:00
Gunnar Beutner d397933eff Fix a crash in Timer::Call
fixes #8473
2015-02-27 14:07:12 +01:00
Gunnar Beutner 9567cd663b Fix another potential hang in TlsStream::Handshake
refs #8550
2015-02-27 09:03:23 +01:00
Gunnar Beutner bb2cdff435 Fix a deadlock in ApiClient::Disconnect
fixes #8549
2015-02-26 17:23:06 +01:00
Gunnar Beutner 4e8c5706e1 Don't send heartbeats during log replay
fixes #8461
refs #8485
2015-02-26 14:59:39 +01:00
Gunnar Beutner fd090e057b Implement 'else if'
fixes #8548
2015-02-26 13:51:13 +01:00