Alexander A. Klimov
b4e3736e31
WarnOnImplicitlySetGlobalVar(): warn only on sins inside actual DSL code
2019-09-23 15:09:57 +02:00
Michael Friedrich
3a154516dc
Merge pull request #7503 from Icinga/bugfix/api-ciphers-el6
...
API: Add AES128-GCM-SHA256 compatible cipher for el6
2019-09-16 14:54:57 +02:00
Michael Friedrich
d3eb62301e
API: Add AES128-GCM-SHA256 compatible cipher for el6
...
fixes #7501
2019-09-16 14:19:22 +02:00
Michael Friedrich
9622474d93
Merge pull request #7502 from Icinga/feature/docs-debugger-2-11
...
Docs: Update debugging instructions for 2.11
2019-09-16 10:36:52 +02:00
Michael Friedrich
0c1bfc03ce
Docs: Update debugging instructions for 2.11
2019-09-13 17:05:56 +02:00
Michael Friedrich
358d9517dd
Merge pull request #7496 from waja/docu_fix
...
Docu fix
2019-09-13 08:42:12 +02:00
Jan Wagner
7a49ed4c81
This should also apply if host.vars.notification.mail is not defined, but service.vars.notification.mail is
2019-09-12 17:20:15 +02:00
Jan Wagner
c1aaa10650
mail-service-notification may make more sense for a service apply
2019-09-12 17:18:35 +02:00
Jan Wagner
9ebfd32d2f
Fixing syntax, else if shoudl work
2019-09-12 17:17:48 +02:00
Michael Friedrich
6a059e972a
Merge pull request #7495 from Icinga/bugfix/http-buffer-revert
...
Revert: Always reset Boost beast buffer in HttpServerConnection#ProcessMessages #7476
2019-09-12 17:03:12 +02:00
Michael Friedrich
9ec246a2f4
Revert: Always reset Boost beast buffer in HttpServerConnection#ProcessMessages #7476
...
Not a simple revert but also adds a comment for the buffer.
refs #7476
2019-09-12 17:00:17 +02:00
Michael Friedrich
79358221ad
Merge pull request #7480 from Icinga/feature/docs-windows-dev
...
Dev Docs: Update Windows to Visual Studio 2019
2019-09-12 16:05:32 +02:00
Michael Friedrich
132749161b
Docs: Update Windows for VS 2019, add CI details
2019-09-12 15:49:48 +02:00
Michael Friedrich
195f22f53d
Merge pull request #7491 from Icinga/bugfix/boost-asio-coroutine-exception-wrapper
...
Introduce IoEngine::SpawnCoroutine wrapping asio::spawn and Boost exceptions
2019-09-09 17:48:12 +02:00
Michael Friedrich
e5e9f2526a
Dev: Fix CMake generator platform for VS 2019 in PS scripts
2019-09-09 17:11:26 +02:00
Michael Friedrich
c5e68fb05f
Dev Docs: Update Windows to Visual Studio 2019
2019-09-09 17:11:23 +02:00
Michael Friedrich
2c0e0da2d9
Introduce IoEngine::SpawnCoroutine wrapping asio::spawn and Boost exceptions
...
This is required to
- catch all exceptions and wrap them into Boost exceptions. They
are the only ones allowed with Boost.Coroutine.
- set a dedicated coroutine stack size for Windows.
refs #7431
2019-09-09 16:40:35 +02:00
Michael Friedrich
0dbbba44dd
Merge pull request #7490 from Icinga/bugfix/asio-deprecated-io-service
...
Quality: Replace deprecated Boost IO service code
2019-09-09 16:05:38 +02:00
Michael Friedrich
5fa7331cc9
Quality: Replace deprecated Boost IO service code
...
https://github.com/boostorg/asio/issues/110
https://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/example/cpp03/services/logger_service.hpp
2019-09-09 15:27:57 +02:00
Michael Friedrich
9e16502581
Merge pull request #7487 from Icinga/bugfix/http-api-shutdown-avoid-io
...
API: Avoid I/O on shutdown
2019-09-09 14:21:24 +02:00
Alexander A. Klimov
0a9563b3db
HttpServerConnection#ProcessMessages(): avoid I/O if shutting down
...
refs #7431
2019-09-09 13:37:44 +02:00
Alexander A. Klimov
b85b8b9697
HttpServerConnection#ProcessMessages(): avoid I/O after boost::asio::error::operation_aborted
...
refs #7431
2019-09-09 13:29:47 +02:00
Alexander A. Klimov
dfaeb88ac3
{HttpServer,JsonRpc}Connection#Disconnect(): cancel I/O ops ASAP
...
refs #7431
2019-09-09 13:11:51 +02:00
Michael Friedrich
b3c48e7520
Merge pull request #7485 from Icinga/bugfix/api-disconnect-defer
...
Avoid the Defer-Disconnect destructor pattern with Boost.Coroutines
2019-09-09 11:41:34 +02:00
Michael Friedrich
613925813f
Merge pull request #7486 from Icinga/bugfix/http-header-error-handling
...
Rewrite error handling in HttpServerConnection#EnsureValidHeaders()
2019-09-09 11:40:44 +02:00
Michael Friedrich
c5aa978912
Rewrite error handling in HttpServerConnection#EnsureValidHeaders()
...
Throwing local exceptions unnecessarily pollutes the exception
stack with immediate unwinding. Avoid this pattern at all cost within
Boost.Coroutines. MSVC may handle exceptions differently and cause
problems with stack unwinding.
refs #7431
refs #7351
2019-09-09 11:03:21 +02:00
Michael Friedrich
17d4d17307
Avoid the Defer-Disconnect destructor pattern with Boost.Coroutines
...
Exceptions in Disconnect() might be thrown (this has been reworked
into error_code locally) which are swallowed inside the Destructor
for being dangerous. On the other hand, swallowing them may
corrupt the stack unwinding operation from the coroutine layer.
The best is to avoid Defer inside lib/remote and call Disconnect()
directly after breaking from other operations.
refs #7351
refs #7431
2019-09-09 10:57:13 +02:00
Michael Friedrich
5aa5ab956d
Merge pull request #7483 from Icinga/bugfix/jsonrpc-boost-asio-coroutine-exceptions
...
JsonRpcConnection: Don't swallow exceptions in Boost.Coroutine
2019-09-09 10:21:21 +02:00
Michael Friedrich
fbee705105
Merge pull request #7481 from Icinga/feature/check-network-perfdata
...
Add summarized performance data to check_network
2019-09-09 09:47:37 +02:00
Michael Friedrich
ebb0826be0
JsonRpcConnection: Don't swallow exceptions in Boost.Coroutine
...
refs #7351
2019-09-09 09:26:12 +02:00
Michael Insel
1bd91b0998
Add summarized performance data to check_network
...
This adds two new performance data values to check_network, 'network_in'
and 'network_out'.
On systems with multiple network interfaces the 'network_in' value holds
the summarized input bytes and the 'network_out' value holds the
summarized output bytes.
2019-09-06 20:46:32 +02:00
Michael Friedrich
897b81d461
Merge pull request #7479 from Icinga/feature/windows-dev
...
Build: Add Powershell script for development config for building Windows debug packages
2019-09-06 12:52:47 +02:00
Michael Friedrich
2178e150f9
Build: Add Powershell script for development config for building Windows debug packages
2019-09-06 10:51:06 +02:00
Michael Friedrich
cdacd545c6
Merge pull request #7477 from Icinga/bugfix/api-boost-exceptions-errors
...
HttpServerConnection: Prefer error codes over Boost exceptions
2019-09-06 10:22:42 +02:00
Michael Friedrich
a208f7baf0
HttpServerConnection: Prefer error codes over Boost exceptions
...
When run within a coroutine, exceptions on Windows may influence
bad behaviour here. Instead, we'll check for the error code
and extract the message from memory. In contrast to exceptions
which are stored on the stack frame and then return, this costs
a little more memory but simplifies the logic.
This doesn't fix the linked issue, but is related to the analysis.
refs #7431
2019-09-06 10:06:17 +02:00
Michael Friedrich
4a005c5d46
Merge pull request #7476 from Icinga/bugfix/api-beast-buffer
...
Always reset Boost beast buffer in HttpServerConnection#ProcessMessages
2019-09-06 09:56:29 +02:00
Michael Friedrich
eabba2de42
Always reset Boost beast buffer in HttpServerConnection#ProcessMessages
...
refs #7431
2019-09-06 09:31:16 +02:00
Michael Friedrich
1f50a705f9
Adjust code comment for Logger->Flush() on Windows
2019-09-06 09:24:34 +02:00
Michael Friedrich
2cf38ba8ce
Ensure that issue templates are more readable
2019-09-02 15:10:35 +02:00
Michael Friedrich
52af379839
Merge pull request #7467 from Icinga/feature/docs-development-2-11
...
Docs: Update Linux and Windows Dev instructions for 2.11
2019-09-02 09:36:47 +02:00
Michael Friedrich
cf8a49bc78
Docs: Update dev chapter for Debian Buster
2019-09-02 09:20:56 +02:00
Michael Friedrich
e4341a5bdc
Docs: Update Boost setup instructions for Windows dev environment
2019-09-01 11:08:15 +02:00
Michael Friedrich
426c26f6cb
Merge pull request #7464 from Icinga/feature/docs-windows-agent-versions
...
Docs: Update supported Windows agent versions
2019-08-30 16:37:09 +02:00
Michael Friedrich
74ab3192a0
Docs: Sync Vagrant box dev instructions with development docs
2019-08-30 15:18:27 +02:00
Michael Friedrich
22243c10e0
Merge pull request #7463 from Icinga/feature/docs-powershell
...
Docs: Prefer the Powershell commands on Windows
2019-08-30 14:21:19 +02:00
Michael Friedrich
ce9f5a9e2b
Docs: Update supported Windows agent versions
2019-08-30 14:15:08 +02:00
Michael Friedrich
e56de3f55f
Docs: Add Windows debugging
2019-08-30 14:04:40 +02:00
Michael Friedrich
7f28718cad
Docs: Prefer the Powershell commands on Windows
2019-08-30 14:04:05 +02:00
Michael Friedrich
8a07b64800
Merge pull request #7459 from Icinga/feature/expose-problem-handled-counts
...
Metrics: Expose problem/handled counts for hosts/services
2019-08-30 09:04:03 +02:00
Michael Friedrich
55d7da30ca
Metrics: Expose problem/handled counts for hosts/services
...
With the addition of problem/handled as checkable runtime
attributes in #7096 we should also expose them via CIB
into
- icinga check
- /v1/status/CIB
- IcingaApplication runtime macros
This originates from a request by @phil-or at the recent
Icinga meetup in Linz.
2019-08-29 17:04:23 +02:00