tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-24 14:24:41 +02:00
Code Issues Packages Projects Releases Wiki Activity
2,903 Commits 126 Branches 76 Tags
Commit Graph

2903 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Eric Lippmann
4ca1eaa7ce Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 
Conflicts:
	library/Icinga/Web/Form.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-28 13:58:02 +02:00
Johannes Meyer
6783d51f76 A form is "submitted" when it was "sent" but no submit label was set 
This enables us to use handleRequest() as is when no specific submit button
is required.

refs #5525
 2014-08-27 10:28:50 +02:00
Johannes Meyer
0ff79b0948 Replace Form::onFailure() with Form::onShow() 
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.

refs #5525
 2014-08-27 10:25:50 +02:00
Johannes Meyer
d3c2fc858c Access formdata internally using a public helper method 
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.

refs #5525
 2014-08-27 10:19:33 +02:00
Johannes Meyer
65dd3f9a5b Make the form in view scripts accessible using $form instead of $element 
refs #5525
 2014-08-27 10:10:55 +02:00
Johannes Meyer
98b2bce15e Icinga\Web\Form::onSuccess() must not return TRUE 
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.

refs #5525
 2014-08-27 10:09:29 +02:00
Eric Lippmann
6b88f1c98e Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module 
refs #6593
 2014-08-26 16:35:30 +02:00
Johannes Meyer
45cbd3f067 We do not require the request being passed to handleRequest() 
refs #5525
 2014-08-26 12:31:05 +02:00
Johannes Meyer
5c7999fe9b Forms should be responsible for any redirection as well 
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.

refs #5525
 2014-08-26 12:30:37 +02:00
Alexander Fuhr
3a85a45ef2 Fix preferences directory dependency in vagrant provision manifests default.pp 2014-08-26 12:08:55 +02:00
Alexander Fuhr
c8643ab02e Add preferences directory to vagrant provision default.pp 2014-08-26 11:48:27 +02:00
Alexander Klimov
aec66570d6 Merge branch 'bugfix/exceptions-with-printf-params-6931' 
fixes #6931
 2014-08-26 11:25:51 +02:00
Alexander Klimov
1f7d4cb61b Merge branch 'master' into bugfix/exceptions-with-printf-params-6931 2014-08-26 11:24:33 +02:00
Alexander Klimov
a2011b1665 SystemPermissionException: extend IcingaException 
refs #6931
 2014-08-26 11:21:57 +02:00
Alexander Klimov
febb2d1ae2 ProgrammingError: extend IcingaException 
refs #6931
 2014-08-26 11:15:19 +02:00
Alexander Fuhr
d8bbd7a0a0 Merge branch 'bugfix/modules-dashlet-provider-6639' 
fixes #6639
 2014-08-26 10:57:37 +02:00
Alexander Klimov
4ec6dbe3f0 Prefer single quotes ' rather than double quotes " 2014-08-26 10:41:17 +02:00
Alexander Fuhr
42e2b34356 Implement self provided configuration for dashboard/dashlets in modules 
refs #6639
 2014-08-26 10:34:36 +02:00
Alexander Fuhr
bae5ba2352 Add self provided configuration for dashlets in monitoring module 
refs #6639
 2014-08-26 10:34:35 +02:00
Alexander Fuhr
af0cf48197 Add self provided configuration for dashlets 
refs #6639
 2014-08-26 10:34:35 +02:00
Alexander Fuhr
11127446e0 Update description if no dashlets available 
refs #6639
 2014-08-26 10:34:34 +02:00
Alexander Fuhr
b60c3590b0 Deactivate addUrl to Dashboard 
refs #6639
 2014-08-26 10:34:34 +02:00
Alexander Fuhr
7d25efb93c Remove dashboard.ini related parts 
refs #6639
 2014-08-26 10:34:33 +02:00
Alexander Klimov
f754531e4d Fix grammatical error 2014-08-26 10:22:14 +02:00
Johannes Meyer
52534a2f46 It is a form's responsibility to process the request it was submitted with 
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)

refs #5525
 2014-08-25 17:06:45 +02:00
Johannes Meyer
c93ab7951d Check whether a form's data was sent instead of whether it's complete 
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.

refs #5525
 2014-08-25 16:49:54 +02:00
Alexander Klimov
7074fa1331 NotWritableError: extend IcingaException 
refs #6931
 2014-08-25 12:56:35 +02:00
Alexander Klimov
6c9947326d NotReadableError: extend IcingaException 
refs #6931
 2014-08-25 12:38:34 +02:00
Alexander Klimov
f4dbb4df96 NotImplementedError: extend IcingaException 
refs #6931
 2014-08-25 12:21:59 +02:00
Alexander Klimov
013aad8f73 MissingParameterException: extend IcingaException 
refs #6931
 2014-08-25 12:14:18 +02:00
Thomas Gelf
70fe22dfad monitoring/tactical: fix missing translations 2014-08-22 18:08:20 +02:00
Thomas Gelf
5c46355474 translation: refresh de_DE 2014-08-22 17:58:53 +02:00
Thomas Gelf
c31972b99c translation: refresh monitoring module 2014-08-22 17:26:20 +02:00
Johannes Meyer
7b221e2aba It should not be a form's responsibility how its submit button should look.. 
...in case it's a standard button. No need to be DRY here.

refs #5525
 2014-08-22 15:20:54 +02:00
Johannes Meyer
403f745488 Remove obsolete loggingAction 
refs #6933
 2014-08-22 12:34:33 +02:00
Johannes Meyer
5028ec7b0b Avoid NIH 
It's useless to have specific getters and setters if generic methods from the
baseclass can be used as well to accomplish the same task.

refs #6641
 2014-08-22 12:30:13 +02:00
Johannes Meyer
a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer
75a0c17933 Ensure that all forms have a name 
refs #5525
 2014-08-22 12:15:02 +02:00
Johannes Meyer
2b879b344f Do not populate using createElements() and fix documentation blocks 
refs #5525
 2014-08-22 12:04:14 +02:00
Alexander Fuhr
a5373a6e9e Merge branch 'bugfix/modules-menu-provider-6639' 
refs #6639
 2014-08-22 11:46:43 +02:00
Alexander Klimov
9c5878cbbe ConfigurationError: extend IcingaException 
refs #6931
 2014-08-22 11:46:11 +02:00
Alexander Fuhr
20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
Alexander Fuhr
aba5b1c80d Remove menu.ini from icingaweb2.spec 
refs #6639
 2014-08-22 11:40:20 +02:00
Alexander Fuhr
1886569174 Implement Module self provided configuration for menus 
refs #6639
 2014-08-22 11:35:42 +02:00
tgelf
da821fd952 list/hosts: add missing host_attempt column 2014-08-22 05:23:45 -04:00
Alexander Fuhr
f757f69bd1 Change Menu load from config ini files to self provided configuration 
refs #6639
 2014-08-22 11:10:17 +02:00
Alexander Fuhr
7e0047d00e Add Menu configuration in Monitoring Module 
refs #6639
 2014-08-22 11:07:49 +02:00
Thomas Gelf
49cd55eddd list/hosts: cleanup, should look like list/services 
Quite some changes here:

* Compact view should show icons too
* Ignore host icons with legacy HTML hacks
* Remove duplicate code
* Reduce HTML
* Reduce intendation for better readability
* Show attempts on soft states only, even in compact view
* Use the same HTML tags and styles as in list/services
* Fixes nesting error on compact view
 2014-08-22 11:06:45 +02:00
Johannes Meyer
bc05d2ee64 Merge LoggingForm into GeneralForm 
fixes #6933
 2014-08-22 11:05:20 +02:00
Alexander Fuhr
968fa0a1cc Add configuration.php to Doc Module 
refs #6639
 2014-08-22 11:02:08 +02:00