Commit Graph

4475 Commits

Author SHA1 Message Date
Johannes Meyer 4da687ae27 monitoring/list/hostgroups: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer d5fbae7b28 monitoring/list/downtimes: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 122d52c953 monitoring/list/contacts: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 298f2a3061 monitoring/list/comments: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 8779f9f175 IdoQuery: Join customvars with only live references 2022-02-28 13:08:05 +01:00
Johannes Meyer 1092421782 Ido\Query\: Add objecttype_id checks where missing 2022-02-28 13:07:17 +01:00
Johannes Meyer 00353a1f25
Merge pull request #4660 from Icinga/fix/unhandled-service-counter-not-always-visible-3921
Drop the unhandled services counter in host lists
2022-02-28 13:05:29 +01:00
Johannes Meyer e7bc0a136b Perfdata: Render unknown UOMs as-is 2022-02-28 11:53:59 +01:00
Johannes Meyer 796742f03d monitoring/list/hosts: Don't show unhandled service counts
It has too much problems. It wasn't even visible since the
initial release, at least not if there were many results.
It being visible was more a case of chance than guarantee.
We now also identified a major issue with restrictions and
the way we can assemble queries here. In short, there are
too much technical difficulties that we deemed it not
worthwhile to keep.
2022-02-25 17:09:13 +01:00
Johannes Meyer 2e9a94144f HostserviceproblemsummaryQuery: Don't clear order of the host status query 2022-02-25 17:08:39 +01:00
Johannes Meyer a4d34e265f IdoQuery: Don't try to add a `HAVING` without group by rules 2022-02-11 12:11:40 +01:00
Johannes Meyer 7a938f6b02 css: Don't use `.var()` or `var()` calls explicitly 2022-02-10 10:59:01 +01:00
Johannes Meyer 3166d112f1 monitoring/list/hosts: Apply restrictions to host service problem summary 2022-02-07 17:20:41 +01:00
Johannes Meyer 28a8771a37 components/comments.phtml: Use base target `_next` only for comment links 2022-02-07 14:47:03 +01:00
Johannes Meyer 4f501a89f5 monitoring: Avoid duplicate ids for check now and remove ack forms 2022-02-04 17:21:41 +01:00
Johannes Meyer 56cde52351 Drop locales of builtin modules 2022-02-04 15:58:06 +01:00
Johannes Meyer 6b4f4d388a monitoring: Really show custom variable names as-is 2022-02-04 15:56:44 +01:00
Johannes Meyer 316885b271
Merge pull request #4498 from Icinga/bugfix/tactical-4494
/monitoring/tactical: fall back to unknown services if none critical
2021-12-14 10:24:57 +01:00
Sukhwinder Dhillon c30df56de4 Release version 2.9.5 2021-11-17 16:51:55 +01:00
Johannes Meyer 81f6116f3f Release version 2.9.4 2021-11-10 10:17:35 +01:00
Johannes Meyer 47922673fc PluginOutput: Don't "optimize" two subsequent newlines to one
fixes #4522
2021-11-02 09:00:21 +01:00
Ravi Kumar Kempapura Srinivasa be3a722a28 Compress comment detail in Hosts detail and Comments list. 2021-10-07 10:44:10 +02:00
Alexander A. Klimov 6e1ab2c0ea /monitoring/tactical: fall back to unknown services if none critical
refs #4494
2021-09-23 15:17:33 +02:00
Johannes Meyer 83557afd35 IdoQuery: Qualify and resolve subquery filters ASAP
fixes #4508
2021-08-24 09:32:36 +02:00
Johannes Meyer b2274a5589 Release version 2.9.3 2021-08-10 10:11:44 +02:00
Eric Lippmann 1e1b4b74ad If appropriate, set the API parameter all_services for schedule-downtime
Since Icinga 2.11.0 the schedule-downtime API supports the
all_services parameter. So far we've always sent a separate
request for scheduling service downtimes. As of Icinga 2.13.0,
these service downtimes are automatically removed when the host
downtimes are removed. Of course, this doesn't work if we don't
use the all_services parameter but send a separate request.
With this commit we set this parameter if the transport is API
and Icinga is equal to or greater than 2.11.0.

In addition, if child_options and all_services were previously set,
a request was sent per host and service. This is now also only a
single request if an API command transport is requested or only
API command transports are configured.
2021-08-09 16:55:05 +02:00
Johannes Meyer 907f7826b2 Release version 2.9.2 2021-07-28 09:33:41 +02:00
Johannes Meyer 1b2cd8fdf3 Release version 2.9.1 2021-07-27 15:22:32 +02:00
Johannes Meyer b94617c575 ServicestatusQuery: Define correct grouping rules for contacts and -groups
fixes #4464
2021-07-21 17:41:55 +02:00
Johannes Meyer d123b390b1 MonitoredObject: Keep structure of nested cvs during protection
fixes #4439
2021-07-21 08:01:08 +02:00
Johannes Meyer f73614be4d Raise version to 2.9.0 2021-07-12 10:35:56 +02:00
Johannes Meyer 9c1e4fa491 monitoring: Ensure cvs are also protected in exported results 2021-07-12 09:42:03 +02:00
Johannes Meyer b48fc20edf monitoring/list/(hosts|services): Respect cv blacklist with `?addColumns` 2021-07-12 09:42:03 +02:00
Johannes Meyer e035f5b9f2 monitoring/list/services: Protect custom variables added with `?addColumns` 2021-07-12 09:42:03 +02:00
Johannes Meyer c953e4f92d monitoring/list/hosts: Protect custom variables added with `?addColumns` 2021-07-12 09:42:03 +02:00
Johannes Meyer 1dc6f35916 MonitoredObject: Make customvar protection available to the outside 2021-07-12 09:42:03 +02:00
Johannes Meyer 76dafc8c1e monitoring/list/*: Don't apply restrictions in case of `?format=sql` 2021-07-08 08:14:13 +02:00
Johannes Meyer 963fdbd3e2 ServicegroupQuery: Join hostgroups with a LEFT JOIN
refs #4404
2021-07-05 14:59:24 +02:00
Johannes Meyer 13125e8059 HostgroupQuery: Join services and servicegroups with a LEFT JOIN
refs #4404
2021-07-05 14:58:49 +02:00
Johannes Meyer 37c982a044 MonitoringWizard: Remove redundant requirements and steps 2021-06-30 18:54:47 +02:00
Johannes Meyer b88dad9525 css: Respect `--icinga-*` 2021-06-28 16:22:19 +02:00
Johannes Meyer 6c235c64b5 css: Respect `--tr-*-color` 2021-06-28 14:12:58 +02:00
Johannes Meyer 804fe75d55 css: Respect `--color-*` 2021-06-28 12:37:30 +02:00
Johannes Meyer e3dbd01e86 css: Respect `--text-color-light` 2021-06-23 17:40:06 +02:00
Johannes Meyer ac45a51ffb css: Respect `--text-color-inverted` 2021-06-23 17:40:06 +02:00
Johannes Meyer 49f905af06 Integrate light theme's `gray-lighter` using a media query 2021-06-23 17:40:06 +02:00
Johannes Meyer b7f42e52dc Integrate light theme's `gray-light` using a media query 2021-06-23 17:40:06 +02:00
Johannes Meyer d82577c0e0 Integrate light theme's `gray` using a media query 2021-06-23 17:40:06 +02:00
Johannes Meyer 039fdfc8af Integrate light theme's `@text-color` using a media query 2021-06-23 17:40:06 +02:00
Johannes Meyer 96687e37c6 Integrate light theme's `@body-bg-color` using a media query 2021-06-23 17:40:06 +02:00
Florian Strohmaier e5cf4cdd17 CSS: Match `.object-features` label color with `th`s 2021-06-23 07:39:55 +02:00
Florian Strohmaier ac1a364682 Contact: Fix th styles 2021-06-23 07:39:55 +02:00
Florian Strohmaier 034697abf9 module.less: Remove monitorung-statusbar gradient 2021-06-23 07:39:55 +02:00
Ravi Kumar Kempapura Srinivasa f8b122b894 Add end time and comment options to settings section for host/service downtime dialog
[hostdowntime_end_fixed], [hostdowntime_end_flexible], [hostdowntime_flexible_duration], [servicedowntime_end_fixed], [servicedwontime_end_flexible],
[servicedowntime_flexible_duration] and [comment_text] options added to [settings] section in config.ini file used in  host/service downtime dialog.
2021-06-18 13:57:58 +02:00
Johannes Meyer 84949f214e monitoring: Provide health hook 2021-05-14 15:45:35 +02:00
Damiano Chini 89fdccb858 Pass event instead of object to the getHtmlForEvent method of EventDetailsExtensionHook 2021-05-11 12:36:07 +02:00
Johannes Meyer 4e48f9d2a1 ProcessCheckResultForm: Skip objects with passive checks disabled
Icinga won't accept check results for such.
2021-04-14 10:56:04 +02:00
Johannes Meyer 1a5cedfee1 setup: Skip browser validation when validating a form manually
fixes #4291
2021-04-13 16:57:03 +02:00
Johannes Meyer a4d495e17c PerfData: Don't render missing values as `0.00` 2021-04-13 14:50:18 +02:00
Johannes Meyer e671324ddb tests: Don't use deprecated assertion `assertRegExp()` 2021-04-09 12:38:43 +02:00
Johannes Meyer f27e872d90 tests: Don't make use of deprecated phpunit features 2021-04-09 12:38:43 +02:00
Johannes Meyer cb87190138 tests: Add `:void` return type declarations 2021-04-09 12:38:43 +02:00
Alexander A. Klimov 6d5024c671 *downtimestarthistoryQuery#joinBaseTables(): don't call func_get_arg() with an invalid index
... as PHP 8 doesn't tolerate that.

refs #4287
2021-04-09 12:37:03 +02:00
Johannes Meyer fe51f8c968 IdoQuery: Accept any character in custom var names
fixes #4342
2021-04-06 10:47:03 +02:00
Johannes Meyer 0fc06d7795 Transform `*` equal/unequal comparisons to NULL checks
This comes from https://github.com/Icinga/ipl-sql/pull/31
2021-03-12 09:50:59 +01:00
Johannes Meyer 91d4669dcb
Merge pull request #4285 from Icinga/bugfix/curl-monitoring-service-show-4281
CheckNowCommandForm#init(): set submit label
2021-02-18 12:21:50 +01:00
Johannes Meyer cc65164a67 Adjust global permissions 2021-02-18 11:11:39 +01:00
Johannes Meyer e01f51ffc7 PluginOutput: Fix that subsequent escaped newlines are not transformed
fixes #4297
2021-02-15 11:23:36 +01:00
Johannes Meyer 77ca3e0c31 DeleteDowntimeCommandForm: Show error notification if not successful
resolves #4303
2021-02-03 15:42:13 +01:00
Alexander A. Klimov 6af1e5d43b Monitoring: add expire option for comments
refs #3447
2020-11-30 17:24:57 +01:00
Alexander A. Klimov 7aacbd4db8 CheckNowCommandForm#init(): set submit label
... otherwise Form#handleRequest() bypasses Form#isSubmitted()
on API requests and considers the CheckNowCommandForm submitted.

refs #4281
2020-11-26 18:38:55 +01:00
Rick Henry 92ef10c22b Add notification badges for disabled active checks
We mistakenly disabled active checks in our Icinga environment and did
not notice for some time. This commit hooks into the badge mechanic used
when notifications are turned off, and also provides badges when active
host checks and active service checks are disabled.
2020-11-22 21:18:08 +00:00
Johannes Meyer d918d6c86f
Merge pull request #4235 from Icinga/fix/sparkline-js-performance
Drop sparkline.js and render inline-pies as SVG
2020-11-18 09:37:31 +01:00
Jorge Vallecillo 865e4b9b2a Fix typos: consecutive use of 'the' 2020-11-18 09:26:39 +01:00
Johannes Meyer c1bb17709a Navigation\Action: Don't try to resolve non existing urls
fixes #4211
2020-11-16 13:21:16 +01:00
Johannes Meyer b01bd74d5c ServicestatusQuery: Join contactgroups with the correct type id 2020-11-16 13:18:28 +01:00
Johannes Meyer 459e61ba55 ServicegroupQuery: Join contactgroups with the correct type id 2020-11-16 13:18:28 +01:00
Johannes Meyer fbacd3db36 list/services: Avoid duplicates when filtering contact(group)s
fixes #4238
2020-11-16 13:17:32 +01:00
Eric Lippmann d42c912ea4 Use ticket hook in downtime details 2020-09-30 09:32:18 +02:00
Eric Lippmann 5243160d5d Add Comment to comment details and use ticket hook 2020-09-30 09:32:18 +02:00
Eric Lippmann 7f48040637 Load ticket hook for downtime details 2020-09-30 09:32:12 +02:00
Eric Lippmann 1aad3152d0 Load ticket hook for comment details 2020-09-30 09:32:02 +02:00
Eric Lippmann 893617ef96 Load ticket hook for event details 2020-09-30 09:31:49 +02:00
Johannes Meyer 8c73f0462e InlinePie: Utilize SVG to render charts instantly
Inline pie charts usually don't contain that much
data and the SVG should be rather small in size.
So it doesn't hurt rendering them instantly.
2020-09-28 16:40:39 +02:00
Johannes Meyer 77244b2c1b Raise version to v2.8.2 2020-08-19 11:03:31 +02:00
Johannes Meyer 0db4dc0311 IdoQuery: Force array cast when lowering subquery filter expressions
fixes #4196
2020-07-06 08:34:40 +02:00
Johannes Meyer c3d329bd48 Raise version to 2.8.1 2020-06-29 10:30:58 +02:00
Alexander A. Klimov 361fc27922 /monitoring/tactical: don't show negative amounts of monitored objects
refs #4174
2020-06-18 08:52:53 +02:00
Massimiliano Torromeo 9a29d8f3d4 Set default db charset for MySQL ido resources to latin1
latin1 seems to be the only supported charset for MySQL but the current upstream default charset is utf8mb4 and to be safe it should be set explicitly
2020-06-17 13:27:31 +02:00
Johannes Meyer 4505e29ce3 IdoQuery: Lowercase subquery ci filters on postgres
fixes #4178
2020-06-16 09:59:19 +02:00
Johannes Meyer e95fac3ff1 Raise version to 2.8.0 2020-06-08 10:51:35 +02:00
Johannes Meyer a240e306ed Preserve/Remove param `showCompact` instead of `view` 2020-06-04 08:50:41 +02:00
Johannes Meyer f6edad9336 Transmit the user who clears an acknowledgement 2020-05-14 13:58:19 +02:00
Johannes Meyer 08bc671fb7 Transmit the user who cancels a downtime 2020-05-14 13:58:03 +02:00
Johannes Meyer 287edb7932 Transmit the user who deletes a comment 2020-05-14 13:57:22 +02:00
Johannes Meyer a2009913c9 WithCommentCommand: Utilize `CommandAuthor` 2020-05-14 13:51:21 +02:00
Johannes Meyer b4e7d80807 Introduce trait `CommandAuthor` 2020-05-14 13:50:48 +02:00
Johannes Meyer 4aab354b7f PluginOutput: Adjust html detection regex again 2020-05-13 17:16:22 +02:00
Johannes Meyer 5d603cd026 Macro: Also resolve `service.name` to `service_description`
resolves #4000
2020-05-13 15:32:44 +02:00
Johannes Meyer 87e676e1fb customvars.phtml: Show a customvar name as-is
Don't uppercase first, exchange `_` for spaces and lower everything else

resolves #3987
2020-05-13 14:56:58 +02:00
Thomas Gelf bdea1bfd47 Query\*notificationQuery: add missing host_alias
Fixes an Exception when searching for a specific alias (as offered in
the filter form)
2020-05-04 12:26:49 +02:00
Johannes Meyer 6a4b07a0f7 Remove `required => true` from skip validation switches 2020-04-20 14:44:35 +02:00
Johannes Meyer a087089025 monitoring: Update module description in module.info 2020-04-20 11:16:10 +02:00
Johannes Meyer abef0621ff forms: Remove `required => true` from force creation checkboxes 2020-04-20 09:04:04 +02:00
Johannes Meyer 5ace00ed0b list/servicegrid: Make problems only work in no-js envs 2020-04-15 09:42:36 +02:00
Johannes Meyer 9c2f6f4fd7
Merge pull request #4008 from Al2Klimov/bugfix/checkbox-required
Form: allow checkboxes to be required
2020-04-09 16:05:42 +02:00
Johannes Meyer dfda22017b TacticalController: Subtract not checked count from pending count
Pending counts include not checked objects as well

fixes #3280
2020-04-09 16:04:36 +02:00
Johannes Meyer e01852f34b Update `required` attribute of all forms
Some were missing it, some were adding it unnecessarily.
Since it's now displayed what's required this needed to
be streamlined.
2020-04-09 14:39:52 +02:00
Feu Mourek d7a8765fc9 Add appropriate aria labels to tactical overview 2020-04-09 08:36:29 +02:00
Johannes Meyer d72bdc2c32 Raise version to 2.8.0-rc1 2020-03-13 10:40:35 +01:00
Johannes Meyer 13a329ba20 Update po files of all available locales 2020-03-13 10:40:35 +01:00
Johannes Meyer cd738e858c Update de_DE translations
fixes #3994
2020-03-13 10:40:35 +01:00
Johannes Meyer 201e2f136d ScheduleServiceCheckCommandForm: Only ignore services if rescheduling is restricted 2020-01-31 16:07:56 +01:00
Johannes Meyer 6d6e235e5c ScheduleHostCheckCommandForm: Only ignore hosts if rescheduling is restricted 2020-01-31 16:07:56 +01:00
Johannes Meyer b555c4bd8b
Merge pull request #4047 from Icinga/fix/firefox-layout-issues
Fix Firefox layout issues
2020-01-16 16:05:44 +01:00
Eric Lippmann 154357aa11 DeleteDowntimesCommandForm: Allow iterable for setDowntimes()
The command form loops over the downtimes to delete. It is not necessary
to expect an array here. The Icinga DB web module passes an iterable
here.
2020-01-14 14:36:50 +01:00
Eric Lippmann 9ddd941b42 DeleteCommentsCommandForm: Allow iterable for setComments()
The command form loops over the comments to delete. It is not necessary
to expect an array here. The Icinga DB web module passes an iterable
here.
2020-01-14 14:30:50 +01:00
Johannes Meyer 82733f321e css: Fix collapsed border spacing in FF in list views
fixes #4043
2020-01-13 16:01:50 +01:00
Valentina Da Rold 48fb288206 Add EventDetailsExtensionHook and include it into EventController 2020-01-13 09:33:24 +01:00
Johannes Meyer d79feca63f
Merge pull request #3969 from WuerthPhoenix/custom-tab-hook
Add custom tab hook
2019-12-12 15:55:25 +01:00
Johannes Meyer 7417349cec
Merge pull request #4025 from papillon326/master
Update Japanese translation
2019-12-12 14:00:38 +01:00
Florian Strohmaier e1c47a8f59 module.less: Fix status-bar height 2019-12-11 11:14:34 +01:00
Johannes Meyer da5704fa83
Revert "Introduce option to hide specific customvars in web" 2019-12-10 07:56:11 +01:00
papillon326 be5a6a4251 Update Japanese translation 2019-12-09 18:15:20 +09:00
Johannes Meyer 33cb90b0e3 monitoring: Also consider normal acknowledgements for acke`d problems 2019-12-09 08:42:13 +01:00
Florian Strohmaier 8ebc04f2c1 Monitoring: Beautify quick-action item hover 2019-12-06 15:36:34 +01:00
Florian Strohmaier 955ab298f7 CSS: Flex layout to container contents 2019-12-06 15:36:34 +01:00
Florian Strohmaier 098898eca6 Services/Hosts: Remove status-bar-ghost 2019-12-06 15:36:34 +01:00
Johannes Meyer a6d2590666 hosts/services: Remove `*_active_checks_enabled` from a redirect's filter
Actually only a quick fix but who cares..
2019-12-05 15:42:47 +01:00
Johannes Meyer bb7f1cd24b monitoring: Apply permission `no-monitoring/contacts` where applicable 2019-12-05 08:50:51 +01:00
Johannes Meyer a9d5f2a6f0 monitoring: Provide new permission `no-monitoring/contacts` 2019-12-05 08:50:14 +01:00
Nicolai Buchwitz e7f965e70c fix sytax error (missing space after comma) 2019-12-04 13:06:26 +01:00
Nicolai Buchwitz 55104cba14 Introduce hide customvar option in monitoring view 2019-12-04 13:06:26 +01:00
Johannes Meyer 7b488d7f93 swag: Fix violations of PSR-12
PSR-2 has been deprecated and phpcs v3.5.3
now checks for the successor PSR-12
2019-12-04 11:28:08 +01:00
Feu Mourek 57f966734a Perfdata: add function to get perfdata unit 2019-11-04 11:36:57 +01:00
Johannes Meyer e0be21f655 Raise version to 2.7.3 2019-10-18 07:41:53 +02:00
Johannes Meyer ded92c786a Add missing columns to empty group queries 2019-10-18 07:32:58 +02:00
Johannes Meyer 8e51518e96 ServicegroupQuery: Really join hosts if instructed to do so
fixes #3983
2019-10-17 16:14:28 +02:00
Johannes Meyer 362c30c1dd Raise version to 2.7.2 2019-10-16 08:12:09 +02:00
Johannes Meyer 01bcf980f2
Merge pull request #3965 from Icinga/fix/slow-queries-when-filtering-groups-3928
Enhance query performance when filtering for groups and reduce double query execution
2019-10-16 08:05:30 +02:00
Johannes Meyer bb2673a49a EventController: Use `DateFormatter::formatDateTime` to render dates
fixes #3968
2019-10-14 08:12:35 +02:00
Johannes Meyer cbc12ab31e event-history.phtml: Don't use `hasResult()` to check if there are results
28ec1e236 has no result on history views as they never count their results.
So restructuring this particular view script I deemed reasonable since the
history queries tend to show very poor performance.

refs #3905
refs #3836
2019-10-11 10:27:43 +02:00
Johannes Meyer 908c408d3d ServicegroupsummaryQuery: Fetch empty groups with a union query
refs #3928
2019-10-11 10:27:43 +02:00
Johannes Meyer faca6d53c8 HostgroupsummaryQuery: Add empty groups to the union
refs #3928
2019-10-11 10:27:43 +02:00
Johannes Meyer fae60f06bf Revert "Show empty groups with a filter chain too"
This reverts commit fadf12e98a.
2019-10-08 13:39:52 +02:00
Johannes Meyer 0e729bb85b Revert "ServicegroupQuery: Use left joins instead of inner joins"
This reverts commit 23066d2cc4.
2019-10-08 13:39:52 +02:00
Johannes Meyer 94b0689b95 Revert "HostgroupQuery: Use left joins instead of inner joins"
This reverts commit 4ef085bdcd.
2019-10-08 13:39:52 +02:00
Johannes Meyer 25e1942a9b
Merge pull request #3956 from Icinga/bugfix/checks-wrongly-marked-as-late-3696
Fix checks being marked as late when they are scheduled for later time
2019-10-08 13:39:21 +02:00
Johannes Meyer 8ec0c40f21 monitoring: Fix missing load more link when there's a single row 2019-10-08 13:36:35 +02:00
Johannes Meyer c21867699a ServicestatusQuery: Adjust `next_update` calculation to respect `next_check` 2019-10-08 13:21:43 +02:00