tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
14,059 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

1877 Commits

Author SHA1 Message Date
Eric Lippmann 42991b0756 Ensure correct URL for the refresh container button 
Shifted params no longer appear in the URL which is retrieved from the request object.
We now use Url::fromRequest() instead.
 2016-07-13 10:24:30 +02:00
Johannes Meyer 4774db16ef View: Add methods setHelperFunction and dropHelperFunction 2016-07-11 09:08:43 +02:00
Eric Lippmann 97451dae86 Merge branch 'bugfix/remove-large-add-to-menu-tab-11850' 
fixes #11850
 2016-06-02 17:57:51 +02:00
hailthemelody@rm-laptop04 188703cf95 fix various typos 
Signed-off-by: Johannes Meyer <johannes.meyer@netways.de>
 2016-06-02 08:24:05 +02:00
Alexander A. Klimov 50037d8ec9 Tabs: fix wrong parameter for array_splice() 
refs #11850
 2016-05-31 14:47:25 +02:00
Alexander A. Klimov 2179c3aaef FilterEditor: check for a hidden form field instead of the submit button 2016-04-27 15:05:25 +02:00
Alexander A. Klimov 6def061742 FilterEditor: correct submit button name 2016-04-27 12:49:40 +02:00
Alexander A. Klimov 281e6e8163 Revert "Revert "FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed"" 
This reverts commit 45a6259b4c.
 2016-04-27 12:46:48 +02:00
Alexander A. Klimov 45a6259b4c Revert "FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed" 
This reverts commit 61a04e7ba1.
 2016-04-27 12:10:46 +02:00
Marius Hein 6607af61e1 Set dashboard active if it is not disabled 2016-04-26 13:50:02 +02:00
Alexander A. Klimov eecd15ee68 NavigationItem: fall back to the default renderer if an error occurrs 
fixes #10486
 2016-04-25 15:26:08 +02:00
Alexander A. Klimov 242cdab754 DateTimePicker: implement getFormat() 
refs #10847
 2016-04-18 17:19:57 +02:00
Alexander A. Klimov 61a04e7ba1 FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed 
fixes #10848
 2016-04-18 15:15:41 +02:00
Eric Lippmann be7263ebfa Fix that only one default dashboard could be removed 
fixes #11078
 2016-04-13 12:27:25 +02:00
Eric Lippmann 7dbcd27c3c Remove superfluous whitespace 2016-04-13 11:04:54 +02:00
Eric Lippmann 9082a5204e Fix tab order of refresh and close container controls 2016-04-13 11:04:23 +02:00
Florian Strohmaier 0a9c0925cb CSS: Add space before the autosubmit info in forms 2016-04-07 12:46:13 +02:00
Eric Lippmann c7aec8ae64 Respect module stylesheets again when generating the ETag 
fixes #11465
 2016-03-29 11:39:41 +02:00
Markus Frosch 88d973ac39 Restrict access to application log with 'application/log' permission 
fixes #11279
 2016-03-02 20:47:37 +01:00
Eric Lippmann 9c5dfc5207 Merge branch 'bugfix/benchmark-not-always-rendered-10856' 
fixes #10856
 2016-02-27 22:49:44 +01:00
Eric Lippmann 03d7f3a1f4 Ensure trailing slash if cookie path is detected automatically 
Seems like IE (8, 9, ?) has problems w/o the trailing slash and additional directories on the server that start w/ the path.

refs #11187
 2016-02-27 22:42:32 +01:00
Eric Lippmann 5f43ac8f26 Fix path, secure flag and domain of session cookies 
refs #11187
 2016-02-27 22:24:01 +01:00
Eric Lippmann 5f642879c7 Respect cookie domain config in Cookie.php 
refs #11187
 2016-02-27 22:19:37 +01:00
Eric Lippmann 7cef06f981 Disable benchmark only if the layout is disabled 
Benchmark should be disabled if the response is not HTML. This is most likely the case when the layout is disabled.
If Web 2 or Zend sends JSON for example, the layout is disabled.

The follwing code inside an action disables the layout (and view):
$this->_helper->layout()->disableLayout();

The following code inside an action disables the action's view script:
$this->_helper->viewRenderer->setNoRender(true);

Note that an action's view script is also disabled via setNoRender() when rendering another view script via
render() or renderScript().

Another appraoch is to check the content-type. If explicitly set to not HTML, disable benchmark:

$renderBenchmark = true;
$response = $this->getResponse();
$headers = $response->getHeaders();
foreach ($headers as $header) {
    if (strtolower($header['name']) === 'content-type'
        && stristr($header['value'], 'text/html') === false
    ) {
        $renderBenchmark = false;
        break;
    }
}
if ($renderBenchmark) {
    $layout->benchmark = $this->renderBenchmark();
}

Maybe we should also provide a action method for disabling benchmark, regardless of the user's setting.

refs #10856
 2016-02-27 20:14:02 +01:00
Eric Lippmann bf7d082576 Fix PHPDoc of Url::addFilter() 2016-02-27 16:25:04 +01:00
Alexander A. Klimov 5b0730574d Simplify Url::addFilter() 
This changes the rendered resulting Url from x&(y&z) to x&y&z.

refs #10778
 2016-02-27 16:23:09 +01:00
Eric Lippmann 8433bf1fc1 Don't hide the filter editor from the view if the view is compact 
refs #10778
 2016-02-27 15:57:00 +01:00
Eric Lippmann d8b14cb772 Control whether a filter editor should be rendered via setVisible() 
We (may) have situations where a controller or view has to access the filter editor being created via Controller::setupFilterControl().
This is impossible if the view is compact because the filterEditor will be unset. This change introduces FilterEditor::setVisible() for
giving the responsibility of rendering to the filter editor. Controller::setupFilterControl() will be adapted accordingly.

refs #10778
 2016-02-27 15:51:13 +01:00
Alexander A. Klimov b7bdf2e8d4 Implement UrlValidator 2016-02-23 16:34:18 +01:00
Johannes Meyer c7443924bd NavigationItemRenderer: Ignore target for '#' urls 
fixes #11197
 2016-02-22 11:13:23 +01:00
Alexander A. Klimov 9ef78e6856 Fix double escape of `&' in navigation items 
fixes #11190
 2016-02-19 15:38:34 +01:00
Alexander A. Klimov 41a8c75a4f FilterEditor: always escape filter embedded in HTML 2016-02-19 15:22:10 +01:00
Alexander A. Klimov a83ab2c7cb Escape URLs of navigation items while rendering them 
fixes #11091
 2016-02-18 15:01:21 +01:00
Thomas Gelf 97b5800f32 LessCompiler: fix #layout usage in module CSS 2016-02-17 18:26:07 +01:00
Alexander A. Klimov c5281935c6 Regenerate a session ID only if the session exists 
refs #11151
 2016-02-15 11:14:37 +01:00
Alexander A. Klimov 474803fee4 Change all license headers to only reflect a file's year of creation 
refs #11000
 2016-02-08 15:41:00 +01:00
Eric Lippmann 7fd575080e PHP7: Rename String to StringHelper 
refs #10251
 2016-01-27 16:46:55 +01:00
Eric Lippmann e9bc11d340 Fix case sensitive interpretation of dashboard config files 
fixes #10878
 2016-01-27 15:45:37 +01:00
Eric Lippmann 78c1e17c20 lib/Response: Allow to control the auto-refresh interval 2016-01-27 09:14:11 +01:00
Eric Lippmann f7ba48eaac CSS: Remove main-content.less 
Not in use anymore.
 2016-01-25 08:50:18 +01:00
Eric Lippmann f5945ff908 CSS: Move colors to mixins 2016-01-25 08:20:58 +01:00
Eric Lippmann d2e4664dce Add aria-label to dropdown menu and close container control 2016-01-25 07:23:12 +01:00
Johannes Meyer 8a17cc5161 login: Fix that the system's default theme is not applied 
fixes #11021
 2016-01-22 16:34:31 +01:00
Eric Lippmann bc187d91c5 monitoring: Make inline pie charts accessible 2016-01-22 13:33:22 +01:00
Eric Lippmann 9a5e69a8ec Improve tab styles for accessibility 2016-01-12 08:52:30 +01:00
Eric Lippmann 79fbed0ad4 Use icon font instead of images in the dashboard settings tab extension 2016-01-12 08:52:30 +01:00
Eric Lippmann 7c1ccc685f Rename close-toggle to close-container-control 2016-01-12 08:52:30 +01:00
Eric Lippmann 31df702a80 Remove logo.less 
Not used anymore.
 2016-01-12 08:52:30 +01:00
Eric Lippmann cbfaee8681 CSS: Optimize dashboard, column and controls styles 
fixes #7350
fixes #10289
fixes #10871
 2016-01-12 08:52:30 +01:00
Eric Lippmann 25d8215b95 Fix Dashboard::setDefaultPane() activating an inexistent pane 2015-12-22 14:54:33 +01:00
Eric Lippmann 9599b63a55 Fix that setting a default theme had not effect 2015-12-22 13:00:01 +01:00
Uwe Ebel 3c47436c1b Fix the wrong mask for temp. directory in FileCache.php 
Detail see https://dev.icinga.org/issues/10892.

ref #10892

Signed-off-by: Thomas Gelf <thomas@gelf.net>
 2015-12-21 13:46:04 +01:00
Eric Lippmann ca1f412080 JS: Include autofocus behavior 
refs #10671
 2015-12-21 13:03:28 +01:00
Eric Lippmann a3f89c8d20 lib/Tabs: Throw HttpNotFoundException when activating an inexistent tab 
refs #10884
 2015-12-21 10:09:13 +01:00
Eric Lippmann 11e7d1050f Merge branch 'bugfix/line-breaks-in-comments-10603' 
fixes #10603
 2015-12-21 09:39:12 +01:00
Alexander A. Klimov 21f7af4b64 Revert "Merge branch 'bugfix/logout-requires-restart-of-browser-10330'" 
This reverts commit 94f4c670c1, reversing
changes made to 7d5c15469e.

refs #10330
 2015-12-17 18:50:51 +01:00
Alexander A. Klimov f6cd4794ee NavigationItemRenderer::renderTargetAttribute(): don't use the same name for two different variables 
refs #10330
 2015-12-17 17:45:03 +01:00
Alexander A. Klimov a9b818d52c NavigationItemRenderer: split actualLinkTarget() into getIcingaLinkTarget() and getHtmlLinkTarget() 
refs #10330
 2015-12-17 17:38:21 +01:00
Alexander A. Klimov 5edd8df1b6 NavigationItemRenderer: provide more human-readable aliases for native HTML link targets 
refs #10330
 2015-12-17 16:52:14 +01:00
Alexander A. Klimov 2473c4bbef NavigationItemRenderer: provide more human-readable aliases for internal link targets 
refs #10330
 2015-12-17 16:51:45 +01:00
Eric Lippmann 8006090108 Merge branch 'feature/theming-10705' 
resolves #10705
 2015-12-16 12:49:11 +01:00
Eric Lippmann 755f361e4c Add behavior for dropdown navigation items 
Dropdown navigation is not yet accessible. The added behavior listens for activity on dropdown-navigation-item for toggling the CSS class active.
 2015-12-16 12:48:02 +01:00
Eric Lippmann 2d5bd3085f Don't send cookies on API requests 2015-12-10 13:34:54 +01:00
Eric Lippmann bcd1402123 CSS: Combine header-, footer-elements and layout-colors in layout.less 2015-12-10 13:34:53 +01:00
Eric Lippmann b193ea5d32 Fix print styles 2015-12-10 13:34:53 +01:00
Eric Lippmann a1bb4bb695 Merge branch 'master' into feature/theming-10705 2015-12-07 14:17:57 +01:00
Eric Lippmann cce6af9243 Don't load inaccessible themes 
refs #10705
 2015-12-07 13:51:30 +01:00
Eric Lippmann bf0b673640 Fix section for themes config in StyleSheet 
refs #10705
 2015-12-07 12:37:34 +01:00
Johannes Meyer e7399c312f SortBox: Add support for sort defaults provided by the controller action 2015-12-04 07:44:55 +01:00
Johannes Meyer 4f5afb5ee2 SortBox: Fix "algorithm" to detect the opposite sort direction 2015-12-03 17:15:57 +01:00
Johannes Meyer 3d60e60842 SortBox: Fix too strict sort param check 
One was able to produce invalid SQL or other
errors by adding "sort=" as parameter.
 2015-12-03 15:17:09 +01:00
Eric Lippmann 3a22168b64 Handle no-cache control in JavaScript and StyleSheet, not in FileCache 2015-11-27 16:51:19 +01:00
Eric Lippmann bac09fd125 Fix void method result used in JavaScript 2015-11-27 16:48:38 +01:00
Eric Lippmann 1f467ecfaa Add theme to the stylesheet if set and ... 
... revamp interface of LessCompiler and StyleSheet

refs #10705
 2015-11-27 16:40:17 +01:00
Eric Lippmann 59b540cc12 lib: Implement cookie handling in Response 
Cookies set via Response::setCookie() or Response::getCookies()::add() will be automatically sent to client.
 2015-11-27 15:51:38 +01:00
Eric Lippmann 2a0d3412d1 lib: Add CookieSet for maintaining a set of cookies 2015-11-27 15:50:29 +01:00
Eric Lippmann 8fb9d94f46 lib: Allow to control reload CSS header in Response 
Whenever the theme is switched, client side script code has to be instructed to reload CSS.

refs #10705
 2015-11-27 15:44:40 +01:00
Eric Lippmann 5d4a628e2d Provide cookie implementation 2015-11-27 15:42:18 +01:00
Eric Lippmann 271b5f9d5c Move cookie support detection to a helper class 
Icinga\Web\Cookie will become a real cookie implementation.
 2015-11-27 15:42:18 +01:00
Eric Lippmann 6e618300ec Guard the FileCache if the systemd private tmp directory for the web server has been removed 
refs #10123
 2015-11-26 12:13:02 +01:00
Eric Lippmann 045e4a99b5 Guard FileCache against an existing but not writeable runtime path 
fixes #10123
 2015-11-26 12:02:55 +01:00
Eric Lippmann 91e576d530 lib: Add nl2br view helper 
refs #10603
 2015-11-20 15:17:38 +01:00
Eric Lippmann 96466241c2 Fix img helper not setting icon class 2015-11-16 15:27:59 +01:00
Eric Lippmann 0cc54ce34b Refresh session every 10 minutes 
Quick and dirty fix.

fixes #10229
 2015-11-16 14:19:33 +01:00
Eric Lippmann 5e5e9709a5 Show sort direction as toggle button 2015-11-16 10:20:21 +01:00
Thomas Gelf d903f850da Application\Hook: move existing ones, keep compat 2015-11-13 17:37:02 +01:00
Thomas Gelf 576747f792 Application\Hook is the new Hook loader 2015-11-13 17:37:02 +01:00
Eric Lippmann d5fe0c9610 Merge branch 'feature/dope-layout-5543#2' 2015-11-13 15:21:07 +01:00
Bernd Erk 39aa888131 Adds new about page and dotted bottom lines in detail 2015-11-13 13:57:09 +01:00
Bernd Erk ecf929ec96 Fixes form decorator and uses sprintf 2015-11-12 23:11:07 +01:00
Bernd Erk d8d917ef5a Remove long required hint in forms 2015-11-12 16:01:20 +01:00
Eric Lippmann 47401ca4b2 Don't talk about panes 
refs #5543
 2015-11-12 15:53:38 +01:00
Eric Lippmann ad31f3fbdb CSS: Remove selection-toolbar 
Not in use.

refs #5543
 2015-11-12 13:08:05 +01:00
Eric Lippmann b64bf06df7 CSS: Move limiter and pagination styles to controls.less 
refs #5543
 2015-11-12 13:07:35 +01:00
Eric Lippmann 0abbe2583b Introduce a form the limiter control 
refs #5543
 2015-11-12 13:04:52 +01:00
Eric Lippmann 75091d0eaa Reduce HTML for sparkline pie charts 
refs #5543
 2015-11-11 15:11:14 +01:00
Johannes Meyer a662fc9af0 Controller: Re-add "view" as preserved column 
We're still utilizing this in the dashboard..
 2015-11-10 16:08:02 +01:00
Eric Lippmann 8a26e81c1c Remove LogoutNavigationItemRenderer 
refs #5543
 2015-11-10 14:06:49 +01:00
Johannes Meyer 8d04c8548a Do not hardcode action specific parameters to preserve in the FilterEditor 
This should only happen for other control parameters or framework
specific stuff. This is still subject to improvement, as this solution is
rather ugly imho..

refs #10370
 2015-11-10 11:51:26 +01:00
Eric Lippmann 802cba3fb8 CSS: Move variables from themes/icinga.less to base.less 
refs #5543
 2015-11-09 13:32:59 +01:00
Eric Lippmann b5c8579d0e lib: Fix Url paramter encoding if parameter is a Url object 
fixes #10321
 2015-11-09 09:55:17 +01:00
Eric Lippmann ba4256d983 Quick and dirty fix menu in FF 
refs #5543
 2015-11-04 17:49:43 +01:00
Eric Lippmann 8cc96e61da Re-add time-ago, -since and -until CSS classes 
refs #5543
 2015-10-28 10:41:22 +01:00
Eric Lippmann bb33a43cb9 CSS: Don't pollute time related format helpers w/ text-small 
fixes #10301
 2015-10-27 16:23:32 +01:00
Eric Lippmann 4eb92438dd Add nav-level-$level CSS classes to navigation 2015-10-27 13:52:18 +01:00
Eric Lippmann 6e5ba364fb CSS: Introduce badge-nav-item 
refs #5543
 2015-10-26 12:44:11 +01:00
Eric Lippmann 8341415d28 nav: Give item renderer a chance to set the CSS class of the outer li element 
refs #5543
 2015-10-26 12:32:49 +01:00
Eric Lippmann 4593c78d16 lib: Fix JSON response exception on form failure 2015-10-26 12:30:50 +01:00
Eric Lippmann e07e16d7a1 lib: Remove UserNavigationItemRenderer 2015-10-22 14:26:53 +02:00
Johannes Meyer 98e0081d81 Limiter: Use the limit also as priority 
fixes #10288
 2015-10-05 10:54:43 +02:00
Eric Lippmann 54bb99a96d Merge branch 'feature/dope-layout-5543' 
refs #5543
 2015-10-02 11:16:35 +02:00
Johannes Meyer 53f29131af ActionController: Use a controller's inner layout script instead of "body" 
"body" is still the default inner layout script.
 2015-10-02 10:18:37 +02:00
Eric Lippmann 56ed92a8e6 Merge branch 'master' into feature/dope-layout-5543 2015-10-01 21:29:35 +02:00
Thomas Gelf 9ca81320ac Search: re-add object names, allow for addresses 
It's now possible do search for IP (and IPv6) addresses. Object names
are once again allowed

fixes #9591
fixes #10163
 2015-10-01 18:48:36 +02:00
Johannes Meyer 209c084f51 Form: Only add the ViewHelper decorator for hidden form fields 
refs #5543
 2015-10-01 18:31:05 +02:00
Johannes Meyer 14ae04b631 RecursiveNavigationRenderer: Allow to enforce the standard item renderer 2015-10-01 17:43:48 +02:00
Eric Lippmann 3d2521abf0 Merge branch 'master' into feature/dope-layout-5543 2015-10-01 17:42:24 +02:00
Johannes Meyer 8c8af9cd50 DashboardPane: Fix that ordering dashlets is persistent 2015-10-01 17:35:11 +02:00
Johannes Meyer b63a956a38 Dashboard: Respect original dashlet order 2015-10-01 17:34:45 +02:00
Johannes Meyer 0cc06d6af9 NavigationItem: Improve merge "algorithm" 2015-10-01 17:12:55 +02:00
Thomas Gelf 270520eac3 helpers/icon: allow for img urls outside of icons 
Icon images where restricted to img/icons, this did not allow modules
to use custom images. Left behaviour for img urls without slash
untouched.
 2015-10-01 16:52:39 +02:00
Thomas Gelf cb5f741f22 UserNavigationItemRenderer: disable avatar 
Broken on ff, no such image, rendering issues - postponed
 2015-10-01 16:39:20 +02:00
Johannes Meyer d54e5f62e6 NavigationItem: Accept priority while merging if none is set yet 2015-10-01 16:32:47 +02:00
Eric Lippmann 08ab0befcd CSS: compat.less and monitoring detail 
refs #5543
 2015-10-01 16:31:25 +02:00
Johannes Meyer b74f8ce51d Wizard: Add css class control-group to all buttons 
refs #5543
 2015-10-01 13:34:16 +02:00
Matthias Jentsch db74f7e780 Fix icon layout in dropdown 
refs #5543
 2015-10-01 11:18:00 +02:00
Johannes Meyer 85e7e7920a Url: Fix detection of the current base url when stripping it from a given path 2015-10-01 10:42:28 +02:00
Eric Lippmann 968754ec2e CSS: Add class no-icon to menu items w/o an icon 
refs #5543
 2015-10-01 02:51:46 +02:00
Eric Lippmann c318454a45 CSS: Style form descriptions, hints, notifications and errors 
refs #5543
 2015-10-01 02:49:38 +02:00
Eric Lippmann 51d6c61bf7 CSS: Re-add spinner for autosubmit 
refs #5543
 2015-10-01 01:59:56 +02:00
Eric Lippmann 05904de5d5 Fix about markup 
refs #5543
 2015-10-01 00:55:49 +02:00
Eric Lippmann be3c43ef77 Add tab to new, update and remove role 
refs #5543
 2015-10-01 00:25:54 +02:00
Eric Lippmann 48b1c5ff30 CSS: Move spinner related styles to spinner.less 
refs #5543
 2015-09-30 22:24:26 +02:00
Eric Lippmann 02a3f56481 CSS: Disable logo.less 
refs #5543
 2015-09-30 18:52:59 +02:00
Eric Lippmann 231c63b703 Merge branch 'master' into feature/dope-layout-5543 2015-09-30 18:52:52 +02:00
Johannes Meyer c2ac841871 Make the about page pretty 
refs #9247
 2015-09-30 17:07:55 +02:00
Matthias Jentsch 7e81b00a96 Fix multi-view badge filters 
Allow providing a base URL for StateBadges to display hosts and services based on a filter.

refs #5543
 2015-09-30 16:58:42 +02:00
Johannes Meyer bd206e3718 Url: Do not trim leading slahes in method setPath() 
We're handling external urls specifically now.
 2015-09-30 15:42:01 +02:00
Johannes Meyer eef4322188 Url: Fix automatic stripping of the current base url in method fromPath() 2015-09-30 15:36:45 +02:00
Johannes Meyer 415690134b Add tab extension to add the current container url as new menu entry 2015-09-30 14:47:42 +02:00
Johannes Meyer 722152a876 Url: Fix that full external urls with path component are incorrectly handled 
fixes #10236
 2015-09-30 13:41:50 +02:00
Johannes Meyer 1c7b398219 Navigation: Do not provide "dashlet" as default item type 
Please revert this commit once we're about to finish the new
implementation.

refs #6084
 2015-09-30 12:55:21 +02:00
Johannes Meyer 95d1ce371c Navigation: Add static method getItemTypeConfiguration() 
refs #10246
 2015-09-30 11:18:15 +02:00
Eric Lippmann 274910a611 CSS: Use class form-controls for form buttons by default 
refs #5543
 2015-09-30 09:53:36 +02:00
Eric Lippmann c36c0455d4 CSS: Use icon-info-circled for form control help 
refs #5543
 2015-09-30 09:52:53 +02:00
Eric Lippmann eb246babd5 CSS: Add grid.less 
refs #5543
 2015-09-29 17:02:59 +02:00
Eric Lippmann ca45522da7 CSS: Move badge related styles to badges.less 2015-09-28 17:02:37 +02:00
Eric Lippmann 98f1e9028e Fix user menu CSS classes 
refs #5543
 2015-09-28 16:40:16 +02:00
Eric Lippmann ed6da19876 lib: Support setting CSS class for li on navigation items 
refs #5543
 2015-09-28 16:39:28 +02:00
Eric Lippmann c3b085cf7f lib: Respect Cache-Control: no-cache 
fixes #9688
 2015-09-28 15:59:11 +02:00
Eric Lippmann d03647f2e6 JS: Rename dblclickselect to selectable 
refs #9826
 2015-09-28 15:44:25 +02:00
Eric Lippmann 9dff864b80 Prepare markup for new user menu 
refs #5543
 2015-09-28 14:48:54 +02:00
Eric Lippmann 2ff822c2ac Merge branch 'master' into feature/ipv6-addresses-9645-9826 2015-09-28 13:09:30 +02:00
Johannes Meyer 2f9bd78721 Merge branch 'master' into bugfix/Prettify-page-layout-when-accessing-a-non-existent-route-while-not-being-authenticated-10009 2015-09-28 09:55:07 +02:00
Johannes Meyer d627f419ef Fix that an object's notes and action url label is escaped twice 
fixes #10218
 2015-09-28 09:05:17 +02:00
Eric Lippmann ab50fcc091 CSS: Introduce .primary-nav 
refs #5543
 2015-09-27 16:06:46 +02:00
Eric Lippmann 8cd715f2d4 CSS: Include main.less after nav.less 
refs #5543
 2015-09-27 16:00:19 +02:00
Eric Lippmann 2996cb77ab Navigation: Close the navigation item after all children have been rendererd 
refs #5543
 2015-09-27 15:43:49 +02:00
Eric Lippmann 63e0549618 Navigation: Support empty labels for creating containers 
refs #5543
 2015-09-27 15:42:26 +02:00
Eric Lippmann 9115e1d834 CSS: Move monitoring/colors.less to application 
refs #5543
 2015-09-27 14:28:36 +02:00
Eric Lippmann d59b09ca48 Fix badge markup in the BadgeNavigationItemRenderer 
refs #5543
 2015-09-27 14:16:51 +02:00
Eric Lippmann 30ed3ad760 Fix badge markup in the BadgeMenuItemRenderer 
refs #5543
 2015-09-27 14:16:36 +02:00
Eric Lippmann 4c798d4e04 Fix coding style in the SummaryNavigationItemRenderer 
refs #5543
 2015-09-27 14:16:10 +02:00
Eric Lippmann 181f6d5285 CSS: Re-add form.less but w/ out-commented content 
refs #5543
 2015-09-27 13:37:35 +02:00
Eric Lippmann 901a5b6d34 lib: Remove obsolete navigation renderer classes 
refs #5543
 2015-09-27 13:32:14 +02:00
Eric Lippmann 9789aed870 lib: Fix navigation renderer usage in the limiter widget 
refs #5543
 2015-09-27 13:29:22 +02:00
Eric Lippmann a9f0aa6bcd lib: Fix navigation usage in the limiter widget 
refs #5543
 2015-09-27 13:22:43 +02:00
Eric Lippmann d79a160547 Navigation: Disable ids on li for the moment 
refs #5543
 2015-09-27 13:11:49 +02:00
Eric Lippmann d3ac1b16ee Merge branch 'master' into feature/dope-layout-5543 2015-09-27 13:11:11 +02:00
Eric Lippmann ed9a6aa39d lib: Fix Navigation::addItem() 
refs #5543
 2015-09-27 12:26:58 +02:00
Alexander A. Klimov ed935696ac CSS: outsource .logo related rules into a new .less file `logo.less' 
refs #10009
 2015-09-25 15:31:39 +02:00
Johannes Meyer a55cced039 Merge branch 'master' into feature/custom-menu-items-5600 
Conflicts:
	modules/monitoring/application/views/scripts/list/comments.phtml
	modules/monitoring/application/views/scripts/list/downtimes.phtml
 2015-09-25 14:12:43 +02:00
Eric Lippmann 7ff74ae36a lib: Use navigation classes in the limiter control 
refs #5543
 2015-09-25 13:36:28 +02:00
Eric Lippmann 823a2cc8ea CSS: Add nav.less and limiter.less to our stylesheet 
refs #5543
 2015-09-25 13:36:04 +02:00
Eric Lippmann 1122ffafad lib: Add navigation classes (WIP) 
- Lacks custom renderer functionality
- Lacks navigation item priorities
- Lacks permission handling

refs #5600
 2015-09-25 13:16:44 +02:00
Eric Lippmann 59b9155ca7 CSS: Include dev.less in our style sheet 
refs #5543
 2015-09-25 00:35:12 +02:00
Johannes Meyer 165dc00fad Url: Do not throw ProgrammingError if there is no relative url available 
refs #5600
 2015-09-24 14:03:15 +02:00
Eric Lippmann 27f3dd94d2 CSS: Add text-small to time-since, -until and -ago 
refs #5543
 2015-09-24 10:28:56 +02:00
Eric Lippmann 5b1e4f0a1c CSS: Add new main.less to our stylesheet 
refs #5543
 2015-09-23 13:41:39 +02:00
Eric Lippmann 2e9ea40eb1 CSS: Disable main-content.less for now 
refs #5543
 2015-09-23 13:37:19 +02:00
Eric Lippmann e982735451 CSS: Rename main.less to base.less 
refs #5543
 2015-09-23 13:36:25 +02:00
Eric Lippmann d1b141d142 CSS: Include main.less in our stylesheet 
refs #5543
 2015-09-23 11:01:55 +02:00
Eric Lippmann 12227d9d08 CSS: Disable defaults.less for now 
refs #5543
 2015-09-23 10:57:39 +02:00
Eric Lippmann 8b9cdc5c1e CSS: Include normalize.css in our style sheet 
refs #5543
 2015-09-23 10:43:43 +02:00
Johannes Meyer 5193fce1dd Url: Fix external url detection 
refs #5600
 2015-09-22 16:18:27 +02:00
Johannes Meyer 81e13109fc Revert "Url: Add support macros" 
This reverts commit 33231d24da.
There is no need for url macros, since we're handling absolute
urls correctly now.
 2015-09-22 15:51:00 +02:00
Johannes Meyer 33231d24da Url: Add support macros 
refs #5600
 2015-09-22 14:15:04 +02:00
Johannes Meyer 7321d67b4f Url: Consider urls with a leading slash as absolute.. 
..and make it possible to have a url without a base.

refs #5600
 2015-09-22 14:14:41 +02:00
Johannes Meyer 3c7155f246 NavigationItemRenderer: Pass external urls through the iframe module 
refs #5600
 2015-09-21 14:13:10 +02:00
Johannes Meyer 7e460e7c03 Url: Remove redundant slash on urls without path 2015-09-21 14:04:36 +02:00
Johannes Meyer 776d06d6ca Url: Fix host check in fromPath() 
refs #5600
 2015-09-21 14:03:53 +02:00
Johannes Meyer c8d3aa2517 Url: Support external urls in fromPath() 
refs #5600
 2015-09-21 13:10:35 +02:00
Johannes Meyer 3aaf726856 Update CSS style used for the navigation 
refs #5600
 2015-09-21 11:13:05 +02:00
Johannes Meyer 76cf01869e NavigationItem: Add property $target 
refs #5600
 2015-09-21 10:18:46 +02:00
Eric Lippmann 46ab8d847d Forms: Wrap the label and the help icon in a div 
refs #5543
 2015-09-19 21:58:02 +02:00
Eric Lippmann a92c0de52f CSS: Disable all form styles for the moment 
refs #5543
 2015-09-19 21:57:29 +02:00
Eric Lippmann cf8548a29d CSS: Add Icinga theme (WIP) 
refs #5543
 2015-09-18 15:25:14 +02:00
Johannes Meyer d4a9198310 Navigation: Only fail if there's really no chance to create the requested hierarchy 
refs #5600
 2015-09-17 14:42:02 +02:00
Johannes Meyer b6fe6ffd6b Navigation: Relax type check in method fromConfig() 
refs #5600
 2015-09-17 13:41:28 +02:00
Eric Lippmann 79c9a8af9b lib: Fix Number::isValid(), again :) 2015-09-17 12:52:09 +02:00
Johannes Meyer 83bde3aa81 Form: Rename property $parent to $_parent 
Zend.. I love you..
 2015-09-17 11:23:47 +02:00
Johannes Meyer 4f5a5c83bc Navigation: Add method hasRenderableItems() 
refs #5600
 2015-09-17 11:01:06 +02:00
Johannes Meyer bf4e492fa1 Action: Accept and apply option "filter" 
refs #5600
 2015-09-17 11:00:40 +02:00
Johannes Meyer b1ee12f721 NavigationItem: Allow to dynamically decide whether to render an item 
refs #5600
 2015-09-17 09:11:17 +02:00
Johannes Meyer 84f733b177 DashboardPane: Rename param $order to $ordered in method getDashlets 
refs #5600
 2015-09-17 08:25:17 +02:00
Johannes Meyer 54d08f99e8 DashboardPane: Order dashlets alphabetically 
refs #5600
 2015-09-16 15:31:41 +02:00
Johannes Meyer 8b7a1ce28f Late translate a module's dashboard-pane/dashlet labels 
refs #5600
 2015-09-16 14:29:33 +02:00
Johannes Meyer d0eb61dc2e Form: Add property $parent 
refs #5600
 2015-09-15 16:09:33 +02:00
Johannes Meyer 1d6ad6df21 Merge branch 'master' into feature/custom-menu-items-5600 
Conflicts:
	modules/monitoring/configuration.php
 2015-09-15 13:31:30 +02:00
Eric Lippmann e8c21868ff lib: Fix Number::isValid() 
- Calls $this->translate()
- Always performs is_numeric check, even if the element is not required
 2015-09-07 16:57:09 +02:00
Eric Lippmann b897813e71 lib: Add Form::setRequest() 2015-09-07 13:55:52 +02:00
Eric Lippmann 1fb613e811 api/forms: Fix array access of a notification 
refs #9606
 2015-09-07 13:49:53 +02:00
Eric Lippmann d3fe1e1973 api/response: Allow setting null as success data 
refs #9606
 2015-09-07 13:45:13 +02:00
Eric Lippmann b20eb681c0 api/forms: Use the first success notification as success message 
refs #9606
 2015-09-07 13:44:46 +02:00
Eric Lippmann f467d085b0 api: Use JsonResponse in form 
refs #9606
 2015-09-07 13:36:12 +02:00
Johannes Meyer 21180e2fd4 NavigationItem: Fix method conflictsWith() 
...

refs #5600
 2015-09-07 13:26:44 +02:00
Johannes Meyer 6b13f2a987 NavigationRenderer: Do not render an empty header 
refs #5600
 2015-09-07 13:25:25 +02:00
Eric Lippmann 25abc16e15 lib: Replace Repsonse::sendJson() w/ Response::json() 
refs #9606
 2015-09-07 13:24:21 +02:00
Eric Lippmann a9cb8bfb2c lib: Add JsonResponse class 
refs #9606
 2015-09-07 13:22:58 +02:00
Johannes Meyer f9441c91d5 Navigation: Load shared navigation items 
refs #5600
 2015-09-07 13:22:36 +02:00
Johannes Meyer ee43fdad0a DashboardPane: Consider dashlets when merging 
refs #5600
 2015-09-07 13:21:31 +02:00
Johannes Meyer bf2cb9ab7e NavigationItem: Provide a more sophisticated conflict detection 
refs #5600
 2015-09-07 13:20:49 +02:00
Johannes Meyer 0feaec7af1 NavigationItem: Return a instance of Url in method getUrl(), really 
refs #5600
 2015-09-07 13:20:17 +02:00
Johannes Meyer 451a0c91f2 NavigationItem: Add missing return statement in method merge() 
refs #5600
 2015-09-07 13:19:36 +02:00
Johannes Meyer f958a1c323 Navigation: Load a user's navigation items 
refs #5600
 2015-09-07 12:20:14 +02:00
Johannes Meyer 411c6e0546 Navigation: Fix that a module's item class is not found 
refs #5600
 2015-09-07 12:01:05 +02:00
Eric Lippmann 0f8c28d749 Merge branch 'master' into feature/api-9606 2015-09-07 11:33:44 +02:00
Johannes Meyer f9b68b683b NavigationItem: Consider unknown properties as element attributes 
refs #5600
 2015-09-07 09:49:05 +02:00
Johannes Meyer ca72bd5455 NavigationRendererInterface: Use "div" as default outer element tag 
"nav" is less often necessary.

refs #5600
 2015-09-07 09:48:32 +02:00
Johannes Meyer e63e15e471 Add class DashboardPane 
refs #5600
 2015-09-07 09:06:40 +02:00
Johannes Meyer b5711f4031 Dashboard: Load panes by utilizing the new Navigation 
This is only a quick fix to avoid adjusting the complete dashboard
implementation.

refs #5600
 2015-09-07 09:05:50 +02:00
Johannes Meyer a3539b0817 Navigation: Fix method getActiveItem() failing badly for empty navigations 
refs #5600
 2015-09-07 08:37:06 +02:00
Johannes Meyer 6dd49761ff Navigation: Add method getActiveItem() 
refs #5600
 2015-09-04 16:21:09 +02:00
Johannes Meyer 6967fffb1f Navigation: Add support dashboard-panes and check module permissions 
refs #5600
 2015-09-04 15:51:51 +02:00
Johannes Meyer 2af06e9415 NavigationItem: Re-introduce a default priority of 100 
refs #5600
 2015-09-04 14:20:21 +02:00
Johannes Meyer b2a0f1b9c2 Navigation: Peform a case-insensitive search when merging items 
refs #5600
 2015-09-04 14:17:16 +02:00
Johannes Meyer 63f8f34c15 Navigation: Add method load() 
Supports currently only module menus.

refs #5600
 2015-09-04 13:55:31 +02:00
Johannes Meyer 881880f18f SummaryNavigationItemRenderer: Fix method getTitle() 
refs #5600
 2015-09-04 13:48:29 +02:00
Johannes Meyer 8e24ec978d BadgeNavigationItemRenderer: Use view() instead of getView() 
refs #5600
 2015-09-04 13:47:57 +02:00
Johannes Meyer 044fe031da NavigationItemRenderer: Add method init() 
refs #5600
 2015-09-04 13:47:38 +02:00
Johannes Meyer 1a42c04c8e NavigationItem: Fix locating a module's custom navigation renderer 
refs #5600
 2015-09-04 13:47:17 +02:00
Matthias Jentsch ca33e71f2d Deduplicate and clean up service summary component 
Remove redundant component view script and streamline subFilter handling in all views that render it. Remove
heading from component to allow embedding in different types of views.

refs #10033
 2015-09-04 13:02:57 +02:00
Johannes Meyer 5ff3db8a3c Url: Explicitly handle '#' 
Feels like a quick&dirty solution. Feel free to improve it.

refs #5600
 2015-09-04 10:34:39 +02:00
Johannes Meyer 07588595f2 NavigationItem: Automatically determine whether it's active or not 
refs #5600
 2015-09-04 10:10:33 +02:00
Johannes Meyer baefc89f85 NavigationRenderer: Provide a id for outer item markup (<li>) 
refs #5600
 2015-09-04 09:41:39 +02:00
Johannes Meyer 2855778dc7 Revert "NavigationItemRenderer: Provide a id if none is set" 
This reverts commit c60839d798.
 2015-09-04 09:38:03 +02:00
Johannes Meyer 975cc92f6b NavigationItem: Provide "#" as default url for items with children 
refs #5600
 2015-09-04 09:31:23 +02:00
Johannes Meyer 4e948b46bf NavigationRenderer: Add id "navigation" to the navigation's heading 
refs #5600
 2015-09-04 09:26:28 +02:00
Johannes Meyer c60839d798 NavigationItemRenderer: Provide a id if none is set 
refs #5600
 2015-09-04 09:25:58 +02:00
Johannes Meyer a8d5a78aa2 NavigationItem: Fix method getUniqueName() 
refs #5600
 2015-09-04 09:25:25 +02:00
Johannes Meyer a6b2c23684 Update navigation rendering code to fit the previous adjustments 
refs #5600
 2015-09-04 09:08:20 +02:00
Johannes Meyer 9e558c9861 Add class SummaryNavigationItemRenderer 
refs #5600
 2015-09-03 15:53:42 +02:00
Johannes Meyer ad6a2938ab Add class BadgeNavigationItemRenderer 
refs #5600
 2015-09-03 15:53:23 +02:00
Johannes Meyer b53fb04a0f Move navigation related renderer classes to the new namespace 
refs #5600
 2015-09-03 15:52:37 +02:00
Johannes Meyer 7adfc58878 NavigationItem: Add missing return keyword in method render() 
refs #5600
 2015-09-03 15:04:39 +02:00
Johannes Meyer a930ea7f7a Navigation: Add method render() 
refs #5600
 2015-09-03 15:04:07 +02:00
Johannes Meyer 9a725330fb NavigationItem: Provide the item to the renderer before calling render 
refs #5600
 2015-09-03 14:22:38 +02:00
Johannes Meyer 16ece09b0a NavigationItemRenderer: Add option $target 
refs #5600
 2015-09-03 13:36:34 +02:00
Johannes Meyer 67dee62c57 NavigationItemRenderer: Add support for options 
refs #5600
 2015-09-03 13:36:13 +02:00
Johannes Meyer c3ad665c15 Navigation: Fix accessing a non-existent and static variable 
refs #5600
 2015-09-03 12:52:07 +02:00
Johannes Meyer c35db55857 Navigation: Add missing new keyword 
refs #5600
 2015-09-03 11:26:27 +02:00
Johannes Meyer 2834e206d5 NavigationItem: Add support for custom renderers 
refs #5600
 2015-09-03 11:25:51 +02:00
Johannes Meyer 811269df01 NavigationItem: Rename method getView() to view() 
refs #5600
 2015-09-03 10:39:11 +02:00
Johannes Meyer 206168672b NavigationItem: Add method getUniqueName() 
refs #5600
 2015-09-03 10:22:47 +02:00
Johannes Meyer e6a6ae996a Navigation: Merge other navigations more sophisticated 
refs #5600
 2015-09-03 09:57:52 +02:00
Johannes Meyer 537db6000e NavigationItem: Add method merge() 
refs #5600
 2015-09-03 09:56:22 +02:00
Johannes Meyer a626e8f7fb NavigationItem: Allow to set and get single url parameters 
refs #5600
 2015-09-03 09:56:02 +02:00
Johannes Meyer 1fb5c96ef1 Navigation: Add method order() 
refs #5600
 2015-09-03 08:52:02 +02:00
Johannes Meyer 00447488ee NavigationItem: Drop interface Countable 
$item->count(), count of what?
$item->getChildren()->count(), Its children, of course!

refs #5600
 2015-09-03 08:49:30 +02:00
Johannes Meyer f4a6ab73c0 NavigationItem: Add property priority 
refs #5600
 2015-09-03 08:33:13 +02:00
Johannes Meyer 1393db687b NavigationItem: Adjust some docblocks 
refs #5600
 2015-09-02 15:42:54 +02:00
Johannes Meyer 298c4ad38b NavigationItem: Cast a string to Url already in setUrl() 
refs #5600
 2015-09-02 15:35:08 +02:00
Johannes Meyer 1788cc9b6a NavigationItem: Use setView() to initiliaze $view 
refs #5600
 2015-09-02 15:33:45 +02:00
Johannes Meyer 6802c0a9e4 NavigationItem: Do not disable the complete parent hierarchy.. 
..if just a child gets deactivated.

refs #5600
 2015-09-02 15:32:37 +02:00
Johannes Meyer 2bfeb335a5 NavigationItem: Add method setParent() and getParent() 
refs #5600
 2015-09-02 15:30:35 +02:00
Johannes Meyer e2beb7d027 NavigationItem: Return the name if no label is set in getLabel() 
refs #5600
 2015-09-02 15:27:34 +02:00
Johannes Meyer 1ef4a2f7d0 NavigationItem: Do not provide a default for setProperties() 
refs #5600
 2015-09-02 15:26:07 +02:00
Johannes Meyer 8a29660226 NavigationItem: Overwrite the property in method setAttributes() 
A setter sets something instead of patching it.

refs #5600
 2015-09-02 15:25:10 +02:00
Johannes Meyer 5efcb18fa0 NavigationItem: Set the parent on a child in method setChildren() 
refs #5600
 2015-09-02 15:21:40 +02:00
Johannes Meyer c9050e2f21 NavigationItem: Initialize $children before setting the properties 
refs #5600
 2015-09-02 15:20:26 +02:00
Johannes Meyer 62f7a49a45 NavigationItem: Reduce code complexity in method addChild() 
refs #5600
 2015-09-02 15:17:26 +02:00
Johannes Meyer c03109c4c6 NavigationItem: Catch exceptions thrown in __toString() 
refs #5600
 2015-09-02 15:16:05 +02:00
Johannes Meyer 95a3f1c011 Navigation: Clear the parent name from a configured navigation item 
refs #5600
 2015-09-02 15:14:55 +02:00
Johannes Meyer 29413360d9 Navigation: Add method merge() 
refs #5600
 2015-09-02 13:34:56 +02:00
Johannes Meyer a4c2081f64 Navigation: Remove method hasItems() 
Redundant, as it's expressible with "! $nav->isEmpty()".

refs #5600
 2015-09-02 13:29:07 +02:00
Johannes Meyer f449c78dbf NavigationItem: Make it having a name instead of a id.. 
..and require it as first argument on construction time.

refs #5600
 2015-09-02 13:27:12 +02:00
Johannes Meyer b3159ee60d NavigationItem: Accept arrays for method setChildren() 
refs #5600
 2015-09-02 12:59:05 +02:00
Johannes Meyer 83974b7698 Navigation: Add method fromConfig() 
refs #5600
 2015-09-02 12:58:12 +02:00
Johannes Meyer 997b57834c Navigation: Add method fromArray() 
refs #5600
 2015-09-02 12:57:49 +02:00
Johannes Meyer 0788041c43 Navigation: Accept item configuration for method addItem() 
And check an item's permission.

refs #5600
 2015-09-02 12:57:14 +02:00
Johannes Meyer c154f96d44 Navigation: Add method createItem() 
refs #5600
 2015-09-01 16:02:44 +02:00
Eric Lippmann 52b0c8c258 lib: Add navigation classes (WIP) 
- Lacks custom renderer functionality
- Lacks navigation item priorities
- Lacks permission handling

refs #5600
 2015-09-01 12:48:45 +02:00
Eric Lippmann 4fb6856caf Fix exception when navigating to the preferences after namespacing all controllers 2015-08-31 10:19:30 +02:00
Eric Lippmann e7e1b1a98e Dispatcher: Default to the default module if no module has been given in the request 
This is most likely the case when custom routes have been added to the router w/o the module parameter being set.

refs #5786
 2015-08-28 13:13:20 +02:00
Eric Lippmann 9cf56410e9 lib: Fix PHPDoc of Form::populate() 2015-08-27 15:52:13 +02:00
Eric Lippmann 4070f6c75b Merge branch 'master' into feature/namespaced-controllers-5786 2015-08-27 15:05:44 +02:00
Eric Lippmann 28009eb563 Rename controller namespace to Controllers 
refs #5786
 2015-08-27 13:03:45 +02:00
Eric Lippmann c294283636 Merge branch 'bugfix/service-grid-grouping-postgres-9333' 
Conflicts:
	modules/monitoring/application/controllers/ListController.php
	modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php

fixes #9333
fixes #9538
 2015-08-27 12:58:49 +02:00
Johannes Meyer 8cc1970a9f SearchDashboard: Use t() instead of the view helper 
Since it's library code we do not need to use the module-aware
translation helper.
 2015-08-25 16:51:50 +02:00
Eric Lippmann c8790fad93 Merge branch 'bugfix/service-grid-display_name-9538' into bugfix/service-grid-grouping-postgres-9333 
Conflicts:
	library/Icinga/Data/PivotTable.php
	modules/monitoring/application/controllers/ListController.php
 2015-08-25 15:51:20 +02:00
Eric Lippmann 96fb3b5d4b Merge branch 'master' into feature/api-9606 2015-08-25 09:25:59 +02:00
Eric Lippmann ec390d7a8b lib: Add Controller::httpBadRequest() for responding w/ HTTP 400 immideately 
refs #9606
 2015-08-24 15:59:59 +02:00
Johannes Meyer 7c86f19aee SearchDashboard: Utilize createDashlet() and set a progress label 
refs #8848
 2015-08-24 12:36:59 +02:00
Johannes Meyer 320a4080ec Dashlet: Add support for CSS animated progress labels 
refs #8848
 2015-08-24 12:36:35 +02:00
Johannes Meyer db4c81a093 Pane: Add method createDashlet() 
refs #8848
 2015-08-24 12:35:38 +02:00
Eric Lippmann ceaba90872 css: Load mixins.less 2015-08-21 16:45:05 +02:00
Matthias Jentsch 675a130787 Fix active configuration/application menu highlighting 
Fix a bug that caused the application config to not be set to active when navigating through history.

refs #9761
 2015-08-21 16:04:04 +02:00
Johannes Meyer d31b60102e Form: Fix that form titles are missing 
The description may not be set at the time
loadDefaultDecorators() is called.
 2015-08-21 14:20:09 +02:00
Johannes Meyer 9ca278d7b2 Merge branch 'master' into feature/activity-indicators-for-form-submits-8369 2015-08-21 13:37:54 +02:00
Johannes Meyer fbca28c024 Form: Only add a form header if a description is set 
refs #8369
 2015-08-21 13:34:17 +02:00
Johannes Meyer 747f6dcf77 Form: Show the form autosubmit warning in the header tag... 
...and use a unique id for the progress element.

refs #8369
 2015-08-21 11:40:38 +02:00
Eric Lippmann 85ef98f72d lib: Add PHPDoc to Request::hasCookieSupport() 2015-08-21 11:27:03 +02:00
Johannes Meyer b9d64b40a4 forms.less: Fix help icon layout 2015-08-21 10:36:08 +02:00
Johannes Meyer 7244906515 Wizard: Use a constant for the name and id of the progress element 
refs #8369
 2015-08-21 10:16:23 +02:00
Johannes Meyer 07b17cc701 Wizard: Add Spinner decorator to the first (and only) submit button 
refs #8369
 2015-08-21 09:52:57 +02:00
Matthias Jentsch 44271471e3 Allow declarative definitions of badge renderers and improve interface 
Allow the data backend, columns and generated tooltips to be defined in the configuration instead of providing subclasses for every new configuration. Provide an abstract BadgeMenuItemRenderer that allows creating Badges with less boilerplate.

fixes #9694
 2015-08-20 18:16:33 +02:00
Johannes Meyer 46cd47b73c Form: Automatically set data-progress-element... 
..for forms with form based autosubmit warnings.

refs #8369
 2015-08-20 16:54:20 +02:00
Johannes Meyer 32f8c0770c Wizard: Use a single spinner for all submit buttons 
refs #8369
 2015-08-20 16:13:56 +02:00
Johannes Meyer 20f144bd4b Spinner: Accept option `id' 
refs #8369
 2015-08-20 16:13:30 +02:00
Eric Lippmann c5f444efe8 lib: Don't alias Zend classes in the ActionController 2015-08-20 16:10:39 +02:00
Eric Lippmann 6ca02a519b lib: Fix type hint of Controller::getResponse() 2015-08-20 16:07:24 +02:00
Eric Lippmann 1c5a784022 lib: Move Request::sendJson() to Response::sendJson() 
refs #9606
 2015-08-20 16:05:45 +02:00
Eric Lippmann 870b73ae09 lib: Rename Request::getIsApiRequest() to ::isApiRequest() 
There's no setter involved.

refs #9606
 2015-08-20 16:02:25 +02:00
Eric Lippmann 62f0281a62 lib: Fix type hint of Controller::getRequest() 2015-08-20 16:00:24 +02:00
Eric Lippmann 1130e453f6 lib: Fix typos in the Form's PHPDoc 2015-08-20 15:57:52 +02:00
Eric Lippmann f9f813e50b lib: Fix PHPDoc of Form::populate() 2015-08-20 15:56:45 +02:00
Eric Lippmann 0ce4e12db8 lib: Fix type hints for Form::getElements() 2015-08-20 15:55:18 +02:00
Eric Lippmann dd23bd9397 Form: Respond w/ JSON-encoded messages if API requests fail 
refs #9606
 2015-08-20 15:48:42 +02:00
Johannes Meyer a77dc3665c Form: Show a spinner for ongoing form submits 
This will only be shown if there's no progress label set.

refs #8369
 2015-08-20 15:05:02 +02:00
Johannes Meyer 275b57cb69 Form: Allow to set a progress label 
refs #8369
 2015-08-20 15:04:15 +02:00
Johannes Meyer 690d60672c Introduce form element decorator Spinner 
refs #8369
 2015-08-20 14:34:43 +02:00
Eric Lippmann 71ff4512c3 lib/form: Bypass sent and submit handling if the form is an API target 
refs #9606
 2015-08-20 13:11:36 +02:00
Eric Lippmann e07cdd21ac lib: Add Request::sendJson() 
refs #9606
 2015-08-20 13:11:36 +02:00
Johannes Meyer 63e639caf0 Handle module identification directly in the ActionController 
Fixes some issues with more complex customisations in a
module's controller.
Obsoletes: 93f8297344
 2015-08-19 13:39:46 +02:00
Johannes Meyer 036da072c5 Revert "ActionController: Give modules a chance to dynamically require auth" 
This reverts commit 93f8297344.
 2015-08-19 13:39:46 +02:00
Eric Lippmann 1492218962 Fix SortBox not usable w/o SortRules 
The SortBox assumes the first avaiable sort column as default column if the given Sortable does not implement the SortRules interface.
When changing the direction of the default sort column, the sort box did not pass the column to Sortable::sort(). Thus the Sortable did not know by which column to sort.
Now the SortBox passes the sort column even if the direction of the default column is changed.

refs #9333
 2015-08-18 14:18:48 +02:00
Johannes Meyer 93f8297344 ActionController: Give modules a chance to dynamically require auth 2015-08-18 11:28:02 +02:00
Eric Lippmann e31dce97a9 Fix dispatching namespaced module controllers 
refs #5786
 2015-08-18 11:11:28 +02:00
Johannes Meyer e5f249270a Merge branch 'master' into feature/provide-a-complete-list-of-filter-columns-9029 2015-08-17 15:41:40 +02:00
Johannes Meyer f7b0e6956d FilterEditor: Only apply the filter if a query is set 
refs #9029
 2015-08-17 13:43:48 +02:00
Eric Lippmann 7252f3237a Introduce a constant for the controller namespace 
refs #5786
 2015-08-17 13:43:34 +02:00
Eric Lippmann 06e879f078 Throw an expcetion in our Dispatcher if the controller is not an instance of Zend_Controller_Action_Interface 
refs #5786
 2015-08-17 13:38:16 +02:00
Eric Lippmann e26a7fd4d1 Use Zend_Cotroller_Dispatcher_Standard::getActionMethod() in the Dispatcher 
refs #5786
 2015-08-17 13:34:47 +02:00
Eric Lippmann 965fee1e9e Fix 'void' method result used in the Dispatcher 
refs #5786
 2015-08-17 13:31:05 +02:00
Eric Lippmann 8b32edd6e9 Default to Zend's dispatcher if the controller name is empty 
refs #5786
 2015-08-17 13:29:47 +02:00
Eric Lippmann e8c0e97bb3 Add PHPDoc to the Dispatcher 
refs #5786
 2015-08-17 13:10:01 +02:00
Eric Lippmann f972a034e7 Fix license header in Dispatcher 
refs #5786
 2015-08-17 13:08:41 +02:00
Eric Lippmann 392eee5a1f Merge branch 'master' into feature/namespaced-controllers-5786 
Conflicts:
	library/Icinga/Application/Web.php
 2015-08-17 12:59:44 +02:00
Johannes Meyer 97245c5166 FilterEditor: Uppercase all words for non labelled filter columns 
refs #9029
 2015-08-14 15:36:54 +02:00
Johannes Meyer ca4789f114 FilterEditor: Fix automatic filter label creation 
refs #9029
 2015-08-13 17:20:40 +02:00
Johannes Meyer 1e6c394693 Controller: Create the filter editor in setupFilterControl() ... 
...instead of demanding a concrete controller to do so.
We still have to decide how to handle parameter preservation
properly.

refs #9029
 2015-08-13 17:05:13 +02:00
Johannes Meyer 63fb8dcafa FilterEditor: Do not show an empty line at the bottom of the select 2015-08-13 15:59:00 +02:00
Johannes Meyer 41b80efa0e FilterEditor: Support queries implementing the FilterColumns interface 
refs #9029
 2015-08-13 15:58:04 +02:00
Johannes Meyer 2e7ff7dd6e FilterEditor: Require an instance of Filterable for setQuery() 
refs #9029
 2015-08-13 11:35:45 +02:00
Johannes Meyer fc35f3e46b FilterEditor: Apply the filter on the query internally 
refs #9029
 2015-08-13 11:33:25 +02:00
Johannes Meyer 069fcc40ea FilterEditor: Accept null for method setColumns() 
refs #9029
 2015-08-13 11:30:26 +02:00
Johannes Meyer 9ad14fc644 FilterEditor: Accept null for method setSearchColumns() 
refs #9029
 2015-08-13 11:30:05 +02:00
Alexander Fuhr a9ff6eebc0 Merge branch 'master' into bugfix/cookie-support-7383 2015-08-13 11:22:14 +02:00
Alexander Fuhr 813154f6ef Cookie: Make it no static and use the request 
refs #7383
 2015-08-13 11:19:48 +02:00
Alexander Fuhr 2332b94f0b Request: Add getResponse() to retrieve the Response 
refs #7383
 2015-08-13 11:19:08 +02:00
Johannes Meyer fa1e3a763d Do not show the full layout on the login page 
...

refs #9892
 2015-08-13 08:12:30 +02:00
Alexander Fuhr ad8f16c185 Cookie: Set the rigth license line header 
refs #7383
 2015-08-11 16:37:05 +02:00
Alexander Fuhr cea3727c97 Merge conflicts 2015-08-11 16:35:14 +02:00
Eric Lippmann aa4e3c5a22 Dashboard: Defer construction of the Url object to Dashlet::getUrl() 
Before, the Url object was constructed in Dashlet::setUrl() and Dashlet::__construct8) which lead to an exception when parsing a module's configuration.php from our CLI.

refs #9375
 2015-08-10 14:05:08 +02:00
Eric Lippmann 1363ea4370 Menu: Defer construction of the Url object to Menu::getUrl() 
Before, the Url object was constructed in Menu::setUrl() which lead to an exception when parsing a module's configuration.php from our CLI.

refs #9375
 2015-08-10 14:05:00 +02:00
Johannes Meyer c7cc9e66df JavaScript: Load all available module javascript files 
refs #9702
 2015-08-06 15:15:02 +02:00
Johannes Meyer 9cea83242c StyleSheet: Load all available module stylesheets 
refs #9702
 2015-08-06 15:14:29 +02:00
Markus Frosch 083900dae0 Implement DblClickSelect as a Icinga Behavior 
refs #9826
 2015-08-04 14:06:33 +02:00
Eric Lippmann 688a08585b Merge branch 'master' into bugfix/error-prone-generictts-9611 
Conflicts:
	modules/monitoring/application/views/scripts/show/components/downtime.phtml
 2015-08-03 15:05:45 +02:00
Eric Lippmann ea5db51213 Fix "Try to get an inexistent pane." when clicking on the "Search" tab 2015-08-03 13:01:11 +02:00
Eric Lippmann 139baffdc6 lib: Make Dashboard::$tabs protected 
The SearchDashboard has to override Dashboard::getTabs() in order to set up the correct tab.
 2015-08-03 13:01:11 +02:00
Eric Lippmann 177fafaa56 lib: Fix TicketHook's PHPDoc 
refs #9611
 2015-08-03 11:05:48 +02:00
Eric Lippmann 451be1e97f monitoring/hooks: Add TicketHook::createLinks() 
Instead of calling preg_replace_callback w/o error handling in our view scripts, TicketHook::createLinks() will take care of that.

refs #9611
 2015-07-31 15:31:41 +02:00
Johannes Meyer 6c105b867e Form: Be less error-prone while calling array_search 2015-07-31 11:05:09 +02:00
Johannes Meyer 5345831742 SessionNamespace: Be less error-prone while calling array_search 2015-07-31 11:04:51 +02:00
Johannes Meyer 449a19c3a3 Session: Be less error-prone while calling array_search 2015-07-31 11:04:43 +02:00
Johannes Meyer 24cb123f47 Tabs: Be less error-prone while calling array_search 2015-07-31 11:04:36 +02:00
Eric Lippmann a234852f32 Merge branch 'feature/basic-auth-9660' 
resolves #9660
 2015-07-30 15:05:07 +02:00
Eric Lippmann 9060e8a034 lib: Only call Icinga::app()->getRequest() for getting the request outside of a controller 
Saves a call to getFrontController().

refs #9660
 2015-07-30 14:02:44 +02:00
Eric Lippmann 81aad9d6a6 Rename Notifiation::getMessages() to popMessages() 
Because the call to popMessages()--before getMessages()--automatically resets the notification messages on the instance, popMessages() is a much better name for the method.

refs #9660
 2015-07-30 13:45:39 +02:00
Eric Lippmann d545e1f7d1 lib: Don't write the empty notifications array into the session 
I combined this w/ introducing some constants for notification types and PHPDoc.

refs #9660
 2015-07-30 13:42:59 +02:00
Eric Lippmann 9aa1599a18 Form: Disable CSRF counter measure only on API requests 
refs #9660
 2015-07-30 12:04:22 +02:00
Eric Lippmann c23c7a5fa9 lib: Add Request::getIsApiRequest() 
If the Accept header is set to application/json it's an API request.

refs #9660
 2015-07-30 12:03:33 +02:00
Eric Lippmann db505281ee lib: Disable CSRF token on HTTP authenticated users and not XHR 
refs #9660
 2015-07-30 09:33:04 +02:00
Eric Lippmann 9f0e48a0a1 Don't send the X-Icinga-Module header more than once 
fixes #9349
 2015-07-30 09:28:05 +02:00
Matthias Jentsch 20aa17c831 Merge branch 'bugfix/selected-row-lost-after-autorefresh-8623' 
fixes #8623
 2015-07-29 17:30:45 +02:00
Matthias Jentsch 3e7cc299ec Fix issue that caused the refresh button to remove side bar 
Do not apply base target globally for all toolbar elements, but specifically for those that should remove side-bars.

refs #8623
refs #6436
 2015-07-29 17:18:52 +02:00
Thomas Gelf ba906d2fca FilterEditor: allow to set custom filter columns 2015-07-29 17:13:18 +02:00
Eric Lippmann 432efcb089 lib: Handle Response::setRerenderLayout() correctly 
The header is different if it's not a redirect.

refs #9660
 2015-07-29 15:08:36 +02:00
Eric Lippmann aaae7e03b4 lib: Introduce Response::setRerenderLayout() 
Instead of handling response headers based on flags in our controllers, this should happen in the request for usage w/o controllers.

refs #9660
 2015-07-29 14:39:45 +02:00
Eric Lippmann 91720810cc lib: Document Response::redirectAndExit() 
refs #9660
 2015-07-29 14:22:45 +02:00
Eric Lippmann a31c799043 lib: Introduce Response::getRequest() 
refs #9660
 2015-07-29 14:20:39 +02:00
Eric Lippmann 07849e0fea lib: Rename Authentication/Manager to Authentication/Auth 
refs #9660
 2015-07-28 17:08:55 +02:00
Eric Lippmann 7cfc78558d Merge branch 'master' into feature/secure-modules-9644 
Conflicts:
	library/Icinga/Exception/IcingaException.php
 2015-07-28 13:42:02 +02:00
Johannes Meyer e231ef8061 SortBox: Fix some documenation and code style issues 2015-07-28 12:04:16 +02:00
Johannes Meyer f7b35b04f4 SortBox: Properly apply sort rules and show the user the default 
refs #6644
 2015-07-28 12:03:50 +02:00
Eric Lippmann 78285b95a3 Make Controller::httpNotFound() variadic 
refs #9644
 2015-07-28 10:40:02 +02:00
Johannes Meyer 4d9aa54814 SortBox: Utilize a separate form for each control 
refs #9421
 2015-07-27 11:43:47 +02:00
Johannes Meyer 86ad6c48ff Form: Automatically remove query parameters only for GET forms 
refs #9421
 2015-07-27 08:52:33 +02:00
Eric Lippmann 8358e9165c Don't require the module permission for the default module 
refs #9644
 2015-07-24 15:11:21 +02:00
Thomas Gelf 727a2d7141 Paginator: relax requirements to Paginatable 
* we need no full query interface here
* introduced new interface "Paginatable"

fixes #9483
 2015-07-23 13:48:49 +02:00
Eric Lippmann a34ad0227f Don't load module menu entries if the authenticated user lacks the module permission 
refs #9644
 2015-07-23 12:59:30 +02:00
Eric Lippmann fd77c30838 Don't load module dashboards if the authenticated user lacks the module permission 
refs #9644
 2015-07-23 12:57:23 +02:00
Eric Lippmann e8e01257e6 Change interface of SearchDashboard to allow setting a user before calling ::search() 
Because search dashlets are provided by modules, the authenticated user's module permissions have to be validated before loading search dashlets provided by modules.

refs #9644
 2015-07-23 12:53:08 +02:00
Eric Lippmann b4f4ce4406 Require the module's permission for every module automatically 
Module permissions are not required if authentication is disabled on the controller.

refs #9644
 2015-07-23 12:51:10 +02:00
Eric Lippmann b000ae3a37 Do not require permissions if authentication is not required 
refs #9644
 2015-07-23 12:50:02 +02:00
Eric Lippmann aa567f8cd7 Introduce ModuleActionController::$requiresModulePermission 
refs #9644
 2015-07-22 14:56:02 +02:00
Eric Lippmann 13d954a956 Fix rawurlencode call 2015-07-22 13:36:25 +02:00
Eric Lippmann 52e352751e Revert "ModuleActionController: fix forward/X-Icinga-Module" 
This reverts commit bf82bd4ce1.

We have a not merged branch for this.

refs #9349
 2015-07-22 13:34:44 +02:00
Markus Frosch ab8e775188 Fix duplicate headers on forward() inside a controller 
This avoids that the JS loader flattening arrays.

refs #9349
 2015-07-22 13:34:44 +02:00
Johannes Meyer 54a77b7253 Merge branch 'master' into feature/support-for-file-uploads-8758 2015-07-22 13:30:56 +02:00
Johannes Meyer a199d36207 Stylesheet: Disable extendend @import statements provided by LESS 
fixes #9687
 2015-07-22 12:45:10 +02:00
Thomas Gelf bf82bd4ce1 ModuleActionController: fix forward/X-Icinga-Module 2015-07-22 10:53:42 +02:00
Johannes Meyer cecd94be50 Merge branch 'master' into feature/support-for-file-uploads-8758 2015-07-22 08:47:24 +02:00
Johannes Meyer c0de2e6ee3 Form: Add missing use statement for the ProgrammingError exception 2015-07-22 08:39:24 +02:00
Eric Lippmann ce2b686252 Add file and line of logged menu item renderer exceptions 
fixes #9696
 2015-07-21 16:54:23 +02:00
Johannes Meyer 8f2849f32a Form: Improve code readability.. 
..and avoid the necessity to provide another mock when testing
Form::handleRequest().

refs #8758
 2015-07-21 16:48:56 +02:00
Johannes Meyer 7c89887773 Form: Provide an absolute url as redirect url for successful frame uploads 
refs #8758
 2015-07-21 16:35:56 +02:00
Johannes Meyer 6c9819204d Form: Only work with a single type when handling redirect urls 
$form->setRedirectUrl('some/url') still works, but $form->getRedirectUrl()
will only return instances of Icinga\Web\Url now.
 2015-07-21 16:33:24 +02:00
Johannes Meyer fc481e527b Form: Process request parameter _frameUpload 
This parameter is being used to flag a request as form submission issued
by utilizing an iframe. Appending it to a form's action causes no redirection
to take place in case of successful submission and a reduced but still valid
layout to be printed in any way. Redirection must be handled by the client
regarding the meta tag "redirectUrl".

refs #8758
 2015-07-21 15:22:24 +02:00
Johannes Meyer 0a9a066749 Form: Do not create a new instance of Url when returning the redirect url 
We're shifting parameters and by creating a new instance we'll lose
such changes.

refs #8758
 2015-07-21 15:13:56 +02:00
Johannes Meyer 47fbc24f17 Merge branch 'master' into bugfix/improve-form-notifications-8983 
Conflicts:
	library/Icinga/Web/Form.php
	modules/setup/application/forms/AdminAccountPage.php
 2015-07-20 15:52:10 +02:00
Johannes Meyer 2164bb86c8 Tabs: Do not create a new instance of Url when rendering the refresh url 
We're shifting parameters and by creating a new instance we'll lose
such changes.

refs #8758
 2015-07-16 11:27:31 +02:00
Johannes Meyer 549f36f82c Form: Do not create a new instance of Url when setting the action 
We're shifting parameters and by creating a new instance we'll lose
such changes.

refs #8758
 2015-07-16 11:27:02 +02:00
Johannes Meyer d192410435 Introduce GET parameter _disableLayout to ... disable the entire layout 
refs #8758
 2015-07-16 11:23:48 +02:00
Johannes Meyer f3c8f2229f ErrorLabeller: Provide localized output for the MimeType validator 
refs #8758
 2015-07-15 15:15:15 +02:00
Johannes Meyer 5b908d85bb Form: Fix notifications 
* Coding style issues
* Notifications were not grouped by type
* Notifications of sub-forms were overwriting existing ones
(cherry picked from commit 147f6be714)
 2015-07-01 14:26:03 +02:00
Johannes Meyer d5ba40ac19 Form: Add hint support 
Hints are short messages displayed at the bottom of a form
used to describe specific aspects on how to interact with
the form.

refs #8983
 2015-06-30 15:02:58 +02:00
Johannes Meyer ea6f707bdf FormDescriptions: Do not render a description for required fields 
refs #8983
 2015-06-30 14:28:27 +02:00
Johannes Meyer 147f6be714 Form: Fix notifications 
* Coding style issues
* Notifications were not grouped by type
* Notifications of sub-forms were overwriting existing ones
 2015-06-30 14:25:33 +02:00
Matthias Jentsch aecfb2eb97 Merge branch 'bugfix/multiselection-not-visible-9054' 
fixes #9054
fixes #9346
 2015-06-30 14:08:19 +02:00
Johannes Meyer 702a9c9523 Form: Show notifications and errors below any descriptions 
They might be textually related to one or more descriptions.

refs #8983
 2015-06-30 13:22:54 +02:00
Matthias Jentsch 6a7e3fe440 Document multi selection and use clearer names 
refs #9054
 2015-06-30 13:03:41 +02:00
Matthias Jentsch aec59d9941 Use current filter to highlight active rows instead of storing active rows in JS 
Clean up selection code and move it into separate behavior and parse filter query to fetch selectable rows.

refs #9054
refs #9346
 2015-06-29 18:48:42 +02:00
Johannes Meyer e795665421 Wizard: Issue a partial validation only if desired for a certain page 
fixes #9306
 2015-06-29 17:08:31 +02:00
Johannes Meyer ebe144c16a Form: Do not encode actions twice 2015-06-24 16:15:45 +02:00
Johannes Meyer 8448f4ade4 Revert "Tabs: Merge the action's params into the current request url's params" 
This reverts commit ba4dd255ec.

fixes #9494
 2015-06-24 15:27:39 +02:00
Johannes Meyer 2e375dd57c Do not bypass the view renderer when rendering benchmarks 
fixes #9402
 2015-06-22 13:56:41 +02:00
Johannes Meyer d36f90d8cb Navigation: Restructure authentication backend configuration 
This moves the configuration tabs for user and group backends into
a dedicated menu entry called "Authentication". All tabs previously
available in this menu entry were moved into their own dedicated
menu entry as well to not to confuse users.

fixes #9398
 2015-06-22 13:26:24 +02:00
Thomas Gelf cd70c27519 Merge remote-tracking branch 'origin/master' into feature/refine-ui-for-rc1-9361 2015-06-18 15:18:42 +02:00
Thomas Gelf 1f5db2f8c1 ActionController: introduce showCompact 
Works like view=compact, it will allow us to "free" the "view" parameter
 2015-06-18 13:41:12 +02:00
Thomas Gelf 2f62a4383a Layout: add showFullscreen parameter 
refs #6729
 2015-06-18 13:41:12 +02:00
Thomas Gelf 3462f0ee9a Merge remote-tracking branch 'origin/master' into feature/refine-ui-for-rc1-9361 
Conflicts:
	modules/monitoring/application/views/scripts/host/history.phtml
	modules/monitoring/application/views/scripts/list/services.phtml
 2015-06-18 11:26:51 +02:00
Johannes Meyer 4d06bff5e8 Merge branch 'master' into feature/Move-notifications-to-the-bottom-of-the-page-8247 2015-06-17 12:47:58 +02:00
Johannes Meyer ba4dd255ec Tabs: Merge the action's params into the current request url's params 2015-06-16 16:02:32 +02:00
Johannes Meyer 68be11b929 UrlParams: Allow conversion to an associative array 2015-06-16 16:01:42 +02:00
Thomas Gelf b3028e9988 Merge remote-tracking branch 'origin/master' into feature/refine-ui-for-rc1-9361 2015-06-16 11:49:03 +02:00
Thomas Gelf 7a18638504 Revert "Web/Menu: move "About" to config section" 
Has been fixed in current master.
This reverts commit 56d67def00.
 2015-06-16 11:48:40 +02:00
Johannes Meyer aa0b1d43ef Menu: Move about page into the system menu as sub-entry 2015-06-16 11:43:58 +02:00
Thomas Gelf 56d67def00 Web/Menu: move "About" to config section 
This is IMO never worth a main menu entry, at least not in it's current
implementation and look-a-like.
 2015-06-16 00:18:31 +02:00