Commit Graph

12340 Commits

Author SHA1 Message Date
Eric Lippmann fadf12e98a Show empty groups with a filter chain too 2019-08-14 11:50:14 +02:00
Eric Lippmann c8ed889114 Fix operator in wildcard filter chains 2019-08-13 17:19:45 +02:00
Eric Lippmann 214a34a5a8 Always use subquery filters for subquery targets in the group views 2019-08-13 17:18:50 +02:00
Eric Lippmann 31d3153d2b Support wildcard filters in chains (#3903) 2019-08-12 13:41:38 +02:00
Feu Mourek 2ca3ffcb60 Add borders around form inputs (#3908) 2019-08-12 13:34:05 +02:00
Johannes Meyer b0875d40f1
Merge pull request #3895 from Icinga/fix/dashboard-migration-requires-all-locales
Don't fail dashboard migration just because a locale is missing
2019-08-12 13:33:07 +02:00
Johannes Meyer 86eefe5abf
monitoring: Highlight links in markdown content (#3893)
Doesn't apply to all markdown content. Our only use-case
currently is in the monitoring module and this already got
a known style for external/custom links.

Other modules may want to apply a different style or possibly
none at all.

resolves #3888
2019-08-12 12:58:29 +02:00
Eric Lippmann 6e05d852ee Forms: Distinguish placeholders from real values (#3911)
We now also use the ::placeholder pseudo-element selector instead of
several vendor prefixes.
2019-08-12 12:54:44 +02:00
Johannes Meyer 6bbafd1c3e
Merge pull request #3899 from Icinga/bugfix/solarized-theme-contrast-issues-3892
Bugfix/solarized theme contrast issues 3892
2019-08-12 11:24:31 +02:00
Johannes Meyer 6e5353fd50 solarized-dark: Let the dashboard settings look less weird 2019-08-12 11:17:12 +02:00
Feu Mourek 18f23ec551 Fix menu header contrast (#3898)
fixes #3897
2019-08-12 11:01:14 +02:00
Johannes Meyer be235c2357
Merge pull request #3902 from Icinga/fix/login-form-error-styles-3894
Fix bad looking login form errors
2019-08-12 10:56:51 +02:00
Johannes Meyer de0a46aaaf list/servicegrid: Also show problem toggle if the grid is flipped
fixes #3906
2019-08-12 10:43:03 +02:00
Feu Mourek 359d7f735b CSS: Edit form control classes in solarized dark 2019-08-08 11:00:13 +02:00
Eric Lippmann 97a679dbb9
Merge pull request #3905 from Icinga/revert-3836-fix/query-double-execution
Revert "Fix double query execution"
2019-08-07 13:34:53 +02:00
Eric Lippmann 666bdfb4c4 Revert "Fix double query execution"
This reverts PR 6ea012af7e, reversing
changes made to be5b9f870b.

The reverted commit fixed a double query execution bug by only executing
the query once in either SimpleQuery::hasResult() or upon iteration.

But the fix (b20291a60) introduced two problems:

* Default sort rules no longer work
* Show more links missing

We work with DataView objects in our controllers and views. When
iterating over a DataView, it applies its default sort rules and then
returns the underlying query, see DataView::getIterator().

DataView::hasResult() on the other hand does not apply the default sort
rules. So, if hasResult() is called first, the default sort rules are no
longer applied because the query will be executed only once.
The fix would be as easy as to apply sorting in DataView::hasResult() as
well.

But now the show more part kicks in. We know whether there are more
results because we execute queries with $limit + 1. This is enabled via
SimpleQuery::peekAhead(). Unfortunately, we call
SimpleQuery::peekAhead() ALWAYS after SimpleQuery::hasResult(). And
that's why the show more links are missing because the query is executed
only once with the "wrong" limit.

For now, we just revert the commit in question and postpone a proper fix
for the double execution.
2019-08-07 13:29:57 +02:00
Eric Lippmann 53529115e5 Fix bad looking login form errors 2019-08-05 17:17:32 +02:00
Florian Strohmaier fab25f87a7 Login: Fix error messages 2019-08-05 15:47:17 +02:00
Feu Mourek 75971ac3e2 Apply styles to editor / fiter controlls as well 2019-08-05 13:02:21 +02:00
Feu Mourek 61eabf0724 Darken menu styles and add splash of colour for selected 2019-08-05 12:51:43 +02:00
Feu Mourek b71f0780a7 Sort colour variables and adapt menu colours 2019-08-02 15:47:11 +02:00
Johannes Meyer 5333bbf04d loader.js: Also set title directly if layout is base target 2019-08-02 15:42:58 +02:00
Johannes Meyer 53598ecd18 DashboardCommand: Don't swallow custom dashboards 2019-08-02 14:14:28 +02:00
Feu Mourek bc4bb6741b Add form-backgrounds colour and apply to toggles and buttons 2019-08-02 12:53:52 +02:00
Johannes Meyer 49e84f2ad0 migrate: Don't fail dashboard migration just because a locale is missing 2019-08-02 12:00:26 +02:00
Feu Mourek 7acdf789e0 Change input background colour to darker shade 2019-08-02 10:54:11 +02:00
Feu Mourek f9a18e1ee6 Fix contrast for form inputs
refs #3892
2019-08-01 13:59:16 +02:00
Johannes Meyer 861c5601b6
Merge pull request #3875 from Icinga/feature/prepare-v2.7
Release v2.7
2019-07-30 10:49:59 +02:00
Johannes Meyer 105f32a006 locale: Update de_DE translation of the setup module 2019-07-30 10:36:01 +02:00
Johannes Meyer 7237d7e086 locale: Update de_DE translation of the monitoring module 2019-07-30 10:35:30 +02:00
Johannes Meyer 9d3ba8965f locale: Update de_DE translation 2019-07-30 10:35:02 +02:00
Eric Lippmann aa3ed53e6e Update AUTHORS 2019-07-30 10:19:53 +02:00
Eric Lippmann f35946df29 Raise version to 2.7.0 2019-07-30 10:19:53 +02:00
Johannes Meyer d271bea8ae CHANGELOG.md: Add changelog for v2.7 2019-07-30 10:19:53 +02:00
Johannes Meyer 5a57903f6c forms.less: Fix element error layout 2019-07-30 10:17:57 +02:00
Eric Lippmann 7730058c2c Fix Event Grid PostgreSQL error
PostgreSQL fails with failed to find conversion function from
unknown to text. PostgreSQL won't detect the type of object_type.
Most likely because it's used in a CASE statement and provided by a
subquery:

select case when s.object_type = 'service' then 1 else 0 end from
(select ('service') as object_type) as s;

This commit just removes object_type from the CASE statements because we
don't need them anyway. Recently we've changed the event grid query to
only select hosts or services and not both.
2019-07-30 09:32:59 +02:00
Peter Eckel 718ecd05a7 Fix Icinga 2 version detection
With this commit the version prefix character is treated as optional
which always used to be 'r' or 'v'. But this is gone since Icinga 2
version 2.11.0 RC1.

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2019-07-30 09:32:17 +02:00
Johannes Meyer 00e499024f
Merge pull request #3868 from Icinga/feature/subquery-filter-in-chain
Support subquery filters in filter chains
2019-07-30 09:28:21 +02:00
Eric Lippmann ac08fb2c3b Fix filtered links in the tactical overview
Filter chains require parantheses to work properly.
2019-07-30 09:17:25 +02:00
Eric Lippmann e61cb71c17 Use unique values for combined AND group membership filters 2019-07-30 09:17:25 +02:00
Eric Lippmann 0de923fc5f Support "old" combined group membership filter in subquery filter chains 2019-07-30 09:17:25 +02:00
Eric Lippmann bee5099a08 Fix show all services links in the servicegroup overview
Before, the forced servicegroup_name paramemter may interfere with an
existing servicegroup_name filter.
2019-07-30 09:17:25 +02:00
Eric Lippmann 58e3ae46a7 Fix servicegroup subquery filter in the servicegroup view 2019-07-30 09:17:25 +02:00
Eric Lippmann cc94c12e55 Fix show all hosts/services links in the hostgroup overview
Before, the forced hostgroup_name paramemter may interfere with an
existing hostgroup_name filter.
2019-07-30 09:17:25 +02:00
Eric Lippmann 9a75e101ee Support subquery filters in filter chains
Before, combined membership filters were only possible in filter
expressions, e.g. hostgroup_name=(a&b). Now, also
(hostgroup_name=a&hostgroup_name=b) is supported which makes it easier
to build such filters with the filter editor.
2019-07-30 09:17:25 +02:00
Eric Lippmann b8fb193bdd Add FilterChain::setFilters() 2019-07-30 09:17:25 +02:00
Johannes Meyer a33fda9dd7
Merge pull request #3846 from Icinga/feature/contact-and-contactgroup-filter
Add contact and contactgroup filters
2019-07-30 09:07:55 +02:00
Johannes Meyer ea3a541017
Merge pull request #3801 from Icinga/feature/improve-host-service-distinction-in-lists-3615
Improve host-service distinction in lists
2019-07-30 08:55:03 +02:00
Eric Lippmann bfec423eae Compat: Provide empty LESS mixin .code()
Some 3rd party modules (e.g. vsphere) use this mixin (though we never had it).
With lessphp version 0.5.0 using undefined mixins now throws exceptions.
Since we can't rely that users upgrade those modules first,
we provide the mixin for compatibility here.
2019-07-30 08:31:03 +02:00
Johannes Meyer d13cade0f3
Merge pull request #3871 from Icinga/feature/add-servicegrid-problem-toggle-3793
Servicegrid: Add toggle to show problems only or everything
2019-07-30 08:26:46 +02:00