erictian
db0f0d3c79
Remove CONST modifier to be spec compliance
...
Signed-off-by: erictian
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12194 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-24 09:38:10 +00:00
niruiyu
284ee2e829
Fix the comments to follow UEFI Spec regarding how to check an EFI_HANDLE is valid/invalid.
...
Signed-off-by: niruiyu
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11987 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-06 03:55:36 +00:00
erictian
17a6c337d2
when timeout is 0, infinite loop on the timeout request to follow UEFI spec
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11343 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-04 01:26:40 +00:00
ydong10
c9325700d0
Refine soma code to make code run safely.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10877 6f19259b-4bc3-4df7-8a09-765794883524
2010-09-15 07:48:11 +00:00
mdkinney
2dda77a650
Update UHCI and ECHI drivers to both Stop and Reset the host controller at ExitBootServices().
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10464 6f19259b-4bc3-4df7-8a09-765794883524
2010-05-07 22:46:14 +00:00
hhtian
cd5ebaa06d
Update the copyright notice format
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10420 6f19259b-4bc3-4df7-8a09-765794883524
2010-04-24 09:49:11 +00:00
lgao4
6691cae97e
Fix compile break on IA32 arch.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10292 6f19259b-4bc3-4df7-8a09-765794883524
2010-03-20 06:49:56 +00:00
erictian
aa91de055c
Fix a bug that usb keybarod can not work well when it is inserted at a usb 2.0 hub.
...
It's due to AsyncInterruptList does not update the corresponding QTDHw->Data with pci bus master address.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10286 6f19259b-4bc3-4df7-8a09-765794883524
2010-03-19 06:54:35 +00:00
lgao4
6bfbb5f0e0
1. Correct File header to ## @file
...
2. Remove unnecessary .common] postfix on section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10052 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-24 00:21:16 +00:00
rsun3
1ccdbf2a3e
Improve coding style in MdeModulePkg.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9793 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-19 06:42:21 +00:00
eric_tian
db731882fa
For the data region which will be touched by Pci Bus Master, we should allocate memory by PciIo.AllocateBuffer() but not AllocatePool() base library API. So the memory region can be used to map into Pci controller-specific address thru PciIo.Map().
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9323 6f19259b-4bc3-4df7-8a09-765794883524
2009-09-30 03:00:36 +00:00
eric_tian
3af875e220
In various archs, Processor memory address may not be same with Pci memory address. For usb host controller, we should use pci memory address to initialize framelist register and all address field in QH/TD.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9259 6f19259b-4bc3-4df7-8a09-765794883524
2009-09-14 05:26:09 +00:00
eric_tian
9420fc148a
modify the incorrect timeout value definitions in Usb driver
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9117 6f19259b-4bc3-4df7-8a09-765794883524
2009-08-19 01:41:43 +00:00
eric_tian
a261044cf5
code cleanup:
...
1. remove unused macro/remove unnecessary included header file
2. for those values defined by PCI spec, use the naming of definition in IndustryStandard/Pci.h
3. use BITX macro in Base.h rather than define one by self.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8992 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-24 05:34:55 +00:00
gikidy
0254efc01e
Replace references to RFC 3066 with RFC 4646.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8212 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-30 05:32:11 +00:00
jljusten
6d3ea23f11
Fix various 'EFIAPI' inconsistencies found while building MdeModulePkg.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8062 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-10 20:58:18 +00:00
vanjeff
0428a6cb12
fixed DMA not be stopped issue when gBS->ExitBootServices called.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8058 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-10 08:31:45 +00:00
eric_tian
3dcdbe7a52
update
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7694 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-25 13:08:46 +00:00
eric_tian
fd0d484170
clean ecc
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7461 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:17:01 +00:00
qwang12
7b728d6273
Use TO_START and BY_START for UEFI driver model driver.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7431 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 07:59:50 +00:00
qwang12
e08d88c59e
3) Doxygen comment cleanup.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7429 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 06:59:23 +00:00
eric_tian
603e7c0ce1
Add information in Meta-Data file
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7398 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 00:30:18 +00:00
eric_tian
af58e37731
add parameter check logic to clean up Klocwork warning.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7390 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 05:50:45 +00:00
jji4
49fabc83a5
Source level security checked
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7301 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 05:23:02 +00:00
jji4
7351070b11
Library usage checked
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7132 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 06:53:45 +00:00
jji4
7df7393feb
check the usage of %d,%x,%ld,%lx and so on in debug print statement.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7080 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 08:48:36 +00:00
qhuang8
f3f2e05db8
Clean up to update the reference of the these macros:
...
EFI_SIGNATURE_16 -> SIGNATURE_16
EFI_SIGNATURE_32 -> SIGNATURE_32
EFI_SIGNATURE_64 -> SIGNATURE_64
EFI_FIELD_OFFSET -> OFFSET_OF
EFI_MAX_BIT -> MAX_BIT
EFI_MAX_ADDRESS -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7056 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:34:21 +00:00
gikidy
5f8be01274
Add description to .inf files.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7004 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 03:21:13 +00:00
jji4
d354ab7ff9
1)Global variables have been moved backward ahead of functions.
...
2)INF comments have been reviewed.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6839 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 07:12:25 +00:00
gikidy
cfc8865f17
Remove some useless EDK_RELEASE_VERSION, EFI_SPECIFICATION_VERSION ,and review VALID_ARCHITECTURES in inf files with DSC file.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6818 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 09:08:05 +00:00
jji4
aa79b0b379
Global variables have been moved backward ahead of functions.
...
Only a few cases were left due to its module structure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6816 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 08:52:39 +00:00
vanjeff
ed66e1bc0d
clean up the un-suitable ';' location when declaring the functions.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
lgao4
60c93673b3
The driver and library in MdePkg, MdeModulePkg and Nt32Pkg that don't depend on PI spec should include Uefi.h not PiDxe.h.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5758 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-30 14:09:38 +00:00
lgao4
e872988180
remove the unused msa files in MdeModulePkg.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5726 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-25 05:03:29 +00:00
qhuang8
d3f1611730
Update some module INF files in MdeModulePkg to "UEFI_DRIVER"
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5676 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 09:18:44 +00:00
eric_tian
9920ae74af
modify coding style to pass ecc tool
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5575 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-28 02:43:46 +00:00
eric_tian
ab6495eacf
modify coding style to pass ecc tool and provide comments that complied with Doxgen.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5429 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-09 01:50:16 +00:00
eric_tian
a92d4e8a8e
Make USB Stack code pass ECC tool check.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5405 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-02 05:45:04 +00:00
vanjeff
b4c24e2d42
[Description]:
...
Sync 3 trackers.
1. A bug that may cause the low/full speed device behind 2.0 hub will not work.
2. MajorRevision and MinorRevision need updating.
3. Misuse UhciConvertPollRate in UHCI driver.
[Impaction]:
EhicDxe, UhciDxe and UsbBusDxe.
[Reference Info]:
EDK tracker 1122 - A bug that may cause the low/full speed device behind 2.0 hub will not work .
EDK tracker 1101 - Phoenix found issue in USB and Misuse UhciConvertPollRate in UHCI driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5370 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-25 05:50:41 +00:00
qhuang8
cc582cffd1
Rename the confusing PCD.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5169 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-06 09:34:46 +00:00
qhuang8
dd4047a51c
[Description]:
...
Add a feature flag in Uhci & Ehci to disable legacy USB SMI.
[Impaction]:
Platform integrator can choose to legacy USB SMI or not.
[Reference Info]
EDK Tracker 1082
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5081 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 11:02:59 +00:00
lgao4
f0a83bb308
[Description]:
...
Don't need disable the legacy USB SMI in UHCI and EHCI, which is only required by UoL.
[Impaction]:
Uhci and Ehci driver default don't need disable the legacy USB SMI.
[Reference Info]:
EDK tracker 1082
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4850 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-14 05:06:26 +00:00
jljusten
1682995344
edk2/MdeModulePkg/Bus/Pci/UhciDxe/ComponentName.c:
...
Fix #include filename for case-sensitive filesystems.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4753 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-26 01:10:10 +00:00
vanjeff
1c61953576
1. Added EFI_MEDIA_CHANGED and EFI_INVALID_PARAMETER returns in UsbMassReadBlocks().
...
2. Use DEBUG () to replace some native debug function in USB stack modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4689 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-13 09:08:24 +00:00
vanjeff
392d56cf4e
fixed comments problem.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4619 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-24 02:38:23 +00:00
vanjeff
ea5632e56d
1. Remove USB HC Protocol installing from Uhci module. It only installs USB2 HC protocol.
...
2. Restore Incompatible Pci Device Support Protocol in PciBus module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4617 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-23 09:41:04 +00:00
vanjeff
6a6d955c5f
Fixed potential issues to release resources when error occurs.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4341 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-28 03:55:36 +00:00
vanjeff
68246fa809
Save original PCI attributes in start() function and restore it in Stop() for those PCI device drivers.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4212 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-25 07:59:45 +00:00
lgao4
96f6af14d6
Remove the special logic on EFI_PCI_DEVICE_ENABLE in PciBus driver. And update drivers that use this macro. The reason is that
...
PciIoAttributes() in PciIo.c treats EFI_PCI_DEVICE_ENABLE specially so that when EFI_PCI_DEVICE_ENABLE is passed in, only the supported bits of driver will be enabled. Now many drivers use EFI_PCI_DEVICE_ENABLE to enable PCI device even if some of them don't support some of the attributes like EFI_PCI_IO_ATTRIBUTE_MEMORY. This doesn't conform to UEFI 2.0 spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4115 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-15 07:44:27 +00:00
qhuang8
d1aeb0bdc3
Add compiler hint of "GLOBAL_REMOVE_IF_UNREFERENCED" to prevent static unicode string table linked into final image if both PcdComponentNameDisabled and PcdComponentName2Disabled are set to TRUE.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4084 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-11 03:36:31 +00:00