eb3063e36d
Form: Add prefix path for custom form validators
...
refs #8415
2015-02-12 09:11:02 +01:00
97261cd8bd
lib: Do not setLayout('pdf') twice
2015-02-11 15:15:18 +01:00
ec8a89b96e
lib: Add recursive iterator over a DOMNode
2015-02-11 13:20:01 +01:00
c5b6d7ee41
Ensure that all required form elements are marked as such in HTML markup
...
refs #8349
2015-02-05 13:15:18 +01:00
6bae2e0a53
Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL
2015-02-04 10:52:27 +01:00
49e96b7200
Revert "monitoring/security: Guard delete comment action"
...
This reverts commit 4ef5f0c813
2015-02-03 16:51:00 +01:00
e8466ec7be
Fix inlinePie borders and SVG sizes
...
Add white border to inline piecharts in the list, to make them more visible on mouse hovering. Set a default image size for the loaded svg charts.
2015-02-03 16:46:12 +01:00
5b4fab0750
Add license header
...
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
5fa2e3cfdc
Revert "Add license header"
...
This reverts commit 338d067aba
2015-02-03 16:16:26 +01:00
4ef5f0c813
monitoring/security: Guard delete comment action
2015-02-03 16:11:56 +01:00
338d067aba
Add license header
...
fixes #7788
2015-02-03 15:51:04 +01:00
08fd000496
Remove any topbar related stuff
...
It's not used anywhere.
2015-02-03 12:42:02 +01:00
cb08b25e17
Remove executable flags from some PHP libraries
...
Note: dompdf.php is actually a CLI script, but has no shebang and is not used
in Icingaweb2.
Fixes #8345
2015-02-03 10:50:50 +01:00
f8c5bf6819
Web\Hook: support hook base classes in modules
...
refs #8207
2015-02-02 17:44:29 +01:00
3596e7ce62
FilterEditor: use preserved params
...
fixes #7904
2015-02-02 17:07:54 +01:00
9d6906bd64
Save user dashboards to Icinga Web 2's configuration directory
...
fixes #8056
2015-02-02 15:06:29 +01:00
5a1ebf9c89
lib: Implement Tab::getUrl()
2015-02-02 14:16:26 +01:00
bf470125c3
Merge branch 'master' into feature/create-missing-directories-when-creating-inis-8219
...
Conflicts:
modules/monitoring/library/Monitoring/MonitoringWizard.php
2015-01-30 16:21:42 +01:00
df29dd0e7c
Implement Form::hasPermission() and Form::getPermission()
2015-01-30 09:35:01 +01:00
2faf5f0ca1
Throw SecurityException in ActionController::assertPermission()
2015-01-30 09:34:19 +01:00
63305fdf9a
Add Icinga\Application\Config::saveIni()
...
Simplifies saving INI files. Icinga\File\Ini\IniWriter does already require an
instance of Icinga\Application\Config so it's obvious to give "Config" the
task to initialize the writer.. We do also have a central place to handle
creating missing ancestor directories now.
refs #8219
2015-01-30 09:32:08 +01:00
dd483d98df
LessCompiler: Remove useless argument
...
refs #6417
2015-01-29 14:04:47 +01:00
c1df1f822e
ifont: Reorganize files and drop use less attributes
...
fixes #6417
2015-01-29 11:25:37 +01:00
4abb30e55b
Merge branch 'master' into bugfix/ie8-fixes-6417
2015-01-28 17:08:56 +01:00
9d05190517
ifont: Fix empty font glyphs for IE8
...
The embedded font is included inline in the stylesheets. IE falls back and
tries to load one of the other font sources which was not exported by the web
server. This fix moves the fontello directory to public and add add a
prefix path to the embedded stylesheet.
refs #6417
2015-01-28 17:06:55 +01:00
6fde4eec30
Show all tabs except "Add to Dashboard" when issuing a command
...
refs #8279
2015-01-28 12:50:29 +01:00
cd8822ceff
lib: Add View::hasPermission()
2015-01-23 09:36:45 +01:00
6da3cb8403
lib: Reorder auth related functions in the ActionController
2015-01-23 09:36:05 +01:00
ef0a7c0e77
Revert "Security: Temporary grant all permissions"
...
This reverts commit 9b7e75a616
2015-01-22 17:11:53 +01:00
0f13c0428c
Controller: Introduce method assertHttpMethod()
...
We have actions where only certain HTTP methods, e.g. POST are allowed but they are not restricted yet.
Controller::assertHttpMethod() takes a number of allowed HTTP methods and responds with HTTP 405 in case
the current request's method is not one of the given methods.
2015-01-22 15:47:16 +01:00
9b7e75a616
Security: Temporary grant all permissions
...
We'll introduce permissions and restrictions in the next hours. Because our web setup
does not configure permissions yet, all permissions are granted for all users from now on.
2015-01-22 15:20:38 +01:00
94d727dbb8
Fix error in Icinga\Web\Form in case the label decorator is missing
...
Zend_Form::getDecorator() returns false instead of null in case the
decorator is not found.
2015-01-22 09:21:50 +01:00
10eacf9682
Allow jumping to already visited pages
...
This was already possible using just the base implementation of Wizard
but since WebWizard has optional pages it did not work with pages that
had such an optional page as previous page.
refs #8191
2015-01-21 15:39:06 +01:00
64a8006973
Add Wizard::isComplete()
...
Wizard::isFinished() is not applicable in case a wizard is a child of another
wizard. Wizard::isComplete() fulfills the need to check whether a user went
through a wizard entirely.
refs #8191
2015-01-21 13:56:53 +01:00
1f6a81aefb
Add Wizard::skipPage()
...
Required to not to duplicate code in custom wizards and to avoid errors
when detecting the direction.
refs #8191
2015-01-21 13:07:08 +01:00
2288e2a687
Add support for nested wizards
...
The amount of vertical dimensions is not limited as well as the location a
nested wizard can occur in the main wizard's order. In case a custom
implementation is used as nested wizard, all core functionalities are
still being utilized.
refs #8191
2015-01-20 15:54:14 +01:00
a1a36301fe
View: Add string helpers
2015-01-19 14:20:57 +01:00
50bbf77d0c
Fix module domain detection in Form::getTranslationDomain()
...
The usage of preg_replace had two errors:
1) The regular expression was wrong
2) $matches[0] always contains the full matched string, not the first parenthesized subpattern
The correct version of preg_replace would've been:
if (preg_match('/^Icinga\\\\Module\\\\([A-Za-z]+)\\\\/', get_called_class(), $matches) === 1) {
return strtolower($matches[1]);
}
But since there's no benefit of using a regular expression here except less speed, I replaced it
with using explode.
refs #7551
2014-12-30 10:08:33 +01:00
a1950aabba
Fix some obsolete or wrong docstrings
2014-12-29 16:27:28 +01:00
4cf8da4bb9
Do not focus logout menu item after a recurring login
...
Implement new MenuItemRenderer made for pages that are not part
of the regular site navigation and should trigger a complete site reload
instead of handling it via XHR.
2014-12-29 16:20:05 +01:00
5e40ce2088
Only check the session save path is writable if the session handler is 'files'
...
fixes #8053
Signed-off-by: Eric Lippmann <eric.lippmann@netways.de>
2014-12-29 09:37:47 +01:00
7f5ba135ee
Revert "Relax session storage check to the `files' save handler"
...
This reverts commit f7d11ce11f#8053
2014-12-29 09:37:07 +01:00
41c101d99f
Use neutral default color in perfdata piecharts
...
If nothing is known about the state of the monitoring object, the piecharts should neither indicate OK nor Critical.
2014-12-23 16:12:25 +01:00
cda5a6a903
Streamline chart implementation
...
Define sparkline layout through CSS class and remove label/tooltip formatting.
fixes #7077
2014-12-23 15:26:45 +01:00
64a2acd12e
Do not display labels for single data sets in perfdata piecharts
...
Display generic chart titles for the whole piechart that only contain title and percentage and don't style perfdata piecharts using HTML properties.
refs #7077
refs #6200
refs #7304
2014-12-23 15:14:17 +01:00
f7d11ce11f
Relax session storage check to the `files' save handler
...
fixes #8053
2014-12-22 11:02:48 +01:00
6d263ae316
Do NOT fetch the translation domain from the request in Form::translate(..)
...
It might be the case that a module is using a library form...
refs #7551
2014-12-19 13:07:51 +01:00
cf43b81400
Use the class namespace instead of the request in Form::translate(Plural)
...
refs #7551
2014-12-19 12:08:54 +01:00
e5d2d4cec2
Add module-aware Form::translate and Form::translatePlural
...
refs #7551
2014-12-19 11:29:24 +01:00
4dfac28393
lib: Fix PHPDoc of Form::setOnSuccess()
2014-12-18 17:21:06 +01:00
9647293f1b
Add our own dispatcher prototype for namespaced controllers
...
refs #5786
2014-12-18 17:11:30 +01:00
7710fd7b0e
Hide unsupported export formats
...
refs #8112
2014-12-18 16:20:41 +01:00
3fde78f2b3
Enable the dompdf float support and fix our list's layout
2014-12-15 13:56:19 +01:00
bca28a5ae2
Display inline pie-charts also in views exported to PDF
...
fixes #6463
2014-12-15 13:55:20 +01:00
cddb68bffb
ActionController: shift global parameters globally
2014-12-03 10:40:48 +01:00
1e8523aae6
Add Cookie helper class for cookie support detection
...
refs #7383
2014-11-26 14:24:19 +01:00
d41602a67c
Rearrange imports in Menu.php
2014-11-25 16:11:01 +01:00
eed10159fd
Menu: Don't render sub menus when a dot appears in the label
...
I guess this was intended to be a feature. Turns out to be a bug though :)
fixes #7772
2014-11-21 17:39:18 +01:00
d84318d8b8
Fix Menu's PHPDoc
...
Don't use @var and don't use @return self for fluent interfaces.
2014-11-21 17:13:39 +01:00
99ad72a0da
Remove the Help decorator
2014-11-20 13:50:40 +01:00
bdc0321f62
Dashboard: Fix wrong URL
...
refs #7751
2014-11-20 13:41:12 +01:00
bb664a87ea
Fix ugly positioning of help icons
...
If an element has a description, the description is now added to the element's label as title.
The CSS class has-feedback ensurers that the help icon is rendererd. If everything is working fine,
I'll the remove the super duper Help decorator.
2014-11-20 13:25:58 +01:00
e600dc8adb
Dashboard: Rename component to dashlet
...
refs #7751
2014-11-20 12:08:50 +01:00
fa44197947
Dashboard: fix complex urls
2014-11-19 16:45:15 +01:00
2830b13082
Merge branch 'master' into feature/security-gui-5647
2014-11-19 16:31:26 +01:00
32af89e0a7
Merge remote-tracking branch 'origin/master' into bugfix/broken-badges-7736
2014-11-19 15:28:27 +01:00
a2818bd937
Merge branch 'master' into feature/security-gui-5647
2014-11-19 14:13:26 +01:00
48699cacf4
Fix navigation layout in firefox and chrome
...
Hover css still broken
refs #7736
2014-11-19 12:15:18 +01:00
dbc1b1ce3e
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
2014-11-19 11:48:22 +01:00
a40f357f3c
Dashboard: Show error message when can not write to file
...
refs #4537
2014-11-19 11:47:31 +01:00
47d81ccf7b
css: allow to override vendor styles
...
* no more hovered icon underline
* simulate padding for headers in .controls
2014-11-19 10:33:57 +01:00
a5411c7a1c
Dashboard: Fix reading and disabled system dashboards
...
refs #4537
2014-11-19 10:33:41 +01:00
cfb0ca1be0
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
2014-11-19 10:21:50 +01:00
704a87c0f2
FilterEditor: make active element fit hover colors
2014-11-19 10:07:30 +01:00
eb823c4045
Widget\FilterEditor: fix root element stripping
2014-11-19 09:53:25 +01:00
c6ffdb3862
Widget\FilterEditor: fix failing parameter checking
2014-11-19 09:44:47 +01:00
5ace5fd2dc
Dashboard: Change icons
...
refs #4537
2014-11-18 17:47:57 +01:00
aef81a56d6
Merge branch 'master' into feature/security-gui-5647
...
Conflicts:
library/Icinga/Application/Config.php
library/Icinga/File/Ini/IniWriter.php
library/Icinga/Web/Form.php
library/Icinga/Web/Menu.php
2014-11-18 17:08:25 +01:00
f2717b6d26
Introduce Form::setOnSuccess() in favor of overriding the constructor
...
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
Conflicts:
library/Icinga/Web/Form.php
2014-11-18 17:02:39 +01:00
10cfecf2ec
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
...
Conflicts:
application/controllers/DashboardController.php
library/Icinga/Web/Form.php
library/Icinga/Web/Widget/Dashboard.php
2014-11-18 16:36:42 +01:00
07c0180b1c
Merge branch 'master' into feature/redesign-7144
2014-11-18 16:36:19 +01:00
80871313e4
Dashboard: Remove actions
...
refs #4537
2014-11-18 16:28:04 +01:00
1cbdd2b51c
Fix that hidden elements are getting ovewritten when validating a form
...
This works by "disabling" hidden elements which causes the browser not
to submit them. Due to a bug in Zend we need to manually ensure that
Form::isValid does not overwrite the value of disabled elements with null.
fixes #7717
2014-11-18 15:06:46 +01:00
760bf1a020
Disable partial validation of forms by default
2014-11-18 15:06:46 +01:00
38ef33276a
Replace description decorator through help decorator
...
refs #7696
resolves #7696
2014-11-18 14:58:54 +01:00
4a4fbaee8e
Add Help decorator for icon help description
...
refs #7696
2014-11-18 14:58:05 +01:00
c288a68ed5
Merge branch 'master' into bugfix/drop-zend-config-7147
...
Conflicts:
application/forms/LdapDiscoveryForm.php
2014-11-18 13:21:18 +01:00
7621f6642d
Adjust usages of Icinga\Application\Config
...
refs #7147
2014-11-18 13:11:52 +01:00
8805e4af4b
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
2014-11-18 12:52:02 +01:00
3e58ec2530
Dashboard: Use new controller actions
...
refs #4537
2014-11-18 12:51:28 +01:00
f9d7062476
Form: Add our element and decorator paths instead of calling createIcingaFormElement
...
createIcingaFormElement lacks all stuff applied in Zend_Form::createElement().
2014-11-18 12:51:06 +01:00
9a79cd58e9
Re-enable auto-refresh
2014-11-18 10:48:33 +01:00
e3629a7f41
Number element: Use is_numeric in favor of Zend's float validator
...
The float validator uses Zend_Locale which we have stripped in our vendor library thus leading to erroneous validation.
Further we'll use php-intl instead of Zend_Locale one day :)
fixes #7692
2014-11-18 10:31:40 +01:00
cbcd276b44
Dashboard: Rewrite forms and controller [WIP]
...
refs #4537
2014-11-18 10:04:41 +01:00
47414f3528
Introduce Form::setOnSuccess() in favor of overriding the constructor
...
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
2014-11-18 10:00:58 +01:00
bec0085683
Dashboard: Add urls to any dashboard (form)
...
refs #4537
2014-11-18 09:59:24 +01:00
769e8f2636
Dashboard/Component: Add remove link
...
refs #4537
2014-11-18 09:59:23 +01:00
b679c1e770
Dashboard: Refactor search/replace implementation
...
refs #4537
2014-11-18 09:59:23 +01:00
979bec24a5
Dashboard: Write user dashboards to disk
...
refs #4537
2014-11-18 09:59:23 +01:00
f6a2f6515d
Dashboard: Introduce user flag widget
...
Fix: Do not render disabled components.
refs #4537
2014-11-18 09:59:23 +01:00
af799d42dc
Widget/Dashboard: Cleanup object and remove unused stuff
...
refs #4537
2014-11-18 09:59:23 +01:00
f83bcbfd2b
updates current font set and changes service and reporting icons
2014-11-17 17:08:08 +01:00
878aa81d98
Changes conf icon in menu
2014-11-17 17:08:08 +01:00
0cea370a5c
Widget\Tab: fix tagParams check breaking tabs
2014-11-16 19:37:11 +01:00
2e1cc8ed35
Widget\Tabs: use icon font
2014-11-16 14:41:22 +01:00
9e0e3f12e3
FilterChain: addFilter should return itself
2014-11-16 02:49:33 +01:00
387928de02
Filter: support 'q' searches
...
This makes the overall search play nice with the FilterEditor and
reduces code in the action controller. Still some work to do, but
seems to be pretty fine right now.
2014-11-16 02:40:28 +01:00
5630374058
FilterEditor: handle ignoreParams correctly
2014-11-16 00:19:28 +01:00
e0bf021fb9
FilterEditor: apply submitted changes do filter
2014-11-15 23:49:37 +01:00
b1f82bd025
FilterEditor: add request handle support
2014-11-15 23:49:06 +01:00
7da87b7341
FilterEditor: split render function and clean up
2014-11-15 23:48:17 +01:00
0e4a8575a9
FilterEditor: new helper for text inputs
2014-11-15 23:46:36 +01:00
1c5cba9ddf
FilterEditor: don't sort all select's
...
Columns are now sorted separately, so that's fine
2014-11-15 23:45:03 +01:00
2eb2fa51da
FilterEditor: cache available columns
2014-11-15 23:43:13 +01:00
1d4ea88251
FilterEditor: clean up selectColumn
2014-11-15 23:42:15 +01:00
e6ded2eb3c
FilterEditor: use new id helper in selectSign
2014-11-15 23:39:21 +01:00
934a0a4914
FilterEditor: helper function for op dropdown
2014-11-15 23:38:36 +01:00
c700e86008
FilterEditor: add helper rendering new filters
2014-11-15 23:37:31 +01:00
711b1a5224
FilterEditor: elementId helper method for inputs
2014-11-15 23:34:21 +01:00
7993ad2fde
FilterEditor: add a couple of link generators
...
remove/add/strip/cancel
2014-11-15 23:32:38 +01:00
d6e3f06997
FilterEditor: readability
2014-11-15 23:31:17 +01:00
4a38c069f3
FilterEditor: do not export removal function
2014-11-15 23:30:06 +01:00
8858069514
FilterEditor: addTo method for special operations
...
Removed obsolete mark function
2014-11-15 23:27:58 +01:00
ee16391720
FilterEditor: no title, add cancel button
2014-11-15 23:24:55 +01:00
dcc0c213b2
FilterEditor: add redirect support
...
Not the cleanest way, could be improved
2014-11-15 23:18:50 +01:00
ac483a0fe6
FilterEditor: add compact search render support
...
We show the search box and a filter preview while not modifying the
filter
2014-11-15 23:11:55 +01:00
44d5ee8fa0
FilterEditor: make constructor parameter optional
...
...and use new setters
2014-11-15 23:02:38 +01:00
c5ca3b633c
FilterEditor: allow additional parameter control
...
We may want to keep additional parameters in our url and ignore other
ones when the filter changes
2014-11-15 22:57:25 +01:00
269f4b4c83
FilterEditor: allow to set the query from outside
...
Query will be used to provide a column list
2014-11-15 22:55:26 +01:00
118abbe980
FilterEditor: url-setter and protected lazy-shortcut
2014-11-15 22:54:40 +01:00
e75d0aa10e
FilterEditor: add getter and setter for Filter
...
We will shift quite some logic over here
2014-11-15 22:52:55 +01:00
a75bfd1dfb
FilterEditor: add failsafe string cast
2014-11-15 22:50:35 +01:00
0fd4a094ea
Web\Request: the request should know the URL
2014-11-15 22:40:29 +01:00
2ecdfefa85
Widget\Tabs: use icon for dropdown tabs
2014-11-15 22:39:42 +01:00
39d7d13ddb
AbstractWidget: default properties should be empty
...
Helps troubleshooting, getter would fail with a hard-to-track error
otherwise.
2014-11-15 16:54:59 +01:00
da47c7fc7e
Merge remote-tracking branch 'origin/master' into feature/redesign-7144
2014-11-14 21:32:57 +01:00
ddf2ef5cc9
Remove $request parameter from Form::onSuccess and Form::onRequest
...
fixes #7552
2014-11-14 14:59:29 +01:00
49d66a7b73
Use lessphp from the include path
...
refs #6165
refs #6166
2014-11-14 13:27:02 +01:00
6624b764cf
Use JShrink from the include path
...
refs #6165
refs #6166
2014-11-14 11:55:06 +01:00
1c4a5ce86f
Leave it up to Icinga\Web\Form to instantiate our own form elements
2014-11-14 10:15:27 +01:00
872dce2208
Prefer form elements of Icinga\Web\Form\Element in Form::createElement
2014-11-14 10:15:27 +01:00
69fdc6a329
Chart/InlinePie: smaller, white border for hover
...
I roughly changed the piechart defaults to their original (icon-like)
size. However, this is NOT how we should handle such changes. We MUST
be able to style them via CSS and get rid of that incredible amount of
HTML attributes.
I want to be able to set the height directly in CSS as em/px. And I want
also be able to set it to 100% and size the outer container.
refs #7077
2014-11-14 09:54:20 +01:00
d55c2a4c87
Widget\Filter*: fix parse error, replace minus
2014-11-13 21:47:40 +01:00
903219b302
Merge branch 'master' into feature/redesign-7144
...
Conflicts:
library/Icinga/Web/Menu.php
public/css/icinga/menu.less
2014-11-13 21:11:36 +01:00
20be45e8da
Enable icon font
2014-11-13 20:08:58 +01:00
6201858a68
Merge branch 'master' into feature/redesign-7144
2014-11-13 17:47:26 +01:00
ac2ec83852
Merge branch 'master' into feature/localization-form-6073
...
Conflicts:
library/Icinga/Application/ApplicationBootstrap.php
test/php/library/Icinga/User/Store/DbStoreTest.php
2014-11-13 17:03:41 +01:00
f86d3e7636
Web\StyleSheet: PCRE problem workaround, PHP5.3.7
...
Lines with embedded fonts where too long for lessphp's PCRE matches
unless PHP 5.3.7
2014-11-13 16:35:26 +01:00
28c239c6fd
Web\Controller: initial commit
...
* This is the controller all modules should inherit from.
* We will flip code with the ModuleActionController as soon as a couple
of pending feature branches are merged back to the master.
2014-11-13 15:42:25 +01:00
1c0e427d3b
Web\StyleSheet: compile webfont too
...
refs #6936
2014-11-13 15:41:13 +01:00
50869c783d
MonitoringMenuItemRenderer: webfont icon support
...
refs #6936
2014-11-13 15:30:00 +01:00
b16959bc44
Widget\Tab: support webfont icons
...
refs #6936
2014-11-13 15:22:47 +01:00
29c7c2e707
Web\MenuRenderer: support webfont icons
...
refs #6936
2014-11-13 15:21:49 +01:00
1aa8858dca
helpers/icon: support webfont shortcuts
...
* set icon class instead of icon image if no such is given
* fix TODO: merge parameter classes
refs #6936
2014-11-13 15:17:36 +01:00
ef2ec0442c
Merge branch 'master' into feature/redesign-7144
2014-11-13 14:40:26 +01:00
6be51d1565
Use Icinga\Web\Form\Element\Button instead of Zend's button
...
Due to a bug in Zend prior to 1.12.2 we need our own button implementation
to support earlier versions of the Zend Framework. The side effect is, that
this button can also be used as submit button for our forms as isChecked
will do its job now properly.
2014-11-13 14:26:12 +01:00
ac8cc0613c
Merge branch 'master' into feature/redesign-7144
...
Conflicts:
application/views/scripts/authentication/login.phtml
public/css/icinga/login.less
2014-11-12 17:21:54 +01:00
75475b1684
Rename getBootstrapDirecory() to getBootstrapDirectory()
2014-11-12 17:14:43 +01:00
b27d1d0058
Merge branch 'master' into feature/setup-wizard-7163
2014-11-12 14:48:15 +01:00
993390941a
Add user account menu and move logout and preferences inside it
2014-11-12 13:22:14 +01:00
5851886877
Widget\Tab: no underlined space after icon
2014-11-12 11:30:06 +01:00
62aacce469
Place the noscript button next to the element it is supposed to apply
2014-11-12 10:48:52 +01:00
7aae291f69
Merge branch 'master' into feature/setup-wizard-7163
2014-11-12 10:08:28 +01:00
f24b0e2a4e
MonitoringBackend: a few more places, doesn't hurt
2014-11-12 00:20:37 +01:00
0992f6cc15
Monitoring/MenuRenderers: unify logic, perftuning
...
This reduces duplicate code, query will be fired only once right now.
fixes #7554
2014-11-11 21:50:49 +01:00
8e3394fd55
Merge branch 'master' into feature/redesign-7144
2014-11-11 13:54:13 +01:00
9d292269b1
Merge branch 'master' into feature/setup-wizard-7163
...
Conflicts:
application/forms/Config/Resource/LdapResourceForm.php
test/php/application/forms/Config/Authentication/LdapBackendFormTest.php
2014-11-11 09:44:11 +01:00
8f212018ec
Move the setup wizard code to a dedicated module
...
refs #7163
2014-11-10 15:11:44 +01:00
79493592bb
Do not use Installer anywhere.
...
"It's setup."
refs #7163
2014-11-10 10:30:52 +01:00
7b99b74ae1
Prefer Icinga\Application\Config instead of Zend_Config
...
refs #7147
2014-11-07 13:53:03 +01:00
f9e8cc84b9
Design: headline and main menu
2014-11-06 00:09:14 +01:00
a06568ce41
security: Add menu entry for security
...
refs #5647
2014-11-04 16:19:20 +01:00
d2eddcbec6
Introduce Form::setOnSuccess() in favor of overriding the constructor
...
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
2014-11-04 16:15:06 +01:00
0db658b7f3
Fix that pgsql privileges were tested in case of mysql
...
refs #7163
2014-11-04 15:51:11 +01:00
170ded6510
Merge branch 'master' into feature/setup-wizard-7163
...
Conflicts:
library/Icinga/Authentication/Backend/LdapUserBackend.php
library/Icinga/File/Ini/IniWriter.php
2014-11-04 14:22:53 +01:00
581935c26f
Fix database setup and add support for the new schema
...
refs #7163
2014-11-04 13:51:15 +01:00
805cb9f079
Do not report whether files were skipped because they already exist
...
I've removed the summary earlier as a user does not configure this in any
way so it's not necessary to show him what should had happened to files
as well.
refs #7163
2014-11-04 13:47:37 +01:00
ea1f51ad9a
Use callable as type hint instead of Callback
...
PHP 5.4 introduces callable for type hinting and PSR-5 proposes callable.
2014-10-31 15:59:45 +01:00
16352fc10c
Move Logger to the Application namespace
...
fixes #7148
2014-10-31 10:27:17 +01:00
538bc8aec8
Drop unused method parameter in DbTool::checkPrivileges
2014-10-30 15:08:04 +01:00
521a36e0af
Fix method documentation of DbTool::checkPgsqlPriv()
2014-10-30 15:07:33 +01:00
e58520c3e6
Drop irritating and redundant docblock warning
2014-10-30 15:06:57 +01:00
1bd1b58d46
Drop unused use statement
2014-10-30 15:06:14 +01:00
9cd4aeec06
Fix MySQL login creation in DbTool::addLogin()
...
refs #7163
2014-10-29 15:45:57 +01:00
33a64eb55a
Do not throw an exception in DbTool due to an implementation detail
...
Throwing exceptions due to failing logic which is purely an implementation
detail must not affect the calling code in any way.
refs #7163
2014-10-29 15:45:26 +01:00
47d9426a1f
Use a hardcoded path where to look for modules
...
refs #7163
2014-10-29 15:43:08 +01:00
6a3244d8df
Do not show a summary for the MakeDirStep
...
The user does not configure anything this step will process so there is no
need to show the user a summary about something he can't control.
refs #7163
2014-10-29 08:38:59 +01:00
83cfcef85c
Add EnableModuleStep
...
refs #7163
2014-10-29 08:38:59 +01:00
a899070606
Move MakeDirStep to Icinga\Web\Setup
...
refs #7163
2014-10-29 08:38:59 +01:00
2e8c0cffe6
Check privileges of database user accounts before continuing with the setup
...
Implement owner and privilege checks for postgresql, and fix some errors in
existing MySQL privilege checks.
resolves #7389
2014-10-27 15:08:52 +01:00
851682cf18
Make page count assertion more sensitive
...
refs #7163
2014-10-24 14:06:31 +02:00
03bbc2e2e6
Use a dedicated method to clear a wizard's session
...
Simplifies session removal in case a sub-class of Icinga\Web\Wizard
requires special session handling
refs #7163
2014-10-24 13:55:41 +02:00
216c072024
Implement installation routines modularly
...
This allows us to "merge" module installation
routines with our main installer routines.
refs #7163
2014-10-23 11:41:16 +02:00
a5b10235d2
Add more detail to error messages when token validation fails
...
refs #7163
fixes #7410
2014-10-21 16:10:21 +02:00
9f127be1dc
Merge branch 'master' into feature/setup-wizard-7163
...
Conflicts:
application/forms/Config/General/LoggingConfigForm.php
2014-10-17 13:04:59 +02:00
d1ea7e87a2
Improve form styling slightly
2014-10-15 15:46:07 +02:00
38ee467603
Fix that the session is written too early when post-dispatching
2014-10-15 13:15:30 +02:00
2c09ca1623
Fix that retrieving notifications causes them to be dropped entirely
...
I've broke this when doing some improvements while being
brainless, obviously.
2014-10-15 13:14:51 +02:00
5d44a005a0
Fix that notifications are not registered
2014-10-15 13:02:56 +02:00
937dbe2c15
Add missing close buttons to views without tabs
2014-10-14 17:54:52 +02:00
b5798331db
Wrap form notifications in <p> by default, not <div>
2014-10-13 09:41:36 +02:00
437b41c6c1
Merge branch 'master' into feature/setup-wizard-7163
2014-10-13 08:18:43 +02:00
ca6eca6b67
Quote database names, usernames and passwords when setting up the db
...
refs #7163
2014-10-09 16:02:18 +02:00
c3404fdc67
Support prepared statements in DbTool::exec and DbTool::query
...
refs #7163
2014-10-09 15:03:51 +02:00
f8f27e046d
Ensure that we advance a wizard when pushing ENTER
...
refs #7163
2014-10-09 13:41:06 +02:00
cc61dc2b01
Form: Don't override Zend_Form::setDefaults()
...
fixes #7315
2014-10-08 17:43:28 +02:00
1cbe2451a8
Merge branch 'master' into feature/setup-wizard-7163
...
Conflicts:
application/forms/Config/Resource/StatusdatResourceForm.php
2014-10-08 16:34:31 +02:00
89ae05899b
Query a particular login name and create database logins using the DbTool
...
refs #7163
2014-10-08 15:33:51 +02:00
abc34a5f1a
Add database setup routines
...
refs #7163
2014-10-07 17:08:50 +02:00
b50c780bcf
Let the setup's view scripts be a bit more generic
...
refs #7163
2014-10-06 16:04:58 +02:00
83006c014c
Wrap wizard buttons in a div
...
refs #7163
2014-10-06 11:07:21 +02:00
2956d9e342
form: Correctly set our default element decorators
2014-10-06 10:42:24 +02:00
fa96a1cbbe
Number: Extend our FormElement class
2014-10-06 10:21:17 +02:00
a3409b166d
Note: Extend our FormElement class
2014-10-06 10:21:02 +02:00
9be52a9148
DateTimePicker: Extend our FormElement class
...
fixes #7322
2014-10-06 10:20:26 +02:00
9db76bf371
CsrfCounterMeasure: Save calls to `setRequired()' and `setIgnore()'
2014-10-06 10:19:36 +02:00
8106fe4f79
form: Add `FormElement' as base class for our elements
2014-10-06 10:19:05 +02:00
a980184eb9
Move css instructions to dedicated stylesheet
...
refs #7163
2014-10-01 15:46:58 +02:00
ed91e119d2
Add close-button to all containers
...
refs #6216
2014-10-01 14:51:51 +02:00
8f79e0a713
Fix warning "references should be passed by variable only"
2014-10-01 09:17:48 +02:00
08d259eccf
Add database creation page
...
refs #7163
2014-10-01 09:16:53 +02:00
bbee06b57f
form: Ignore note elments when retrieving values at form level
2014-10-01 08:18:34 +02:00
7b01525456
Fix that navigation buttons have labels
...
refs #7163
refs #7320
2014-09-29 16:42:38 +02:00
513d5e30a4
Merge branch 'master' into feature/setup-wizard-7163
2014-09-29 16:16:12 +02:00
ab8436dea8
Fix Icinga\Web\Form\Element\Note using its default decorators
2014-09-29 16:12:38 +02:00
cbadaa78d6
Merge branch 'master' into feature/setup-wizard-7163
2014-09-29 15:35:52 +02:00
4a14dc5916
Add interface for setup wizards
...
refs #7163
2014-09-29 14:19:05 +02:00
5d6391242c
Add interface for installers
...
refs #7163
2014-09-29 14:18:50 +02:00
929344e68b
Add container to store and handle installation requirements
...
refs #7163
2014-09-29 12:25:29 +02:00
aa17f2828d
Add utility to ease working with databases without the use of Zend
...
refs #7163
2014-09-29 12:24:56 +02:00
7c53e6f7be
Improve page permission handling
...
refs #7163
2014-09-29 11:31:59 +02:00
5c13a19b1a
Populate a wizard page in case the user moves backwards
...
refs #7163
2014-09-29 11:31:13 +02:00
73b41769e7
__toString() should call __toString() as well if possible
...
There may be cases that an error occurs and another _toString()
implementation handles that appropriately. This is such a case.
2014-09-29 11:28:58 +02:00
3107eb87bb
Silence stat() call
2014-09-29 11:24:59 +02:00
b2f12e1caa
Revert "lib: Remove form element `Note'"
...
This reverts commit c21d7d1fdd
2014-09-26 16:19:44 +02:00
c8a24f72b8
Introduce getValue() in Preferences and fix the loading of values
2014-09-26 14:15:50 +02:00
8e48853f4d
Add Wizard
...
This is a container/controller for form based wizards. Can be used directly
or by using a subclass that allows for a more customized handling.
refs #7163
2014-09-24 10:46:36 +02:00
028a6c442b
Fix persisting notification messages in the session
2014-09-24 10:46:35 +02:00
635b802a2b
Add tests for hasChanged, set/getByRef and fix setByRef
2014-09-24 10:46:35 +02:00
6f988cb94c
Remove method write() from Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
c00dbf9f46
Write session on response
...
There should not be any necessity to write the session once changes are
being made to it. We now track whether changes were made and write
the session when responding to the user's request if so.
2014-09-24 10:46:35 +02:00
7fcd665aaa
Fix value invalidation in Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
efab6c7827
Add method set/getByRef to Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
c772787967
Re-add TokenValidator
...
refs #7163
2014-09-24 10:46:35 +02:00
cde3ec6bc8
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
modules/monitoring/application/controllers/TimelineController.php
2014-09-23 22:54:17 -07:00
07a4b25560
Merge branch 'master' into bug/history-notification-time-format-6980
2014-09-23 11:38:24 +02:00
e784aa34b6
Implement DateTimeRenderer and fix history time format
...
refs #6980
2014-09-23 11:36:09 +02:00
6c8f324dd4
Add filter widget to StateHistorySummary and fix some minor bugs
...
fixes #6979
2014-09-19 17:41:44 +02:00
4ce71ef2f2
Display a tooltip on days without events
2014-09-19 17:41:44 +02:00
6f1cb6f1f3
Adjust brightness for different event type colors
2014-09-19 17:41:44 +02:00
65203fddcf
Add additional state history filters for time interval and event type
2014-09-19 17:41:44 +02:00
ef2f332869
Do not refresh a container when form input was changed or a form element is focused
...
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.
refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
264d818133
Do not save config references in the `ActionController'
...
This is redundant because our `Config' class already caches loaded configs.
2014-09-19 14:44:21 +02:00
119e23e79e
Make `InlinePie's setters fluent
2014-09-19 14:43:25 +02:00
bea110d0c7
Fix `Form::isSubmitted()' for dynamic submit labels
2014-09-19 14:27:04 +02:00
5b5f553d0d
form: Fix dynamic submit label retrieval
2014-09-19 13:39:38 +02:00
c51b05296e
Merge branch 'master' into bugfix/commands-6593
2014-09-19 13:18:47 +02:00
3c9859a0f1
Call `Form::getSubmitLabal()' in `Form::addSubmitButton()'
...
This allows us to dynamically define submit labels in form subclasses.
2014-09-19 13:00:15 +02:00
5ba96c32f9
`Form::setDefaults()' fix strict standards violation
...
Declaration of Icinga\Web\Form::setDefaults() should be compatible with that of Zend_Form::setDefaults().
2014-09-19 12:59:01 +02:00
7eb51f6367
form/csrf: Set the csrf element decorators in the element not in the form
2014-09-19 12:57:53 +02:00
d091e2150c
Fix `ActionController::prepareInit()' php doc
2014-09-16 18:43:14 +02:00
b38ef9c0bd
Implement plural and context based translation functionality
...
refs #6982
2014-09-16 15:19:23 +02:00
c21d7d1fdd
lib: Remove form element `Note'
...
Zend already provides this.
2014-09-16 09:54:23 +02:00
5c647719e4
lib/ModuleActionController: Fix stupid code
2014-09-16 09:29:03 +02:00
f8edb4f220
lib: Add method `ActionController::prepareInit()'
...
As it should not be required for controllers to call the parent's init() method, base controllers should use
prepareInit() in order to prepare the controller initialization.
2014-09-16 09:28:10 +02:00
e2b5e05f21
Implement plural translation (testing)
2014-09-15 14:11:42 +02:00
8bf66425d1
Merge branch 'master' into bugfix/commands-6593
2014-09-15 09:27:56 +02:00
9e0d6657b7
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-15 09:27:07 +02:00
f48094f01a
Merge branch 'master' into feature/translation-plurals-6982
2014-09-15 08:34:19 +02:00
1932a912f8
Fix month-naming for different week arrangements
...
fixes #7179
2014-09-12 11:51:51 +02:00
6c3c466f92
Start history grid weeks at monday
...
Add configuration option for week-start and set the default to Monday.
2014-09-12 11:51:51 +02:00
e42b7b3026
Display current weeks at the beginning of the history grid
...
fixes #7179
2014-09-12 11:51:51 +02:00
8ceef96d28
Web\Hook: remove unused methods
2014-09-12 09:53:38 +02:00
93777ac15e
Web/Response: use & to encode XHR redirection URLs
2014-09-12 09:28:11 +02:00
ad53f7ad3d
Use EventEmitter class as a way to delegate events from behaviors to the dom
2014-09-12 09:09:21 +02:00
0e926ba05e
Revert "Revert "Web\Hook: register('grapher')
...
This reverts commit 65564cda65
2014-09-12 09:02:23 +02:00
583fd46f15
Experimental Plural Translation Implementation
...
Personal BACKUP
2014-09-11 18:04:10 +02:00
65564cda65
Revert "Web\Hook: register('grapher') => GrapherHook"
...
This reverts commit 4a89c2e163
2014-09-11 15:00:28 +02:00
9376ceed33
Add missing use-statement for Exceptions in MenuRenderer
...
fixes #7157
2014-09-10 17:12:19 +02:00
f58da73e2d
Move javascript behaviors into separate classes
2014-09-10 17:02:39 +02:00
d99d50b3c4
Add stub for javascript behaviors
2014-09-10 17:02:38 +02:00
ea63dad087
viewHelpers: use the view
...
refs #7177
2014-09-10 16:56:26 +02:00
631b3d9f6e
viewHelpers: There is no $this, not before 5.4
...
refs #7177
2014-09-10 16:54:57 +02:00
c2fe0232ca
helpers/attributes: escape value
...
refs #7177
2014-09-10 16:07:00 +02:00
27960fc628
Catch exceptions in MenuItemRenderers
...
fixes #7157
2014-09-10 14:38:11 +02:00
83772c6684
Merge branch 'master' into bugfix/rebuild-form-builder-5525
2014-09-09 16:03:22 +02:00
71f55e388f
Only display custom menu renders on XHR requests and not in regular HTML
...
The main navigation should be rendered without a working backend.
fixes #7143
2014-09-09 15:33:42 +02:00
e7c021845d
Simplify subform usage
...
refs #5525
2014-09-09 15:00:33 +02:00
f7f6bcc447
Make Form base class more test friendly..
...
refs #5525
2014-09-09 09:31:15 +02:00
c8ce1088c9
Disable checking whether a form is sent when form identification is disabled
...
refs #5525
2014-09-09 09:30:33 +02:00
a352131d65
Move charts.less into widgets.less
...
Don't use a separate less file for only two styles
2014-09-08 16:25:11 +02:00
e8164c6da0
Show tooltips to describe menu badges
2014-09-08 10:38:02 +02:00
0e7ca591ec
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
application/views/helpers/FormDateTime.php
modules/monitoring/application/forms/Command/CommandForm.php
2014-09-08 10:16:05 +02:00
e39dd64a1b
Fix layout of HistoryColorGrid
...
Use actual color for critical hosts and only display the first two letters of the weekday
2014-09-08 09:52:28 +02:00
12b4865559
Fix incompatible declaration of Form::setDefaults()
...
PHP with strict standards: Declaration of Icinga\Web\Form::setDefaults()
should be compatible with that of Zend_Form::setDefaults()
refs #5525
2014-09-08 09:42:02 +02:00
930e6e7d71
We shouldn't require Form::createElements() to return self
...
refs #5525
2014-09-08 09:24:53 +02:00
ae9e5a40cc
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-08 08:46:53 +02:00
4a89c2e163
Web\Hook: register('grapher') => GrapherHook
2014-09-05 18:54:50 +02:00
51d14af154
Merge branch 'master' into feature/navigation-unhandled-badges-7114
...
Conflicts:
library/Icinga/Web/Menu.php
2014-09-05 18:14:29 +02:00
19eca5f50b
Show all unhandled host and services in a menu
...
Add the option to define custom renderers for menu items and implement renderers to
display all unhandled services and host in a badge in the navigation.
resolves #7114
2014-09-05 17:57:20 +02:00
596800bd7d
helpers/url: overwrite existing params
2014-09-05 17:56:55 +02:00
4bb065d9bb
Web\Menu: provide and render unique id
...
fixes #7083
2014-09-05 17:24:55 +02:00
b034028ff8
Menu: do not show application log when none exists
...
Added new functions to the logger to get rid of distributed logging config
"knowledge".
fixes #7062
fixes #7098
2014-09-05 15:31:30 +02:00
3ce42489c6
Timezone detection: Client implementation
...
refs #6078
2014-09-05 15:24:13 +02:00
e205ca4d0b
FilterWidget: remove icon titles
...
fixes #7105
2014-09-05 14:50:22 +02:00
33d2175b77
Web\UrlParams: allow to merge single value
2014-09-05 13:35:51 +02:00
baa775dd74
Web\Url: document with() method
2014-09-05 11:40:43 +02:00
1c2207f51d
Web\Url: provide a with() function
2014-09-05 11:21:10 +02:00
4c8407e2b6
Web\StyleSheet: outer #layout access for modules
...
fixes #7093
2014-09-05 10:56:26 +02:00
b14e7f5696
LessCompiler: remove obsolete cache-related comment
2014-09-05 10:56:25 +02:00
fc72ddfbc8
Adjust Preferences/GeneralForm to use handleRequest() &. Co.
...
refs #5525
2014-09-05 10:21:24 +02:00
d021747bde
Fix form widgets
...
refs #5525
2014-09-05 09:17:09 +02:00
8846f17ae1
Make it possible to disable form identification
...
refs #5525
2014-09-05 09:16:09 +02:00
ba623d0544
SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString
2014-09-04 22:54:41 +02:00
0f7f2f2d8b
SearchDashboard: rename ::load() to ::search()
...
Function signature didn't match parent factory function
fixes #7081
2014-09-04 19:35:31 +02:00
0f8d5bddba
Web\Menu: make use of Web\Url
...
refs #7083
2014-09-04 19:18:09 +02:00
f91892cb80
Web\Url: add matches() function
...
fixes #6992
2014-09-04 18:46:58 +02:00
e4d1143870
Add SearchDashboardTest
2014-09-04 18:31:08 +02:00
1eacde0233
Implement modules self provided search configuration
...
refs #6495
2014-09-04 16:31:10 +02:00
c8eaf66823
GrapherHook: Rework hook
...
refs #6932
2014-09-04 14:00:48 +02:00
4fb47ef768
Hook classes: Add class suffix if not exist
...
refs #7066
refs #7067
refs #7068
2014-09-04 14:00:48 +02:00
c3c0043307
Merge branch 'master' into bugfix/commands-6593
2014-09-03 23:23:20 +02:00
a4da3b61b3
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-03 23:23:02 +02:00
da85112538
Merge branch 'master' into feature/svg-chart-tooltips-7024
2014-09-03 17:08:00 +02:00
37b168995b
Rename tipsy stylesheet file type to css and add license
2014-09-03 17:01:07 +02:00
b10b1ea034
Add jQuery tooltips
2014-09-03 15:53:56 +02:00
2025fb3a2f
lib: Let the date-and-time input control behave as defined in HTML5
...
refs #6593
2014-09-03 14:40:58 +02:00
acbd2bd7c0
Merge branch 'master' into feature/dashboard-component-disabled-property-6986
2014-09-03 14:40:30 +02:00
906de4e679
lib: Add the HTML5 attributes 'min', 'max' and 'step' to the number input control
...
refs #6593
2014-09-03 14:39:42 +02:00
1a4e908461
lib: Let `DateTimeValidator' validate values as defined in HTML5
...
See http://www.w3.org/TR/html-markup/datatypes.html#common.data.datetime for the specification.
refs #6593
2014-09-03 14:36:18 +02:00
7cfc051228
Add tests for Dashboard and fix doc blocks
...
refs #6986
2014-09-03 14:36:04 +02:00
54a834266c
Form::createElements() should add elements instead of returning them
...
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().
refs #5525
2014-09-03 12:21:31 +02:00
3d352ba446
Filter: add FilterNotEqual and FilterMatch
...
fixes #6557
2014-09-02 19:51:56 +02:00
5485ca8a25
lib: Use Zend's `Int' validator in the `Number' form element
...
Further disabled default decorators since our form sets them.
refs #5525
2014-09-02 16:54:43 +02:00
95c839a8bd
Remove remaining usages of the ElementWrapper- and HelpText-Decorator
...
refs #5525
2014-09-02 16:50:59 +02:00
6faedf5733
ActionController: no benchmark for no renderer
...
Benchmarks should not be shown when the renderer is no longer available.
2014-09-02 16:49:28 +02:00
e4687a60f9
Web\JavaScript: use Cache and ETags
...
refs #6927
2014-09-02 16:25:44 +02:00
1ba3df310c
Remove BaseConfigController, User\Message and Widget\AlertMesageBox
...
refs #6758
2014-09-02 16:25:03 +02:00
539ab91ffa
Add the FormErrors decorator as default decorator for forms
...
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.
refs #5525
2014-09-02 16:25:03 +02:00
f0d6cf994e
Web\StyleSheet: use Cache and ETags
2014-09-02 16:24:55 +02:00
ff6483cec5
Web\FileCache: initial implementation
...
refs #6927
2014-09-02 16:22:48 +02:00
338f549233
Add class ReadablePathValidator
2014-09-02 16:19:45 +02:00
39bb01b433
Rename Icinga\Web\Form::onShow() to onRequest()
...
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.
refs #5525
2014-09-02 16:19:45 +02:00
d4c4ab7b2c
lib/form: Fix default element decorators but breaking noscript layout
...
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.
Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.
refs #5525
2014-09-02 15:23:07 +02:00
8478ef3fce
lib: Remove `HelpText' form element decorator
...
Zend already has a `Description' decorator.
refs #5525
2014-09-02 15:05:47 +02:00
7143837ae3
lib: Remove `ElementWrapper' form element decorator
...
Zend has a `Label' decorator already.
refs #5525
2014-09-02 15:04:23 +02:00
62c0f0be03
Web\Session: implement lazy loading
...
fixes #7055
2014-09-02 13:23:15 +02:00
26339b128a
Add disabled property and implement the functionality
...
refs #6986
2014-09-02 13:16:21 +02:00
bb0e1dc105
Revert "Fixes unaccepted behavior in module configuration"
...
This reverts commit 236d384bab
2014-09-02 10:23:41 +02:00
cd8015f41a
Pass the current form instance to the callback as second argument
...
refs #5525
2014-09-01 14:58:16 +02:00
0822aff293
library/form: Fix return value of `getName()' not being filterd the first time it's called
...
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.
refs #5525
2014-09-01 14:40:45 +02:00
f3e74f0f24
library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
...
Before, the class attribute would've been overwritten.
refs #5525
2014-09-01 09:44:04 +02:00
fb5685bac3
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Config/Authentication/BaseBackendForm.php
application/forms/Config/Authentication/DbBackendForm.php
application/forms/Config/Authentication/LdapBackendForm.php
application/forms/Config/Authentication/ReorderForm.php
application/forms/Config/LoggingForm.php
application/forms/Config/ResourceForm.php
application/forms/Preference/GeneralForm.php
library/Icinga/Application/Config.php
library/Icinga/Web/Form.php
modules/monitoring/application/controllers/ConfigController.php
modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
79b0ed64ec
Make it possible to provide a closure to be called instead of onSuccess()
...
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.
refs #5525
2014-08-29 12:21:31 +02:00
bf23688e73
Make autosubmit work in non-JS enviroments
...
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.
refs #5525
2014-08-29 09:08:53 +02:00
486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
3642b7b6fc
Adjust CSS for inlinePies to be centered on the current line
2014-08-28 18:27:30 +02:00
45638b218c
Throw IcingaException rather than Exception
...
fixes #7014
2014-08-27 16:03:15 +02:00
7ff51caed0
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
236d384bab
Fixes unaccepted behavior in module configuration
...
fixes #7011
2014-08-27 14:57:08 +02:00
e1329058db
Do not hard code the name of the form identification element
...
Like the csrf element name the form identification element name should
be publicly accessible as well.
refs #5525
2014-08-27 13:14:40 +02:00
1dea19504f
Revert "Remove leading backslashes from the targets of use statements"
...
This reverts commit 87a5967501
2014-08-27 12:24:11 +02:00
88698cb05d
Hook/TopBar: Rework interface for monitoring top bar
...
refs #6929
2014-08-27 11:31:48 +02:00
b7ae66b496
Hook: Add web hook base class
...
refs #6929
2014-08-27 11:31:47 +02:00
e0d7c3855d
Hook: Add class suffix for base class testing
...
refs #6928
2014-08-27 11:31:47 +02:00
87a5967501
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
5abf41edef
Hook/ConfigurationTab: Remove deprecated implementation
...
ConfigurationTab hook is not used anywhere. Test is
removed also.
2014-08-27 10:29:04 +02:00
6783d51f76
A form is "submitted" when it was "sent" but no submit label was set
...
This enables us to use handleRequest() as is when no specific submit button
is required.
refs #5525
2014-08-27 10:28:50 +02:00
0ff79b0948
Replace Form::onFailure() with Form::onShow()
...
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.
refs #5525
2014-08-27 10:25:50 +02:00
d3c2fc858c
Access formdata internally using a public helper method
...
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.
refs #5525
2014-08-27 10:19:33 +02:00
65dd3f9a5b
Make the form in view scripts accessible using $form instead of $element
...
refs #5525
2014-08-27 10:10:55 +02:00
98b2bce15e
Icinga\Web\Form::onSuccess() must not return TRUE
...
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.
refs #5525
2014-08-27 10:09:29 +02:00
7e5b5a0b30
Hook/Grapher: Rework hook interface
...
Rework interface based on specification and changed consumer calls.
refs #6932
2014-08-27 09:35:43 +02:00
376e9aa160
Rename hook base classes
...
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes
refs #6928
2014-08-26 14:29:55 +02:00
45cbd3f067
We do not require the request being passed to handleRequest()
...
refs #5525
2014-08-26 12:31:05 +02:00
5c7999fe9b
Forms should be responsible for any redirection as well
...
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.
refs #5525
2014-08-26 12:30:37 +02:00
1f7d4cb61b
Merge branch 'master' into bugfix/exceptions-with-printf-params-6931
2014-08-26 11:24:33 +02:00
febb2d1ae2
ProgrammingError: extend IcingaException
...
refs #6931
2014-08-26 11:15:19 +02:00
42e2b34356
Implement self provided configuration for dashboard/dashlets in modules
...
refs #6639
2014-08-26 10:34:36 +02:00
52534a2f46
It is a form's responsibility to process the request it was submitted with
...
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)
refs #5525
2014-08-25 17:06:45 +02:00
c93ab7951d
Check whether a form's data was sent instead of whether it's complete
...
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.
refs #5525
2014-08-25 16:49:54 +02:00
7b221e2aba
It should not be a form's responsibility how its submit button should look..
...
...in case it's a standard button. No need to be DRY here.
refs #5525
2014-08-22 15:20:54 +02:00
2b879b344f
Do not populate using createElements() and fix documentation blocks
...
refs #5525
2014-08-22 12:04:14 +02:00
9c5878cbbe
ConfigurationError: extend IcingaException
...
refs #6931
2014-08-22 11:46:11 +02:00
1886569174
Implement Module self provided configuration for menus
...
refs #6639
2014-08-22 11:35:42 +02:00
bb7972aa39
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/controllers/AuthenticationController.php
application/controllers/ConfigController.php
application/forms/Authentication/LoginForm.php
application/forms/Preference/GeneralForm.php
modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
995355ec30
lib/Limiter: fix translate w/ sprintf
2014-08-19 16:29:11 +02:00
f49a34625e
Url\Params: check for QUERY_STRING before using it
...
fixes #6957
2014-08-19 14:53:56 +02:00
db3ef8fbd0
ActionController: remove redirectToLogin default
...
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
2014-08-19 12:28:24 +02:00
9d4a4f49c9
ActionController: JS should redirect to __SELF__...
...
...once you lost your session. That's the only way to do this in a
smooth way. When the server get's an unauthenticated request for a
single container, redirecting to auth/login?redir=<that-container>
was not what you expect.
Together with JS handling __SELF__ in redirection URLs this will
play fine.
refs #6935
2014-08-19 09:57:24 +02:00
b9cc964e24
Url\Params: remove() should reindex on change
...
There was a small bug, fixed.
refs #6699
2014-08-19 09:49:53 +02:00
344909dfcd
Web\UrlParams: add() and set() should encode...
...
...while there is now a addEncoded function, mostly for internal use.
refs #6699
2014-08-19 09:45:58 +02:00
217595dc15
Web/Url: more intuitive separator usage
...
One might not expect to get a URL with params separated by & while
this is the correct way of writing them to HTML attributes. So default
behaviour is right now that all functions return URL params separated
by &, but if you cast a URL (or it's params) to a string, & will be
used.
Additionally there are toString functions allowing you to choose the
separator "manually".
refs #6699
2014-08-19 09:42:16 +02:00
7caccd7691
Web\Url: remove stripUrlFragment()
...
This function had an interesting history and seems to be a result of
missunderstanding of each others commits. Removed, as the fragment is
already there.
refs #6699
2014-08-19 09:36:15 +02:00
f2ed813c9a
Fix that Icinga\Web\Url::fromPath drops fragments
...
fixes #6284
2014-08-14 14:23:31 +02:00
666591beb7
Encode url before passing it to Icinga\Form\Dashboard\AddUrlForm
...
fixes #6611
2014-08-13 16:41:40 +02:00
7311ab964e
Do not set the full url from the request as action with form parameters
...
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.
fixes #6806
2014-08-13 14:50:21 +02:00
e7da9c0a00
Make our anti CSRF logic being a form element
...
refs #5525
2014-08-12 14:43:10 +02:00
fe63ce664f
Make use if 'ignore´ instead of explicitly unsetting array keys
...
refs #5525
2014-08-12 13:57:28 +02:00
4b1169c0a1
Fix improper form submission
...
refs #5525
2014-08-12 10:41:19 +02:00
8f729bfb65
ActionController: set a default window title
...
In case a controller action didn't set a view title this fix restores
the default title on XHR requests.
fixes #6797
2014-07-31 17:04:26 +02:00
c3731fa79e
Adjust removeresource-action to suit the new resource form interface
...
refs #5525
2014-07-24 16:17:30 +02:00
a68ccecb28
Revert "Do not use htmlspecialchars in widgets"
...
This reverts commit 2ff43abcf5
2014-07-23 12:28:04 +02:00
2ff43abcf5
Do not use htmlspecialchars in widgets
...
refs #6759
2014-07-23 12:12:05 +02:00
8b2cc3a558
Do not consider <button type=submit> when checking form completion
...
refs #5525
2014-07-23 10:58:45 +02:00
0bf0213547
Rename Form::addElement to Form::createElement
...
Since we are using mainly createElement and addElement is only an alias for
createElement if no object is passed our changes to addElement can safely
be moved to createElement.
refs #5525
2014-07-23 10:57:46 +02:00
25c9ee567d
Add missing use statement for Zend_View_Abstract
2014-07-23 10:54:22 +02:00
75e09f2c69
Do not consider submit buttons when checking form completion
...
refs #5525
2014-07-21 15:25:00 +02:00
091ddbe552
Partiall revert bfc54b7e
...
Refactor Url->getParams() to return an instance of UrlParam instead of an array.
fixes #6760
2014-07-21 09:22:19 +02:00
f5ac592645
Do not consider disabled elements when checking form completion
...
Values of disabled inputs are not sent by browsers.
refs #5525
2014-07-21 08:57:41 +02:00
f4ff2c90f2
It's a form's responsibility how its submit button should look like
...
refs #5525
2014-07-18 09:54:36 +02:00
6ac471c598
Also mention the viewscript functionality of Form::loadDefaultDecorators()
...
refs #5525
2014-07-18 09:52:50 +02:00
8f0b9899a3
We cannot know what kind of data is passed to Form::isValid()
...
refs #5525
2014-07-18 09:52:05 +02:00
78a6175acc
Make form creation lazy and implement the new validation mechanism
...
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.
refs #5525
2014-07-18 09:51:15 +02:00
37fd3deb67
Rename initCsrfToken to addCsrfToken and move it upwards
...
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.
refs #5525
2014-07-18 09:43:03 +02:00
58188c5cc1
We only want to rely on Form::isValid() when about to process forms
...
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.
refs #5525
2014-07-18 09:33:09 +02:00
802c095bf8
Configuration values need to be inserted to forms explicitly
...
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.
refs #5525
2014-07-18 09:27:10 +02:00
21cd503ee7
Form buttons need to be added explicitly
...
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.
refs #5525
2014-07-18 09:24:49 +02:00
47ae4d79dc
Forms do not need a special title property
...
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.
refs #5525
2014-07-18 09:21:11 +02:00
1de2d0c14f
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Authentication/LoginForm.php
library/Icinga/Test/BaseTestCase.php
library/Icinga/Web/Form.php
library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
bfc54b7e32
Fix array conversion of the Dashboard and its Components
...
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.
refs #6691
2014-07-16 17:31:01 +02:00
5c507d5d91
Fix notice that the session has been already started after retrieving its id
2014-07-16 15:39:40 +02:00
e6dee9fe89
Protect login against CSRF
...
refs #5626
2014-07-16 09:55:23 +02:00
19f05256a0
Only call session_start() when reading from session
...
fixes #6383
2014-07-16 09:55:22 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
e567ad67c5
Display statehistory summary vertically
...
fixes #6636
2014-07-14 15:26:35 +02:00
0dce204651
Refactor Icinga\Web\Form
...
We eagerly waited badly for a new approach to build forms, so here it is.
Should be the best compromise between the Zend_Form functionality and
our requirements regarding automatic submits.
refs #5525
2014-07-10 11:13:45 +02:00
1a1263d9d8
Rename Icinga\Web\Form\Decorator\BootstrapForm
...
We do not use bootstrap anymore but do not want the default Zend
decorators either so this decorator got a more common name.
refs #5525
2014-07-10 11:09:48 +02:00
49c679fe0f
FilterEditor: hide "add" links
...
They where there to show how this should look like. Removed for now as
they are not implemented yet.
refs #6668
2014-07-08 17:21:36 +02:00
bb2c85f90b
Remove forgotten ActionController::requiresConfig() call
...
Should have been reverted by last commit but was not.
2014-07-07 16:12:26 +02:00
82d2f5ac9b
Revert "Merge branch 'feature/install-wizard-6136'"
...
This reverts commit 88d4262e7c6fae333048
2014-07-07 15:09:03 +02:00
0d4166b1bd
ModuleActionController: fix reference, var removed
2014-07-04 12:39:23 +02:00
3cfdf4c977
Web\Response: add redirection function
...
The response now provides redirectAndExit(). One more step to clean up
our action controller. Please not that this is still unused right now.
2014-07-04 12:35:33 +02:00
3772b9c16f
ActionController: set layout module name early
...
Didn't work correctly before
2014-07-04 12:33:49 +02:00
143a1e44fe
Add a HTML renderer for Icinga\Web\Menu
...
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator
refs #6153
2014-07-03 15:46:46 +02:00
be18af7e7e
Merge Icinga\Web\MenuItem into Icinga\Web\Menu
...
We do not need an additional class for the menu's root item just to
encapsulate our config handling, so these two classes were now merged
into a single one. Icinga\Web\Menu now also extends from
RecursiveIterator to be able to render the menu more efficient to html.
refs #6153
2014-07-03 15:14:47 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
f2e5d8afa5
Remove @codeCoverageIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:58:37 +02:00
62928c48b0
helpers/timeSince: fix c&p error
2014-06-27 23:37:39 +02:00
7112ed23f4
Chart\InlinePie: locale-ignorant cast for floats
...
This has already been fixed with 92f454c3be0c5d4b#6348
2014-06-25 22:13:19 +02:00
10d1520711
Widget\Limiter: show "all"
...
In case we pass limit=0 we show this, still unsure whether we should
provide a link for "showing all" - might really hurt with millions of
history rows.
2014-06-25 20:39:10 +02:00
59dd80ed32
ActionController: benchmark should measure rendering
...
We have been cheating a little bit, now the measurement should be more
precise.
2014-06-25 20:37:17 +02:00
d49f30ff77
Improve InlinePie performance
...
Use str_replace instead of preg_replace
2014-06-25 15:24:53 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
8839166090
Add number format 'none' to InlinePie
2014-06-25 14:53:39 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
1dcf44b9cd
FilterEditor: fix buggy dropdown boxes
...
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
2014-06-25 10:37:06 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
b38bcfc19b
Widget\FilterEditor: correct expression output
...
Filter expressions should be filled into form fields exactly as we
expect them at parse time.
fixes #6568
2014-06-24 21:00:01 +02:00
47b893e1ea
Widget\FilterEditor: handle custom vars
...
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.
fixes #6569
2014-06-24 20:57:41 +02:00
3f9f4bb9e1
ModuleActionController: module object shortcut
...
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
2014-06-24 20:54:39 +02:00
b7b99cfd67
Widget\AlertMessageBox: fix broken widget
...
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.
I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
ba9a633b73
Web\Form: relax form submission check
...
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.
Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.
fixes #6423
fixes #5967
refs #6540
2014-06-23 13:31:34 +02:00
ea44de8698
ActionController/translate: detect domain only once
2014-06-22 20:09:23 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
61600ae2d4
ModuleActionController: fix typo
2014-06-22 19:39:54 +02:00
997587d729
Chart\InlinePie: remove ugly default border
2014-06-22 16:38:12 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
bb23d0636c
ModuleActionController: use isXhr()
2014-06-22 16:04:55 +02:00
3774eb6889
ActionController: add isXhr() method
...
Makes things easier as we use this a lot
2014-06-22 15:36:41 +02:00
331d756a2a
ActionController: isolate ignoreXhrBody
...
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
2014-06-22 15:33:38 +02:00
b4f8ef74fa
ActionController: remove obsolete code
2014-06-22 15:20:55 +02:00
631603aba3
ActionController: create postDispatchXhr
...
Moved XHR-specific stuff to a dedicated post-dispatch function
2014-06-22 15:17:28 +02:00
cf995b366b
ActionController: cleanup postDispatch
...
Make XHR handling more readable, move module-related stuff to the
module controller
2014-06-22 15:11:08 +02:00
de19745eb2
ActionController: move moduleInit to Module controller
2014-06-22 13:54:02 +02:00
2cd25b7376
ActionController: if/else should be easy to read
2014-06-22 13:52:40 +02:00
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
b350e3640d
Web\Window: move window handle to dedicated class
...
One more step in cleaning up our ActionController
2014-06-22 13:01:48 +02:00
d69a6d1640
ActionController: remove getRequestUrl
...
Thie removes complexity and makes redirection to login less error-
prone.
2014-06-22 12:23:34 +02:00
9608d8254d
ActionController: remove addModuleContainer
...
This method was obsolete
2014-06-22 12:09:07 +02:00
4980b700da
ActionController: __construct() as first function
2014-06-22 12:07:50 +02:00
a4955df1a9
controller->Auth(): one more lazy-loading helper
...
Not sure about the capital A, but doesn't look so bad - and similar
to Config().
2014-06-22 12:06:09 +02:00
373e1c5ecb
Web\Controller: re-introduce ModuleActionController
...
This will help getting rid of a couple of if/else constructs
2014-06-22 12:03:37 +02:00
469eb3dc98
Web\Url: remove forgotten "debug" line
2014-06-22 11:59:24 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
216c2ca770
Autorefresh: should work also on initial page load
...
fixes #6296
2014-06-21 01:54:32 +02:00
c0c7a815f8
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-20 19:18:38 +02:00
3e24a2cbe4
Paginator/SlidingWithBorder: use less space
...
Showing less items right now. It would be great if we could steer
this by parameter. IMO we should also think about dropping ZF
pagination and use a custom tiny widget.
2014-06-20 17:31:32 +02:00
afd6b11b7b
Web\Url: add set/mergeValues support
2014-06-20 15:50:55 +02:00
2cf79fe9a7
Widget\SortBox: hardcode some styles
...
This is a quickfix, should be moved to CSS once we know how our HTML
elements will definitively look like
2014-06-20 14:55:43 +02:00
916c9c027e
forms: fix isSubmitted
...
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.
Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.
fixes #5967
2014-06-20 14:32:22 +02:00
01631720cc
Dashboard\Component: don't pass on limit
...
Dashlets might be limited to just a few line, we shoultn't pass on
this parameters when showing the "large" variant
2014-06-20 14:29:45 +02:00
ac7354295a
Accessibiltiy: add alt tag for icons
...
Screen readers to not read title tags per default
2014-06-20 14:28:19 +02:00
27e7839d1b
Widget\Limiter: initial commit
...
This allows one to easily switch row count shown on a single page
2014-06-20 13:48:17 +02:00
07134cf931
JS/XHR: handle multiple notifications
...
As there seems to be problems with sending the same header multiple
times we put multiple notifications in one header.
2014-06-20 13:20:20 +02:00
617741c62f
helpers/widget: options are opional
2014-06-20 13:18:52 +02:00
dbf03ee647
ActionController: refine url handling on redirect
2014-06-20 13:18:03 +02:00
7cad4de3be
ActionController: allow to disable autorefresh
2014-06-20 13:17:11 +02:00
f498cd0c81
Web\Url: small fixes, allow override queryString
2014-06-20 12:41:16 +02:00
d504c27641
timeUntil/timeSince: add timestamp hover title
...
It's sometimes easier to read "full" timestamps.
2014-06-20 12:28:55 +02:00
317094aed3
Widget\FilterWidget: ui cleanup
2014-06-20 12:16:33 +02:00
644dd5e33e
Widget\FilterEditor: improve the filter editor
...
This adds quite a bunch of changes. Part of the filter-modifying
complexity has been moved to the filter, the editor widget itself
now makes use of new filter capabilities such as changing operator
or expression type.
2014-06-20 12:03:22 +02:00
aae49ce0c0
Do not show tooltips for piechart areas that indicate empty or free areas
...
refs #6117
2014-06-18 17:38:25 +02:00
6555d347a7
Escape InlinePie html and adjust chart size
...
fixes #6117
2014-06-18 14:43:14 +02:00
be0c5d4b23
Add more meaningful tooltip labels to InlinePies
...
Show current title, a well-formated value and a label for each area in a
tooltip and add the ability to customize tooltip labels of InlinePies
refs #6117
2014-06-18 14:43:14 +02:00
Johannes Meyer
Eric Lippmann
Matthias Jentsch
Markus Frosch
Thomas Gelf
Marius Hein
Boden Garman
Alexander Fuhr
Bernd Erk
Gunnar Beutner
Alexander Klimov
Matthias Jentsch