tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,904 Commits 117 Branches 71 Tags 80 MiB
Commit Graph

1452 Commits

Author SHA1 Message Date
Alexander Fuhr fcc56c9809 monitoring: Fix some of `DataView's PHPDoc 2014-10-07 16:09:19 +02:00
Alexander Fuhr a9ae75b6b0 monitoring: Fix that sorting a data view is not possible if its sort 
rules are empty
 2014-10-07 16:05:20 +02:00
Eric Lippmann 1b23fd7fbe monitoring: Don't support status.dat as backend 
Icinga Web 2 will not support status.dat for now and maybe forever.
 2014-10-07 13:22:07 +02:00
Eric Lippmann 2126b8c341 monitoring: Fix link to an object's contact in the detail views 2014-10-07 13:21:28 +02:00
Eric Lippmann f954e8ce48 monitoring: Remove obsolete helper `ResolveComments' 2014-10-07 11:47:24 +02:00
Eric Lippmann 8a8ce49f73 monitoring: Call `hasBetterUrl()' in every list action 
fixes #6679
 2014-10-06 17:08:27 +02:00
Alexander Fuhr a0122763a6 Fix Queries: Summaries, Host, Service 2014-10-06 11:37:33 +02:00
Alexander Fuhr e96065e065 Implement validation for filter and sort columns 2014-10-06 11:32:15 +02:00
Eric Lippmann 531448eee4 monitoring: Fix setting a resource on a backend 
The resources were indexed by integers instead of the resource names.
 2014-10-01 14:17:29 +02:00
Matthias Jentsch f188bf6b9c Make "hosts" and "services" views responsive 2014-10-01 09:24:52 +02:00
Alexander Fuhr e6c674e221 MonitoredObject: Implement awesome __isset() 2014-09-30 14:47:17 +02:00
Matthias Jentsch ac2aeca9e6 Conform StatehistoryForm to new Form implementation 2014-09-30 11:34:04 +02:00
Eric Lippmann 23c1097577 Fix showing a contact throwing an exception 2014-09-30 10:11:40 +02:00
Johannes Meyer cbadaa78d6 Merge branch 'master' into feature/setup-wizard-7163 2014-09-29 15:35:52 +02:00
Alexander Fuhr f7b7e0283a Translation: another bunch of translatable strings 2014-09-29 15:20:19 +02:00
Alexander Fuhr 31609ecb34 Remove typo in RemoteInstaceForm 
refs #7307
 2014-09-26 17:14:13 +02:00
Alexander Fuhr 285d10ef22 Replace Zend Note Element through Icingas Note Element 
fixes #7318
fixes #7309
fixes #7307
 2014-09-26 16:32:07 +02:00
Alexander Fuhr c73b291cf4 Add a better time format for downtime 2014-09-26 15:57:00 +02:00
Alexander Fuhr cf997e998f Fix eventhistory sort oder 
fixes #7267
 2014-09-26 14:59:06 +02:00
Thomas Gelf d7f8a7823f GroupsummaryQuery: adjust queries to fix ZF woes 
Some less brackets also here. Dropping COALESCE as the subquery will
never return NULL

fixes #7303
 2014-09-24 19:50:43 +02:00
Thomas Gelf 98fa84bd17 StatusSummaryQuery: one more quickfix 
Tactical overview works again right now

refs #7303
 2014-09-24 19:47:02 +02:00
Thomas Gelf 45fc768813 StatusSummaryQuery: workaround for silly ZF fix 
This brings the tiny summaries back. Host- and servicegroups and TO are
still broken.

refs #7303
 2014-09-24 19:33:05 +02:00
Johannes Meyer c00dbf9f46 Write session on response 
There should not be any necessity to write the session once changes are
being made to it. We now track whether changes were made and write
the session when responding to the user's request if so.
 2014-09-24 10:46:35 +02:00
Johannes Meyer 032437cdeb The *group dataview classes are not in camelCase 
Developing on case-insensitive filesystems for mainly
case-sensitive ones is bad habit ;P
 2014-09-24 10:21:19 +02:00
Eric Lippmann c4d13a7850 monitoring: Fix `$this' usage in a closure 2014-09-23 23:00:19 -07:00
Eric Lippmann cde3ec6bc8 Merge branch 'master' into bugfix/commands-6593 
Conflicts:
	modules/monitoring/application/controllers/TimelineController.php
 2014-09-23 22:54:17 -07:00
Eric Lippmann 3229e5e587 monitoring: Add new multiselection controllers 2014-09-23 22:47:26 -07:00
Eric Lippmann 1710a50d5c Fix form CSS 2014-09-23 22:43:33 -07:00
Eric Lippmann 0b723bb57d monitoring: Deprecate the host and service action of the `ShowController' 
There are the `HostController' and the `ServiceController' now instead.
 2014-09-23 22:37:14 -07:00
Eric Lippmann 3034ac5257 monitoring/commands: Show affected objects in command forms 
refs #6593
 2014-09-23 22:34:19 -07:00
Eric Lippmann c8f00be75b monitoring/commands: Fix that removing a comment from the comment list opens and closes the detail area 
This extends to removing a downtime from the downtime list.

refs #6593
 2014-09-23 22:23:56 -07:00
Eric Lippmann 4258b13d45 monitoring/commands: Remove `MonitoringCommands' view helper 
The helper is not used anywhere.

refs #6593
 2014-09-23 22:21:23 -07:00
Eric Lippmann e847770135 monitoring/commands: Remove false property from the schedule service check command 
refs #6593
 2014-09-23 22:19:35 -07:00
Eric Lippmann 051c9691a9 Remove "WTF" comment 2014-09-23 22:18:06 -07:00
Eric Lippmann df18eab69b monitoring: Provide service stats on both the host and the service object 2014-09-23 22:17:22 -07:00
Eric Lippmann 6625e8d391 monitoring: Add tabs to the host and service controller 2014-09-23 22:16:33 -07:00
Eric Lippmann 70500be5f7 monitoring/commands: Fix the delete comment and delete downtime commands 
They included the involved object's name which is wrong.

refs #6593
 2014-09-23 17:40:13 -07:00
Eric Lippmann 9601942116 monitoring/commands: Default 'schedule downtime for all services on the hosts' to false 
refs #6593
 2014-09-23 17:39:32 -07:00
Eric Lippmann b10737017d monitoring/commands: Default 'reschedule all service checks on the hosts' to false 
refs #6593
 2014-09-23 17:36:15 -07:00
Alexander Fuhr 07a4b25560 Merge branch 'master' into bug/history-notification-time-format-6980 2014-09-23 11:38:24 +02:00
Alexander Fuhr e784aa34b6 Implement DateTimeRenderer and fix history time format 
refs #6980
 2014-09-23 11:36:09 +02:00
Matthias Jentsch 6c8f324dd4 Add filter widget to StateHistorySummary and fix some minor bugs 
fixes #6979
 2014-09-19 17:41:44 +02:00
Matthias Jentsch dc6562b97e Add missing StateHistoryForm 2014-09-19 17:41:44 +02:00
Matthias Jentsch 44e5fe7e12 Join Host and Servicegroups for extended filtering 2014-09-19 17:41:44 +02:00
Matthias Jentsch 7385be06ea Move SelectBoxes into form 2014-09-19 17:41:44 +02:00
Matthias Jentsch 65203fddcf Add additional state history filters for time interval and event type 2014-09-19 17:41:44 +02:00
Matthias Jentsch dc05b2e933 Transform TimelineIntervalBox into a generic ListBox 
Add options to control the changed url parameter and the displayed label to make it usable in generic cases.
 2014-09-19 17:41:43 +02:00
Eric Lippmann 2dd81d12ba monitoring: Add `DataView::count()' 2014-09-19 15:42:13 +02:00
Eric Lippmann 27650be481 monitoring/commands: Add missing `ListController' change from the last commit 
refs #6593
 2014-09-19 14:41:51 +02:00
Eric Lippmann 274f2e7410 monitoring/commands: Fix remove commands in the list comments and list downtimes views 
refs #6593
 2014-09-19 14:34:42 +02:00
Eric Lippmann 4b7096bbbf monitoring: Support host and service filters for downtimes 
refs #7278
 2014-09-19 14:28:23 +02:00
Eric Lippmann 72a9a53201 monitoring/commands: Use translate plurar in the object command forms 
refs #6593
 2014-09-19 14:25:49 +02:00
Eric Lippmann 8afdc3db1a monitoring: Replace show partials calls to getHost() and getService() with getName() 2014-09-17 09:48:30 +02:00
Eric Lippmann 5cdcf36243 monitoring: Add HostController's show action view script 2014-09-17 09:46:42 +02:00
Eric Lippmann 71ffd0ed74 monitoring/commands: Add schedule host check command form 
refs #6593
 2014-09-16 18:48:36 +02:00
Eric Lippmann 4d8b6dddf1 monitoring/commands: Add schedule host downtime command form 
refs #6593
 2014-09-16 18:48:07 +02:00
Eric Lippmann a2a645892d monitoring: Add `HostController' 2014-09-16 18:46:58 +02:00
Eric Lippmann 0084fed2c3 monitoring/`ServiceController': Extend `MonitoredObjectController' 2014-09-16 18:46:27 +02:00
Eric Lippmann 05776651b4 modules/commands: Fix `IcingaCommandFileCommandRenderer's `getHost()' and `getService()' calls 
refs #6593
 2014-09-16 18:45:31 +02:00
Eric Lippmann cc2d06e582 monitoring/`Service': Add `getStateText()', let `getHost()' return the host object 
refs #6593
 2014-09-16 18:44:44 +02:00
Eric Lippmann 88b3b5d690 monitoring/`Host': Add `fetchServices', `fetchStats' and `getStateText' 2014-09-16 18:39:13 +02:00
Eric Lippmann c04768ee8f monitoring/`MonitoredObject': Use `host_name' and `service_description' for filtering 2014-09-16 18:38:03 +02:00
Eric Lippmann 0a81aeefa2 monitoring: Deprecate `MonitoringState' view helper 2014-09-16 18:21:41 +02:00
Eric Lippmann 92d855e035 monitoring/lib: Add `MonitoredObjectController' 
The `MonitoredObjectController' should be the base class for the host and service controller.
 2014-09-16 17:29:29 +02:00
Eric Lippmann 0e6e37199a monitoring/commands: Add 'command-form' partial 
refs #6593
 2014-09-16 17:28:00 +02:00
Eric Lippmann 8bf66425d1 Merge branch 'master' into bugfix/commands-6593 2014-09-15 09:27:56 +02:00
Eric Lippmann 9e0d6657b7 Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 
Conflicts:
	application/forms/Preference/GeneralForm.php
 2014-09-15 09:27:07 +02:00
Eric Lippmann a18287d183 monitoring/commands: Rename `PropagateHostDowntime' to `PropagateHostDowntimeCommand' 
refs #6593
 2014-09-13 20:34:51 +02:00
Eric Lippmann 6bfab25009 monitoring/commands: Remove the `CommandForm' view helper 
All command forms will be renderered using their real classes.

refs #6593
 2014-09-13 20:33:45 +02:00
Eric Lippmann 33e0fbb7d9 monitoring/commands: Fix code compliance 
refs #6593
 2014-09-12 16:53:48 +02:00
Eric Lippmann 9b5c1f06d0 monitoring/commands: Let detail snippets use the new command forms 
refs #6593
 2014-09-12 16:52:45 +02:00
Eric Lippmann 17e04e9937 monitoring: Point service's detail to the new `ServiceController' in the services list view 
refs #6593
 2014-09-12 16:51:18 +02:00
Eric Lippmann 5d07b04f82 monitoring/commands: Introduce `ServiceController' 
refs #6593
 2014-09-12 16:50:42 +02:00
Eric Lippmann 5f13db73ce monitoring/commands: Use the toggle instance features command form in the process controller 
refs #6593
 2014-09-12 16:46:07 +02:00
Eric Lippmann 3a9774e6e5 monitoring/commands: Support toggling instance features 
refs #6593
 2014-09-12 16:43:18 +02:00
Eric Lippmann 4d784c6097 monitoring/commands: Re-add the changed identifier to object features 
refs #6593
 2014-09-12 16:42:00 +02:00
Eric Lippmann 442f956945 monitoring/commands: Fix object command forms code compliance 
refs #6593
 2014-09-12 15:03:03 +02:00
Eric Lippmann e5e806a3a1 monitoring/commands: Fix instance command forms code compliance 
refs #6593
 2014-09-12 15:02:31 +02:00
Eric Lippmann 16bc0e5d5a monitoring/commands: Add icon to the check now command form 
refs #6593
 2014-09-12 13:29:23 +02:00
Eric Lippmann 1d54c7f836 monitoring/commands: Support 'DISABLE_NOTIFICATIONS_EXPIRE_TIME' 
refs #6593
 2014-09-12 10:42:48 +02:00
Eric Lippmann 3f216f26ff monitoring/commands: Remove superseded command forms and command objects 
refs #6593
 2014-09-12 10:20:38 +02:00
Eric Lippmann c0e3447339 monitoring: Adapt host and service classes to match their base class' interface 2014-09-12 10:17:46 +02:00
Eric Lippmann aca5a2e466 monitoring: Fetch Icinga object properties lazily 2014-09-12 10:16:31 +02:00
Eric Lippmann b6ac31d10f monitoring/commands: Let transports use the Icinga command file command renderer 
refs #6593
 2014-09-11 17:39:59 +02:00
Eric Lippmann 1df8076234 monitoring/commands: Add command renderer for the Icinga command file 
refs #6593
 2014-09-11 17:39:13 +02:00
Eric Lippmann b4faa0142b monitoring/commands: Add object command forms 
refs #6593
 2014-09-11 17:20:20 +02:00
Eric Lippmann 746e75e5ed monitroing/commands: Remove method `CommandForm::inline()' 
Inline forms will set themselves as inline.

refs #6593
 2014-09-11 17:19:00 +02:00
Eric Lippmann 3845301dfb monitoring/commands: Add object command classes 
refs #6593
 2014-09-11 17:18:07 +02:00
Eric Lippmann 92571599df monitoring/commands: Move toggle instance feature command forms into a single form 
refs #6593
 2014-09-11 17:16:13 +02:00
Eric Lippmann 22771e6f6f monitoring/commands: Rename `DisableNotificationsCommandForm' to `DisableNotificationsExpireCommandForm' 
The associated command also has 'Expired' in its name.

refs #6593
 2014-09-11 17:13:57 +02:00
Eric Lippmann c40ac6f9dc monitoring/commands: Add `DisableNotificationsExpireCommand' 
refs #6593
 2014-09-11 17:11:32 +02:00
Eric Lippmann 1247fdcad4 monitoring/commands: Move toggle instance feature commands into a single command 
refs #6593
 2014-09-11 17:10:20 +02:00
Alexander Fuhr 3615b96093 Fix Incorrect plural form in host overview 
fixes #7172
 2014-09-11 15:46:23 +02:00
Marius Hein 9c2cf0bd0f StateHistoryQuery: Make whereToSql robust 
This fixes bugs is a array for expression comes in or types
does not exist.

fixes #7133
 2014-09-10 10:07:03 +02:00
Eric Lippmann 5757a6f34b monitoring: Fix typo in the `Downtime' data view 2014-09-10 09:29:01 +02:00
Eric Lippmann 171b366744 monitoring/commands: Let `AddCommentCommand' be the command object for adding both host and service commands 
refs #6593
 2014-09-09 16:41:41 +02:00
Eric Lippmann 28a66c8541 monitoring/commands: Introduce `ObjectCommand' for commands that involve a Icinga object 
refs #6593
 2014-09-09 16:40:09 +02:00
Eric Lippmann d9fbbca447 monitoring/commands: Move `AddCommentCommand' to `WithCommentCommand' 
`AddCommentCommand' will be the command for adding both host and service comments.

refs #6593
 2014-09-09 16:39:22 +02:00
Eric Lippmann a841b0956d monitoring/commands: Do not require command objects to return the command string 
There will be command renderer instead.

refs #6593
 2014-09-09 16:35:06 +02:00
Johannes Meyer 83772c6684 Merge branch 'master' into bugfix/rebuild-form-builder-5525 2014-09-09 16:03:22 +02:00
Johannes Meyer ceeb3a9ff8 Fix createElements() not returning self where applicable 
refs #5525
 2014-09-09 13:24:39 +02:00
Johannes Meyer c8bdb70d06 Remove command form tests 
refs #5525
 2014-09-09 09:27:04 +02:00
Matthias Jentsch 40611659ed Fix disappearing tooltips on SVG reload 
Use a unified linebreak in the chart controller, so the tooltip handling will recognize the titles as identical
 2014-09-08 16:23:14 +02:00
Johannes Meyer f53519c54d Rename ConfigForm::setConfig() to ConfigForm::setIniConfig() 
We do not want to override Zend_Form::setConfig() so this renaming is
required. set*Ini*Config() because ConfigForm::save() utilizes an ini-writer
to persist the configuration to disk.

refs #5525
 2014-09-08 13:31:25 +02:00
Eric Lippmann 0e7ca591ec Merge branch 'master' into bugfix/commands-6593 
Conflicts:
	application/forms/Preference/GeneralForm.php
	application/views/helpers/FormDateTime.php
	modules/monitoring/application/forms/Command/CommandForm.php
 2014-09-08 10:16:05 +02:00
Matthias Jentsch e39dd64a1b Fix layout of HistoryColorGrid 
Use actual color for critical hosts and only display the first two letters of the weekday
 2014-09-08 09:52:28 +02:00
Johannes Meyer 930e6e7d71 We shouldn't require Form::createElements() to return self 
refs #5525
 2014-09-08 09:24:53 +02:00
Johannes Meyer ae9e5a40cc Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Preference/GeneralForm.php
 2014-09-08 08:46:53 +02:00
Gunnar Beutner 7d623fdfe3 Fix spelling mistake: Unandled -> Unhandled 2014-09-05 23:42:49 +02:00
Thomas Gelf 6095e44064 Host/Service: provide process_perfdata attribute 2014-09-05 19:05:13 +02:00
Thomas Gelf ccb8f51ba9 list/eventhistory: sort by timestamp, not raw_ts 2014-09-05 18:44:29 +02:00
Thomas Gelf cbaa2d8ae9 StateHistoryQuery: tune type queries 2014-09-05 18:41:51 +02:00
Thomas Gelf adab58e769 list/statehistorysummary: fix filter links 2014-09-05 18:38:56 +02:00
Thomas Gelf 22b3b0e46a list/hosts: no time for pending, state on dashboard 2014-09-05 18:36:56 +02:00
Thomas Gelf d1dae46fae show/history: link notification contacts, show state 2014-09-05 18:20:35 +02:00
Thomas Gelf fe6a1b1f0f list/notifications: don't show contact... 
...when showing notifications for a single contact, other cleanup.

refs #7104
 2014-09-05 18:16:59 +02:00
Thomas Gelf 9ea377fd45 NotificationHistoryQuery: names instead of aliases 
refs #7104
 2014-09-05 18:16:59 +02:00
Thomas Gelf 48f49c56b2 show/contact: first attempt to restyle them 
refs #7104
 2014-09-05 18:16:59 +02:00
Thomas Gelf 38c6d6aaf8 StatusSummaryQuery: reorganize, add new columns 
refs #6993
 2014-09-05 18:16:58 +02:00
Matthias Jentsch 51d14af154 Merge branch 'master' into feature/navigation-unhandled-badges-7114 
Conflicts:
	library/Icinga/Web/Menu.php
 2014-09-05 18:14:29 +02:00
Thomas Gelf 3fbf1727da monitoring/show: provide summary data to views 
refs #6993
 2014-09-05 18:03:45 +02:00
Thomas Gelf 6689fabb1e show/services: use new services summary 
refs #6993
 2014-09-05 18:01:34 +02:00
Thomas Gelf 66dba8b98d show/host: use new host services summary 
refs #6993
 2014-09-05 18:00:26 +02:00
Thomas Gelf 4da3f55cd9 component/hostservicesummary: initial commit 
refs #6993
 2014-09-05 17:58:48 +02:00
Matthias Jentsch 19eca5f50b Show all unhandled host and services in a menu 
Add the option to define custom renderers for menu items and implement renderers to
display all unhandled services and host in a badge in the navigation.

resolves #7114
 2014-09-05 17:57:20 +02:00
Thomas Gelf 315c2a6e51 list/comments: fix PHP warning 2014-09-05 17:54:09 +02:00
Thomas Gelf d4d3c776a5 list/services: use new snippet, cleanup HTML 
refs #6993
 2014-09-05 17:43:13 +02:00
Thomas Gelf 65b2a25fd6 list/components/servicesummary: show state summary 
refs #6993
 2014-09-05 17:41:53 +02:00
Thomas Gelf c312139334 list/services: provide summaries to the view 
refs #6993
 2014-09-05 17:40:57 +02:00
Thomas Gelf caab729451 monitoring/list: get rid of last DataView traces 2014-09-05 17:38:02 +02:00
Thomas Gelf 6e33061b21 monitoring/module.less: prepare styles for summary 
refs #6993
 2014-09-05 16:03:07 +02:00
Johannes Meyer 7d212658bc Fix "Use statement with non compound name..." in TimelineController 2014-09-05 09:17:54 +02:00
Johannes Meyer d021747bde Fix form widgets 
refs #5525
 2014-09-05 09:17:09 +02:00
Thomas Gelf 7b35741985 monitoring/show: forgot to check for existance 2014-09-04 18:57:20 +02:00
Thomas Gelf 05a64ceea9 monitoring/show: use global hasPreviews check once 
refs #6932
 2014-09-04 18:51:54 +02:00
Thomas Gelf dccc57b7a2 CommandForm: fix broken function 2014-09-04 18:39:02 +02:00
Thomas Gelf b6b16e25e9 monitoring/show: use new grapher hook interface 
refs #6932
 2014-09-04 16:43:07 +02:00
Alexander Fuhr 70ac8077e6 Merge branch 'master' into feature/modules-search-capabilities-6495 2014-09-04 16:33:40 +02:00
Alexander Fuhr 1eacde0233 Implement modules self provided search configuration 
refs #6495
 2014-09-04 16:31:10 +02:00
Marius Hein 6fcf5ec88a DateTime: Remove global and user formattings 
refs #6077
 2014-09-04 16:02:10 +02:00
Eric Lippmann a83ddb9d8e monitoring/commands: Let `ScheduleDowntimeCommand' extend `AddCommentCommand' 
refs #6593
 2014-09-04 15:52:20 +02:00
Eric Lippmann a94e84f3b0 monitoring/commands: Add common `AddCommentCommand' 
refs #6593
 2014-09-04 15:51:41 +02:00
Eric Lippmann 9cfd74d618 monitoring: Introduce `ServiceController' 
In the long term, `ServiceController' and the upcmoing `HostController' should replace `ShowController'.

refs #6593
 2014-09-04 15:43:37 +02:00
Eric Lippmann 1358a5d49f monitoring/commands: Add command form for scheduling a service downtime 
refs #6593
 2014-09-04 15:42:46 +02:00
Eric Lippmann fe47441efc monitoring/commands: Add command to schedule a service downtime 
refs #6593
 2014-09-04 15:42:11 +02:00
Eric Lippmann 1c8f880d18 modules/command: Remove old `ScheduleDowntimeCommand' 
refs #6593
 2014-09-04 15:38:48 +02:00
Eric Lippmann f57bb0f6a1 modules/commands: Add common `ScheduleDowntimeCommand' 
`ScheduleDowntimeCommand' is the base class for commands scheduling downtimes.

refs #6593
 2014-09-04 15:37:30 +02:00
Eric Lippmann 6f8fc3eb6d modules/command: Add command description to `DisableNotificationsCommandForm' 
refs #6593
 2014-09-04 15:30:54 +02:00
Thomas Gelf 6739034a14 monitoring/list: handle q param and search for *q* 
Handle the generic search parameter q, search defaults to *searchString*
instead of searchString* right now.

refs #6680
refs #6495
 2014-09-04 15:12:49 +02:00
Marius Hein f8b3ffb3c8 AbstractObject: Rename to MonitoredObject 
refs #6932
 2014-09-04 14:00:48 +02:00
Eric Lippmann ed645b1eeb monitoring/commands: Fix `CommandForm::getTransport()'s PHPDoc 
refs #6593
 2014-09-04 13:29:12 +02:00
Eric Lippmann cb23ef3c4e monitoring/commands: Add `DisableNotificationsCommandForm' 
`DisableNotificationsCommandForm' is the form for disabling host and service notifications w/ an optional expire date and time on an Icinga instance.

refs #6593
 2014-09-04 13:06:47 +02:00
Eric Lippmann 3d0a74bfdb monitoring/commands: Add `ToggleNotificationsCommandForm' 
`ToggleNotificationsCommandForm' is the form for enabling/disabling host and service notifications on an Icinga instance.

refs #6593
 2014-09-04 13:04:54 +02:00
Eric Lippmann bc1d00f146 monitoring/commands: Fix `ToggleFeatureCommandForm::createElements()' 
`Icinga\Web\Form::createElements()' no longer requires to return an array of elements
because elements should be created directly.

refs #6593
 2014-09-04 13:02:38 +02:00
Eric Lippmann 8d109132b0 monitoring/commands: Add common `ScheduleDowntimeCommandForm' 
`ScheduleDowntimeCommandForm' should be the base class for forms scheduling downtimes.

refs #6593
 2014-09-04 13:01:42 +02:00
Eric Lippmann a45b17fcd0 monitoring/lib: Add methods `Service::getHostName()' and `Service::getName()' 
The upcoming service command objects will require a service object.
In order to build the command string, the service command objects require
retrieval of the service's host name and the service's name.

The actual implementation of the methods is subject to change

refs #6593
 2014-09-04 12:54:52 +02:00
Johannes Meyer 439d1895a7 Adjust Monitoring\BackendForm to use handleRequest() & Co. 
refs #5525
 2014-09-04 11:25:47 +02:00
Johannes Meyer 9d66cc9023 Adjust Monitoring\InstanceForm to use handleRequest() & Co. 
refs #5525
 2014-09-04 08:47:16 +02:00
Eric Lippmann c3c0043307 Merge branch 'master' into bugfix/commands-6593 2014-09-03 23:23:20 +02:00
Thomas Gelf 8fdf20fbf2 Groupsummary: remove invalid sort column discovery 
This didn't result in a loop 'til now as it wasn't even used. The problem
here is that the same View is used for tow differend things, this makes no
sense. In the meantime removing that code fixes related problems.
 2014-09-03 18:55:20 +02:00
Matthias Jentsch da85112538 Merge branch 'master' into feature/svg-chart-tooltips-7024 2014-09-03 17:08:00 +02:00
Johannes Meyer 49562e75d7 Adjust ..\Monitoring\Form\Config\SecurityForm to use handleRequest() 
refs #5525
 2014-09-03 15:08:37 +02:00
Eric Lippmann 5d1f2ada97 monitoring/commands: Fix `ToggleFeatureCommandForm::onSucces()'s PHPDoc 
refs #6593
 2014-09-03 14:42:49 +02:00
Johannes Meyer c4d17a3509 Drop Zend_View_Helper_MonitoringProperties as it's not used anywhere 2014-09-03 10:27:24 +02:00
Johannes Meyer 06c7c4bd3e Fix that the MonitoringProperties view helper returns locale aware floats 
refs #7063
 2014-09-03 10:09:43 +02:00
Johannes Meyer 07151d0a5e Fix that the MonitoringProperties view helper returns locale aware floats 
refs #7063
 2014-09-03 10:01:20 +02:00
Thomas Gelf 1734f01040 CommentdeletionhistoryQuery: 1970-01-01 -> -02 
refs #7000
 2014-09-02 17:02:58 +02:00
Thomas Gelf a58b2aac00 Ido\StatusQuery: join ALL latest comment 
And it was soooo fast :p

refs #7057
 2014-09-02 15:31:06 +02:00
Eric Lippmann 9bcd861b1c Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 2014-09-02 15:27:27 +02:00
Thomas Gelf d8e71d3790 monitoring/list: ignore post in applyFilter 
refs #6644
 2014-09-02 14:07:46 +02:00
Marius Hein 19136b548a StatusQuery: Separate last comment fields 
fixes #7057
 2014-09-02 13:57:43 +02:00
Thomas Gelf 8a5e274c8b monitoring/show: handle format=sql after pagination 2014-09-02 13:26:48 +02:00
Thomas Gelf e75de8cf60 monitoring/list: redirect when posting new order 
refs #6644
 2014-09-02 13:07:20 +02:00
Thomas Gelf 307787cfb7 DataView: use default sort order if none given 
We should not be forced to order(null) to have the default order, that
should be the default in case order has not been called.

refs #6644
 2014-09-02 12:54:38 +02:00
Thomas Gelf 6be31f4f51 Downtime*Query: use 1970-01-02 as "null" 
refs #7000
 2014-09-02 12:47:03 +02:00
Thomas Gelf 4a95b9d942 StatusSummaryQuery: respect pending, add columns 2014-09-02 12:45:15 +02:00
Thomas Gelf 153013bbc6 Ido\StatusQuery: pending hosts are not problems 2014-09-02 12:28:25 +02:00
Matthias Jentsch 4b55bcf8b6 Add tooltips to bar charts 
Add a class to format and populate tooltips from graph data sets and implement
those tooltips in the ChartController.
 2014-09-02 12:24:29 +02:00
Thomas Gelf 8f124051e3 MonitoringBackend: use correct config object 2014-09-02 11:32:48 +02:00
Alexander Fuhr bb0e1dc105 Revert "Fixes unaccepted behavior in module configuration" 
This reverts commit 236d384bab.
 2014-09-02 10:23:41 +02:00
Alexander Fuhr a47c376fb3 Revert "Fixes dashboard title configuration" 
This reverts commit 968fa36cfd.
 2014-09-02 10:23:39 +02:00
Eric Lippmann ae180166b3 monitoring/commands: Let `ToggleFeatureCommandForm' extend `CommandForm' 
`InstanceCommandForm' was renamed to `CommandForm'.

efs #659
 2014-09-02 09:57:15 +02:00
Eric Lippmann c27c5690ba monitoring/commands: Rename `InstanceCommandForm' to `CommandForm' 
Since the old `CommandForm' is removed, `InstanceCommandForm' is now the new base class for all command forms.

refs #6593
 2014-09-02 09:55:38 +02:00
Eric Lippmann 4b210f95ea monitoring/commands: Remove `CommandForm' which will be replaced 
Remove the rubbish.

refs #6593
 2014-09-02 09:51:40 +02:00
Eric Lippmann c005ef434e monitoring/commands: Add form for enabling/disabling the processing of host and service performance data on an Icinga instance 
refs #6593
 2014-09-01 16:21:49 +02:00
Eric Lippmann d47951f9d6 monitoring/commands: Add form for enabling/disabling passive service checks on an Icinga instance 
refs #6593
 2014-09-01 16:21:23 +02:00
Eric Lippmann 8686074fb1 monitoring/commands: Add form for enabling/disabling passive host checks on an Icinga instance 
refs #6593
 2014-09-01 16:20:56 +02:00
Eric Lippmann 176a1a72ca monitoring/commands: Add form for enabling/disabling processing of service checks via the OCHP command on an Icinga instance 
refs #6593
 2014-09-01 16:20:31 +02:00
Eric Lippmann ff10cdaf03 monitoring/commands: Add form for enabling/disabling processing of host checks via the OCHP command on an Icinga instance 
refs #6593
 2014-09-01 16:20:07 +02:00
Eric Lippmann 5a100ea99f monitoring/commands: Add form for enabling/disabling host and service flap detection on an Icinga instance 
refs #6593
 2014-09-01 16:19:37 +02:00
Eric Lippmann 939f8b82cc monitoring/commands: Add form enabling/disabling host and service event handlers on an Icinga instance 
refs #6593
 2014-09-01 16:19:12 +02:00
Eric Lippmann e8b70ffccd monitoring/commands: Add form for enabling/disabling active service checks on an Icinga instance 
refs #6593
 2014-09-01 16:17:13 +02:00
Eric Lippmann e2cdff67b2 monitoring/commands: Add form for enabling/disabling active host checks on an Icinga instance 
refs #6593
 2014-09-01 16:16:47 +02:00
Marius Hein 1c24273c9b Backend: Better implementation for createBackend 
Thanks eric!

fixes #7043
 2014-09-01 16:11:34 +02:00
Marius Hein 63cb357d48 TimelineController: Fix The use statement with non-compound ... 
fixes #7023
 2014-09-01 15:58:55 +02:00
Marius Hein 6b6826f737 Bug7043Test: Fix test to run without ini configuration 
fixes #7043
 2014-09-01 15:53:32 +02:00
Eric Lippmann 920c0b9c6d monitoring/commands: Add (ENABLE|DISABLE)_PERFORMANCE_DATA commands 
`TogglePerformanceData' is the command object for enabling/disabling the processing of host and service performance data on an Icinga instance.

refs #6593
 2014-09-01 15:20:14 +02:00
Eric Lippmann 0edd14559c monitoring/commands: Add (ENABLE|DISABLE)_PASSIVE_SERVICE_CHECKS commands 
`TogglePassiveServiceChecks' is the command object for enabling/disabling passive service checks on an Icinga instance.

refs #6593
 2014-09-01 15:18:40 +02:00
Eric Lippmann efd16ba79f monitoring/commands: Add (ENABLE|DISABLE)_PASSIVE_HOST_CHECKS commands 
`TogglePassiveHostChecks' is the command object for enabling/disabling passive host checks on an Icinga instance.

refs #6593
 2014-09-01 15:18:31 +02:00
Eric Lippmann c5e35c9614 monitoring/commands: Add (START|STOP)_OBSESSING_OVER_SERVICE_CHECKS commands 
`ToggleObsessingOverServiceChecks' is the command object for enabling/disabling processing of service checks via the OCHP command on an Icinga instance.

refs #6593
 2014-09-01 15:15:11 +02:00
Eric Lippmann cd29adc0bd monitoring/commands: Add (START|STOP)_OBSESSING_OVER_HOST_CHECKS commands 
`ToggleObsessingOverHostChecks' is the command object for enabling/disabling processing of host checks via the OCHP command on an Icinga instance.

refs #6593
 2014-09-01 15:14:49 +02:00
Eric Lippmann cdbd24ec99 monitoring/commands: Add (ENABLE|DISABLE)_NOTIFICATIONS/DISABLE_NOTIFICATIONS_EXPIRE_TIME commands 
`ToggleNotifications' is the command object for enabling/disabling host and service notifications on an Icinga instance with an optional expire time for disabling notifications.

refs #6593
 2014-09-01 15:14:39 +02:00
Eric Lippmann 5474c661e1 monitoring/commands: Add (ENABLE|DISABLE)_FLAP_DETECTION commands 
`ToggleFlapDetection' is the command object for enabling/disabling host and service flap detection on an Icinga instance.

refs #6593
 2014-09-01 15:14:31 +02:00
Eric Lippmann 010c5b45ba monitoring/commands: Add (ENABLE|DISABLE)_EVENT_HANDLERS commands 
`ToggleEventHandlers' is the command object for enabling/disabling host and service event handlers on an Icinga instance.

refs #6593
 2014-09-01 15:14:23 +02:00
Eric Lippmann fda48788ff monitoring/commands: Add (START|STOP)_EXECUTING_SVC_CHECKS commands 
`ToggleActiveServiceChecks' is the command object for enabling/disabling active service checks on an Icinga instance.

refs #6593
 2014-09-01 15:14:15 +02:00
Eric Lippmann d2d69b9bcd monitoring/commands: Add (START|STOP)_EXECUTING_HOST_CHECKS commands 
`ToggleActiveHostChecks' is the command object for enableing/disabling active host checks on an Icinga instance.

refs #6593
 2014-09-01 15:13:59 +02:00
Johannes Meyer 0e63e36ec0 Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form 
This is a generic form not necessarily being used just for configuration
purposes.

refs #5525
 2014-09-01 15:11:09 +02:00
Eric Lippmann dae29678dd monitoring/commands: Add `ToggleFeatureCommandForm' 
`ToggleFeatureCommandForm' should be the base class for forms enabling/disabling features of an Icinga instance.

refs #6593
 2014-09-01 15:01:32 +02:00
Eric Lippmann 8cacd2f00f monitoring/commands: Add `InstanceCommandForm' 
The `InstanceCommandForm' should be the base class for forms that handle program-wide commands.

refs #6593
 2014-09-01 15:00:20 +02:00
Marius Hein 160fc900d0 Backend: Set name if create default backend 
fixes #7043
 2014-09-01 14:46:06 +02:00
Eric Lippmann 57dd9a699e monitoring/commands: ToggleFeature: Use 'return $this' for documenting fluent interfaces 
refs #6593
 2014-09-01 10:29:34 +02:00
Marius Hein f47bc46654 GroupSummary/Postgres: Fix group by in initial join query 
refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein 21f0b4c925 CommandQuery: Remove select * from joins (Postgres) 
refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein b4e9bad87a NotificationHistoryQuery: Add missing field to group statement 
refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein e46dd4bdfd DowntimeQuery: Postgres fixes 
Change is_fixed to boolean check and illegal postgres timerange of
'0000-00-00 00:00:00'.

refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein 62f502d276 Postgres/StatusQuery: Fix concatenation and group by 
refs #5896
 2014-09-01 10:00:04 +02:00
Eric Lippmann a01ee00c27 Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 
Conflicts:
	library/Icinga/Protocol/Commandpipe/Transport/Transport.php
 2014-08-29 17:24:44 +02:00
Johannes Meyer fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-29 16:05:56 +02:00
Eric Lippmann 8c82f1a868 monitoring/commands: Add common `ToggleFeature' command 
`ToggleFeature' should be used for enabling/disabling concrete features of the monitoring host.

refs #6593
 2014-08-29 15:45:35 +02:00
Eric Lippmann 4d353ac7bf monitoring/commands: Add `CommandTransport' factory 
Instead of auto-detecting which transport class to use, the instances configuration
now supports a new setting named `transport' with the possible values 'local' and 'remote'.

refs #6593
 2014-08-29 15:36:55 +02:00
Eric Lippmann 6324192127 monitoring/commands: Throw `LogicException' if the remote host is not set in `RemoteCommandFile' 
refs #6593
 2014-08-29 15:36:11 +02:00
Eric Lippmann 6fdc436f65 monitoring/commands: Add `TransportException' 
`TransportException' should be thrown if a command was not sent.

refs #6593
 2014-08-29 15:14:53 +02:00
Eric Lippmann 249099348e monitoring/commands: Replace `SecureShell' with `RemoteCommandFile' 
`RemoteCommandFile' is configured via property setters instead of the too general `setEndpoint' function.
The ssh command to be executed only has the option 'BatchMode' set to 'yes' as this is enough to disable
interactive authentication methods. Further, all arguments become espaced.

refs #6593
 2014-08-29 15:08:58 +02:00
Eric Lippmann ec46b368df monitoring/commands: Replace `LocalPipe' with `LocalCommandFile' 
`LocalCommandFile' is configured via property setters instead of the too general `setEndpoint' function.

refs #6593
 2014-08-29 15:04:48 +02:00
Eric Lippmann 2ac4a8503c monitoring/commands: Remove the `Transport' interface 
The `Transport' interface is superseded by the `CommandTransportInterface'.

refs #6593
 2014-08-29 14:44:49 +02:00
Eric Lippmann e7eae87f16 monitoring/commands: Replace `Command' with `IcingaCommand' 
Since there's already a `Cli\Command', `Command' is now named `IcingaCommand'.
All concrete Icinga commands should extend `IcingaCommand' which handles
command encoding. All other "features" of the `Command' object have been removed
because theses "features" should be handled by upcoming concrete command classes.

refs #6593
 2014-08-29 14:38:52 +02:00
Eric Lippmann 0e2e1bc005 monitoring/commands: Add `CommandTransportInterface' 
All concrete Icinga command transport classes should implement the `CommandTransportInterface' .

refs #6593
 2014-08-29 14:34:16 +02:00
Matthias Jentsch 3642b7b6fc Adjust CSS for inlinePies to be centered on the current line 2014-08-28 18:27:30 +02:00
Matthias Jentsch e799d65d3f Only apply SVG responsiveness when not rendered in compact mode 
Don't let SVGs grow vertically in when displayed in the dashboard, to avoid wasted space
 2014-08-28 16:52:02 +02:00
Matthias Jentsch 648debff88 Draw charts for single ServiceGroups as PieChart 2014-08-28 16:50:29 +02:00
Eric Lippmann 4ca1eaa7ce Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 
Conflicts:
	library/Icinga/Web/Form.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-28 13:58:02 +02:00
Marius Hein 0a2b504db8 Gracatar: Pre sized with 60px because of display latency 
refs #7020
 2014-08-28 13:41:21 +02:00
Marius Hein c4c5bcdd48 ContactQuery: Change timeperiod joins to joinLeft() 
refs #7020
 2014-08-28 13:39:49 +02:00
Marius Hein 436a4d2965 ResourceConfig: Chance createResouce to create 
Not useful everywhere. Changed on the best suitable places.

refs #5514
 2014-08-28 12:14:55 +02:00
Alexander Klimov c194c02435 Remove useless 'use \Exception' 2014-08-28 11:45:26 +02:00
Marius Hein fdef695896 Fix: The use statement with non-compound name 'Exception' has no effect 2014-08-28 11:34:08 +02:00
Matthias Jentsch 947cd0c5d3 Merge branch 'master' of git.icinga.org:icingaweb2 
fixes #7006
 2014-08-27 17:22:09 +02:00
Matthias Jentsch 6a32c3a8ab Make charts responsive 
Let pie and grid charts of the chart controller automatically adapt to changing viewport sizes.
 2014-08-27 17:21:55 +02:00
Marius Hein 5e84ff4ac4 Show/Contact: Add notification history to view 
refs #4804
 2014-08-27 16:38:29 +02:00
Marius Hein 9465c3ffb6 Show/Contact: Add commands to view 
Create a new command query and join contact information into.

refs #4804
 2014-08-27 16:38:29 +02:00
Alexander Klimov 8b0df6c9f7 UnsupportedBackendException: extend IcingaException 
refs #6931
 2014-08-27 16:29:56 +02:00
Alexander Klimov 45638b218c Throw IcingaException rather than Exception 
fixes #7014
 2014-08-27 16:03:15 +02:00
Alexander Klimov 7ff51caed0 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 15:51:49 +02:00
Alexander Fuhr 968fa36cfd Fixes dashboard title configuration 
fixes #7011
 2014-08-27 15:03:28 +02:00
Alexander Fuhr 236d384bab Fixes unaccepted behavior in module configuration 
fixes #7011
 2014-08-27 14:57:08 +02:00
Eric Lippmann 1dea19504f Revert "Remove leading backslashes from the targets of use statements" 
This reverts commit 87a5967501.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
 2014-08-27 12:24:11 +02:00
Marius Hein 88698cb05d Hook/TopBar: Rework interface for monitoring top bar 
refs #6929
 2014-08-27 11:31:48 +02:00
Alexander Klimov 87a5967501 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 11:16:44 +02:00
Marius Hein 89541f5727 Merge branch 'bugfix/hook-interface-6932' 
fixes #6932
fixes #6928
 2014-08-27 09:39:56 +02:00
Marius Hein 7e5b5a0b30 Hook/Grapher: Rework hook interface 
Rework interface based on specification and changed consumer calls.

refs #6932
 2014-08-27 09:35:43 +02:00
Eric Lippmann 6b88f1c98e Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module 
refs #6593
 2014-08-26 16:35:30 +02:00
Goran Rakic 746f53fd20 Do not hide OK hosts and services from the Pie Chart 
Having a single hostgroup, and all hosts and services up, landing page Pie Chart is empty. This restores display of OK hosts and services.
 2014-08-26 15:20:15 +02:00
Marius Hein 376e9aa160 Rename hook base classes 
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes

refs #6928
 2014-08-26 14:29:55 +02:00
Alexander Klimov 1f7d4cb61b Merge branch 'master' into bugfix/exceptions-with-printf-params-6931 2014-08-26 11:24:33 +02:00
Alexander Klimov febb2d1ae2 ProgrammingError: extend IcingaException 
refs #6931
 2014-08-26 11:15:19 +02:00
Alexander Fuhr bae5ba2352 Add self provided configuration for dashlets in monitoring module 
refs #6639
 2014-08-26 10:34:35 +02:00
Thomas Gelf 70fe22dfad monitoring/tactical: fix missing translations 2014-08-22 18:08:20 +02:00
Thomas Gelf 5c46355474 translation: refresh de_DE 2014-08-22 17:58:53 +02:00
Thomas Gelf c31972b99c translation: refresh monitoring module 2014-08-22 17:26:20 +02:00
Johannes Meyer 7b221e2aba It should not be a form's responsibility how its submit button should look.. 
...in case it's a standard button. No need to be DRY here.

refs #5525
 2014-08-22 15:20:54 +02:00
Johannes Meyer 5028ec7b0b Avoid NIH 
It's useless to have specific getters and setters if generic methods from the
baseclass can be used as well to accomplish the same task.

refs #6641
 2014-08-22 12:30:13 +02:00
Johannes Meyer 75a0c17933 Ensure that all forms have a name 
refs #5525
 2014-08-22 12:15:02 +02:00
Johannes Meyer 2b879b344f Do not populate using createElements() and fix documentation blocks 
refs #5525
 2014-08-22 12:04:14 +02:00
Alexander Klimov 9c5878cbbe ConfigurationError: extend IcingaException 
refs #6931
 2014-08-22 11:46:11 +02:00
Alexander Fuhr 20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
tgelf da821fd952 list/hosts: add missing host_attempt column 2014-08-22 05:23:45 -04:00
Alexander Fuhr 7e0047d00e Add Menu configuration in Monitoring Module 
refs #6639
 2014-08-22 11:07:49 +02:00
Thomas Gelf 49cd55eddd list/hosts: cleanup, should look like list/services 
Quite some changes here:

* Compact view should show icons too
* Ignore host icons with legacy HTML hacks
* Remove duplicate code
* Reduce HTML
* Reduce intendation for better readability
* Show attempts on soft states only, even in compact view
* Use the same HTML tags and styles as in list/services
* Fixes nesting error on compact view
 2014-08-22 11:06:45 +02:00
Alexander Klimov 30d0ebcdfd Make 'modules/monitoring/config.ini' doesn't have to exist 2014-08-21 12:36:28 +02:00
Alexander Klimov d1b1bc368f Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid() 
refs #5525
 2014-08-21 11:51:49 +02:00
Alexander Klimov b81e96574a SecurityForm: replace create() with createElements() and add addSubmitButton() 
refs #5525
 2014-08-21 11:48:07 +02:00
Johannes Meyer 11063495b2 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	modules/monitoring/application/controllers/ConfigController.php
 2014-08-21 10:22:16 +02:00
Thomas Gelf a8d33d90e2 Monitoring\Object: fix a couple of cv-related issues 
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
 2014-08-20 13:36:03 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
 2014-08-20 13:13:50 +02:00
Alexander Klimov bb65fb396a Merge branch 'bugfix/sensitive-custom-vars-6641' 
fixes #6641
 2014-08-20 12:29:45 +02:00
Alexander Klimov 78b98a7d67 SecurityForm: Add helptext 
refs #6641
 2014-08-20 12:21:11 +02:00
Johannes Meyer 09dfcca0bc Merge branch 'master' into bugfix/styled-history-views-6637 2014-08-20 11:39:03 +02:00
Johannes Meyer 4ceecf1146 Let comment view look more standardized and add limit control 
refs #6637
 2014-08-20 11:34:24 +02:00
Alexander Klimov 071937910b Monitoring/Object: filter protected customvars 
Move the responsibility from the viewscript to Monitoring/Object

refs #6641
 2014-08-19 18:46:37 +02:00
Alexander Fuhr ba748cbc4a Refactor multiSelect and highlight 
refs #6705
 2014-08-19 18:33:28 +02:00
Alexander Klimov ea0248ecf4 Remove '{{SAVE_ICON}}', tiny design fixes 
refs #6641
 2014-08-19 17:54:22 +02:00
Alexander Fuhr 6fe47bf5b0 Fix rows highlighting after refresh 
fixes #6705
 2014-08-19 17:32:17 +02:00
Johannes Meyer 3573908071 Let downtime view look more list-like and fix downtime end calculation 
refs #6637
 2014-08-19 17:03:35 +02:00
Alexander Klimov 3e079efe2a SecurityForm: replace `customvars' with `protected_customvars' 
refs #6641
 2014-08-19 14:51:30 +02:00
Alexander Fuhr 7035099468 Fix the host_unhandled_service_count error 
fixes #6833
 2014-08-19 14:43:24 +02:00
Alexander Klimov 65473ac8ee Monitoring config: use SecurityForm 
refs #6641
 2014-08-19 14:04:00 +02:00
Alexander Klimov 1ba3954b95 Monitoring config: implement SecurityForm 
refs #6641
 2014-08-19 14:02:26 +02:00
Alexander Klimov 6b468b7f9b Monitoring_ConfigController: make writeConfiguration's parameter `file' non-required 
refs #6641
 2014-08-19 13:51:10 +02:00
Alexander Klimov 0464099764 Monitoring: implement "Security" config tab 2014-08-19 11:19:30 +02:00
Johannes Meyer 332be22f7e Fix object history dates make output look similar to the event history 
refs #6637
 2014-08-18 15:32:12 +02:00
Johannes Meyer bbddb9ed87 Add limit-control and fix indentation of the eventhistory view 
refs #6637
 2014-08-18 15:30:59 +02:00
Johannes Meyer 043688e514 Make event history view more fancier 
refs #6637
 2014-08-15 17:03:03 +02:00
Johannes Meyer cae84a5d7f Fix float formatting of timeline circle margins and widths 
fixes #6926
 2014-08-15 13:39:02 +02:00
Johannes Meyer 54461f9319 Treat hard states more severe than soft states 
fixes #6571
 2014-08-15 12:40:56 +02:00
Johannes Meyer dc8181cdc5 Escape linefeeds and carriage returns in commands and show them as html 
fixes #6088
 2014-08-14 10:23:04 +02:00
Johannes Meyer b5d6481c12 Make it possible to translate the process info view 
refs #6610
 2014-08-13 15:52:33 +02:00
Johannes Meyer 7311ab964e Do not set the full url from the request as action with form parameters 
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.

fixes #6806
 2014-08-13 14:50:21 +02:00
Johannes Meyer fe63ce664f Make use if 'ignore´ instead of explicitly unsetting array keys 
refs #5525
 2014-08-12 13:57:28 +02:00
Johannes Meyer f23bf912eb Remove obsolete use statements 2014-08-12 09:49:52 +02:00
Johannes Meyer be14844fa8 Merge EditInstanceForm with CreateInstanceForm and rename it 
As with the backend form, a user might like to change the name of an
instance. The new form and its actions are also adjusted to suit the new form interface.

refs #5525
 2014-08-11 14:49:42 +02:00
Thomas Gelf 96925487bd CLI/monitoring/list: fix DataView-related exception 
This uses the renamed DataView serviceStatus instead of the former
status and fixes the problem that CLI still assumed to have fetch
and count function on the DataView.

fixes #6777
 2014-07-31 17:24:56 +02:00
Thomas Gelf 51484ebf88 monitoring/Perfdata: ignore invalid min/max 
key=23;0;0;0;0 and key=23;;;; lead to division by zero exceptions
This should fix this by ignoring empty strings for min/max (formerly
it got "converted" to float(0)) and also ignores min == max.

fixes #6828
 2014-07-31 16:52:34 +02:00
Johannes Meyer 5a738112ea Remove isExistingBackend/-Instance 
It is more efficient to access configuration files only once instead of
accessing them multiple times in different locations.

refs #5525
 2014-07-25 16:02:13 +02:00
Johannes Meyer d7ed6bd249 Adjust removebackend-action to suit the new backend form interface 
Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.

refs #5525
 2014-07-25 16:00:38 +02:00
Johannes Meyer a78d11345b Adjust createbackend-action to suit the new backend form interface 
refs #5525
 2014-07-25 15:58:44 +02:00
Johannes Meyer b743cf8143 Adjust editbackend-action to suit the new backend-form interface 
refs #5525
 2014-07-25 14:55:36 +02:00
Johannes Meyer 488ea4633d Merge EditBackendForm with CreateBackendForm and rename it 
It is not necessary to distinct between whether a backend is created or
edited as a user perhaps likes to change the name of a backend directly
instead of the need to remove and recreate it.

refs #5525
 2014-07-25 14:50:53 +02:00
Johannes Meyer af5a3262be Revert backslash removal in front of namespace-less use statement 2014-07-25 09:12:12 +02:00
Johannes Meyer 26d42da635 Re-add getResourcesByType as simplified version 
refs #5525
 2014-07-25 08:58:50 +02:00
Johannes Meyer a6bd802e3e Remove unnecessary properties and its getters/setters 
refs #5525
 2014-07-25 08:58:11 +02:00
Johannes Meyer 5f7652133e Fix code-style and documentation 2014-07-25 08:39:27 +02:00
Alexander Klimov a4b7204e23 Contactgroups view: correct links to contacts detail pages 
fixes #6514
 2014-07-23 13:10:09 +02:00
Alexander Klimov a2809552f2 Do not use htmlspecialchars in view scripts 
fixes #6759
 2014-07-23 12:41:05 +02:00
Eric Lippmann 9269a0cbd5 Revert "Do not use htmlspecialchars in view scripts" 
This reverts commit 607aa9b203.

`Perfdata::escape()' does not exist. But `Perfdata::view::escape()' does.
 2014-07-23 12:29:27 +02:00
Alexander Klimov 607aa9b203 Do not use htmlspecialchars in view scripts 
fixes #6759
 2014-07-23 12:12:49 +02:00
Matthias Jentsch cb27a3d0f1 Do not use height and width in bar charts, to avoid layout errors 2014-07-22 17:57:40 +02:00
Matthias Jentsch 0a500efd8a Determine the max value in LinearUnit dynamically 
The range between min and max should always be divisable by the amount of
ticks, to ensure that the vertical lines are always at a full discrete value.

fixes #6769
 2014-07-21 17:21:54 +02:00
Matthias Jentsch 53c9292b41 Fix BarChart padding in Dashboard 
Use max-width instead of width in the chart layout to make better use of the available space, but prevent the charts from growing too big. Use a bigger weight and height in the default dashboard configuration.

fixes #6744
 2014-07-21 13:06:35 +02:00
Alexander Klimov f9a274d079 Add contact detail view 
refs #4804
refs #6514
 2014-07-18 17:35:24 +02:00
Alexander Klimov 96d3406446 Prefer style="clear: both;" rather than Bootstrap's class="clearfix" 2014-07-17 17:46:28 +02:00
Alexander Klimov 882699201d Contacts: replace foreach loop with hardcoded HTML and move the styles to a CSS file 2014-07-17 17:33:45 +02:00
Alexander Klimov eca0d50bae Don't use printf format strings as array keys 
An array with printf format strings as keys looks pretty ugly
 2014-07-17 11:26:18 +02:00
Johannes Meyer 4d199180b3 We do not want to access $_POST directly if it is possible to avoid it 2014-07-17 09:28:10 +02:00
Johannes Meyer b7f5c8a84d Fix that the default sort order of a view is not being applied 
fixes #6644
 2014-07-17 09:28:10 +02:00
Alexander Klimov b23e36aa1a Swap array keys and values 
Non-hardcoded keys may be not unique
 2014-07-16 17:54:06 +02:00
Alexander Klimov 62da942159 Don't close and re-open php tags, remove unneeded spaces 
To close and re-open php tags makes no sense if there's nothing between them
 2014-07-16 17:54:06 +02:00
Alexander Klimov 1ad263170e Revert "Small fixes" 
This reverts commit 8086292b1b.

The commit included too many changes.
 2014-07-16 15:30:20 +02:00
Johannes Meyer f1d7cd8b50 Remove forgotten coding standards annotation 2014-07-16 13:59:43 +02:00
Alexander Klimov cb04c42bab Use htmlspecialchars to prevent attacks 2014-07-16 13:10:28 +02:00
Alexander Klimov 8086292b1b Small fixes 2014-07-15 18:00:52 +02:00
Alexander Klimov 4c415aac5c Make contacts' view look more like contactgroups' view 2014-07-15 16:17:02 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files 
refs #6309
 2014-07-15 13:43:52 +02:00
Alexander Klimov d021ddebee Make contacts' view work like the downtimes' one 
fixes #6513
 2014-07-15 10:47:12 +02:00
Johannes Meyer bacea36ad9 Improve piechart limitation and show non-piechart perfdata as well 
The perfdata helper did an improper limitation as it might have skipped
valid values due to applying the limit before the filter. When not in compact
view the helper now also shows non-piechart values by using their raw
representation.

refs #6515
 2014-07-14 13:48:30 +02:00
Johannes Meyer 5908e9fc70 Do not show pie charts for perfdata values when no percentage is available 
refs #6515
 2014-07-11 16:32:05 +02:00
Johannes Meyer ec2d1daa6b Perfdata plugin should also have a knowledge about labels 
Prior to this change the PerfdataSet only knew the labels of a performance
data value which prevented the Perfdata object from being used
individually.

refs #6515
 2014-07-11 16:31:00 +02:00
Johannes Meyer b4dc0f38b3 Fix monitoring backend configuration not showing resource selection fields 
fixes #6448
 2014-07-10 15:50:52 +02:00
Johannes Meyer 53f3d74103 Fix word wrapping in perfdata labels and values 
fixes #6377
 2014-07-10 14:54:53 +02:00
Matthias Jentsch b85ac3ab45 Translate labels in the ChartController 2014-07-09 18:13:40 +02:00
Matthias Jentsch 8d697a3d8e Fix coding style 2014-07-09 18:13:40 +02:00
Johannes Meyer 0d92efc1b0 Consider is_active column when fetching host and service statistics 
fixes #6157
 2014-07-09 11:49:22 +02:00
Thomas Gelf 2b05aa9504 monitoring/list: do not apply empty filter 
Fixes problems with the servicematrix when no filter is applied.
I'm not yet happy with this, calls to where() should automagically
handle existing empty filters.

fixes #6543
 2014-07-08 16:36:05 +02:00
Thomas Gelf 9a6821c860 monitoring/list/hosts: restore page behaviour 
The problem here was that an accidentally removed closing div tag in
15325949 caused the application to missbehave badly. Host details where
rendered below the list in some scenarios and the whole multicolumn
thingy started to feel broken.
 2014-07-08 15:17:00 +02:00
Johannes Meyer 1950c09478 Remove encoding suffix from locale identifiers 
We do not need those as the encoding of a gettext-catalog is already
mentioned in its header.

refs #6602
 2014-07-07 09:09:22 +02:00
Thomas Gelf e3b2f15863 list/hosts: show unhandled services righthand 
This way we automagically fix the problem with the wrong row links.
I guess we should re-introduce the "row-action" class allowing "precedence"
rules, so also a link not being the first one in a row could act as "row-link".

Changed formatting / text output a little bit, IMO even more cure is needed.

fixes #6645
 2014-07-04 18:13:44 +02:00
Matthias Jentsch d2098be625 Only display header when not in compact mode 
fixes #6508
 2014-07-04 12:45:17 +02:00
Johannes Meyer 7eb0f3c472 Remove @codingStandardsIgnoreStart/-Stop annotations 
refs #6091
 2014-06-30 13:59:58 +02:00
Matthias Jentsch 9a1b7179e1 Fix violations of coding guidelines 2014-06-30 12:33:51 +02:00
Matthias Jentsch 7fe056d03a Display note when host and service is not found 
When the show/host and show/service views do not find a host or service,
don't show a non-working view, but display a error message

fixes #6469
 2014-06-30 12:33:51 +02:00
Matthias Jentsch a2fa5c055c Display a message when a list view is empty 
fixes #6469
 2014-06-30 12:33:51 +02:00